Completed
Push — master ( 1c8f09...485292 )
by Mahmoud
06:58
created
app/Containers/Authorization/Actions/SyncPermissionsOnRoleAction.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -59,10 +59,10 @@
 block discarded – undo
59 59
         $permissions = [];
60 60
 
61 61
         if (is_array($permissionsIds)) {
62
-            foreach ($permissionsIds as $permissionId){
62
+            foreach ($permissionsIds as $permissionId) {
63 63
                 $permissions[] = $this->getPermissionTask->run($permissionId);
64 64
             }
65
-        }else{
65
+        } else {
66 66
             $permissions[] = $this->getPermissionTask->run($permissionsIds);
67 67
         }
68 68
 
Please login to merge, or discard this patch.
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@
 block discarded – undo
62 62
             foreach ($permissionsIds as $permissionId){
63 63
                 $permissions[] = $this->getPermissionTask->run($permissionId);
64 64
             }
65
-        }else{
65
+        } else{
66 66
             $permissions[] = $this->getPermissionTask->run($permissionsIds);
67 67
         }
68 68
 
Please login to merge, or discard this patch.
app/Containers/Authorization/UI/API/Controllers/Controller.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 use App\Containers\Authorization\UI\API\Requests\SyncUserRolesRequest;
31 31
 use App\Containers\Authorization\UI\API\Transformers\PermissionTransformer;
32 32
 use App\Containers\Authorization\UI\API\Transformers\RoleTransformer;
33
-use App\Containers\User\Models\User;
34 33
 use App\Containers\User\UI\API\Transformers\UserTransformer;
35 34
 use App\Ship\Parents\Controllers\ApiController;
36 35
 
Please login to merge, or discard this patch.
app/Containers/Debugger/Tasks/RequestsDebuggerTask.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
     }
44 44
 
45 45
     /**
46
-     * @param $request
46
+     * @param \Illuminate\Http\Request $request
47 47
      * @param $response
48 48
      */
49 49
     public function run($request, $response)
@@ -76,11 +76,11 @@  discard block
 block discarded – undo
76 76
      * Feel free to pass any extra data to be displayed.
77 77
      *
78 78
      * @param $request
79
-     * @param $user
79
+     * @param string $user
80 80
      * @param $browser
81 81
      * @param $authHeader
82 82
      * @param $responseContent
83
-     * @param $requestData
83
+     * @param string $requestData
84 84
      */
85 85
     private function log($request, $user, $browser, $authHeader, $responseContent, $requestData)
86 86
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace App\Containers\Debugger\Tasks;
4 4
 
5 5
 use App;
6
-use DB;
7 6
 use Illuminate\Support\Facades\Config;
8 7
 use Jenssegers\Agent\Facades\Agent;
9 8
 use Log;
Please login to merge, or discard this patch.
app/Ship/Engine/Loaders/MiddlewaresLoaderTrait.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
     private function registerMiddlewareGroups(array $middlewareGroups = [])
31 31
     {
32 32
         foreach ($middlewareGroups as $key => $middleware) {
33
-            if($middleware){
33
+            if ($middleware) {
34 34
                 $this->app['router']->middlewareGroup($key, $middleware);
35 35
             }
36 36
         }
Please login to merge, or discard this patch.
app/Containers/Debugger/Tasks/QueryDebuggerTask.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,6 @@
 block discarded – undo
19 19
      * Write the DB queries in the Log and Display them in the
20 20
      * terminal (in case you want to see them while executing the tests).
21 21
      *
22
-     * @param bool|false $terminal
23 22
      */
24 23
     public function run()
25 24
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
             $consoleOutputEnabled = Config::get('debugger.queries.output.console');
31 31
             $logOutputEnabled = Config::get('debugger.queries.output.log');
32 32
 
33
-            DB::listen(function ($event) use ($consoleOutputEnabled, $logOutputEnabled) {
33
+            DB::listen(function($event) use ($consoleOutputEnabled, $logOutputEnabled) {
34 34
                 $fullQuery = vsprintf(str_replace(['%', '?'], ['%%', '%s'], $event->sql), $event->bindings);
35 35
 
36 36
                 $result = $event->connectionName . ' (' . $event->time . '): ' . $fullQuery;
Please login to merge, or discard this patch.
app/Containers/Stripe/Tests/Unit/ChargeUsersTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use App\Containers\Stripe\Tasks\CreateStripeAccountObjectTask;
6 6
 use App\Containers\Stripe\Tasks\ChargeWithStripeTask;
7 7
 use App\Containers\Stripe\Tests\TestCase;
8
-use App\Ship\Features\Payment\Proxies\PaymentsProxy;
9 8
 use Illuminate\Support\Facades\App;
10 9
 
11 10
 /**
Please login to merge, or discard this patch.
app/Ship/Features/Payment/Proxies/PaymentsProxy.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
     }
38 38
 
39 39
     /**
40
-     * @param $object
40
+     * @param ChargeableInterface $object
41 41
      *
42 42
      * @return  null
43 43
      */
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
     }
48 48
 
49 49
     /**
50
-     * @param $object
50
+     * @param ChargeableInterface $object
51 51
      *
52 52
      * @return  null
53 53
      */
Please login to merge, or discard this patch.
app/Ship/Parents/Exceptions/Exception.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -112,9 +112,9 @@
 block discarded – undo
112 112
 
113 113
 
114 114
     /**
115
-     * @param $statusCode
115
+     * @param integer $statusCode
116 116
      * @param $message
117
-     * @param $code
117
+     * @param integer $code
118 118
      */
119 119
     private function logTheError($statusCode, $message, $code)
120 120
     {
Please login to merge, or discard this patch.
app/Ship/Features/Tests/PhpUnit/TestsAuthHelperTrait.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -154,7 +154,7 @@
 block discarded – undo
154 154
     }
155 155
 
156 156
     /**
157
-     * @param $user
157
+     * @param User $user
158 158
      * @param $access
159 159
      *
160 160
      * @return  mixed
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -5,8 +5,6 @@
 block discarded – undo
5 5
 use App;
6 6
 use App\Containers\Authentication\Tasks\ApiLoginThisUserObjectTask;
7 7
 use App\Containers\User\Models\User;
8
-use Artisan;
9
-use Dingo\Api\Http\Response as DingoAPIResponse;
10 8
 use Illuminate\Support\Facades\Hash;
11 9
 
12 10
 /**
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
      */
79 79
     private function findOrCreateTestingUser($userDetails, $access)
80 80
     {
81
-        return $this->testingUser ? : $this->createTestingUser($userDetails, $access);
81
+        return $this->testingUser ?: $this->createTestingUser($userDetails, $access);
82 82
     }
83 83
 
84 84
     /**
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
         ];
127 127
 
128 128
         // if no user detail provided, use the default details, to find the password or generate one before encoding it
129
-        return $this->prepareUserPassword($userDetails ? : $defaultUserDetails);;
129
+        return $this->prepareUserPassword($userDetails ?: $defaultUserDetails); ;
130 130
     }
131 131
 
132 132
     /**
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
161 161
      */
162 162
     private function setupTestingUserAccess($user, $access)
163 163
     {
164
-        $access = $access ? : $this->getAccess();
164
+        $access = $access ?: $this->getAccess();
165 165
 
166 166
         $user = $this->setupTestingUserPermissions($user, $access);
167 167
         $user = $this->setupTestingUserRoles($user, $access);
Please login to merge, or discard this patch.