Localization - Code Metrics - Inspection of "run composer update" - Porto-SAP/Hello-API - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1c8f09...485292 )

by Mahmoud

created 2017-02-24 20:38 UTC

Localization A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
wmc	7
lcom	1
cbo	0
dl	0
loc	76
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	handle()	17	1
A	validateLanguage()	10	2
A	findLanguage()	5	2
A	getSupportedLanguages()	4	1

<?php

namespace App\Containers\Localization\Middlewares;

use Closure;
use Illuminate\Foundation\Application;

/**
 * Class Localization
 *
 * @author  Mahmoud Zalt  <[email protected]>
 */
class Localization
{

    /**
     * Localization constructor.
     *
     * @param \Illuminate\Foundation\Application $app
     */
    public function __construct(Application $app)
    {
        $this->app = $app;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }


    /**
     * Handle an incoming request.
     *
     * @param  \Illuminate\Http\Request $request
     * @param  \Closure                 $next
     *
     * @return mixed
     */
    public function handle($request, Closure $next)
    {
        // find and validate the lang on that request
        $lang = $this->validateLanguage($this->findLanguage($request));

        // set the local language
        $this->app->setLocale($lang);

        // get the response after the request is done
        $response = $next($request);

        // set Content Languages header in the response
        $response->headers->set('Content-Language', $lang);

        // return the response
        return $response;
    }

    /**
     * @param $lang
     *
     * @return string|Exception
     */
    private function validateLanguage($lang)
    {
        // check the languages defined is supported
        if (!array_key_exists($lang, $this->getSupportedLanguages())) {
            // respond with error
            $lang = abort(403, 'Language not supported.');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        }

        return $lang;
    }

    /**
     * @param $request
     *
     * @return  string
     */
    private function findLanguage($request)
    {
        // read the language from the request header, if the header is missed, take the default local language
        return $request->header('Content-Language') ? : $this->app->config->get('app.locale');
    }

    /**
     * @return array
     */
    private function getSupportedLanguages()
    {
        return $this->app->config->get('localization.supported_languages');
    }

}


1			<?php
2
3			namespace App\Containers\Localization\Middlewares;
4
5			use Closure;
6			use Illuminate\Foundation\Application;
7
8			/**
9			* Class Localization
10			*
11			* @author Mahmoud Zalt <[email protected]>
12			*/
13			class Localization
14			{
15
16			/**
17			* Localization constructor.
18			*
19			* @param \Illuminate\Foundation\Application $app
20			*/
21			public function __construct(Application $app)
22			{
23			$this->app = $app;
			0 ignored issues – show Bug introduced 2017-02-24 20:45 UTC by Report Bug Copy Issue Report The property `app` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
24			}
25
26
27			/**
28			* Handle an incoming request.
29			*
30			* @param \Illuminate\Http\Request $request
31			* @param \Closure $next
32			*
33			* @return mixed
34			*/
35			public function handle($request, Closure $next)
36			{
37			// find and validate the lang on that request
38			$lang = $this->validateLanguage($this->findLanguage($request));
39
40			// set the local language
41			$this->app->setLocale($lang);
42
43			// get the response after the request is done
44			$response = $next($request);
45
46			// set Content Languages header in the response
47			$response->headers->set('Content-Language', $lang);
48
49			// return the response
50			return $response;
51			}
52
53			/**
54			* @param $lang
55			*
56			* @return string\|Exception
57			*/
58			private function validateLanguage($lang)
59			{
60			// check the languages defined is supported
61			if (!array_key_exists($lang, $this->getSupportedLanguages())) {
62			// respond with error
63			$lang = abort(403, 'Language not supported.');
			0 ignored issues – show Bug introduced 2017-02-24 20:45 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$lang` is correct as `abort(403, 'Language not supported.')` (which targets `abort()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
64			}
65
66			return $lang;
67			}
68
69			/**
70			* @param $request
71			*
72			* @return string
73			*/
74			private function findLanguage($request)
75			{
76			// read the language from the request header, if the header is missed, take the default local language
77			return $request->header('Content-Language') ? : $this->app->config->get('app.locale');
78			}
79
80			/**
81			* @return array
82			*/
83			private function getSupportedLanguages()
84			{
85			return $this->app->config->get('localization.supported_languages');
86			}
87
88			}
89

Porto-SAP / Hello-API

Push — master ( 1c8f09...485292 )

Localization A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Duplication Side-by-Side

Filter issues like