AssignUserToRoleRequest::all() - Code Metrics - Inspection of "refactor assigning users to roles" - Porto-SAP/Hello-API - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6e2cac...67d760 )

by Mahmoud

created 2017-01-24 16:06 UTC

AssignUserToRoleRequest::all() A

↳ Parent: AssignUserToRoleRequest

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	4

Duplication

Lines	8
Ratio	100 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	8
loc	8
rs	9.4285
cc	1
eloc	4
nc	1
nop	0

<?php

namespace App\Containers\Authorization\UI\API\Requests;

use App\Port\Request\Abstracts\Request;

/**
 * Class AssignUserToRoleRequest.
 *
 * @author Mahmoud Zalt <[email protected]>
 */
class AssignUserToRoleRequest extends Request

{

    /**
     * @return  array
     */
    public function rules()
    {
        return [
            'roles_names' => 'required|exists:roles,name',
            'user_id'    => 'required|exists:users,id',
        ];
    }

    public function all()
    {
        $data = parent::all();

        $data['user_id'] = $this->decodeThisId($data['user_id']);

        return $data;
    }

    /**
     * @return  bool
     */
    public function authorize()
    {
        return $this->user()->hasPermissionTo('manage-roles-permissions');
    }
}


1		<?php
2
3		namespace App\Containers\Authorization\UI\API\Requests;
4
5		use App\Port\Request\Abstracts\Request;
6
7		/**
8		* Class AssignUserToRoleRequest.
9		*
10		* @author Mahmoud Zalt <[email protected]>
11		*/
12	View Code Duplication	class AssignUserToRoleRequest extends Request
		0 ignored issues – show Duplication introduced 2017-01-24 16:12 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
13		{
14
15		/**
16		* @return array
17		*/
18		public function rules()
19		{
20		return [
21		'roles_names' => 'required\|exists:roles,name',
22		'user_id' => 'required\|exists:users,id',
23		];
24		}
25
26		public function all()
27		{
28		$data = parent::all();
29
30		$data['user_id'] = $this->decodeThisId($data['user_id']);
31
32		return $data;
33		}
34
35		/**
36		* @return bool
37		*/
38		public function authorize()
39		{
40		return $this->user()->hasPermissionTo('manage-roles-permissions');
41		}
42		}
43

Porto-SAP / Hello-API

Push — master ( 6e2cac...67d760 )

AssignUserToRoleRequest::all() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like