SyncUserRolesAction::run() - Code Metrics - Porto-SAP/Hello-API - Measure and Improve Code Quality continuously with Scrutinizer

SyncUserRolesAction::run() A
last analyzed 2017-03-23 00:40 UTC

↳ Parent: SyncUserRolesAction

Complexity

Conditions	4
Paths	8

Size

Total Lines	16
Code Lines	8

Duplication

Lines	16
Ratio	100 %

Importance

Changes

Metric	Value
dl	16
loc	16
rs	9.2
c	0
b	0
f	0
cc	4
eloc	8
nc	8
nop	2

<?php

namespace App\Containers\Authorization\Actions;

use App\Containers\Authorization\Data\Repositories\RoleRepository;
use App\Containers\Authorization\Tasks\GetRoleTask;
use App\Containers\Authorization\Tasks\SyncUserRolesTask;
use App\Containers\User\Models\User;
use App\Containers\User\Tasks\FindUserByIdTask;
use App\Ship\Parents\Actions\Action;

/**
 * Class SyncUserRolesAction.
 *
 * @author Mahmoud Zalt <[email protected]>
 */
class SyncUserRolesAction extends Action
{

    /**
     * @var  \App\Containers\Authorization\Tasks\SyncUserRolesTask
     */
    private $syncUserRolesTask;

    /**
     * @var  \App\Containers\Authorization\Data\Repositories\RoleRepository
     */
    private $roleRepository;

    /**
     * @var  \App\Containers\User\Tasks\FindUserByIdTask
     */
    private $findUserByIdTask;

    /**
     * @var  \App\Containers\Authorization\Tasks\GetRoleTask
     */
    private $getRoleTask;

    /**
     * SyncUserRolesTask constructor.
     *
     * @param \App\Containers\Authorization\Data\Repositories\RoleRepository $roleRepository
     * @param \App\Containers\User\Tasks\FindUserByIdTask                    $findUserByIdTask
     */
    public function __construct(
        SyncUserRolesTask $syncUserRolesTask,
        RoleRepository $roleRepository,
        FindUserByIdTask $findUserByIdTask,
        GetRoleTask $getRoleTask
    ) {
        $this->syncUserRolesTask = $syncUserRolesTask;
        $this->roleRepository = $roleRepository;
        $this->findUserByIdTask = $findUserByIdTask;
        $this->getRoleTask = $getRoleTask;
    }


    /**
     * @param $user
     * @param $rolesIds
     *
     * @return  \App\Containers\User\Models\User
     */
    public function run($user, $rolesIds)

    {
        if (!$user instanceof User) {
            $user = $this->call(FindUserByIdTask::class, [$user]);
        }

        if (!is_array($rolesIds)) {
            $rolesIds = [$rolesIds];
        }

        foreach ($rolesIds as $roleId) {
            $roles[] = $this->call(GetRoleTask::class, [$roleId]);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }

        return $this->call(SyncUserRolesTask::class, [$user, $roles]);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }
}


1		<?php
2
3		namespace App\Containers\Authorization\Actions;
4
5		use App\Containers\Authorization\Data\Repositories\RoleRepository;
6		use App\Containers\Authorization\Tasks\GetRoleTask;
7		use App\Containers\Authorization\Tasks\SyncUserRolesTask;
8		use App\Containers\User\Models\User;
9		use App\Containers\User\Tasks\FindUserByIdTask;
10		use App\Ship\Parents\Actions\Action;
11
12		/**
13		* Class SyncUserRolesAction.
14		*
15		* @author Mahmoud Zalt <[email protected]>
16		*/
17		class SyncUserRolesAction extends Action
18		{
19
20		/**
21		* @var \App\Containers\Authorization\Tasks\SyncUserRolesTask
22		*/
23		private $syncUserRolesTask;
24
25		/**
26		* @var \App\Containers\Authorization\Data\Repositories\RoleRepository
27		*/
28		private $roleRepository;
29
30		/**
31		* @var \App\Containers\User\Tasks\FindUserByIdTask
32		*/
33		private $findUserByIdTask;
34
35		/**
36		* @var \App\Containers\Authorization\Tasks\GetRoleTask
37		*/
38		private $getRoleTask;
39
40		/**
41		* SyncUserRolesTask constructor.
42		*
43		* @param \App\Containers\Authorization\Data\Repositories\RoleRepository $roleRepository
44		* @param \App\Containers\User\Tasks\FindUserByIdTask $findUserByIdTask
45		*/
46		public function __construct(
47		SyncUserRolesTask $syncUserRolesTask,
48		RoleRepository $roleRepository,
49		FindUserByIdTask $findUserByIdTask,
50		GetRoleTask $getRoleTask
51		) {
52		$this->syncUserRolesTask = $syncUserRolesTask;
53		$this->roleRepository = $roleRepository;
54		$this->findUserByIdTask = $findUserByIdTask;
55		$this->getRoleTask = $getRoleTask;
56		}
57
58
59		/**
60		* @param $user
61		* @param $rolesIds
62		*
63		* @return \App\Containers\User\Models\User
64		*/
65	View Code Duplication	public function run($user, $rolesIds)
		0 ignored issues – show Duplication introduced 2017-03-20 03:51 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
66		{
67		if (!$user instanceof User) {
68		$user = $this->call(FindUserByIdTask::class, [$user]);
69		}
70
71		if (!is_array($rolesIds)) {
72		$rolesIds = [$rolesIds];
73		}
74
75		foreach ($rolesIds as $roleId) {
76		$roles[] = $this->call(GetRoleTask::class, [$roleId]);
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-03-20 03:51 UTC by Report Bug Copy Issue Report `$roles` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$roles = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
77		}
78
79		return $this->call(SyncUserRolesTask::class, [$user, $roles]);
		0 ignored issues – show Bug introduced 2017-03-20 03:51 UTC by Report Bug Copy Issue Report The variable `$roles` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
80		}
81		}
82

Porto-SAP / Hello-API

SyncUserRolesAction::run() A last analyzed 2017-03-23 00:40 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

SyncUserRolesAction::run() A
last analyzed 2017-03-23 00:40 UTC