Controller - Code Metrics - Porto-SAP/Hello-API - Measure and Improve Code Quality continuously with Scrutinizer

Controller B
last analyzed 2017-03-23 00:40 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	182
Duplicated Lines	4.4 %

Coupling/Cohesion

Components	0
Dependencies	17

Importance

Changes

Metric	Value
wmc	13
lcom	0
cbo	17
dl	8
loc	182
rs	7.8571
c	0
b	0
f	0

13 Methods

Rating	Name	Duplication	Size	Complexity
A	syncUserRoles()	0	6	1
A	deleteRole()	8	8	1
A	revokeRoleFromUser()	0	6	1
A	syncPermissionOnRole()	0	8	1
A	detachPermissionFromRole()	0	8	1
A	listAllPermissions()	0	6	1
A	getPermission()	0	6	1
A	listAllRoles()	0	6	1
A	getRole()	0	6	1
A	assignUserToRole()	0	6	1
A	attachPermissionToRole()	0	8	1
A	createRole()	0	6	1
A	createPermission()	0	6	1

How to fix Duplicated Code

<?php

namespace App\Containers\Authorization\UI\API\Controllers;

use App\Containers\Authorization\Actions\AssignUserToRoleAction;
use App\Containers\Authorization\Actions\AttachPermissionsToRoleAction;
use App\Containers\Authorization\Actions\CreatePermissionAction;
use App\Containers\Authorization\Actions\CreateRoleAction;
use App\Containers\Authorization\Actions\DeleteRoleAction;
use App\Containers\Authorization\Actions\DetachPermissionsFromRoleAction;
use App\Containers\Authorization\Actions\GetPermissionAction;
use App\Containers\Authorization\Actions\GetRoleAction;
use App\Containers\Authorization\Actions\ListAllPermissionsAction;
use App\Containers\Authorization\Actions\ListAllRolesAction;
use App\Containers\Authorization\Actions\RevokeUserFromRoleAction;
use App\Containers\Authorization\Actions\SyncPermissionsOnRoleAction;
use App\Containers\Authorization\Actions\SyncUserRolesAction;
use App\Containers\Authorization\UI\API\Requests\AssignUserToRoleRequest;
use App\Containers\Authorization\UI\API\Requests\AttachPermissionToRoleRequest;
use App\Containers\Authorization\UI\API\Requests\CreatePermissionRequest;
use App\Containers\Authorization\UI\API\Requests\CreateRoleRequest;
use App\Containers\Authorization\UI\API\Requests\DeleteRoleRequest;
use App\Containers\Authorization\UI\API\Requests\DetachPermissionToRoleRequest;
use App\Containers\Authorization\UI\API\Requests\GetPermissionRequest;
use App\Containers\Authorization\UI\API\Requests\GetRoleRequest;
use App\Containers\Authorization\UI\API\Requests\ListAllPermissionsRequest;
use App\Containers\Authorization\UI\API\Requests\ListAllRolesRequest;
use App\Containers\Authorization\UI\API\Requests\RevokeUserFromRoleRequest;
use App\Containers\Authorization\UI\API\Requests\SyncPermissionsOnRoleRequest;
use App\Containers\Authorization\UI\API\Requests\SyncUserRolesRequest;
use App\Containers\Authorization\UI\API\Transformers\PermissionTransformer;
use App\Containers\Authorization\UI\API\Transformers\RoleTransformer;
use App\Containers\User\Models\User;
use App\Containers\User\UI\API\Transformers\UserTransformer;
use App\Ship\Parents\Controllers\ApiController;

/**
 * Class Controller.
 *
 * @author Mahmoud Zalt <[email protected]>
 */
class Controller extends ApiController
{

    /**
     * @param \App\Containers\Authorization\UI\API\Requests\ListAllPermissionsRequest $request
     * @param \App\Containers\Authorization\Actions\ListAllPermissionsAction          $action
     *
     * @return  \Dingo\Api\Http\Response
     */
    public function listAllPermissions(ListAllPermissionsRequest $request, ListAllPermissionsAction $action)
    {
        $permissions = $action->run();

        return $this->response->collection($permissions, new PermissionTransformer());
    }

    /**
     * @param \App\Containers\Authorization\UI\API\Requests\GetPermissionRequest $request
     * @param \App\Containers\Authorization\Actions\GetPermissionAction          $action
     *
     * @return  \Dingo\Api\Http\Response
     */
    public function getPermission(GetPermissionRequest $request, GetPermissionAction $action)
    {
        $permission = $action->run($request['id']);

        return $this->response->item($permission, new PermissionTransformer());
    }

    /**
     * @param \App\Containers\Authorization\UI\API\Requests\ListAllRolesRequest $request
     * @param \App\Containers\Authorization\Actions\ListAllRolesAction          $action
     *
     * @return  \Dingo\Api\Http\Response
     */
    public function listAllRoles(ListAllRolesRequest $request, ListAllRolesAction $action)
    {
        $roles = $action->run();

        return $this->response->collection($roles, new RoleTransformer());
    }

    /**
     * @param \App\Containers\Authorization\UI\API\Requests\GetRoleRequest $request
     * @param \App\Containers\Authorization\Actions\GetRoleAction          $action
     *
     * @return  \Dingo\Api\Http\Response
     */
    public function getRole(GetRoleRequest $request, GetRoleAction $action)
    {
        $role = $action->run($request['id']);

        return $this->response->item($role, new RoleTransformer());
    }

    /**
     * @param \App\Containers\Authorization\UI\API\Requests\AssignUserToRoleRequest $request
     * @param \App\Containers\Authorization\Actions\AssignUserToRoleAction                $action
     *
     * @return  \Dingo\Api\Http\Response
     */
    public function assignUserToRole(AssignUserToRoleRequest $request, AssignUserToRoleAction $action)
    {
        $user = $action->run($request['user_id'], $request['roles_ids']);

        return $this->response->item($user, new UserTransformer());
    }

    /**
     * @param \App\Containers\Authorization\UI\API\Requests\SyncUserRolesRequest $request
     * @param \App\Containers\Authorization\Actions\SyncUserRolesAction         $action
     *
     * @return  \Dingo\Api\Http\Response
     */
    public function syncUserRoles(SyncUserRolesRequest $request, SyncUserRolesAction $action)
    {
        $user = $action->run($request['user_id'], $request['roles_ids']);

        return $this->response->item($user, new UserTransformer());
    }

    /**
     * @param \App\Containers\Authorization\UI\API\Requests\DeleteRoleRequest $request
     * @param \App\Containers\Authorization\Actions\DeleteRoleAction          $action
     *
     * @return  \Dingo\Api\Http\Response
     */
    public function deleteRole(DeleteRoleRequest $request, DeleteRoleAction $action)

    {
        $role = $action->run($request->id);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        return $this->response->accepted(null, [
            'message' => 'Role (' . $role->getHashedKey() . ') Deleted Successfully.',

        ]);
    }

    /**
     * @param \App\Containers\Authorization\UI\API\Requests\RevokeUserFromRoleRequest $request
     * @param \App\Containers\Authorization\Actions\RevokeUserFromRoleAction          $action
     *
     * @return  \Dingo\Api\Http\Response
     */
    public function revokeRoleFromUser(RevokeUserFromRoleRequest $request, RevokeUserFromRoleAction $action)
    {
        $user = $action->run($request['user_id'], $request['roles_ids']);

        return $this->response->item($user, new UserTransformer());
    }

    /**
     * @param \App\Containers\Authorization\UI\API\Requests\AttachPermissionToRoleRequest $request
     * @param \App\Containers\Authorization\Actions\AttachPermissionsToRoleAction         $action
     *
     * @return  \Dingo\Api\Http\Response
     */
    public function attachPermissionToRole(
        AttachPermissionToRoleRequest $request,
        AttachPermissionsToRoleAction $action
    ) {
        $role = $action->run($request['role_id'], $request['permissions_ids']);

        return $this->response->item($role, new RoleTransformer());
    }

    /**
     * @param \App\Containers\Authorization\UI\API\Requests\SyncPermissionsOnRoleRequest $request
     * @param \App\Containers\Authorization\Actions\SyncPermissionsOnRoleAction         $action
     *
     * @return  \Dingo\Api\Http\Response
     */
    public function syncPermissionOnRole(
        SyncPermissionsOnRoleRequest $request,
        SyncPermissionsOnRoleAction $action
    ) {
        $role = $action->run($request['role_id'], $request['permissions_ids']);

        return $this->response->item($role, new RoleTransformer());
    }

    /**
     * @param \App\Containers\Authorization\UI\API\Requests\DetachPermissionToRoleRequest $request
     * @param \App\Containers\Authorization\Actions\DetachPermissionsFromRoleAction       $action
     *
     * @return  \Dingo\Api\Http\Response
     */
    public function detachPermissionFromRole(
        DetachPermissionToRoleRequest $request,
        DetachPermissionsFromRoleAction $action
    ) {
        $role = $action->run($request['role_id'], $request['permissions_ids']);

        return $this->response->item($role, new RoleTransformer());
    }

    /**
     * @param \App\Containers\Authorization\UI\API\Requests\CreateRoleRequest $request
     * @param \App\Containers\Authorization\Actions\CreateRoleAction          $action
     *
     * @return  \Dingo\Api\Http\Response
     */
    public function createRole(CreateRoleRequest $request, CreateRoleAction $action)
    {
        $role = $action->run($request['name'], $request['description'], $request['display_name']);

        return $this->response->item($role, new RoleTransformer());
    }

    /**
     * @param \App\Containers\Authorization\UI\API\Requests\CreatePermissionRequest $request
     * @param \App\Containers\Authorization\Actions\CreatePermissionAction          $action
     *
     * @return  \Dingo\Api\Http\Response
     */
    public function createPermission(CreatePermissionRequest $request, CreatePermissionAction $action)
    {
        $permission = $action->run($request['name'], $request['description'], $request['display_name']);

        return $this->response->item($permission, new PermissionTransformer());
    }


}


1		<?php
2
3		namespace App\Containers\Authorization\UI\API\Controllers;
4
5		use App\Containers\Authorization\Actions\AssignUserToRoleAction;
6		use App\Containers\Authorization\Actions\AttachPermissionsToRoleAction;
7		use App\Containers\Authorization\Actions\CreatePermissionAction;
8		use App\Containers\Authorization\Actions\CreateRoleAction;
9		use App\Containers\Authorization\Actions\DeleteRoleAction;
10		use App\Containers\Authorization\Actions\DetachPermissionsFromRoleAction;
11		use App\Containers\Authorization\Actions\GetPermissionAction;
12		use App\Containers\Authorization\Actions\GetRoleAction;
13		use App\Containers\Authorization\Actions\ListAllPermissionsAction;
14		use App\Containers\Authorization\Actions\ListAllRolesAction;
15		use App\Containers\Authorization\Actions\RevokeUserFromRoleAction;
16		use App\Containers\Authorization\Actions\SyncPermissionsOnRoleAction;
17		use App\Containers\Authorization\Actions\SyncUserRolesAction;
18		use App\Containers\Authorization\UI\API\Requests\AssignUserToRoleRequest;
19		use App\Containers\Authorization\UI\API\Requests\AttachPermissionToRoleRequest;
20		use App\Containers\Authorization\UI\API\Requests\CreatePermissionRequest;
21		use App\Containers\Authorization\UI\API\Requests\CreateRoleRequest;
22		use App\Containers\Authorization\UI\API\Requests\DeleteRoleRequest;
23		use App\Containers\Authorization\UI\API\Requests\DetachPermissionToRoleRequest;
24		use App\Containers\Authorization\UI\API\Requests\GetPermissionRequest;
25		use App\Containers\Authorization\UI\API\Requests\GetRoleRequest;
26		use App\Containers\Authorization\UI\API\Requests\ListAllPermissionsRequest;
27		use App\Containers\Authorization\UI\API\Requests\ListAllRolesRequest;
28		use App\Containers\Authorization\UI\API\Requests\RevokeUserFromRoleRequest;
29		use App\Containers\Authorization\UI\API\Requests\SyncPermissionsOnRoleRequest;
30		use App\Containers\Authorization\UI\API\Requests\SyncUserRolesRequest;
31		use App\Containers\Authorization\UI\API\Transformers\PermissionTransformer;
32		use App\Containers\Authorization\UI\API\Transformers\RoleTransformer;
33		use App\Containers\User\Models\User;
34		use App\Containers\User\UI\API\Transformers\UserTransformer;
35		use App\Ship\Parents\Controllers\ApiController;
36
37		/**
38		* Class Controller.
39		*
40		* @author Mahmoud Zalt <[email protected]>
41		*/
42		class Controller extends ApiController
43		{
44
45		/**
46		* @param \App\Containers\Authorization\UI\API\Requests\ListAllPermissionsRequest $request
47		* @param \App\Containers\Authorization\Actions\ListAllPermissionsAction $action
48		*
49		* @return \Dingo\Api\Http\Response
50		*/
51		public function listAllPermissions(ListAllPermissionsRequest $request, ListAllPermissionsAction $action)
52		{
53		$permissions = $action->run();
54
55		return $this->response->collection($permissions, new PermissionTransformer());
56		}
57
58		/**
59		* @param \App\Containers\Authorization\UI\API\Requests\GetPermissionRequest $request
60		* @param \App\Containers\Authorization\Actions\GetPermissionAction $action
61		*
62		* @return \Dingo\Api\Http\Response
63		*/
64		public function getPermission(GetPermissionRequest $request, GetPermissionAction $action)
65		{
66		$permission = $action->run($request['id']);
67
68		return $this->response->item($permission, new PermissionTransformer());
69		}
70
71		/**
72		* @param \App\Containers\Authorization\UI\API\Requests\ListAllRolesRequest $request
73		* @param \App\Containers\Authorization\Actions\ListAllRolesAction $action
74		*
75		* @return \Dingo\Api\Http\Response
76		*/
77		public function listAllRoles(ListAllRolesRequest $request, ListAllRolesAction $action)
78		{
79		$roles = $action->run();
80
81		return $this->response->collection($roles, new RoleTransformer());
82		}
83
84		/**
85		* @param \App\Containers\Authorization\UI\API\Requests\GetRoleRequest $request
86		* @param \App\Containers\Authorization\Actions\GetRoleAction $action
87		*
88		* @return \Dingo\Api\Http\Response
89		*/
90		public function getRole(GetRoleRequest $request, GetRoleAction $action)
91		{
92		$role = $action->run($request['id']);
93
94		return $this->response->item($role, new RoleTransformer());
95		}
96
97		/**
98		* @param \App\Containers\Authorization\UI\API\Requests\AssignUserToRoleRequest $request
99		* @param \App\Containers\Authorization\Actions\AssignUserToRoleAction $action
100		*
101		* @return \Dingo\Api\Http\Response
102		*/
103		public function assignUserToRole(AssignUserToRoleRequest $request, AssignUserToRoleAction $action)
104		{
105		$user = $action->run($request['user_id'], $request['roles_ids']);
106
107		return $this->response->item($user, new UserTransformer());
108		}
109
110		/**
111		* @param \App\Containers\Authorization\UI\API\Requests\SyncUserRolesRequest $request
112		* @param \App\Containers\Authorization\Actions\SyncUserRolesAction $action
113		*
114		* @return \Dingo\Api\Http\Response
115		*/
116		public function syncUserRoles(SyncUserRolesRequest $request, SyncUserRolesAction $action)
117		{
118		$user = $action->run($request['user_id'], $request['roles_ids']);
119
120		return $this->response->item($user, new UserTransformer());
121		}
122
123		/**
124		* @param \App\Containers\Authorization\UI\API\Requests\DeleteRoleRequest $request
125		* @param \App\Containers\Authorization\Actions\DeleteRoleAction $action
126		*
127		* @return \Dingo\Api\Http\Response
128		*/
129	View Code Duplication	public function deleteRole(DeleteRoleRequest $request, DeleteRoleAction $action)
		0 ignored issues – show Duplication introduced 2017-02-15 19:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
130		{
131		$role = $action->run($request->id);
		0 ignored issues – show Documentation introduced 2017-02-15 18:00 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<App\Containers\Au...ests\DeleteRoleRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
132
133		return $this->response->accepted(null, [
134		'message' => 'Role (' . $role->getHashedKey() . ') Deleted Successfully.',
		0 ignored issues – show Bug introduced 2017-03-22 20:01 UTC by Report Bug Copy Issue Report The method `getHashedKey` cannot be called on `$role` (of type `boolean`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
135		]);
136		}
137
138		/**
139		* @param \App\Containers\Authorization\UI\API\Requests\RevokeUserFromRoleRequest $request
140		* @param \App\Containers\Authorization\Actions\RevokeUserFromRoleAction $action
141		*
142		* @return \Dingo\Api\Http\Response
143		*/
144		public function revokeRoleFromUser(RevokeUserFromRoleRequest $request, RevokeUserFromRoleAction $action)
145		{
146		$user = $action->run($request['user_id'], $request['roles_ids']);
147
148		return $this->response->item($user, new UserTransformer());
149		}
150
151		/**
152		* @param \App\Containers\Authorization\UI\API\Requests\AttachPermissionToRoleRequest $request
153		* @param \App\Containers\Authorization\Actions\AttachPermissionsToRoleAction $action
154		*
155		* @return \Dingo\Api\Http\Response
156		*/
157		public function attachPermissionToRole(
158		AttachPermissionToRoleRequest $request,
159		AttachPermissionsToRoleAction $action
160		) {
161		$role = $action->run($request['role_id'], $request['permissions_ids']);
162
163		return $this->response->item($role, new RoleTransformer());
164		}
165
166		/**
167		* @param \App\Containers\Authorization\UI\API\Requests\SyncPermissionsOnRoleRequest $request
168		* @param \App\Containers\Authorization\Actions\SyncPermissionsOnRoleAction $action
169		*
170		* @return \Dingo\Api\Http\Response
171		*/
172		public function syncPermissionOnRole(
173		SyncPermissionsOnRoleRequest $request,
174		SyncPermissionsOnRoleAction $action
175		) {
176		$role = $action->run($request['role_id'], $request['permissions_ids']);
177
178		return $this->response->item($role, new RoleTransformer());
179		}
180
181		/**
182		* @param \App\Containers\Authorization\UI\API\Requests\DetachPermissionToRoleRequest $request
183		* @param \App\Containers\Authorization\Actions\DetachPermissionsFromRoleAction $action
184		*
185		* @return \Dingo\Api\Http\Response
186		*/
187		public function detachPermissionFromRole(
188		DetachPermissionToRoleRequest $request,
189		DetachPermissionsFromRoleAction $action
190		) {
191		$role = $action->run($request['role_id'], $request['permissions_ids']);
192
193		return $this->response->item($role, new RoleTransformer());
194		}
195
196		/**
197		* @param \App\Containers\Authorization\UI\API\Requests\CreateRoleRequest $request
198		* @param \App\Containers\Authorization\Actions\CreateRoleAction $action
199		*
200		* @return \Dingo\Api\Http\Response
201		*/
202		public function createRole(CreateRoleRequest $request, CreateRoleAction $action)
203		{
204		$role = $action->run($request['name'], $request['description'], $request['display_name']);
205
206		return $this->response->item($role, new RoleTransformer());
207		}
208
209		/**
210		* @param \App\Containers\Authorization\UI\API\Requests\CreatePermissionRequest $request
211		* @param \App\Containers\Authorization\Actions\CreatePermissionAction $action
212		*
213		* @return \Dingo\Api\Http\Response
214		*/
215		public function createPermission(CreatePermissionRequest $request, CreatePermissionAction $action)
216		{
217		$permission = $action->run($request['name'], $request['description'], $request['display_name']);
218
219		return $this->response->item($permission, new PermissionTransformer());
220		}
221
222
223		}
224

Porto-SAP / Hello-API

Controller B last analyzed 2017-03-23 00:40 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

13 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

Controller B
last analyzed 2017-03-23 00:40 UTC