AuthorizationTrait - Code Metrics - Porto-SAP/Hello-API - Measure and Improve Code Quality continuously with Scrutinizer

AuthorizationTrait A
last analyzed 2017-03-23 00:40 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	3
lcom	0
cbo	1
dl	0
loc	27
rs	10
c	1
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	getUser()	4	1
A	hasAdminRole()	4	1
A	hasClientRole()	4	1

<?php

namespace App\Containers\Authorization\Traits;

use Illuminate\Support\Facades\Auth;

/**
 * Class AuthorizationTrait
 *
 * @author  Mahmoud Zalt  <[email protected]>
 */
trait AuthorizationTrait
{
    /**
     * @return  \App\Containers\User\Models\User|null
     */
    public function getUser()
    {
        return Auth::user();
    }

    /**
     * @return  mixed
     */
    public function hasAdminRole()
    {
        return $this->hasRole('admin');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @return  mixed
     */
    public function hasClientRole()
    {
        return $this->hasRole('client');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

}


1			<?php
2
3			namespace App\Containers\Authorization\Traits;
4
5			use Illuminate\Support\Facades\Auth;
6
7			/**
8			* Class AuthorizationTrait
9			*
10			* @author Mahmoud Zalt <[email protected]>
11			*/
12			trait AuthorizationTrait
13			{
14			/**
15			* @return \App\Containers\User\Models\User\|null
16			*/
17			public function getUser()
18			{
19			return Auth::user();
20			}
21
22			/**
23			* @return mixed
24			*/
25			public function hasAdminRole()
26			{
27			return $this->hasRole('admin');
			0 ignored issues – show Bug introduced 2017-02-09 23:45 UTC by Report Bug Copy Issue Report It seems like `hasRole()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
28			}
29
30			/**
31			* @return mixed
32			*/
33			public function hasClientRole()
34			{
35			return $this->hasRole('client');
			0 ignored issues – show Bug introduced 2017-02-09 23:45 UTC by Report Bug Copy Issue Report It seems like `hasRole()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
36			}
37
38			}
39

Porto-SAP / Hello-API

AuthorizationTrait A last analyzed 2017-03-23 00:40 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like

AuthorizationTrait A
last analyzed 2017-03-23 00:40 UTC