PortlandLabs /
slackbot
| 1 | <?php |
||||
| 2 | namespace PortlandLabs\Slackbot\Command; |
||||
| 3 | |||||
| 4 | use PortlandLabs\Slackbot\Command\Argument\Manager; |
||||
|
0 ignored issues
–
show
|
|||||
| 5 | use PortlandLabs\Slackbot\Slack\Rtm\Event\Message; |
||||
| 6 | |||||
| 7 | class RoleCommand extends SimpleCommand |
||||
| 8 | { |
||||
| 9 | |||||
| 10 | protected $description = 'Find out what "Role" you have'; |
||||
| 11 | |||||
| 12 | protected $signature = 'role'; |
||||
| 13 | |||||
| 14 | /** |
||||
| 15 | * Handle a message |
||||
| 16 | * |
||||
| 17 | * @param Message $message |
||||
| 18 | * @param Manager $manager |
||||
| 19 | * |
||||
| 20 | * @return void |
||||
| 21 | */ |
||||
| 22 | public function run(Message $message, Manager $manager) |
||||
| 23 | { |
||||
| 24 | $role = class_basename(get_class($this->checker->getRole($message))); |
||||
| 25 | $an = in_array($role[0], ['A', 'E', 'I', 'O', 'U']) && $role !== 'User' ? 'an' : 'a'; |
||||
| 26 | |||||
| 27 | $this->bot->feignTyping( |
||||
| 28 | $message->getChannel(), |
||||
|
0 ignored issues
–
show
It seems like
$message->getChannel() can also be of type null; however, parameter $channel of PortlandLabs\Slackbot\Bot::feignTyping() does only seem to accept string, maybe add an additional type check?
(
Ignorable by Annotation
)
If this is a false-positive, you can also ignore this issue in your code via the
Loading history...
|
|||||
| 29 | sprintf('You are %s `%s`', $an, $role)); |
||||
| 30 | } |
||||
| 31 | } |
Let?s assume that you have a directory layout like this:
. |-- OtherDir | |-- Bar.php | `-- Foo.php `-- SomeDir `-- Foo.phpand let?s assume the following content of
Bar.php:If both files
OtherDir/Foo.phpandSomeDir/Foo.phpare loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.phpHowever, as
OtherDir/Foo.phpdoes not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: