PortlandLabs / slackbot

src/Command/RememberCommand.php

<?php


namespace PortlandLabs\Slackbot\Command;


use Illuminate\Support\Str;
use PortlandLabs\Slackbot\Bot;
use PortlandLabs\Slackbot\Command\Argument\Manager;

This use statement conflicts with another class in this namespace, PortlandLabs\Slackbot\Command\Manager. Consider defining an alias.

use PortlandLabs\Slackbot\Permission\Admin;
use PortlandLabs\Slackbot\Permission\Checker;
use PortlandLabs\Slackbot\Slack\Rtm\Event\Message;
use Psr\SimpleCache\CacheInterface;
use Psr\SimpleCache\CacheException;

class RememberCommand extends SimpleCommand
{

    protected $description = 'Remember something interesting to be `recall`ed later';

    protected $signature = 'remember {thing} {value}';

    /** @var CacheInterface */
    protected $cache;

    protected $role = Admin::class;

    public function __construct(Bot $bot, Manager $argumentManager, Checker $checker, CacheInterface $cache)
    {
        parent::__construct($bot, $argumentManager, $checker);

        $this->cache = $cache;
        $this->checker = $checker;
    }

    /**
     * @param Message $message
     * @param Manager $manager
     */
    public function run(Message $message, Manager $manager)
    {
        $thing = $manager->get('thing');
        $text = $message->getText();
        $text = substr($text, strpos($text, '>'));

It seems like $text can also be of type null; however, parameter $haystack of strpos() does only seem to accept string, maybe add an additional type check?

It seems like $text can also be of type null; however, parameter $string of substr() does only seem to accept string, maybe add an additional type check?

        $value = trim(substr($text, strpos($text, $thing) + strlen($thing)));

It seems like $thing can also be of type boolean and null; however, parameter $needle of strpos() does only seem to accept string, maybe add an additional type check?

It seems like $thing can also be of type boolean and null; however, parameter $string of strlen() does only seem to accept string, maybe add an additional type check?

        // trim off quotes
        $value = ltrim($value, '"\'');

        $key = Str::snake('remember ' . $thing);

        try {
            $this->cache->set($key, $value);
            $keys = $this->cache->get('rememberindex', []);
            $keys[$key] = $thing;
            $this->cache->set('rememberindex', $keys);
        } catch (CacheException $e) {
            $this->bot->logger()->error('[CMD.RMB] Failed to remember: ' . $e->getMessage());

The method getMessage() does not exist on Psr\SimpleCache\CacheException. It seems like you code against a sub-type of Psr\SimpleCache\CacheException such as Cache\Adapter\Common\Exception\InvalidArgumentException.

            $this->bot->feignTyping($message->getChannel(), 'Hmm.. I wasn\'t able to remember that... What was it again?');

It seems like $message->getChannel() can also be of type null; however, parameter $channel of PortlandLabs\Slackbot\Bot::feignTyping() does only seem to accept string, maybe add an additional type check?

            return;
        }

        $this->bot->feignTyping($message->getChannel(), 'Okay, I\'ve got that remembered! Use the `recall` command to recall.');
    }
}