MultiColumnTable.format() - Code Metrics - Inspection of "Merge pull request #3612 from StackStorm/more_v2.3..." - Plexxi/st2 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — plexxi-v2.3.2 ( 5d46fe )

unknown

created 2017-08-22 17:03 UTC

MultiColumnTable.format() F

↳ Parent: MultiColumnTable

Complexity

Conditions

Size

Total Lines

107

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
cc	29
c	3
b	0
f	0
dl	0
loc	107
rs	2

How to fix Long Method Complexity

# Licensed to the StackStorm, Inc ('StackStorm') under one or more
# contributor license agreements.  See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License.  You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import json
import math
import logging
import sys

from prettytable import PrettyTable
from six.moves import zip


from st2client import formatters
from st2client.utils import strutil
from st2client.utils.terminal import get_terminal_size


LOG = logging.getLogger(__name__)

# Minimum width for the ID to make sure the ID column doesn't wrap across
# multiple lines
MIN_ID_COL_WIDTH = 26

# Minimum width for a column
MIN_COL_WIDTH = 5

# Default attribute display order to use if one is not provided
DEFAULT_ATTRIBUTE_DISPLAY_ORDER = ['id', 'name', 'pack', 'description']

# Attributes which contain bash escape sequences - we can't split those across multiple lines
# since things would break
COLORIZED_ATTRIBUTES = {
    'status': {
        'col_width': 24  # Note: len('succeed' + ' (XXXX elapsed)') <= 24
    }
}


class MultiColumnTable(formatters.Formatter):

    def __init__(self):
        self._table_width = 0

    @classmethod
    def format(cls, entries, *args, **kwargs):
        attributes = kwargs.get('attributes', [])
        attribute_transform_functions = kwargs.get('attribute_transform_functions', {})
        widths = kwargs.get('widths', [])
        widths = widths or []

        if not widths and attributes:
            # Dynamically calculate column size based on the terminal size
            lines, cols = get_terminal_size()

            if attributes[0] == 'id':
                # consume iterator and save as entries so collection is accessible later.
                entries = [e for e in entries]
                # first column contains id, make sure it's not broken up
                first_col_width = cls._get_required_column_width(values=[e.id for e in entries],
                                                                 minimum_width=MIN_ID_COL_WIDTH)
                cols = (cols - first_col_width)
                col_width = int(math.floor((cols / len(attributes))))
            else:
                col_width = int(math.floor((cols / len(attributes))))
                first_col_width = col_width
            widths = []
            subtract = 0
            for index in range(0, len(attributes)):
                attribute_name = attributes[index]

                if index == 0:
                    widths.append(first_col_width)
                    continue

                if attribute_name in COLORIZED_ATTRIBUTES:
                    current_col_width = COLORIZED_ATTRIBUTES[attribute_name]['col_width']
                    subtract += (current_col_width - col_width)
                else:
                    # Make sure we subtract the added width from the last column so we account
                    # for the fixed width columns and make sure table is not wider than the
                    # terminal width.
                    if index == (len(attributes) - 1) and subtract:
                        current_col_width = (col_width - subtract)

                        if current_col_width <= MIN_COL_WIDTH:
                            # Make sure column width is always grater than MIN_COL_WIDTH
                            current_col_width = MIN_COL_WIDTH
                    else:
                        current_col_width = col_width

                widths.append(current_col_width)

        if not attributes or 'all' in attributes:
            entries = list(entries) if entries else []

            if len(entries) >= 1:
                attributes = entries[0].__dict__.keys()
                attributes = sorted([attr for attr in attributes if not attr.startswith('_')])
            else:
                # There are no entries so we can't infer available attributes
                attributes = []

        # Determine table format.
        if len(attributes) == len(widths):
            # Customize width for each column.
            columns = zip(attributes, widths)
        else:
            # If only 1 width value is provided then
            # apply it to all columns else fix at 28.
            width = widths[0] if len(widths) == 1 else 28
            columns = zip(attributes,
                          [width for i in range(0, len(attributes))])

        # Format result to table.
        table = PrettyTable()
        for column in columns:
            table.field_names.append(column[0])
            table.max_width[column[0]] = column[1]
        table.padding_width = 1
        table.align = 'l'
        table.valign = 't'
        for entry in entries:
            # TODO: Improve getting values of nested dict.
            values = []
            for field_name in table.field_names:
                if '.' in field_name:
                    field_names = field_name.split('.')
                    value = getattr(entry, field_names.pop(0), {})
                    for name in field_names:
                        value = cls._get_field_value(value, name)
                        if type(value) is str:
                            break
                    value = strutil.strip_carriage_returns(strutil.unescape(value))
                    values.append(value)
                else:
                    value = cls._get_simple_field_value(entry, field_name)
                    transform_function = attribute_transform_functions.get(field_name,
                                                                           lambda value: value)
                    value = transform_function(value=value)
                    value = strutil.strip_carriage_returns(strutil.unescape(value))
                    values.append(value)
            table.add_row(values)

        # width for the note
        try:
            cls.table_width = len(table.get_string().split("\n")[0])
        except IndexError:
            cls.table_width = 0

        return table

    @property
    def table_width(self):
        return self._table_width

    @table_width.setter
    def table_width(self, value):
        self._table_width = value

    @staticmethod
    def _get_simple_field_value(entry, field_name):
        """
        Format a value for a simple field.
        """
        value = getattr(entry, field_name, '')
        if isinstance(value, (list, tuple)):
            if len(value) == 0:
                value = ''
            elif isinstance(value[0], (str, unicode)):

                # List contains simple string values, format it as comma
                # separated string
                value = ', '.join(value)

        return value

    @staticmethod
    def _get_field_value(value, field_name):
        r_val = value.get(field_name, None)
        if r_val is None:
            return ''

        if isinstance(r_val, list) or isinstance(r_val, dict):
            return r_val if len(r_val) > 0 else ''
        return r_val

    @staticmethod
    def _get_friendly_column_name(name):
        if not name:
            return None

        friendly_name = name.replace('_', ' ').replace('.', ' ').capitalize()
        return friendly_name

    @staticmethod
    def _get_required_column_width(values, minimum_width=0):
        max_width = len(max(values, key=len)) if values else minimum_width
        return max_width if max_width > minimum_width else minimum_width


class PropertyValueTable(formatters.Formatter):

    @classmethod
    def format(cls, subject, *args, **kwargs):
        attributes = kwargs.get('attributes', None)
        attribute_display_order = kwargs.get('attribute_display_order',
                                             DEFAULT_ATTRIBUTE_DISPLAY_ORDER)
        attribute_transform_functions = kwargs.get('attribute_transform_functions', {})

        if not attributes or 'all' in attributes:
            attributes = sorted([attr for attr in subject.__dict__
                                 if not attr.startswith('_')])

        for attr in attribute_display_order[::-1]:
            if attr in attributes:
                attributes.remove(attr)
                attributes = [attr] + attributes
        table = PrettyTable()
        table.field_names = ['Property', 'Value']
        table.max_width['Property'] = 20
        table.max_width['Value'] = 60
        table.padding_width = 1
        table.align = 'l'
        table.valign = 't'

        for attribute in attributes:
            if '.' in attribute:
                field_names = attribute.split('.')
                value = cls._get_attribute_value(subject, field_names.pop(0))
                for name in field_names:
                    value = cls._get_attribute_value(value, name)
                    if type(value) is str:
                        break
            else:
                value = cls._get_attribute_value(subject, attribute)

            transform_function = attribute_transform_functions.get(attribute,
                                                                   lambda value: value)
            value = transform_function(value=value)

            if type(value) is dict or type(value) is list:
                value = json.dumps(value, indent=4)

            value = strutil.strip_carriage_returns(strutil.unescape(value))
            table.add_row([attribute, value])
        return table

    @staticmethod
    def _get_attribute_value(subject, attribute):
        if isinstance(subject, dict):
            r_val = subject.get(attribute, None)
        else:
            r_val = getattr(subject, attribute, None)
        if r_val is None:
            return ''
        if isinstance(r_val, list) or isinstance(r_val, dict):
            return r_val if len(r_val) > 0 else ''
        return r_val


class SingleRowTable(object):
    @staticmethod
    def note_box(entity, limit):
        if limit == 0:
            return None
        elif limit == 1:
            message = "Note: Only one %s is displayed. Use -n/--last flag for more results." \
                % entity[:-1]
        else:
            message = "Note: Only first %s %s are displayed. Use -n/--last flag for more" \
                " results." % (limit, entity)
        # adding default padding
        message_length = len(message) + 3
        m = MultiColumnTable()
        if m.table_width > message_length:
            note = PrettyTable([""], right_padding_width=(m.table_width - message_length))
        else:
            note = PrettyTable([""])
        note.header = False
        note.add_row([message])
        return sys.stderr.write(str(note) + "\n")


1			# Licensed to the StackStorm, Inc ('StackStorm') under one or more
2			# contributor license agreements. See the NOTICE file distributed with
3			# this work for additional information regarding copyright ownership.
4			# The ASF licenses this file to You under the Apache License, Version 2.0
5			# (the "License"); you may not use this file except in compliance with
6			# the License. You may obtain a copy of the License at
7			#
8			# http://www.apache.org/licenses/LICENSE-2.0
9			#
10			# Unless required by applicable law or agreed to in writing, software
11			# distributed under the License is distributed on an "AS IS" BASIS,
12			# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13			# See the License for the specific language governing permissions and
14			# limitations under the License.
15
16			import json
17			import math
18			import logging
19			import sys
20
21			from prettytable import PrettyTable
22			from six.moves import zip
			0 ignored issues – show Bug Best Practice introduced 2015-11-20 23:04 UTC by Report Bug Copy Issue Report This seems to re-define the built-in `zip`. It is generally discouraged to redefine built-ins as this makes code very hard to read. Loading history...
23
24			from st2client import formatters
25			from st2client.utils import strutil
26			from st2client.utils.terminal import get_terminal_size
27
28
29			LOG = logging.getLogger(__name__)
30
31			# Minimum width for the ID to make sure the ID column doesn't wrap across
32			# multiple lines
33			MIN_ID_COL_WIDTH = 26
34
35			# Minimum width for a column
36			MIN_COL_WIDTH = 5
37
38			# Default attribute display order to use if one is not provided
39			DEFAULT_ATTRIBUTE_DISPLAY_ORDER = ['id', 'name', 'pack', 'description']
40
41			# Attributes which contain bash escape sequences - we can't split those across multiple lines
42			# since things would break
43			COLORIZED_ATTRIBUTES = {
44			'status': {
45			'col_width': 24 # Note: len('succeed' + ' (XXXX elapsed)') <= 24
46			}
47			}
48
49
50			class MultiColumnTable(formatters.Formatter):
51
52			def __init__(self):
53			self._table_width = 0
54
55			@classmethod
56			def format(cls, entries, args, *kwargs):
57			attributes = kwargs.get('attributes', [])
58			attribute_transform_functions = kwargs.get('attribute_transform_functions', {})
59			widths = kwargs.get('widths', [])
60			widths = widths or []
61
62			if not widths and attributes:
63			# Dynamically calculate column size based on the terminal size
64			lines, cols = get_terminal_size()
65
66			if attributes[0] == 'id':
67			# consume iterator and save as entries so collection is accessible later.
68			entries = [e for e in entries]
69			# first column contains id, make sure it's not broken up
70			first_col_width = cls._get_required_column_width(values=[e.id for e in entries],
71			minimum_width=MIN_ID_COL_WIDTH)
72			cols = (cols - first_col_width)
73			col_width = int(math.floor((cols / len(attributes))))
74			else:
75			col_width = int(math.floor((cols / len(attributes))))
76			first_col_width = col_width
77			widths = []
78			subtract = 0
79			for index in range(0, len(attributes)):
80			attribute_name = attributes[index]
81
82			if index == 0:
83			widths.append(first_col_width)
84			continue
85
86			if attribute_name in COLORIZED_ATTRIBUTES:
87			current_col_width = COLORIZED_ATTRIBUTES[attribute_name]['col_width']
88			subtract += (current_col_width - col_width)
89			else:
90			# Make sure we subtract the added width from the last column so we account
91			# for the fixed width columns and make sure table is not wider than the
92			# terminal width.
93			if index == (len(attributes) - 1) and subtract:
94			current_col_width = (col_width - subtract)
95
96			if current_col_width <= MIN_COL_WIDTH:
97			# Make sure column width is always grater than MIN_COL_WIDTH
98			current_col_width = MIN_COL_WIDTH
99			else:
100			current_col_width = col_width
101
102			widths.append(current_col_width)
103
104			if not attributes or 'all' in attributes:
105			entries = list(entries) if entries else []
106
107			if len(entries) >= 1:
108			attributes = entries[0].__dict__.keys()
109			attributes = sorted([attr for attr in attributes if not attr.startswith('_')])
110			else:
111			# There are no entries so we can't infer available attributes
112			attributes = []
113
114			# Determine table format.
115			if len(attributes) == len(widths):
116			# Customize width for each column.
117			columns = zip(attributes, widths)
118			else:
119			# If only 1 width value is provided then
120			# apply it to all columns else fix at 28.
121			width = widths[0] if len(widths) == 1 else 28
122			columns = zip(attributes,
123			[width for i in range(0, len(attributes))])
124
125			# Format result to table.
126			table = PrettyTable()
127			for column in columns:
128			table.field_names.append(column[0])
129			table.max_width[column[0]] = column[1]
130			table.padding_width = 1
131			table.align = 'l'
132			table.valign = 't'
133			for entry in entries:
134			# TODO: Improve getting values of nested dict.
135			values = []
136			for field_name in table.field_names:
137			if '.' in field_name:
138			field_names = field_name.split('.')
139			value = getattr(entry, field_names.pop(0), {})
140			for name in field_names:
141			value = cls._get_field_value(value, name)
142			if type(value) is str:
143			break
144			value = strutil.strip_carriage_returns(strutil.unescape(value))
145			values.append(value)
146			else:
147			value = cls._get_simple_field_value(entry, field_name)
148			transform_function = attribute_transform_functions.get(field_name,
149			lambda value: value)
150			value = transform_function(value=value)
151			value = strutil.strip_carriage_returns(strutil.unescape(value))
152			values.append(value)
153			table.add_row(values)
154
155			# width for the note
156			try:
157			cls.table_width = len(table.get_string().split("\n")[0])
158			except IndexError:
159			cls.table_width = 0
160
161			return table
162
163			@property
164			def table_width(self):
165			return self._table_width
166
167			@table_width.setter
168			def table_width(self, value):
169			self._table_width = value
170
171			@staticmethod
172			def _get_simple_field_value(entry, field_name):
173			"""
174			Format a value for a simple field.
175			"""
176			value = getattr(entry, field_name, '')
177			if isinstance(value, (list, tuple)):
178			if len(value) == 0:
179			value = ''
180			elif isinstance(value[0], (str, unicode)):
			0 ignored issues – show Comprehensibility Best Practice introduced 2016-01-14 18:36 UTC by Report Bug Copy Issue Report Undefined variable 'unicode' Loading history...
181			# List contains simple string values, format it as comma
182			# separated string
183			value = ', '.join(value)
184
185			return value
186
187			@staticmethod
188			def _get_field_value(value, field_name):
189			r_val = value.get(field_name, None)
190			if r_val is None:
191			return ''
192
193			if isinstance(r_val, list) or isinstance(r_val, dict):
194			return r_val if len(r_val) > 0 else ''
195			return r_val
196
197			@staticmethod
198			def _get_friendly_column_name(name):
199			if not name:
200			return None
201
202			friendly_name = name.replace('_', ' ').replace('.', ' ').capitalize()
203			return friendly_name
204
205			@staticmethod
206			def _get_required_column_width(values, minimum_width=0):
207			max_width = len(max(values, key=len)) if values else minimum_width
208			return max_width if max_width > minimum_width else minimum_width
209
210
211			class PropertyValueTable(formatters.Formatter):
212
213			@classmethod
214			def format(cls, subject, args, *kwargs):
215			attributes = kwargs.get('attributes', None)
216			attribute_display_order = kwargs.get('attribute_display_order',
217			DEFAULT_ATTRIBUTE_DISPLAY_ORDER)
218			attribute_transform_functions = kwargs.get('attribute_transform_functions', {})
219
220			if not attributes or 'all' in attributes:
221			attributes = sorted([attr for attr in subject.__dict__
222			if not attr.startswith('_')])
223
224			for attr in attribute_display_order[::-1]:
225			if attr in attributes:
226			attributes.remove(attr)
227			attributes = [attr] + attributes
228			table = PrettyTable()
229			table.field_names = ['Property', 'Value']
230			table.max_width['Property'] = 20
231			table.max_width['Value'] = 60
232			table.padding_width = 1
233			table.align = 'l'
234			table.valign = 't'
235
236			for attribute in attributes:
237			if '.' in attribute:
238			field_names = attribute.split('.')
239			value = cls._get_attribute_value(subject, field_names.pop(0))
240			for name in field_names:
241			value = cls._get_attribute_value(value, name)
242			if type(value) is str:
243			break
244			else:
245			value = cls._get_attribute_value(subject, attribute)
246
247			transform_function = attribute_transform_functions.get(attribute,
248			lambda value: value)
249			value = transform_function(value=value)
250
251			if type(value) is dict or type(value) is list:
252			value = json.dumps(value, indent=4)
253
254			value = strutil.strip_carriage_returns(strutil.unescape(value))
255			table.add_row([attribute, value])
256			return table
257
258			@staticmethod
259			def _get_attribute_value(subject, attribute):
260			if isinstance(subject, dict):
261			r_val = subject.get(attribute, None)
262			else:
263			r_val = getattr(subject, attribute, None)
264			if r_val is None:
265			return ''
266			if isinstance(r_val, list) or isinstance(r_val, dict):
267			return r_val if len(r_val) > 0 else ''
268			return r_val
269
270
271			class SingleRowTable(object):
272			@staticmethod
273			def note_box(entity, limit):
274			if limit == 0:
275			return None
276			elif limit == 1:
277			message = "Note: Only one %s is displayed. Use -n/--last flag for more results." \
278			% entity[:-1]
279			else:
280			message = "Note: Only first %s %s are displayed. Use -n/--last flag for more" \
281			" results." % (limit, entity)
282			# adding default padding
283			message_length = len(message) + 3
284			m = MultiColumnTable()
285			if m.table_width > message_length:
286			note = PrettyTable([""], right_padding_width=(m.table_width - message_length))
287			else:
288			note = PrettyTable([""])
289			note.header = False
290			note.add_row([message])
291			return sys.stderr.write(str(note) + "\n")
292

Plexxi / st2

GitHub Access Token became invalid

Push — plexxi-v2.3.2 ( 5d46fe )

MultiColumnTable.format() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Complexity

Duplication Side-by-Side

Filter issues like