Conditions | 9 |
Total Lines | 79 |
Lines | 0 |
Ratio | 0 % |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | # Licensed to the StackStorm, Inc ('StackStorm') under one or more |
||
39 | def __init__(self, base_url=None, auth_url=None, api_url=None, api_version=None, cacert=None, |
||
40 | debug=False, token=None): |
||
41 | # Get CLI options. If not given, then try to get it from the environment. |
||
42 | self.endpoints = dict() |
||
43 | |||
44 | # Populate the endpoints |
||
45 | if base_url: |
||
46 | self.endpoints['base'] = base_url |
||
47 | else: |
||
48 | self.endpoints['base'] = os.environ.get('ST2_BASE_URL', DEFAULT_BASE_URL) |
||
49 | |||
50 | api_version = api_version or os.environ.get('ST2_API_VERSION', DEFAULT_API_VERSION) |
||
51 | |||
52 | if api_url: |
||
53 | self.endpoints['api'] = api_url |
||
54 | else: |
||
55 | self.endpoints['api'] = os.environ.get( |
||
56 | 'ST2_API_URL', '%s:%s/%s' % (self.endpoints['base'], DEFAULT_API_PORT, api_version)) |
||
57 | |||
58 | if auth_url: |
||
59 | self.endpoints['auth'] = auth_url |
||
60 | else: |
||
61 | self.endpoints['auth'] = os.environ.get( |
||
62 | 'ST2_AUTH_URL', '%s:%s' % (self.endpoints['base'], DEFAULT_AUTH_PORT)) |
||
63 | |||
64 | if cacert is not None: |
||
65 | self.cacert = cacert |
||
66 | else: |
||
67 | self.cacert = os.environ.get('ST2_CACERT', None) |
||
68 | |||
69 | # Note: boolean is also a valid value for "cacert" |
||
70 | is_cacert_string = isinstance(self.cacert, six.string_types) |
||
71 | if (self.cacert and is_cacert_string and not os.path.isfile(self.cacert)): |
||
|
|||
72 | raise ValueError('CA cert file "%s" does not exist.' % (self.cacert)) |
||
73 | |||
74 | self.debug = debug |
||
75 | |||
76 | # Note: This is a nasty hack for now, but we need to get rid of the decrator abuse |
||
77 | if token: |
||
78 | os.environ['ST2_AUTH_TOKEN'] = token |
||
79 | |||
80 | self.token = token |
||
81 | |||
82 | # Instantiate resource managers and assign appropriate API endpoint. |
||
83 | self.managers = dict() |
||
84 | self.managers['Token'] = ResourceManager( |
||
85 | models.Token, self.endpoints['auth'], cacert=self.cacert, debug=self.debug) |
||
86 | self.managers['RunnerType'] = ResourceManager( |
||
87 | models.RunnerType, self.endpoints['api'], cacert=self.cacert, debug=self.debug) |
||
88 | self.managers['Action'] = ResourceManager( |
||
89 | models.Action, self.endpoints['api'], cacert=self.cacert, debug=self.debug) |
||
90 | self.managers['ActionAlias'] = ActionAliasResourceManager( |
||
91 | models.ActionAlias, self.endpoints['api'], cacert=self.cacert, debug=self.debug) |
||
92 | self.managers['ApiKey'] = ResourceManager( |
||
93 | models.ApiKey, self.endpoints['api'], cacert=self.cacert, debug=self.debug) |
||
94 | self.managers['LiveAction'] = LiveActionResourceManager( |
||
95 | models.LiveAction, self.endpoints['api'], cacert=self.cacert, debug=self.debug) |
||
96 | self.managers['Policy'] = ResourceManager( |
||
97 | models.Policy, self.endpoints['api'], cacert=self.cacert, debug=self.debug) |
||
98 | self.managers['PolicyType'] = ResourceManager( |
||
99 | models.PolicyType, self.endpoints['api'], cacert=self.cacert, debug=self.debug) |
||
100 | self.managers['Rule'] = ResourceManager( |
||
101 | models.Rule, self.endpoints['api'], cacert=self.cacert, debug=self.debug) |
||
102 | self.managers['Sensor'] = ResourceManager( |
||
103 | models.Sensor, self.endpoints['api'], cacert=self.cacert, debug=self.debug) |
||
104 | self.managers['TriggerType'] = ResourceManager( |
||
105 | models.TriggerType, self.endpoints['api'], cacert=self.cacert, debug=self.debug) |
||
106 | self.managers['Trigger'] = ResourceManager( |
||
107 | models.Trigger, self.endpoints['api'], cacert=self.cacert, debug=self.debug) |
||
108 | self.managers['TriggerInstance'] = TriggerInstanceResourceManager( |
||
109 | models.TriggerInstance, self.endpoints['api'], cacert=self.cacert, debug=self.debug) |
||
110 | self.managers['KeyValuePair'] = ResourceManager( |
||
111 | models.KeyValuePair, self.endpoints['api'], cacert=self.cacert, debug=self.debug) |
||
112 | self.managers['Webhook'] = ResourceManager( |
||
113 | models.Webhook, self.endpoints['api'], cacert=self.cacert, debug=self.debug) |
||
114 | self.managers['Trace'] = ResourceManager( |
||
115 | models.Trace, self.endpoints['api'], cacert=self.cacert, debug=self.debug) |
||
116 | self.managers['RuleEnforcement'] = ResourceManager( |
||
117 | models.RuleEnforcement, self.endpoints['api'], cacert=self.cacert, debug=self.debug) |
||
118 | |||
174 |