Passed
Branch master (f0e7b7)
by Darío
02:39 queued 11s
created
src/Db/TableGateway/AbstractTableGateway.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -73,7 +73,8 @@
 block discarded – undo
73 73
     {
74 74
         $this->currentDriverIdentifier = $connection_identifier;
75 75
 
76
-        if (!isset(self::$drivers[$connection_identifier]))
77
-            self::$drivers[$connection_identifier] = new DriverAdapter($connection_identifier, $auto_connect);
76
+        if (!isset(self::$drivers[$connection_identifier])) {
77
+                    self::$drivers[$connection_identifier] = new DriverAdapter($connection_identifier, $auto_connect);
78
+        }
78 79
     }
79 80
 }
80 81
\ No newline at end of file
Please login to merge, or discard this patch.
src/Db/TableGateway/TableGateway.php 1 patch
Braces   +45 added lines, -45 removed lines patch added patch discarded remove patch
@@ -73,11 +73,11 @@  discard block
 block discarded – undo
73 73
             {
74 74
                 $k++;
75 75
 
76
-                if (is_null($value))
77
-                    $parsed_where[] = "$key IS NULL";
78
-                elseif ($value instanceof SQLFunction)
79
-                    $parsed_where[] = "$key = " . $value->getStatement();
80
-                elseif (is_array($value))
76
+                if (is_null($value)) {
77
+                                    $parsed_where[] = "$key IS NULL";
78
+                } elseif ($value instanceof SQLFunction) {
79
+                                    $parsed_where[] = "$key = " . $value->getStatement();
80
+                } elseif (is_array($value))
81 81
                 {
82 82
                     $parsed_in = [];
83 83
 
@@ -100,8 +100,7 @@  discard block
 block discarded – undo
100 100
                     }
101 101
 
102 102
                     $parsed_where[] = "$key IN (" . implode(", ", $parsed_in) . ")";
103
-                }
104
-                else
103
+                } else
105 104
                 {
106 105
                     switch ($driver)
107 106
                     {
@@ -119,9 +118,9 @@  discard block
 block discarded – undo
119 118
             }
120 119
 
121 120
             $where = "WHERE \r\n\t" . implode(" AND\r\n\t", $parsed_where);
121
+        } else {
122
+                    $where = "";
122 123
         }
123
-        else
124
-            $where = "";
125 124
 
126 125
         $table = $this->entity->getTableName();
127 126
 
@@ -144,8 +143,9 @@  discard block
 block discarded – undo
144 143
      */
145 144
     public function insert(Array $data)
146 145
     {
147
-        if (!count($data))
148
-            throw new \LogicException("Missing values for INSERT statement!");
146
+        if (!count($data)) {
147
+                    throw new \LogicException("Missing values for INSERT statement!");
148
+        }
149 149
 
150 150
         $bind_values = [];
151 151
 
@@ -168,11 +168,11 @@  discard block
 block discarded – undo
168 168
                 continue;
169 169
             }
170 170
 
171
-            if (is_null($value))
172
-                $value = "NULL";
173
-            elseif ($value instanceof SQLFunction)
174
-                $value = $value->getStatement();
175
-            else {
171
+            if (is_null($value)) {
172
+                            $value = "NULL";
173
+            } elseif ($value instanceof SQLFunction) {
174
+                            $value = $value->getStatement();
175
+            } else {
176 176
 
177 177
                 switch ($driver)
178 178
                 {
@@ -222,11 +222,13 @@  discard block
 block discarded – undo
222 222
     {
223 223
         $parsed_set = [];
224 224
 
225
-        if (!count($set))
226
-            throw new \LogicException("You cannot update rows without SET clause");
225
+        if (!count($set)) {
226
+                    throw new \LogicException("You cannot update rows without SET clause");
227
+        }
227 228
 
228
-        if (!count($where))
229
-            throw new SecurityException("You cannot update rows without WHERE clause!");
229
+        if (!count($where)) {
230
+                    throw new SecurityException("You cannot update rows without WHERE clause!");
231
+        }
230 232
 
231 233
         $bind_values = [];
232 234
 
@@ -238,11 +240,11 @@  discard block
 block discarded – undo
238 240
         {
239 241
             $k++;
240 242
 
241
-            if (is_null($value))
242
-                $parsed_set[] = "$key = NULL";
243
-            elseif ($value instanceof SQLFunction)
244
-                $parsed_set[] = "$key = " . $value->getStatement();
245
-            elseif (is_array($value))
243
+            if (is_null($value)) {
244
+                            $parsed_set[] = "$key = NULL";
245
+            } elseif ($value instanceof SQLFunction) {
246
+                            $parsed_set[] = "$key = " . $value->getStatement();
247
+            } elseif (is_array($value))
246 248
             {
247 249
                 $parsed_in = [];
248 250
 
@@ -253,8 +255,9 @@  discard block
 block discarded – undo
253 255
                         case 'Oci8':
254 256
 
255 257
                             # [POSSIBLE BUG] - To Future revision (What about non-string values ?)
256
-                            if (is_string($in_value))
257
-                                $parsed_in[] = ":$k";
258
+                            if (is_string($in_value)) {
259
+                                                            $parsed_in[] = ":$k";
260
+                            }
258 261
 
259 262
                             $bind_values[":$k"] = $in_value;
260 263
                             break;
@@ -269,8 +272,7 @@  discard block
 block discarded – undo
269 272
                 }
270 273
 
271 274
                 $parsed_set[] = "$key IN (" . implode(", ", $parsed_in) . ")";
272
-            }
273
-            else
275
+            } else
274 276
             {
275 277
                 switch ($driver)
276 278
                 {
@@ -296,11 +298,11 @@  discard block
 block discarded – undo
296 298
         {
297 299
             $k++;
298 300
 
299
-            if (is_null($value))
300
-                $parsed_where[] = "$key IS NULL";
301
-            elseif ($value instanceof SQLFunction)
302
-                $parsed_where[] = "$key = " . $value->getStatement();
303
-            elseif (is_array($value))
301
+            if (is_null($value)) {
302
+                            $parsed_where[] = "$key IS NULL";
303
+            } elseif ($value instanceof SQLFunction) {
304
+                            $parsed_where[] = "$key = " . $value->getStatement();
305
+            } elseif (is_array($value))
304 306
             {
305 307
                 $parsed_in = [];
306 308
 
@@ -323,8 +325,7 @@  discard block
 block discarded – undo
323 325
                 }
324 326
 
325 327
                 $parsed_where[] = "$key IN (" . implode(", ", $parsed_in) . ")";
326
-            }
327
-            else
328
+            } else
328 329
             {
329 330
                 switch ($driver)
330 331
                 {
@@ -376,11 +377,11 @@  discard block
 block discarded – undo
376 377
             {
377 378
                 $k++;
378 379
 
379
-                if (is_null($value))
380
-                    $parsed_where[] = "$key IS NULL";
381
-                elseif ($value instanceof SQLFunction)
382
-                    $parsed_where[] = "$key = " . $value->getStatement();
383
-                elseif (is_array($value))
380
+                if (is_null($value)) {
381
+                                    $parsed_where[] = "$key IS NULL";
382
+                } elseif ($value instanceof SQLFunction) {
383
+                                    $parsed_where[] = "$key = " . $value->getStatement();
384
+                } elseif (is_array($value))
384 385
                 {
385 386
                     $parsed_in = [];
386 387
 
@@ -403,8 +404,7 @@  discard block
 block discarded – undo
403 404
                     }
404 405
 
405 406
                     $parsed_where[] = "$key IN (" . implode(", ", $parsed_in) . ")";
406
-                }
407
-                else
407
+                } else
408 408
                 {
409 409
                     switch ($driver)
410 410
                     {
@@ -422,9 +422,9 @@  discard block
 block discarded – undo
422 422
             }
423 423
 
424 424
             $where = "\r\nWHERE \r\n\t" . implode(" AND\r\n\t", $parsed_where);
425
+        } else {
426
+                    throw new SecurityException("You cannot delete rows without WHERE clause!. Use TRUNCATE statement instead.");
425 427
         }
426
-        else
427
-            throw new SecurityException("You cannot delete rows without WHERE clause!. Use TRUNCATE statement instead.");
428 428
 
429 429
         $table = $this->entity->getTableName();
430 430
 
Please login to merge, or discard this patch.
src/Db/TableGateway/EntityAdapter.php 1 patch
Braces   +21 added lines, -16 removed lines patch added patch discarded remove patch
@@ -58,8 +58,9 @@  discard block
 block discarded – undo
58 58
     {
59 59
         $result = $this->tableGateway->select($where);
60 60
 
61
-        if (!count($result))
62
-            return $result;
61
+        if (!count($result)) {
62
+                    return $result;
63
+        }
63 64
 
64 65
         $array_result = [];
65 66
 
@@ -69,8 +70,9 @@  discard block
 block discarded – undo
69 70
 
70 71
             foreach ($row as $key => $value)
71 72
             {
72
-                if (is_string($key))
73
-                    $filtered_array[$key] = $value;
73
+                if (is_string($key)) {
74
+                                    $filtered_array[$key] = $value;
75
+                }
74 76
             }
75 77
 
76 78
             $user_entity = get_class($this->tableGateway->getEntity());
@@ -94,10 +96,11 @@  discard block
 block discarded – undo
94 96
      */
95 97
     public function insert($entity)
96 98
     {
97
-        if ($entity instanceof Entity)
98
-            $entity = get_object_vars($entity);
99
-        else if (!is_array($entity))
100
-            throw new \InvalidArgumentException("Invalid type given. Drone\Db\Entity or Array expected");
99
+        if ($entity instanceof Entity) {
100
+                    $entity = get_object_vars($entity);
101
+        } else if (!is_array($entity)) {
102
+                    throw new \InvalidArgumentException("Invalid type given. Drone\Db\Entity or Array expected");
103
+        }
101 104
 
102 105
         $this->parseEntity($entity);
103 106
 
@@ -126,14 +129,15 @@  discard block
 block discarded – undo
126 129
 
127 130
             foreach ($entity as $key => $value)
128 131
             {
129
-                if (in_array($key, $changedFields))
130
-                    $fieldsToModify[$key] = $value;
132
+                if (in_array($key, $changedFields)) {
133
+                                    $fieldsToModify[$key] = $value;
134
+                }
131 135
             }
132 136
 
133 137
             $entity = $fieldsToModify;
138
+        } else if (!is_array($entity)) {
139
+                    throw new \InvalidArgumentException("Invalid type given. Drone\Db\Entity or Array expected");
134 140
         }
135
-        else if (!is_array($entity))
136
-            throw new \InvalidArgumentException("Invalid type given. Drone\Db\Entity or Array expected");
137 141
 
138 142
         $this->parseEntity($entity);
139 143
 
@@ -152,10 +156,11 @@  discard block
 block discarded – undo
152 156
      */
153 157
     public function delete($entity)
154 158
     {
155
-        if ($entity instanceof Entity)
156
-            $entity = get_object_vars($entity);
157
-        else if (!is_array($entity))
158
-            throw new \InvalidArgumentException("Invalid type given. Drone\Db\Entity or Array expected");
159
+        if ($entity instanceof Entity) {
160
+                    $entity = get_object_vars($entity);
161
+        } else if (!is_array($entity)) {
162
+                    throw new \InvalidArgumentException("Invalid type given. Drone\Db\Entity or Array expected");
163
+        }
159 164
 
160 165
         return $this->tableGateway->delete($entity);
161 166
     }
Please login to merge, or discard this patch.
src/Mvc/Layout.php 1 patch
Braces   +22 added lines, -16 removed lines patch added patch discarded remove patch
@@ -133,8 +133,9 @@  discard block
 block discarded – undo
133 133
     {
134 134
         $config = $module->getConfig();
135 135
 
136
-        if (!array_key_exists($view, $config["view_manager"]["view_map"]) || !file_exists($config["view_manager"]["view_map"][$view]))
137
-            throw new Exception\ViewNotFoundException("The 'view' template " . $view . " does not exists");
136
+        if (!array_key_exists($view, $config["view_manager"]["view_map"]) || !file_exists($config["view_manager"]["view_map"][$view])) {
137
+                    throw new Exception\ViewNotFoundException("The 'view' template " . $view . " does not exists");
138
+        }
138 139
 
139 140
         $this->view = $config["view_manager"]["view_map"][$view];
140 141
     }
@@ -164,8 +165,9 @@  discard block
 block discarded – undo
164 165
     {
165 166
         foreach ($params as $param => $value)
166 167
         {
167
-            if (property_exists(__CLASS__, strtolower($param)) && method_exists($this, 'set'.$param))
168
-                $this->{'set'.$param}($value);
168
+            if (property_exists(__CLASS__, strtolower($param)) && method_exists($this, 'set'.$param)) {
169
+                            $this->{'set'.$param}($value);
170
+            }
169 171
         }
170 172
     }
171 173
 
@@ -194,23 +196,26 @@  discard block
 block discarded – undo
194 196
 
195 197
         if ($controller->getTerminal())
196 198
         {
197
-            if (file_exists($view))
198
-                include $view;
199
-        }
200
-        else
199
+            if (file_exists($view)) {
200
+                            include $view;
201
+            }
202
+        } else
201 203
         {
202
-            if (!is_null($this->view) && !file_exists($this->view))
203
-                throw new Exception\ViewNotFoundException("The 'view' template " . $this->view . " does not exists");
204
+            if (!is_null($this->view) && !file_exists($this->view)) {
205
+                            throw new Exception\ViewNotFoundException("The 'view' template " . $this->view . " does not exists");
206
+            }
204 207
 
205 208
             $config = $controller->getModule()->getConfig();
206 209
 
207
-            if (!array_key_exists($controller->getLayout(), $config["view_manager"]["template_map"]))
208
-                throw new Exception\PageNotFoundException("The 'template' " . $template . " was not defined in module.config.php");
210
+            if (!array_key_exists($controller->getLayout(), $config["view_manager"]["template_map"])) {
211
+                            throw new Exception\PageNotFoundException("The 'template' " . $template . " was not defined in module.config.php");
212
+            }
209 213
 
210 214
             $template = $config["view_manager"]["template_map"][$controller->getLayout()];
211 215
 
212
-            if (!file_exists($template))
213
-                throw new Exception\PageNotFoundException("The 'template' " . $template . " does not exists");
216
+            if (!file_exists($template)) {
217
+                            throw new Exception\PageNotFoundException("The 'template' " . $template . " does not exists");
218
+            }
214 219
 
215 220
             include $template;
216 221
         }
@@ -237,8 +242,9 @@  discard block
 block discarded – undo
237 242
      */
238 243
     public function content()
239 244
     {
240
-        if (!file_exists($this->view))
241
-            throw new Exception\ViewNotFoundException("The 'view' template " . $this->view . " does not exists");
245
+        if (!file_exists($this->view)) {
246
+                    throw new Exception\ViewNotFoundException("The 'view' template " . $this->view . " does not exists");
247
+        }
242 248
 
243 249
         include $this->view;
244 250
     }
Please login to merge, or discard this patch.
src/Mvc/AbstractionController.php 1 patch
Braces   +32 added lines, -24 removed lines patch added patch discarded remove patch
@@ -150,8 +150,9 @@  discard block
 block discarded – undo
150 150
      */
151 151
     public function getPost()
152 152
     {
153
-        if ($_SERVER['REQUEST_METHOD'] == 'POST' && empty($_POST))
154
-            $_POST = json_decode(file_get_contents('php://input'), true);
153
+        if ($_SERVER['REQUEST_METHOD'] == 'POST' && empty($_POST)) {
154
+                    $_POST = json_decode(file_get_contents('php://input'), true);
155
+        }
155 156
 
156 157
         return (array) $_POST;
157 158
     }
@@ -165,8 +166,9 @@  discard block
 block discarded – undo
165 166
      */
166 167
     public function getJson()
167 168
     {
168
-        if ($_SERVER['REQUEST_METHOD'] != 'JSON')
169
-            throw new \LogicException("Request method is not JSON");
169
+        if ($_SERVER['REQUEST_METHOD'] != 'JSON') {
170
+                    throw new \LogicException("Request method is not JSON");
171
+        }
170 172
 
171 173
         $input =  file_get_contents('php://input');
172 174
         $array = explode("&", $input);
@@ -254,8 +256,9 @@  discard block
 block discarded – undo
254 256
         $this->module = new $fqn($module, $this);
255 257
 
256 258
         # detects method change inside Module.php
257
-        if (!is_null($this->getMethod()))
258
-            $method = $this->getMethod();
259
+        if (!is_null($this->getMethod())) {
260
+                    $method = $this->getMethod();
261
+        }
259 262
 
260 263
         if (!is_null($method) && $this->initExecution)
261 264
         {
@@ -265,8 +268,9 @@  discard block
 block discarded – undo
265 268
 
266 269
                 $reflection = new \ReflectionMethod($this, $method);
267 270
 
268
-                if (!$reflection->isPublic())
269
-                    throw new Exception\PageNotFoundException("The method '$method' is not public in the control class '$class'");
271
+                if (!$reflection->isPublic()) {
272
+                                    throw new Exception\PageNotFoundException("The method '$method' is not public in the control class '$class'");
273
+                }
270 274
 
271 275
                 $this->method = $method;
272 276
 
@@ -282,8 +286,7 @@  discard block
 block discarded – undo
282 286
                     $layoutManager = new Layout($layout_params);
283 287
                     $layoutManager->fromController($this);
284 288
                 }
285
-            }
286
-            else {
289
+            } else {
287 290
                 $class = __CLASS__;
288 291
                 throw new Exception\PageNotFoundException("The method '$method' doesn't exists in the control class '$class'");
289 292
             }
@@ -308,8 +311,9 @@  discard block
 block discarded – undo
308 311
     public function isXmlHttpRequest()
309 312
     {
310 313
         # non standard (HTTP_X_REQUESTED_WITH is not a part of PHP)
311
-        if (isset($_SERVER['HTTP_X_REQUESTED_WITH']))
312
-            return true;
314
+        if (isset($_SERVER['HTTP_X_REQUESTED_WITH'])) {
315
+                    return true;
316
+        }
313 317
         return false;
314 318
     }
315 319
 
@@ -320,8 +324,9 @@  discard block
 block discarded – undo
320 324
      */
321 325
     public function isPost()
322 326
     {
323
-        if ($_SERVER["REQUEST_METHOD"] == "POST")
324
-            return true;
327
+        if ($_SERVER["REQUEST_METHOD"] == "POST") {
328
+                    return true;
329
+        }
325 330
         return false;
326 331
     }
327 332
 
@@ -332,8 +337,9 @@  discard block
 block discarded – undo
332 337
      */
333 338
     public function isGet()
334 339
     {
335
-        if ($_SERVER["REQUEST_METHOD"] == "GET")
336
-            return true;
340
+        if ($_SERVER["REQUEST_METHOD"] == "GET") {
341
+                    return true;
342
+        }
337 343
         return false;
338 344
     }
339 345
 
@@ -357,10 +363,11 @@  discard block
 block discarded – undo
357 363
             $i = 1;
358 364
             foreach ($params as $item)
359 365
             {
360
-                if ($i % 2 != 0)
361
-                    $vars[] = $item;
362
-                else
363
-                    $values[] = $item;
366
+                if ($i % 2 != 0) {
367
+                                    $vars[] = $item;
368
+                } else {
369
+                                    $values[] = $item;
370
+                }
364 371
                 $i++;
365 372
             }
366 373
 
@@ -368,10 +375,11 @@  discard block
 block discarded – undo
368 375
 
369 376
             for ($i = 0; $i < $vars_count; $i++)
370 377
             {
371
-                if (array_key_exists($i, $values))
372
-                    $_GET[$vars[$i]] = $values[$i];
373
-                else
374
-                    $_GET[$vars[$i]] = '';
378
+                if (array_key_exists($i, $values)) {
379
+                                    $_GET[$vars[$i]] = $values[$i];
380
+                } else {
381
+                                    $_GET[$vars[$i]] = '';
382
+                }
375 383
             }
376 384
 
377 385
             unset($_GET["params"]);
Please login to merge, or discard this patch.
src/FileSystem/Shell.php 1 patch
Braces   +89 added lines, -70 removed lines patch added patch discarded remove patch
@@ -83,8 +83,9 @@  discard block
 block discarded – undo
83 83
 
84 84
             foreach ($filesForHandler as $item)
85 85
             {
86
-                if ($item != '.' && $item != '..')
87
-                    $contents[] = $item;
86
+                if ($item != '.' && $item != '..') {
87
+                                    $contents[] = $item;
88
+                }
88 89
             }
89 90
 
90 91
             $allContents = $contents;
@@ -99,8 +100,7 @@  discard block
 block discarded – undo
99 100
 
100 101
                         $this->buffer = $handler.'/'.$i;
101 102
                         call_user_func($fileCallback, $this);
102
-                    }
103
-                    elseif (is_dir($handler.'/'.$i))
103
+                    } elseif (is_dir($handler.'/'.$i))
104 104
                     {
105 105
                         $allContents[] = $handler.'/'.$i;
106 106
 
@@ -109,19 +109,21 @@  discard block
 block discarded – undo
109 109
 
110 110
                         $directory = scandir($handler);
111 111
 
112
-                        if (!count($directory) < 3)
113
-                            $this->buffer = $handler.'/'.$i;
112
+                        if (!count($directory) < 3) {
113
+                                                    $this->buffer = $handler.'/'.$i;
114
+                        }
114 115
 
115 116
                         call_user_func($dirCallback, $this);
116 117
                     }
117 118
                 }
118 119
             }
120
+        } else {
121
+                    throw new Exception("The directory '$handler' does not exists");
119 122
         }
120
-        else
121
-            throw new Exception("The directory '$handler' does not exists");
122 123
 
123
-        if (!is_null($callback))
124
-            call_user_func($callback, $this);
124
+        if (!is_null($callback)) {
125
+                    call_user_func($callback, $this);
126
+        }
125 127
 
126 128
         return $allContents;
127 129
     }
@@ -133,10 +135,11 @@  discard block
 block discarded – undo
133 135
      */
134 136
     public function pwd()
135 137
     {
136
-        if (getcwd())
137
-            $this->buffer = getcwd();
138
-        else
139
-            return false;
138
+        if (getcwd()) {
139
+                    $this->buffer = getcwd();
140
+        } else {
141
+                    return false;
142
+        }
140 143
 
141 144
         return $this->buffer;
142 145
     }
@@ -155,9 +158,9 @@  discard block
 block discarded – undo
155 158
 
156 159
         $path = (is_null($path) || empty($path)) ? '.' : $path;
157 160
 
158
-        if (is_file($path))
159
-            $filesToReturn = array($path);
160
-        elseif (is_dir($path))
161
+        if (is_file($path)) {
162
+                    $filesToReturn = array($path);
163
+        } elseif (is_dir($path))
161 164
         {
162 165
             $pathIns = dir($path);
163 166
 
@@ -179,25 +182,25 @@  discard block
 block discarded – undo
179 182
                 foreach ($files as $item) {
180 183
                     $filesToReturn[] = $item;
181 184
                 }
182
-            }
183
-            else {
185
+            } else {
184 186
                 while (false !== ($item = $pathIns->read())) {
185 187
                     $filesToReturn[] = $item;
186 188
                 }
187 189
                 $pathIns->close();
188 190
             }
189
-        }
190
-        else {
191
+        } else {
191 192
 
192 193
             $contents = $this->ls();
193 194
 
194 195
             foreach ($contents as $item)
195 196
             {
196
-                if (!empty($path))
197
-                    if (!strlen(stristr($item, $path)) > 0)
197
+                if (!empty($path)) {
198
+                                    if (!strlen(stristr($item, $path)) > 0)
198 199
                         continue;
199
-                if (strstr($item,'~') === false && $item != '.' && $item != '..')
200
-                    $filesToReturn[] = $item;
200
+                }
201
+                if (strstr($item,'~') === false && $item != '.' && $item != '..') {
202
+                                    $filesToReturn[] = $item;
203
+                }
201 204
             }
202 205
         }
203 206
 
@@ -217,8 +220,9 @@  discard block
 block discarded – undo
217 220
 
218 221
         if (is_dir($path))
219 222
         {
220
-            if (chdir($moveTo))
221
-                return true;
223
+            if (chdir($moveTo)) {
224
+                            return true;
225
+            }
222 226
         }
223 227
 
224 228
         return false;
@@ -235,11 +239,13 @@  discard block
 block discarded – undo
235 239
     {
236 240
         if (file_exists($file))
237 241
         {
238
-            if (!$openFile = fopen($file, 'w+'))
239
-                return false;
242
+            if (!$openFile = fopen($file, 'w+')) {
243
+                            return false;
244
+            }
240 245
 
241
-            if (fwrite($openFile, ""))
242
-                return true;
246
+            if (fwrite($openFile, "")) {
247
+                            return true;
248
+            }
243 249
 
244 250
             fclose($openFile);
245 251
         }
@@ -259,12 +265,13 @@  discard block
 block discarded – undo
259 265
     {
260 266
         $recursive = is_null($recursive) ? false : $recursive;
261 267
 
262
-        if (is_null($file))
263
-            throw new Exception("Missing parameter for rm!");
268
+        if (is_null($file)) {
269
+                    throw new Exception("Missing parameter for rm!");
270
+        }
264 271
 
265
-        if (file_exists($file) && !$recursive)
266
-            unlink($file);
267
-        elseif (is_dir($file) && $recursive)
272
+        if (file_exists($file) && !$recursive) {
273
+                    unlink($file);
274
+        } elseif (is_dir($file) && $recursive)
268 275
         {
269 276
             $that = $this;
270 277
 
@@ -293,14 +300,15 @@  discard block
 block discarded – undo
293 300
     {
294 301
         $recursive = (is_null($recursive)) ? false : $recursive;
295 302
 
296
-        if (empty($file) || empty($dest))
297
-            throw new Exception("Missing parameters!");
303
+        if (empty($file) || empty($dest)) {
304
+                    throw new Exception("Missing parameters!");
305
+        }
298 306
 
299 307
         if (is_dir($dest))
300 308
         {
301
-            if (!$recursive)
302
-                copy($file, $dest.'/'.$file);
303
-            else {
309
+            if (!$recursive) {
310
+                            copy($file, $dest.'/'.$file);
311
+            } else {
304 312
 
305 313
                 $files = array();
306 314
                 $files[0] = array();
@@ -318,20 +326,22 @@  discard block
 block discarded – undo
318 326
 
319 327
                     foreach ($files[1] as $item)
320 328
                     {
321
-                        if (!file_exists($dest.'/'.$item))
322
-                            mkdir("$dest/$item", 0777, true);
329
+                        if (!file_exists($dest.'/'.$item)) {
330
+                                                    mkdir("$dest/$item", 0777, true);
331
+                        }
323 332
                     }
324 333
 
325 334
                     foreach ($files[0] as $item)
326 335
                     {
327
-                        if (!file_exists("$dest/$files"))
328
-                            copy($item, $dest.'/'.$item);
336
+                        if (!file_exists("$dest/$files")) {
337
+                                                    copy($item, $dest.'/'.$item);
338
+                        }
329 339
                     }
330 340
                 });
331 341
             }
342
+        } else {
343
+                    copy($file, $dest);
332 344
         }
333
-        else
334
-            copy($file, $dest);
335 345
 
336 346
         return true;
337 347
     }
@@ -346,17 +356,21 @@  discard block
 block discarded – undo
346 356
      */
347 357
     public function mv($oldfile, $newfile)
348 358
     {
349
-        if (empty($oldfile))
350
-            throw new Exception("Missing parameter for mv!");
359
+        if (empty($oldfile)) {
360
+                    throw new Exception("Missing parameter for mv!");
361
+        }
351 362
 
352
-        if (is_dir($newfile))
353
-                $newfile .= '/'.basename($oldfile);
363
+        if (is_dir($newfile)) {
364
+                        $newfile .= '/'.basename($oldfile);
365
+        }
354 366
 
355
-        if ($oldfile == $newfile)
356
-            throw new Exception("'$oldfile' and '$newfile' are the same file");
367
+        if ($oldfile == $newfile) {
368
+                    throw new Exception("'$oldfile' and '$newfile' are the same file");
369
+        }
357 370
 
358
-        if(!rename($oldfile, $newfile))
359
-            return false;
371
+        if(!rename($oldfile, $newfile)) {
372
+                    return false;
373
+        }
360 374
 
361 375
         return true;
362 376
     }
@@ -372,21 +386,24 @@  discard block
 block discarded – undo
372 386
      */
373 387
     public function mkdir($dir, $dest = null, $recursive = null)
374 388
     {
375
-        if (empty($dir))
376
-            throw new Exception("Missing parameter for mkdir!");
389
+        if (empty($dir)) {
390
+                    throw new Exception("Missing parameter for mkdir!");
391
+        }
377 392
 
378
-        if (empty($dest))
379
-            $dest = '.';
393
+        if (empty($dest)) {
394
+                    $dest = '.';
395
+        }
380 396
 
381 397
         $recursive = (is_null($recursive)) ? false : $recursive;
382 398
 
383
-        if ($recursive)
384
-            mkdir("$dest/$dir", 0777, true);
385
-        else {
399
+        if ($recursive) {
400
+                    mkdir("$dest/$dir", 0777, true);
401
+        } else {
386 402
             if (!is_dir($dir))
387 403
             {
388
-                if(!mkdir("$dir", 0777))
389
-                    return false;
404
+                if(!mkdir("$dir", 0777)) {
405
+                                    return false;
406
+                }
390 407
             }
391 408
         }
392 409
         return true;
@@ -401,12 +418,14 @@  discard block
 block discarded – undo
401 418
      */
402 419
     public function rmdir($dir)
403 420
     {
404
-        if (is_null($dir) || empty($dir))
405
-            throw new Exception("Missing parameter for rmdir!");
421
+        if (is_null($dir) || empty($dir)) {
422
+                    throw new Exception("Missing parameter for rmdir!");
423
+        }
406 424
 
407
-        if (rmdir($dir))
408
-            return true;
409
-        else
410
-            return false;
425
+        if (rmdir($dir)) {
426
+                    return true;
427
+        } else {
428
+                    return false;
429
+        }
411 430
     }
412 431
 }
413 432
\ No newline at end of file
Please login to merge, or discard this patch.
src/Pear/Mail.php 1 patch
Braces   +12 added lines, -8 removed lines patch added patch discarded remove patch
@@ -74,18 +74,21 @@  discard block
 block discarded – undo
74 74
     {
75 75
         @include_once 'System.php';
76 76
 
77
-        if (!class_exists('System', false))
78
-            throw new \RuntimeException("PEAR is not installed in your system!");
77
+        if (!class_exists('System', false)) {
78
+                    throw new \RuntimeException("PEAR is not installed in your system!");
79
+        }
79 80
 
80 81
         include_once 'Net/SMTP.php';
81 82
 
82
-        if (!class_exists('\Net_SMTP', false))
83
-            throw new \RuntimeException("PEAR::Net_SMTP is not installed!");
83
+        if (!class_exists('\Net_SMTP', false)) {
84
+                    throw new \RuntimeException("PEAR::Net_SMTP is not installed!");
85
+        }
84 86
 
85 87
         @include_once 'Mail.php';
86 88
 
87
-        if (!class_exists('\Mail', false))
88
-            throw new \RuntimeException("PEAR::Mail is not installed!");
89
+        if (!class_exists('\Mail', false)) {
90
+                    throw new \RuntimeException("PEAR::Mail is not installed!");
91
+        }
89 92
     }
90 93
 
91 94
     /**
@@ -98,8 +101,9 @@  discard block
 block discarded – undo
98 101
      */
99 102
     protected function error($code, $message = null)
100 103
     {
101
-        if (!array_key_exists($code, $this->errors))
102
-            $this->errors[$message] = (is_null($message) && array_key_exists($code, $this->errors)) ? $this->errors[$code] : $message;
104
+        if (!array_key_exists($code, $this->errors)) {
105
+                    $this->errors[$message] = (is_null($message) && array_key_exists($code, $this->errors)) ? $this->errors[$code] : $message;
106
+        }
103 107
     }
104 108
 
105 109
     /**
Please login to merge, or discard this patch.
src/Db/Driver/SQLServer.php 1 patch
Braces   +23 added lines, -17 removed lines patch added patch discarded remove patch
@@ -31,15 +31,17 @@  discard block
 block discarded – undo
31 31
      */
32 32
     public function __construct($options)
33 33
     {
34
-        if (!array_key_exists("dbchar", $options))
35
-            $options["dbchar"] = "UTF-8";
34
+        if (!array_key_exists("dbchar", $options)) {
35
+                    $options["dbchar"] = "UTF-8";
36
+        }
36 37
 
37 38
         parent::__construct($options);
38 39
 
39 40
         $auto_connect = array_key_exists('auto_connect', $options) ? $options["auto_connect"] : true;
40 41
 
41
-        if ($auto_connect)
42
-            $this->connect();
42
+        if ($auto_connect) {
43
+                    $this->connect();
44
+        }
43 45
     }
44 46
 
45 47
     /**
@@ -52,11 +54,13 @@  discard block
 block discarded – undo
52 54
      */
53 55
     public function connect()
54 56
     {
55
-        if (!extension_loaded('sqlsrv'))
56
-            throw new \RuntimeException("The Sqlsrv extension is not loaded");
57
+        if (!extension_loaded('sqlsrv')) {
58
+                    throw new \RuntimeException("The Sqlsrv extension is not loaded");
59
+        }
57 60
 
58
-        if (!is_null($this->dbport) && !empty($this->dbport))
59
-            $this->dbhost .= ', ' . $this->dbport;
61
+        if (!is_null($this->dbport) && !empty($this->dbport)) {
62
+                    $this->dbhost .= ', ' . $this->dbport;
63
+        }
60 64
 
61 65
         $db_info = array("Database" => $this->dbname, "UID" => $this->dbuser, "PWD" => $this->dbpass, "CharacterSet" => $this->dbchar);
62 66
         $this->dbconn = sqlsrv_connect($this->dbhost, $db_info);
@@ -114,9 +118,9 @@  discard block
 block discarded – undo
114 118
             }
115 119
 
116 120
             $exec = sqlsrv_execute($stmt);
121
+        } else {
122
+                    $exec = $this->result = sqlsrv_query($this->dbconn, $sql, $params, array( "Scrollable" => SQLSRV_CURSOR_KEYSET ));
117 123
         }
118
-        else
119
-            $exec = $this->result = sqlsrv_query($this->dbconn, $sql, $params, array( "Scrollable" => SQLSRV_CURSOR_KEYSET ));
120 124
 
121 125
         if ($exec === false)
122 126
         {
@@ -136,8 +140,9 @@  discard block
 block discarded – undo
136 140
         $this->numFields = sqlsrv_num_fields($this->result);
137 141
         $this->rowsAffected = sqlsrv_rows_affected($this->result);
138 142
 
139
-        if ($this->transac_mode)
140
-            $this->transac_result = is_null($this->transac_result) ? $this->result: $this->transac_result && $this->result;
143
+        if ($this->transac_mode) {
144
+                    $this->transac_result = is_null($this->transac_result) ? $this->result: $this->transac_result && $this->result;
145
+        }
141 146
 
142 147
         return $this->result;
143 148
     }
@@ -204,9 +209,8 @@  discard block
 block discarded – undo
204 209
             {
205 210
                 $data[] = $row;
206 211
             }
207
-        }
208
-        else
209
-            /*
212
+        } else {
213
+                    /*
210 214
              * "This kind of exception should lead directly to a fix in your code"
211 215
              * So much production tests tell us this error is throwed because developers
212 216
              * execute toArray() before execute().
@@ -214,6 +218,7 @@  discard block
 block discarded – undo
214 218
              * Ref: http://php.net/manual/en/class.logicexception.php
215 219
              */
216 220
             throw new \LogicException('There are not data in the buffer!');
221
+        }
217 222
 
218 223
         $this->arrayResult = $data;
219 224
 
@@ -227,7 +232,8 @@  discard block
 block discarded – undo
227 232
      */
228 233
     public function __destruct()
229 234
     {
230
-        if ($this->dbconn)
231
-            sqlsrv_close($this->dbconn);
235
+        if ($this->dbconn) {
236
+                    sqlsrv_close($this->dbconn);
237
+        }
232 238
     }
233 239
 }
234 240
\ No newline at end of file
Please login to merge, or discard this patch.