SQLFunction::getStatement() - Code Metrics - Inspection of "Improve Db tests and code coverage" - Pleets/dronephp - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 87e63f...d6a1bd )

by Darío

created 2019-05-14 03:20 UTC

SQLFunction::getStatement() A

↳ Parent: SQLFunction

Complexity

Conditions	3
Paths	3

Size

Total Lines	13
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
eloc	6
nc	3
nop	0
dl	0
loc	13
ccs	7
cts	7
cp	1
crap	3
rs	10
c	0
b	0
f	0

<?php
/**
 * DronePHP (http://www.dronephp.com)
 *
 * @link      http://github.com/Pleets/DronePHP
 * @copyright Copyright (c) 2016-2018 Pleets. (http://www.pleets.org)
 * @license   http://www.dronephp.com/license
 * @author    Darío Rivera <[email protected]>
 */

namespace Drone\Db;

/**
 * SQLFunction class
 *
 * This class could be used to build specific querys that requires
 * specific database functions that data mapper does not support
 */
class SQLFunction
{
    /**
     * The SQL function name
     *
     * @var string
     */
    private $function;

    /**
     * The arguments for the SQL function
     *
     * @var array
     */
    private $arguments;

    /**
     * Returns the SQL function
     *
     * @return string
     */
    public function getFunction()
    {
        return $this->function;
    }

    /**
     * Returns the arguments for the SQL function
     *
     * @return array
     */
    public function getArguments()
    {
        return $this->arguments;
    }

    /**
     * Constructor
     *
     * @param string $function
     * @param array $args
     *
     * @return null
     */
    public function __construct($function, Array $args)

    {
        $this->function  = $function;
        $this->arguments = $args;
    }

    /**
     * Returns the SQL statment
     *
     * @return string
     */
    public function getStatement()
    {
        $arguments = $this->arguments;

        foreach ($arguments as $key => $arg)
        {
            if (is_string($arg))
// Without braces (not recommended)
if (true)
    doSomething();

// Recommended
if (true) {
    doSomething();
}
                $arguments[$key] = "'$arg'";
        }

        $arguments = implode(", ", array_values($arguments));

        return $this->function . '(' . $arguments . ')';
    }
}

1		<?php
2		/**
3		* DronePHP (http://www.dronephp.com)
4		*
5		* @link http://github.com/Pleets/DronePHP
6		* @copyright Copyright (c) 2016-2018 Pleets. (http://www.pleets.org)
7		* @license http://www.dronephp.com/license
8		* @author Darío Rivera <[email protected]>
9		*/
10
11		namespace Drone\Db;
12
13		/**
14		* SQLFunction class
15		*
16		* This class could be used to build specific querys that requires
17		* specific database functions that data mapper does not support
18		*/
19		class SQLFunction
20		{
21		/**
22		* The SQL function name
23		*
24		* @var string
25		*/
26		private $function;
27
28		/**
29		* The arguments for the SQL function
30		*
31		* @var array
32		*/
33		private $arguments;
34
35		/**
36		* Returns the SQL function
37		*
38		* @return string
39		*/
40		public function getFunction()
41		{
42		return $this->function;
43		}
44
45		/**
46		* Returns the arguments for the SQL function
47		*
48		* @return array
49		*/
50		public function getArguments()
51		{
52		return $this->arguments;
53		}
54
55		/**
56		* Constructor
57		*
58		* @param string $function
59		* @param array $args
60		*
61		* @return null
62		*/
63	2	public function __construct($function, Array $args)
		0 ignored issues – show Coding Style introduced 2019-05-11 23:22 UTC by Report Bug Copy Issue Report As per coding-style, PHP keywords should be in lowercase; expected `array`, but found `Array`. Loading history...
64		{
65	2	$this->function = $function;
66	2	$this->arguments = $args;
67	2	}
68
69		/**
70		* Returns the SQL statment
71		*
72		* @return string
73		*/
74	2	public function getStatement()
75		{
76	2	$arguments = $this->arguments;
77
78	2	foreach ($arguments as $key => $arg)
79		{
80	2	if (is_string($arg))
		0 ignored issues – show Coding Style Best Practice introduced 2019-05-11 23:22 UTC by Report Bug Copy Issue Report It is generally a best practice to always use braces with control structures. Adding braces to control structures avoids accidental mistakes as your code changes: // Without braces (not recommended) if (true) doSomething(); // Recommended if (true) { doSomething(); } Loading history...
81	2	$arguments[$key] = "'$arg'";
82		}
83
84	2	$arguments = implode(", ", array_values($arguments));
85
86	2	return $this->function . '(' . $arguments . ')';
87		}
88		}

Pleets / dronephp

Push — master ( 87e63f...d6a1bd )

SQLFunction::getStatement() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like