Application::__construct() - Code Metrics - Inspection of "Add a simple test for Router class" - Pleets/dronephp - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( b0d82b...8f50d0 )

by Darío
created 2019-03-28 23:10 UTC
Application::__construct() C

↳ Parent: Application
Complexity

Conditions	16
Paths	150
Size

Total Lines	74
Code Lines	41
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	16
eloc	41
nc	150
nop	1
dl	0
loc	74
rs	5.15
c	0
b	0
f	0
How to fix Long Method Complexity

<?php
/**
 * DronePHP (http://www.dronephp.com)
 *
 * @link      http://github.com/Pleets/DronePHP
 * @copyright Copyright (c) 2016-2018 Pleets. (http://www.pleets.org)
 * @license   http://www.dronephp.com/license
 * @author    Darío Rivera <[email protected]>
 */

namespace Drone\Mvc;

use Drone\FileSystem\Shell;

/**
 * Application class
 *
 * This is the main class for mvc pattern
 */
class Application
{
    /**
     * Module path
     *
     * @var array
     */
    protected $modulePath;

    /**
     * List of modules available
     *
     * @var array
     */
    private $modules;

    /**
     * The router instance
     *
     * @var Router
     */
    private $router;

    /**
     * Development or production mode
     *
     * @var boolean
     */
    private $devMode;

    /**
     * Returns the router instance
     *
     * @return Router
     */
    public function getRouter()
    {
        return $this->router;
    }

    /**
     * Constructor
     *
     * @param array $init_parameters
     *
     * @throws \InvalidArgumentException
     * @throws \RuntimeException
     */
    public function __construct(Array $init_parameters)
    {
        # start sessions
        if (!isset($_SESSION))
            session_start();

        if (!array_key_exists('environment', $init_parameters))
            throw new \InvalidArgumentException("The 'environment' key was not defined");

        if (!array_key_exists('dev_mode', $init_parameters['environment']))
            throw new \InvalidArgumentException("The 'dev_mode' key was not defined");

        $this->devMode = $init_parameters["environment"]["dev_mode"];

        if (!array_key_exists('modules', $init_parameters))
            throw new \InvalidArgumentException("The 'modules' key was not defined");

        $this->modules = $init_parameters["modules"];

        # setting module path
        $this->modulePath = (!array_key_exists('module_path', $init_parameters['environment']))
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
            ? 'module'
            : $init_parameters['environment']['module_path'];

        #  setting development or production environment
        if ($this->devMode)
        {
            ini_set('display_errors', 1);
            error_reporting(-1);
        }
        else
        {
            ini_set('display_errors', 0);
            error_reporting(0);
        }

        $this->loadModules($this->modules);

        if (!array_key_exists('router', $init_parameters))
            throw new \InvalidArgumentException("The 'router' key was not defined");

        if (!array_key_exists('routes', $init_parameters["router"]))
            throw new \InvalidArgumentException("The 'routes' key was not defined");

        $this->router = new Router($init_parameters["router"]["routes"]);

        if (!array_key_exists('base_path', $init_parameters['environment']))
            throw new \InvalidArgumentException("The 'base_path' key was not defined");

        $this->router->setBasePath($init_parameters["environment"]["base_path"]);

        # load routes from init_parameters
        foreach ($init_parameters["router"]["routes"] as $name => $route)
        {
            if ($route instanceof \Zend\Router\Http\RouteInterface)
                $this->getRouter()->addZendRoute($name, $route);
            else
                $this->getRouter()->addRoute($route);
        }

        # load routes from each module
        foreach ($this->modules as $module)
        {
            if (file_exists($this->modulePath . "/$module/config/module.config.php"))
            {
                $module_config_file = require($this->modulePath . "/$module/config/module.config.php");

                if (!array_key_exists('router', $module_config_file))
                    throw new \RuntimeException("The 'router' key was not defined in the config file for module '$module'");

                if (!array_key_exists('routes', $module_config_file["router"]))
                    throw new \RuntimeException("The 'routes' key was not defined in the config file for module '$module'");

                $this->getRouter()->addRoute($module_config_file["router"]["routes"]);
            }
        }
    }

    /**
     * Loads module classes and autoloading functions
     *
     * @param array $modules
     *
     * @throws RuntimeException
     *
     * @return null
     */
    private function loadModules($modules)
    {
        if (count($modules))
        {
            foreach ($modules as $module)
            {
                /*
                 *  This instruction includes each module declared.
                 *  Each module has an autoloader to load its classes (controllers and models)
                 */
                if (file_exists($this->modulePath ."/". $module."/Module.php"))
                if (file_exists(/** @scrutinizer ignore-type */ $this->modulePath ."/". $module."/Module.php"))
                    include($this->modulePath ."/". $module."/Module.php");

                spl_autoload_register($module . "\Module::loader");
            }
        }
        else
            throw new \RuntimeException("The application must have at least one module");
    }

    /**
     * Runs the application
     *
     * @return null
     */
    public function run()
    {
        $module     = isset($_GET["module"])     ? $_GET["module"] : null;
        $controller = isset($_GET["controller"]) ? $_GET["controller"] : null;
        $view       = isset($_GET["view"])       ? $_GET["view"] : null;

        $request = new  \Zend\Http\Request();

        # build URI
        $uri = '';
        $uri .= !empty($module)     ? '/' . $module : "";
        $uri .= !empty($controller) ? '/' . $controller : "";
        $uri .= !empty($view)       ? '/' . $view : "";

        if (empty($uri))
            $uri = "/";

        $request->setUri($uri);

        $match = $this->router->getZendRouter()->match($request);

        if (!is_null($match))
        {
            $params = $match->getParams();
            $parts  = explode("\\", $params["controller"]);

            $module     = $parts[0];
            $controller = $parts[2];
            $view       = $params["action"];

            $this->router->setIdentifiers($module, $controller, $view);
        }
        else
            $this->router->setIdentifiers($module, $controller, $view);

        $this->router->run();
    }
}
Pleets / dronephp

Push — master ( b0d82b...8f50d0 )

Application::__construct() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like
