@@ -107,11 +107,12 @@ |
||
107 | 107 | { |
108 | 108 | $this->$prop = $value; |
109 | 109 | |
110 | - if (!in_array($prop, $this->changedFields)) |
|
111 | - $this->changedFields[] = $prop; |
|
110 | + if (!in_array($prop, $this->changedFields)) { |
|
111 | + $this->changedFields[] = $prop; |
|
112 | + } |
|
113 | + } else { |
|
114 | + throw new \LogicException("The property '$prop' does not exists in the class ' " . get_class($this) . " '"); |
|
112 | 115 | } |
113 | - else |
|
114 | - throw new \LogicException("The property '$prop' does not exists in the class ' " . get_class($this) . " '"); |
|
115 | 116 | } |
116 | 117 | } |
117 | 118 |
@@ -31,15 +31,17 @@ discard block |
||
31 | 31 | */ |
32 | 32 | public function __construct($options) |
33 | 33 | { |
34 | - if (!array_key_exists("dbchar", $options)) |
|
35 | - $options["dbchar"] = "AL32UTF8"; |
|
34 | + if (!array_key_exists("dbchar", $options)) { |
|
35 | + $options["dbchar"] = "AL32UTF8"; |
|
36 | + } |
|
36 | 37 | |
37 | 38 | parent::__construct($options); |
38 | 39 | |
39 | 40 | $auto_connect = array_key_exists('auto_connect', $options) ? $options["auto_connect"] : true; |
40 | 41 | |
41 | - if ($auto_connect) |
|
42 | - $this->connect(); |
|
42 | + if ($auto_connect) { |
|
43 | + $this->connect(); |
|
44 | + } |
|
43 | 45 | } |
44 | 46 | |
45 | 47 | /** |
@@ -52,8 +54,9 @@ discard block |
||
52 | 54 | */ |
53 | 55 | public function connect() |
54 | 56 | { |
55 | - if (!extension_loaded('oci8')) |
|
56 | - throw new \RuntimeException("The Oci8 extension is not loaded"); |
|
57 | + if (!extension_loaded('oci8')) { |
|
58 | + throw new \RuntimeException("The Oci8 extension is not loaded"); |
|
59 | + } |
|
57 | 60 | |
58 | 61 | $connection_string = (is_null($this->dbhost) || empty($this->dbhost)) |
59 | 62 | ? $this->dbname |
@@ -106,14 +109,15 @@ discard block |
||
106 | 109 | ]; |
107 | 110 | |
108 | 111 | $this->error($error["message"]); |
112 | + } else { |
|
113 | + $this->error($error["code"], $error["message"]); |
|
109 | 114 | } |
110 | - else |
|
111 | - $this->error($error["code"], $error["message"]); |
|
112 | 115 | |
113 | - if (array_key_exists("code", $error)) |
|
114 | - throw new Exception\InvalidQueryException($error["message"], $error["code"]); |
|
115 | - else |
|
116 | - throw new Exception\InvalidQueryException($error["message"]); |
|
116 | + if (array_key_exists("code", $error)) { |
|
117 | + throw new Exception\InvalidQueryException($error["message"], $error["code"]); |
|
118 | + } else { |
|
119 | + throw new Exception\InvalidQueryException($error["message"]); |
|
120 | + } |
|
117 | 121 | } |
118 | 122 | |
119 | 123 | # Bound variables |
@@ -151,8 +155,9 @@ discard block |
||
151 | 155 | $this->numRows = count($rows); |
152 | 156 | $this->numFields = oci_num_fields($stid); |
153 | 157 | |
154 | - if ($this->transac_mode) |
|
155 | - $this->transac_result = is_null($this->transac_result) ? $stid: $this->transac_result && $stid; |
|
158 | + if ($this->transac_mode) { |
|
159 | + $this->transac_result = is_null($this->transac_result) ? $stid: $this->transac_result && $stid; |
|
160 | + } |
|
156 | 161 | |
157 | 162 | $this->result = $stid; |
158 | 163 | |
@@ -201,9 +206,8 @@ discard block |
||
201 | 206 | { |
202 | 207 | $data[] = $row; |
203 | 208 | } |
204 | - } |
|
205 | - else |
|
206 | - /* |
|
209 | + } else { |
|
210 | + /* |
|
207 | 211 | * "This kind of exception should lead directly to a fix in your code" |
208 | 212 | * So much production tests tell us this error is throwed because developers |
209 | 213 | * execute toArray() before execute(). |
@@ -211,6 +215,7 @@ discard block |
||
211 | 215 | * Ref: http://php.net/manual/en/class.logicexception.php |
212 | 216 | */ |
213 | 217 | throw new \LogicException('There are not data in the buffer!'); |
218 | + } |
|
214 | 219 | |
215 | 220 | $this->arrayResult = $data; |
216 | 221 | |
@@ -224,7 +229,8 @@ discard block |
||
224 | 229 | */ |
225 | 230 | public function __destruct() |
226 | 231 | { |
227 | - if ($this->dbconn) |
|
228 | - oci_close($this->dbconn); |
|
232 | + if ($this->dbconn) { |
|
233 | + oci_close($this->dbconn); |
|
234 | + } |
|
229 | 235 | } |
230 | 236 | } |
231 | 237 | \ No newline at end of file |
@@ -73,11 +73,11 @@ discard block |
||
73 | 73 | { |
74 | 74 | $k++; |
75 | 75 | |
76 | - if (is_null($value)) |
|
77 | - $parsed_where[] = "$key IS NULL"; |
|
78 | - elseif ($value instanceof SQLFunction) |
|
79 | - $parsed_where[] = "$key = " . $value->getStatement(); |
|
80 | - elseif (is_array($value)) |
|
76 | + if (is_null($value)) { |
|
77 | + $parsed_where[] = "$key IS NULL"; |
|
78 | + } elseif ($value instanceof SQLFunction) { |
|
79 | + $parsed_where[] = "$key = " . $value->getStatement(); |
|
80 | + } elseif (is_array($value)) |
|
81 | 81 | { |
82 | 82 | $parsed_in = []; |
83 | 83 | |
@@ -100,8 +100,7 @@ discard block |
||
100 | 100 | } |
101 | 101 | |
102 | 102 | $parsed_where[] = "$key IN (" . implode(", ", $parsed_in) . ")"; |
103 | - } |
|
104 | - else |
|
103 | + } else |
|
105 | 104 | { |
106 | 105 | switch ($driver) |
107 | 106 | { |
@@ -119,18 +118,19 @@ discard block |
||
119 | 118 | } |
120 | 119 | |
121 | 120 | $where = "WHERE \r\n\t" . implode(" AND\r\n\t", $parsed_where); |
121 | + } else { |
|
122 | + $where = ""; |
|
122 | 123 | } |
123 | - else |
|
124 | - $where = ""; |
|
125 | 124 | |
126 | 125 | $table = $this->entity->getTableName(); |
127 | 126 | |
128 | 127 | $sql = "SELECT * \r\nFROM {$table}\r\n$where"; |
129 | 128 | |
130 | - if (count($bind_values)) |
|
131 | - $this->getDriver()->getDb()->execute($sql, $bind_values); |
|
132 | - else |
|
133 | - $this->getDriver()->getDb()->execute($sql); |
|
129 | + if (count($bind_values)) { |
|
130 | + $this->getDriver()->getDb()->execute($sql, $bind_values); |
|
131 | + } else { |
|
132 | + $this->getDriver()->getDb()->execute($sql); |
|
133 | + } |
|
134 | 134 | |
135 | 135 | return $this->getDriver()->getDb()->getArrayResult(); |
136 | 136 | } |
@@ -147,8 +147,9 @@ discard block |
||
147 | 147 | */ |
148 | 148 | public function insert(Array $data) |
149 | 149 | { |
150 | - if (!count($data)) |
|
151 | - throw new \LogicException("Missing values for INSERT statement!"); |
|
150 | + if (!count($data)) { |
|
151 | + throw new \LogicException("Missing values for INSERT statement!"); |
|
152 | + } |
|
152 | 153 | |
153 | 154 | $bind_values = []; |
154 | 155 | |
@@ -171,11 +172,11 @@ discard block |
||
171 | 172 | continue; |
172 | 173 | } |
173 | 174 | |
174 | - if (is_null($value)) |
|
175 | - $value = "NULL"; |
|
176 | - elseif ($value instanceof SQLFunction) |
|
177 | - $value = $value->getStatement(); |
|
178 | - else { |
|
175 | + if (is_null($value)) { |
|
176 | + $value = "NULL"; |
|
177 | + } elseif ($value instanceof SQLFunction) { |
|
178 | + $value = $value->getStatement(); |
|
179 | + } else { |
|
179 | 180 | |
180 | 181 | switch ($driver) |
181 | 182 | { |
@@ -225,11 +226,13 @@ discard block |
||
225 | 226 | { |
226 | 227 | $parsed_set = []; |
227 | 228 | |
228 | - if (!count($set)) |
|
229 | - throw new \LogicException("You cannot update rows without SET clause"); |
|
229 | + if (!count($set)) { |
|
230 | + throw new \LogicException("You cannot update rows without SET clause"); |
|
231 | + } |
|
230 | 232 | |
231 | - if (!count($where)) |
|
232 | - throw new SecurityException("You cannot update rows without WHERE clause!"); |
|
233 | + if (!count($where)) { |
|
234 | + throw new SecurityException("You cannot update rows without WHERE clause!"); |
|
235 | + } |
|
233 | 236 | |
234 | 237 | $bind_values = []; |
235 | 238 | |
@@ -241,11 +244,11 @@ discard block |
||
241 | 244 | { |
242 | 245 | $k++; |
243 | 246 | |
244 | - if (is_null($value)) |
|
245 | - $parsed_set[] = "$key = NULL"; |
|
246 | - elseif ($value instanceof SQLFunction) |
|
247 | - $parsed_set[] = "$key = " . $value->getStatement(); |
|
248 | - elseif (is_array($value)) |
|
247 | + if (is_null($value)) { |
|
248 | + $parsed_set[] = "$key = NULL"; |
|
249 | + } elseif ($value instanceof SQLFunction) { |
|
250 | + $parsed_set[] = "$key = " . $value->getStatement(); |
|
251 | + } elseif (is_array($value)) |
|
249 | 252 | { |
250 | 253 | $parsed_in = []; |
251 | 254 | |
@@ -256,8 +259,9 @@ discard block |
||
256 | 259 | case 'Oci8': |
257 | 260 | |
258 | 261 | # [POSSIBLE BUG] - To Future revision (What about non-string values ?) |
259 | - if (is_string($in_value)) |
|
260 | - $parsed_in[] = ":$k"; |
|
262 | + if (is_string($in_value)) { |
|
263 | + $parsed_in[] = ":$k"; |
|
264 | + } |
|
261 | 265 | |
262 | 266 | $bind_values[":$k"] = $in_value; |
263 | 267 | break; |
@@ -272,8 +276,7 @@ discard block |
||
272 | 276 | } |
273 | 277 | |
274 | 278 | $parsed_set[] = "$key IN (" . implode(", ", $parsed_in) . ")"; |
275 | - } |
|
276 | - else |
|
279 | + } else |
|
277 | 280 | { |
278 | 281 | switch ($driver) |
279 | 282 | { |
@@ -298,11 +301,11 @@ discard block |
||
298 | 301 | { |
299 | 302 | $k++; |
300 | 303 | |
301 | - if (is_null($value)) |
|
302 | - $parsed_where[] = "$key IS NULL"; |
|
303 | - elseif ($value instanceof SQLFunction) |
|
304 | - $parsed_where[] = "$key = " . $value->getStatement(); |
|
305 | - elseif (is_array($value)) |
|
304 | + if (is_null($value)) { |
|
305 | + $parsed_where[] = "$key IS NULL"; |
|
306 | + } elseif ($value instanceof SQLFunction) { |
|
307 | + $parsed_where[] = "$key = " . $value->getStatement(); |
|
308 | + } elseif (is_array($value)) |
|
306 | 309 | { |
307 | 310 | $parsed_in = []; |
308 | 311 | |
@@ -325,8 +328,7 @@ discard block |
||
325 | 328 | } |
326 | 329 | |
327 | 330 | $parsed_where[] = "$key IN (" . implode(", ", $parsed_in) . ")"; |
328 | - } |
|
329 | - else |
|
331 | + } else |
|
330 | 332 | { |
331 | 333 | switch ($driver) |
332 | 334 | { |
@@ -378,11 +380,11 @@ discard block |
||
378 | 380 | { |
379 | 381 | $k++; |
380 | 382 | |
381 | - if (is_null($value)) |
|
382 | - $parsed_where[] = "$key IS NULL"; |
|
383 | - elseif ($value instanceof SQLFunction) |
|
384 | - $parsed_where[] = "$key = " . $value->getStatement(); |
|
385 | - elseif (is_array($value)) |
|
383 | + if (is_null($value)) { |
|
384 | + $parsed_where[] = "$key IS NULL"; |
|
385 | + } elseif ($value instanceof SQLFunction) { |
|
386 | + $parsed_where[] = "$key = " . $value->getStatement(); |
|
387 | + } elseif (is_array($value)) |
|
386 | 388 | { |
387 | 389 | $parsed_in = []; |
388 | 390 | |
@@ -405,8 +407,7 @@ discard block |
||
405 | 407 | } |
406 | 408 | |
407 | 409 | $parsed_where[] = "$key IN (" . implode(", ", $parsed_in) . ")"; |
408 | - } |
|
409 | - else |
|
410 | + } else |
|
410 | 411 | { |
411 | 412 | switch ($driver) |
412 | 413 | { |
@@ -424,9 +425,9 @@ discard block |
||
424 | 425 | } |
425 | 426 | |
426 | 427 | $where = "\r\nWHERE \r\n\t" . implode(" AND\r\n\t", $parsed_where); |
428 | + } else { |
|
429 | + throw new SecurityException("You cannot delete rows without WHERE clause!. Use TRUNCATE statement instead."); |
|
427 | 430 | } |
428 | - else |
|
429 | - throw new SecurityException("You cannot delete rows without WHERE clause!. Use TRUNCATE statement instead."); |
|
430 | 431 | |
431 | 432 | $table = $this->entity->getTableName(); |
432 | 433 |
@@ -31,15 +31,17 @@ discard block |
||
31 | 31 | */ |
32 | 32 | public function __construct($options) |
33 | 33 | { |
34 | - if (!array_key_exists("dbchar", $options)) |
|
35 | - $options["dbchar"] = "UTF-8"; |
|
34 | + if (!array_key_exists("dbchar", $options)) { |
|
35 | + $options["dbchar"] = "UTF-8"; |
|
36 | + } |
|
36 | 37 | |
37 | 38 | parent::__construct($options); |
38 | 39 | |
39 | 40 | $auto_connect = array_key_exists('auto_connect', $options) ? $options["auto_connect"] : true; |
40 | 41 | |
41 | - if ($auto_connect) |
|
42 | - $this->connect(); |
|
42 | + if ($auto_connect) { |
|
43 | + $this->connect(); |
|
44 | + } |
|
43 | 45 | } |
44 | 46 | |
45 | 47 | /** |
@@ -52,11 +54,13 @@ discard block |
||
52 | 54 | */ |
53 | 55 | public function connect() |
54 | 56 | { |
55 | - if (!extension_loaded('sqlsrv')) |
|
56 | - throw new \RuntimeException("The Sqlsrv extension is not loaded"); |
|
57 | + if (!extension_loaded('sqlsrv')) { |
|
58 | + throw new \RuntimeException("The Sqlsrv extension is not loaded"); |
|
59 | + } |
|
57 | 60 | |
58 | - if (!is_null($this->dbport) && !empty($this->dbport)) |
|
59 | - $this->dbhost .= ', ' . $this->dbport; |
|
61 | + if (!is_null($this->dbport) && !empty($this->dbport)) { |
|
62 | + $this->dbhost .= ', ' . $this->dbport; |
|
63 | + } |
|
60 | 64 | |
61 | 65 | $db_info = array("Database" => $this->dbname, "UID" => $this->dbuser, "PWD" => $this->dbpass, "CharacterSet" => $this->dbchar); |
62 | 66 | $conn = sqlsrv_connect($this->dbhost, $db_info); |
@@ -137,13 +141,13 @@ discard block |
||
137 | 141 | } |
138 | 142 | |
139 | 143 | $exec = sqlsrv_execute($stmt); |
140 | - } |
|
141 | - else |
|
144 | + } else |
|
142 | 145 | { |
143 | - if ($isSelectStm) |
|
144 | - $exec = $this->result = sqlsrv_query($this->dbconn, $sql, $params, array( "Scrollable" => SQLSRV_CURSOR_KEYSET )); |
|
145 | - else |
|
146 | - $exec = $this->result = sqlsrv_query($this->dbconn, $sql, $params); |
|
146 | + if ($isSelectStm) { |
|
147 | + $exec = $this->result = sqlsrv_query($this->dbconn, $sql, $params, array( "Scrollable" => SQLSRV_CURSOR_KEYSET )); |
|
148 | + } else { |
|
149 | + $exec = $this->result = sqlsrv_query($this->dbconn, $sql, $params); |
|
150 | + } |
|
147 | 151 | } |
148 | 152 | |
149 | 153 | if ($exec === false) |
@@ -163,11 +167,13 @@ discard block |
||
163 | 167 | $this->numRows = sqlsrv_has_rows($this->result) ? sqlsrv_num_rows($this->result) : $this->numRows; |
164 | 168 | $this->numFields = sqlsrv_num_fields($this->result); |
165 | 169 | |
166 | - if ($isInsertStm || $isUpdateStm || $isDeleteStm) |
|
167 | - $this->rowsAffected = sqlsrv_rows_affected($this->result); |
|
170 | + if ($isInsertStm || $isUpdateStm || $isDeleteStm) { |
|
171 | + $this->rowsAffected = sqlsrv_rows_affected($this->result); |
|
172 | + } |
|
168 | 173 | |
169 | - if ($this->transac_mode) |
|
170 | - $this->transac_result = is_null($this->transac_result) ? $this->result: $this->transac_result && $this->result; |
|
174 | + if ($this->transac_mode) { |
|
175 | + $this->transac_result = is_null($this->transac_result) ? $this->result: $this->transac_result && $this->result; |
|
176 | + } |
|
171 | 177 | |
172 | 178 | return $this->result; |
173 | 179 | } |
@@ -234,9 +240,8 @@ discard block |
||
234 | 240 | { |
235 | 241 | $data[] = $row; |
236 | 242 | } |
237 | - } |
|
238 | - else |
|
239 | - /* |
|
243 | + } else { |
|
244 | + /* |
|
240 | 245 | * "This kind of exception should lead directly to a fix in your code" |
241 | 246 | * So much production tests tell us this error is throwed because developers |
242 | 247 | * execute toArray() before execute(). |
@@ -244,6 +249,7 @@ discard block |
||
244 | 249 | * Ref: http://php.net/manual/en/class.logicexception.php |
245 | 250 | */ |
246 | 251 | throw new \LogicException('There are not data in the buffer!'); |
252 | + } |
|
247 | 253 | |
248 | 254 | $this->arrayResult = $data; |
249 | 255 | |
@@ -257,7 +263,8 @@ discard block |
||
257 | 263 | */ |
258 | 264 | public function __destruct() |
259 | 265 | { |
260 | - if ($this->dbconn) |
|
261 | - sqlsrv_close($this->dbconn); |
|
266 | + if ($this->dbconn) { |
|
267 | + sqlsrv_close($this->dbconn); |
|
268 | + } |
|
262 | 269 | } |
263 | 270 | } |
264 | 271 | \ No newline at end of file |
@@ -58,8 +58,9 @@ discard block |
||
58 | 58 | public function prepare() |
59 | 59 | { |
60 | 60 | # start sessions |
61 | - if (!isset($_SESSION)) |
|
62 | - session_start(); |
|
61 | + if (!isset($_SESSION)) { |
|
62 | + session_start(); |
|
63 | + } |
|
63 | 64 | } |
64 | 65 | |
65 | 66 | /** |
@@ -91,8 +92,7 @@ discard block |
||
91 | 92 | |
92 | 93 | // Best way to view all possible errors |
93 | 94 | error_reporting(-1); |
94 | - } |
|
95 | - else { |
|
95 | + } else { |
|
96 | 96 | ini_set('display_errors', 0); |
97 | 97 | error_reporting(-1); |
98 | 98 | } |
@@ -109,10 +109,11 @@ discard block |
||
109 | 109 | |
110 | 110 | foreach ($app_config_file["router"]["routes"] as $name => $route) |
111 | 111 | { |
112 | - if ($route instanceof \Zend\Router\Http\RouteInterface) |
|
113 | - $this->getRouter()->addZendRoute($name, $route); |
|
114 | - else |
|
115 | - $this->getRouter()->addRoute($route); |
|
112 | + if ($route instanceof \Zend\Router\Http\RouteInterface) { |
|
113 | + $this->getRouter()->addZendRoute($name, $route); |
|
114 | + } else { |
|
115 | + $this->getRouter()->addRoute($route); |
|
116 | + } |
|
116 | 117 | } |
117 | 118 | } |
118 | 119 | |
@@ -146,14 +147,15 @@ discard block |
||
146 | 147 | * This instruction include each module declared in application.config.php |
147 | 148 | * Each module has an autoloader to load its classes (controllers and models) |
148 | 149 | */ |
149 | - if (file_exists("module/".$module."/Module.php")) |
|
150 | - include("module/".$module."/Module.php"); |
|
150 | + if (file_exists("module/".$module."/Module.php")) { |
|
151 | + include("module/".$module."/Module.php"); |
|
152 | + } |
|
151 | 153 | |
152 | 154 | spl_autoload_register($module . "\Module::loader"); |
153 | 155 | } |
156 | + } else { |
|
157 | + throw new \RuntimeException("The application must have at least one module"); |
|
154 | 158 | } |
155 | - else |
|
156 | - throw new \RuntimeException("The application must have at least one module"); |
|
157 | 159 | } |
158 | 160 | |
159 | 161 | /** |
@@ -175,8 +177,9 @@ discard block |
||
175 | 177 | $uri .= !empty($controller) ? '/' . $controller : ""; |
176 | 178 | $uri .= !empty($view) ? '/' . $view : ""; |
177 | 179 | |
178 | - if (empty($uri)) |
|
179 | - $uri = "/"; |
|
180 | + if (empty($uri)) { |
|
181 | + $uri = "/"; |
|
182 | + } |
|
180 | 183 | |
181 | 184 | $request->setUri($uri); |
182 | 185 | |
@@ -191,9 +194,9 @@ discard block |
||
191 | 194 | $view = $params["action"]; |
192 | 195 | |
193 | 196 | $this->router->setIdentifiers($module, $controller, $view); |
197 | + } else { |
|
198 | + $this->router->setIdentifiers($module, $controller, $view); |
|
194 | 199 | } |
195 | - else |
|
196 | - $this->router->setIdentifiers($module, $controller, $view); |
|
197 | 200 | |
198 | 201 | $this->router->run(); |
199 | 202 | } |
@@ -216,8 +216,9 @@ discard block |
||
216 | 216 | */ |
217 | 217 | public function getArrayResult() |
218 | 218 | { |
219 | - if (!empty($this->arrayResult)) |
|
220 | - return $this->arrayResult; |
|
219 | + if (!empty($this->arrayResult)) { |
|
220 | + return $this->arrayResult; |
|
221 | + } |
|
221 | 222 | |
222 | 223 | return $this->toArray(); |
223 | 224 | } |
@@ -313,8 +314,9 @@ discard block |
||
313 | 314 | */ |
314 | 315 | public function autocommit($value) |
315 | 316 | { |
316 | - if ($this->transac_mode) |
|
317 | - throw new \LogicException("You cannot change autocommit behavior during a transaction"); |
|
317 | + if ($this->transac_mode) { |
|
318 | + throw new \LogicException("You cannot change autocommit behavior during a transaction"); |
|
319 | + } |
|
318 | 320 | |
319 | 321 | $this->autocommit = $value; |
320 | 322 | } |
@@ -330,8 +332,9 @@ discard block |
||
330 | 332 | { |
331 | 333 | foreach ($options as $option => $value) |
332 | 334 | { |
333 | - if (property_exists(__CLASS__, strtolower($option)) && method_exists($this, 'set'.$option)) |
|
334 | - $this->{'set'.$option}($value); |
|
335 | + if (property_exists(__CLASS__, strtolower($option)) && method_exists($this, 'set'.$option)) { |
|
336 | + $this->{'set'.$option}($value); |
|
337 | + } |
|
335 | 338 | } |
336 | 339 | } |
337 | 340 | |
@@ -375,8 +378,9 @@ discard block |
||
375 | 378 | */ |
376 | 379 | public function reconnect() |
377 | 380 | { |
378 | - if (!$this->isConnected()) |
|
379 | - throw new \LogicException("Connection was not established"); |
|
381 | + if (!$this->isConnected()) { |
|
382 | + throw new \LogicException("Connection was not established"); |
|
383 | + } |
|
380 | 384 | |
381 | 385 | $this->disconnect(); |
382 | 386 | return $this->connect(); |
@@ -405,8 +409,9 @@ discard block |
||
405 | 409 | */ |
406 | 410 | public function disconnect() |
407 | 411 | { |
408 | - if (!$this->isConnected()) |
|
409 | - throw new \LogicException("Connection was not established"); |
|
412 | + if (!$this->isConnected()) { |
|
413 | + throw new \LogicException("Connection was not established"); |
|
414 | + } |
|
410 | 415 | } |
411 | 416 | |
412 | 417 | /** |
@@ -418,11 +423,13 @@ discard block |
||
418 | 423 | */ |
419 | 424 | public function beginTransaction() |
420 | 425 | { |
421 | - if (!$this->isConnected()) |
|
422 | - $this->connect(); |
|
426 | + if (!$this->isConnected()) { |
|
427 | + $this->connect(); |
|
428 | + } |
|
423 | 429 | |
424 | - if ($this->transac_mode) |
|
425 | - throw new \LogicException($this->standardErrors[Errno::DB_TRANSACTION_STARTED]); |
|
430 | + if ($this->transac_mode) { |
|
431 | + throw new \LogicException($this->standardErrors[Errno::DB_TRANSACTION_STARTED]); |
|
432 | + } |
|
426 | 433 | |
427 | 434 | $this->transac_mode = true; |
428 | 435 | } |
@@ -436,16 +443,19 @@ discard block |
||
436 | 443 | */ |
437 | 444 | public function endTransaction() |
438 | 445 | { |
439 | - if (!$this->transac_mode) |
|
440 | - throw new \LogicException($this->standardErrors[Errno::DB_TRANSACTION_NOT_STARTED]); |
|
446 | + if (!$this->transac_mode) { |
|
447 | + throw new \LogicException($this->standardErrors[Errno::DB_TRANSACTION_NOT_STARTED]); |
|
448 | + } |
|
441 | 449 | |
442 | - if (is_null($this->transac_result)) |
|
443 | - throw new \LogicException($this->standardErrors[Errno::DB_TRANSACTION_EMPTY]); |
|
450 | + if (is_null($this->transac_result)) { |
|
451 | + throw new \LogicException($this->standardErrors[Errno::DB_TRANSACTION_EMPTY]); |
|
452 | + } |
|
444 | 453 | |
445 | - if ($this->transac_result) |
|
446 | - $this->commit(); |
|
447 | - else |
|
448 | - $this->rollback(); |
|
454 | + if ($this->transac_result) { |
|
455 | + $this->commit(); |
|
456 | + } else { |
|
457 | + $this->rollback(); |
|
458 | + } |
|
449 | 459 | |
450 | 460 | $this->result = $this->transac_result; |
451 | 461 |
@@ -84,12 +84,10 @@ discard block |
||
84 | 84 | |
85 | 85 | try { |
86 | 86 | $conn->disconnect(); |
87 | - } |
|
88 | - catch (\Exception $e) |
|
87 | + } catch (\Exception $e) |
|
89 | 88 | { |
90 | 89 | $errorObject = ($e instanceof \LogicException); |
91 | - } |
|
92 | - finally |
|
90 | + } finally |
|
93 | 91 | { |
94 | 92 | $this->assertNotTrue($conn->isConnected()); |
95 | 93 | $this->assertTrue($errorObject, $e->getMessage()); |
@@ -125,12 +123,10 @@ discard block |
||
125 | 123 | |
126 | 124 | try { |
127 | 125 | $conn->reconnect(); |
128 | - } |
|
129 | - catch (\Exception $e) |
|
126 | + } catch (\Exception $e) |
|
130 | 127 | { |
131 | 128 | $errorObject = ($e instanceof \LogicException); |
132 | - } |
|
133 | - finally |
|
129 | + } finally |
|
134 | 130 | { |
135 | 131 | $this->assertTrue($errorObject, $e->getMessage()); |
136 | 132 | $this->assertNotTrue($conn->isConnected()); |
@@ -155,13 +151,11 @@ discard block |
||
155 | 151 | |
156 | 152 | try { |
157 | 153 | $mysqliObject = $conn->connect(); |
158 | - } |
|
159 | - catch (\Exception $e) |
|
154 | + } catch (\Exception $e) |
|
160 | 155 | { |
161 | 156 | $errorObject = ($e instanceof ConnectionException); |
162 | 157 | $message = $e->getMessage(); |
163 | - } |
|
164 | - finally |
|
158 | + } finally |
|
165 | 159 | { |
166 | 160 | $this->assertTrue($errorObject, $message); |
167 | 161 | $this->assertNotTrue($conn->isConnected()); |
@@ -241,13 +235,11 @@ discard block |
||
241 | 235 | { |
242 | 236 | $sql = "INSERT INTO MYTABLE (DESCRIPTION, WRONG) VALUES ('Hello world!')"; |
243 | 237 | $result = $conn->execute($sql); |
244 | - } |
|
245 | - catch (\Exception $e) |
|
238 | + } catch (\Exception $e) |
|
246 | 239 | { |
247 | 240 | $errorObject = ($e instanceof InvalidQueryException); |
248 | 241 | $message = $e->getMessage(); |
249 | - } |
|
250 | - finally |
|
242 | + } finally |
|
251 | 243 | { |
252 | 244 | $this->assertTrue($errorObject, $message); |
253 | 245 | } |
@@ -516,8 +508,7 @@ discard block |
||
516 | 508 | |
517 | 509 | $sql = "INSERT INTO MYTABLE (DESCRIPTION, WRONG) VALUES ('TRANS_SHORTCUT_2')"; |
518 | 510 | $result = $conn->execute($sql); |
519 | - } |
|
520 | - catch (InvalidQueryException $e) |
|
511 | + } catch (InvalidQueryException $e) |
|
521 | 512 | { |
522 | 513 | $message = $e->getMessage(); |
523 | 514 | #·not necessary! |
@@ -141,13 +141,11 @@ |
||
141 | 141 | try |
142 | 142 | { |
143 | 143 | $shell->cp('foo2', 'foo3'); |
144 | - } |
|
145 | - catch (\Exception $e) |
|
144 | + } catch (\Exception $e) |
|
146 | 145 | { |
147 | 146 | # omitting directory |
148 | 147 | $errorObject = ($e instanceof \RuntimeException); |
149 | - } |
|
150 | - finally |
|
148 | + } finally |
|
151 | 149 | { |
152 | 150 | $this->assertTrue($errorObject, $e->getMessage()); |
153 | 151 | } |
@@ -31,15 +31,17 @@ discard block |
||
31 | 31 | */ |
32 | 32 | public function __construct($options) |
33 | 33 | { |
34 | - if (!array_key_exists("dbchar", $options)) |
|
35 | - $options["dbchar"] = "utf8"; |
|
34 | + if (!array_key_exists("dbchar", $options)) { |
|
35 | + $options["dbchar"] = "utf8"; |
|
36 | + } |
|
36 | 37 | |
37 | 38 | parent::__construct($options); |
38 | 39 | |
39 | 40 | $auto_connect = array_key_exists('auto_connect', $options) ? $options["auto_connect"] : true; |
40 | 41 | |
41 | - if ($auto_connect) |
|
42 | - $this->connect(); |
|
42 | + if ($auto_connect) { |
|
43 | + $this->connect(); |
|
44 | + } |
|
43 | 45 | } |
44 | 46 | |
45 | 47 | /** |
@@ -52,13 +54,15 @@ discard block |
||
52 | 54 | */ |
53 | 55 | public function connect() |
54 | 56 | { |
55 | - if (!extension_loaded('mysqli')) |
|
56 | - throw new \RuntimeException("The Mysqli extension is not loaded"); |
|
57 | + if (!extension_loaded('mysqli')) { |
|
58 | + throw new \RuntimeException("The Mysqli extension is not loaded"); |
|
59 | + } |
|
57 | 60 | |
58 | - if (!is_null($this->dbport) && !empty($this->dbport)) |
|
59 | - $conn = @new \mysqli($this->dbhost, $this->dbuser, $this->dbpass, $this->dbname, $this->dbport); |
|
60 | - else |
|
61 | - $conn = @new \mysqli($this->dbhost, $this->dbuser, $this->dbpass, $this->dbname); |
|
61 | + if (!is_null($this->dbport) && !empty($this->dbport)) { |
|
62 | + $conn = @new \mysqli($this->dbhost, $this->dbuser, $this->dbpass, $this->dbname, $this->dbport); |
|
63 | + } else { |
|
64 | + $conn = @new \mysqli($this->dbhost, $this->dbuser, $this->dbpass, $this->dbname); |
|
65 | + } |
|
62 | 66 | |
63 | 67 | if ($conn->connect_errno) |
64 | 68 | { |
@@ -68,8 +72,7 @@ discard block |
||
68 | 72 | * the warning message "Property access is not allowed yet". |
69 | 73 | */ |
70 | 74 | throw new Exception\ConnectionException(mysqli_connect_error(), mysqli_connect_errno()); |
71 | - } |
|
72 | - else |
|
75 | + } else |
|
73 | 76 | { |
74 | 77 | $this->dbconn = $conn; |
75 | 78 | $this->dbconn->set_charset($this->dbchar); |
@@ -116,13 +119,15 @@ discard block |
||
116 | 119 | |
117 | 120 | for ($i = 0; $i < $n_params; $i++) |
118 | 121 | { |
119 | - if (is_string($param_values[$i])) |
|
120 | - $bind_types .= 's'; |
|
121 | - else if(is_float($param_values[$i])) |
|
122 | - $bind_types .= 'd'; |
|
122 | + if (is_string($param_values[$i])) { |
|
123 | + $bind_types .= 's'; |
|
124 | + } else if(is_float($param_values[$i])) { |
|
125 | + $bind_types .= 'd'; |
|
126 | + } |
|
123 | 127 | # [POSSIBLE BUG] - To Future revision (What about non-string and non-decimal types ?) |
124 | - else |
|
125 | - $bind_types .= 's'; |
|
128 | + else { |
|
129 | + $bind_types .= 's'; |
|
130 | + } |
|
126 | 131 | |
127 | 132 | $bind_values[] = '$param_values[' . $i . ']'; |
128 | 133 | } |
@@ -143,12 +148,12 @@ discard block |
||
143 | 148 | * It is useful to prevent rollback transactions on insert statements because |
144 | 149 | * insert statement do not free results. |
145 | 150 | */ |
146 | - if ($res) |
|
147 | - $this->result = $res; |
|
151 | + if ($res) { |
|
152 | + $this->result = $res; |
|
153 | + } |
|
148 | 154 | } |
149 | 155 | } |
150 | - } |
|
151 | - else |
|
156 | + } else |
|
152 | 157 | { |
153 | 158 | $prev_error_handler = set_error_handler(['\Drone\Error\ErrorHandler', 'errorControlOperator'], E_ALL); |
154 | 159 | |
@@ -165,20 +170,23 @@ discard block |
||
165 | 170 | } |
166 | 171 | |
167 | 172 | # identify SELECT, SHOW, DESCRIBE or EXPLAIN queries |
168 | - if (is_object($this->result) && property_exists($this->result, 'num_rows')) |
|
169 | - $this->numRows = $this->result->num_rows; |
|
170 | - else |
|
173 | + if (is_object($this->result) && property_exists($this->result, 'num_rows')) { |
|
174 | + $this->numRows = $this->result->num_rows; |
|
175 | + } else |
|
171 | 176 | { |
172 | 177 | # affected_rows return the same of num_rows on select statements! |
173 | - if (property_exists($this->dbconn, 'affected_rows')) |
|
174 | - $this->rowsAffected = $this->dbconn->affected_rows; |
|
178 | + if (property_exists($this->dbconn, 'affected_rows')) { |
|
179 | + $this->rowsAffected = $this->dbconn->affected_rows; |
|
180 | + } |
|
175 | 181 | } |
176 | 182 | |
177 | - if (property_exists($this->dbconn, 'field_count')) |
|
178 | - $this->numFields = $this->dbconn->field_count; |
|
183 | + if (property_exists($this->dbconn, 'field_count')) { |
|
184 | + $this->numFields = $this->dbconn->field_count; |
|
185 | + } |
|
179 | 186 | |
180 | - if ($this->transac_mode) |
|
181 | - $this->transac_result = is_null($this->transac_result) ? $this->result: $this->transac_result && $this->result; |
|
187 | + if ($this->transac_mode) { |
|
188 | + $this->transac_result = is_null($this->transac_result) ? $this->result: $this->transac_result && $this->result; |
|
189 | + } |
|
182 | 190 | |
183 | 191 | /* |
184 | 192 | * Because mysqli_query() returns FALSE on failure, a mysqli_result object for SELECT, SHOW, DESCRIBE or EXPLAIN queries, |
@@ -247,9 +255,8 @@ discard block |
||
247 | 255 | { |
248 | 256 | $data[] = $row; |
249 | 257 | } |
250 | - } |
|
251 | - else |
|
252 | - /* |
|
258 | + } else { |
|
259 | + /* |
|
253 | 260 | * "This kind of exception should lead directly to a fix in your code" |
254 | 261 | * So much production tests tell us this error is throwed because developers |
255 | 262 | * execute toArray() before execute(). |
@@ -257,6 +264,7 @@ discard block |
||
257 | 264 | * Ref: http://php.net/manual/en/class.logicexception.php |
258 | 265 | */ |
259 | 266 | throw new \LogicException('There are not data in the buffer!'); |
267 | + } |
|
260 | 268 | |
261 | 269 | $this->arrayResult = $data; |
262 | 270 | |
@@ -271,7 +279,8 @@ discard block |
||
271 | 279 | public function __destruct() |
272 | 280 | { |
273 | 281 | # prevent "Property access is not allowed yet" with @ on failure connections |
274 | - if ($this->dbconn !== false && !is_null($this->dbconn)) |
|
275 | - @$this->dbconn->close(); |
|
282 | + if ($this->dbconn !== false && !is_null($this->dbconn)) { |
|
283 | + @$this->dbconn->close(); |
|
284 | + } |
|
276 | 285 | } |
277 | 286 | } |
278 | 287 | \ No newline at end of file |