Passed
Push — master ( b176c5...1503d9 )
by Darío
01:55
created
src/Error/ErrorTrait.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -67,12 +67,13 @@
 block discarded – undo
67 67
      */
68 68
     protected function error($code, $message = null)
69 69
     {
70
-        if (!array_key_exists($code, $this->errors))
71
-            $this->errors[$code] = (array_key_exists($code, $this->standardErrors))
70
+        if (!array_key_exists($code, $this->errors)) {
71
+                    $this->errors[$code] = (array_key_exists($code, $this->standardErrors))
72 72
                 ?
73 73
                     is_null($message)
74 74
                         ? $this->standardErrors[$code]
75 75
                         : preg_replace('/%[a-zA-Z]*%/', $message, $this->standardErrors[$code])
76 76
                 : $message;
77
+        }
77 78
     }
78 79
 }
79 80
\ No newline at end of file
Please login to merge, or discard this patch.
src/Util/ParamTrait.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -70,8 +70,9 @@
 block discarded – undo
70 70
     {
71 71
         $parameters = $this->getParams();
72 72
 
73
-        if (array_key_exists($param, $parameters))
74
-            return true;
73
+        if (array_key_exists($param, $parameters)) {
74
+                    return true;
75
+        }
75 76
 
76 77
         return false;
77 78
     }
Please login to merge, or discard this patch.
src/Util/ArrayDimension.php 1 patch
Braces   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -39,9 +39,9 @@
 block discarded – undo
39 39
                     $again = true;
40 40
                     $new_config[$param . $glue . $key] = $value;
41 41
                 }
42
+            } else {
43
+                            $new_config[$param] = $configure;
42 44
             }
43
-            else
44
-                $new_config[$param] = $configure;
45 45
         }
46 46
 
47 47
         return (!$again) ? $new_config : self::toUnidimensional($new_config, $glue);
Please login to merge, or discard this patch.
src/Exception/Storage.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@
 block discarded – undo
60 60
 
61 61
             if (!empty($string))
62 62
             {
63
-                $data   = json_decode($string, true);
63
+                $data = json_decode($string, true);
64 64
 
65 65
                 # json_encode can return TRUE, FALSE or NULL (http://php.net/manual/en/function.json-decode.php)
66 66
                 if (is_null($data) || $data === false)
Please login to merge, or discard this patch.
Braces   +9 added lines, -6 removed lines patch added patch discarded remove patch
@@ -76,17 +76,20 @@
 block discarded – undo
76 76
             "object"  => serialize($exception)
77 77
         ];
78 78
 
79
-        if (!function_exists('mb_detect_encoding'))
80
-            throw new \RuntimeException("mbstring library is not installed!");
79
+        if (!function_exists('mb_detect_encoding')) {
80
+                    throw new \RuntimeException("mbstring library is not installed!");
81
+        }
81 82
 
82 83
         /*
83 84
          * Encodes to UTF8 all messages. It ensures JSON encoding.
84 85
          */
85
-        if (!mb_detect_encoding($data[$id]["message"], 'UTF-8', true))
86
-            $data[$id]["message"] = utf8_encode($data[$id]["message"]);
86
+        if (!mb_detect_encoding($data[$id]["message"], 'UTF-8', true)) {
87
+                    $data[$id]["message"] = utf8_encode($data[$id]["message"]);
88
+        }
87 89
 
88
-        if (!mb_detect_encoding($data[$id]["object"], 'UTF-8', true))
89
-            $data[$id]["object"] = utf8_decode($data[$id]["object"]);
90
+        if (!mb_detect_encoding($data[$id]["object"], 'UTF-8', true)) {
91
+                    $data[$id]["object"] = utf8_decode($data[$id]["object"]);
92
+        }
90 93
 
91 94
         if (($encoded_data = json_encode($data)) === false)
92 95
         {
Please login to merge, or discard this patch.
src/Mvc/Router.php 1 patch
Braces   +11 added lines, -8 removed lines patch added patch discarded remove patch
@@ -145,8 +145,9 @@  discard block
 block discarded – undo
145 145
         $module = (is_null($this->identifiers["module"]) || empty($this->identifiers["module"]))
146 146
                     ? $this->routes["defaults"]["module"] : $this->identifiers["module"];
147 147
 
148
-        if (!array_key_exists($module, $this->routes))
149
-            throw new Exception\ModuleNotFoundException("The key '$module' does not exists in routes!");
148
+        if (!array_key_exists($module, $this->routes)) {
149
+                    throw new Exception\ModuleNotFoundException("The key '$module' does not exists in routes!");
150
+        }
150 151
 
151 152
         $controller = (is_null($this->identifiers["controller"]) || empty($this->identifiers["controller"]))
152 153
                     ? $this->routes[$module]["controller"] : $this->identifiers["controller"];
@@ -156,10 +157,11 @@  discard block
 block discarded – undo
156 157
 
157 158
         $fqn_controller = '\\' . $module . "\Controller\\" . $controller;
158 159
 
159
-        if (class_exists($fqn_controller))
160
-            $this->controller = new $fqn_controller($module, $view, $this->basePath);
161
-        else
162
-            throw new Exception\ControllerNotFoundException("The control class '$fqn_controller' does not exists!");
160
+        if (class_exists($fqn_controller)) {
161
+                    $this->controller = new $fqn_controller($module, $view, $this->basePath);
162
+        } else {
163
+                    throw new Exception\ControllerNotFoundException("The control class '$fqn_controller' does not exists!");
164
+        }
163 165
     }
164 166
 
165 167
     /**
@@ -176,8 +178,9 @@  discard block
 block discarded – undo
176 178
         $key = array_keys($route);
177 179
         $key = array_shift($key);
178 180
 
179
-        if (array_key_exists($key, $this->routes))
180
-            throw new \LogicException("The key '$key' was already defined as route");
181
+        if (array_key_exists($key, $this->routes)) {
182
+                    throw new \LogicException("The key '$key' was already defined as route");
183
+        }
181 184
 
182 185
         $this->routes = array_merge($this->routes, $route);
183 186
     }
Please login to merge, or discard this patch.
src/Mvc/Application.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -132,8 +132,8 @@
 block discarded – undo
132 132
                  *  This instruction include each module declared in application.config.php
133 133
                  *  Each module has an autoloader to load its classes (controllers and models)
134 134
                  */
135
-                if (file_exists("module/".$module."/Module.php"))
136
-                    include("module/".$module."/Module.php");
135
+                if (file_exists("module/" . $module . "/Module.php"))
136
+                    include("module/" . $module . "/Module.php");
137 137
 
138 138
                 spl_autoload_register($module . "\Module::loader");
139 139
             }
Please login to merge, or discard this patch.
Braces   +19 added lines, -16 removed lines patch added patch discarded remove patch
@@ -58,8 +58,9 @@  discard block
 block discarded – undo
58 58
     public function prepare()
59 59
     {
60 60
         # start sessions
61
-        if (!isset($_SESSION))
62
-            session_start();
61
+        if (!isset($_SESSION)) {
62
+                    session_start();
63
+        }
63 64
     }
64 65
 
65 66
     /**
@@ -91,8 +92,7 @@  discard block
 block discarded – undo
91 92
 
92 93
             // Best way to view all possible errors
93 94
             error_reporting(-1);
94
-        }
95
-        else {
95
+        } else {
96 96
             ini_set('display_errors', 0);
97 97
             error_reporting(-1);
98 98
         }
@@ -109,10 +109,11 @@  discard block
 block discarded – undo
109 109
 
110 110
             foreach ($app_config_file["router"]["routes"] as $name => $route)
111 111
             {
112
-                if ($route instanceof \Zend\Router\Http\RouteInterface)
113
-                    $this->getRouter()->addZendRoute($name, $route);
114
-                else
115
-                    $this->getRouter()->addRoute($route);
112
+                if ($route instanceof \Zend\Router\Http\RouteInterface) {
113
+                                    $this->getRouter()->addZendRoute($name, $route);
114
+                } else {
115
+                                    $this->getRouter()->addRoute($route);
116
+                }
116 117
             }
117 118
         }
118 119
 
@@ -146,14 +147,15 @@  discard block
 block discarded – undo
146 147
                  *  This instruction include each module declared in application.config.php
147 148
                  *  Each module has an autoloader to load its classes (controllers and models)
148 149
                  */
149
-                if (file_exists("module/".$module."/Module.php"))
150
-                    include("module/".$module."/Module.php");
150
+                if (file_exists("module/".$module."/Module.php")) {
151
+                                    include("module/".$module."/Module.php");
152
+                }
151 153
 
152 154
                 spl_autoload_register($module . "\Module::loader");
153 155
             }
156
+        } else {
157
+                    throw new \RuntimeException("The application must have at least one module");
154 158
         }
155
-        else
156
-            throw new \RuntimeException("The application must have at least one module");
157 159
     }
158 160
 
159 161
     /**
@@ -175,8 +177,9 @@  discard block
 block discarded – undo
175 177
         $uri .= !empty($controller) ? '/' . $controller : "";
176 178
         $uri .= !empty($view) ? '/' . $view : "";
177 179
 
178
-        if (empty($uri))
179
-            $uri = "/";
180
+        if (empty($uri)) {
181
+                    $uri = "/";
182
+        }
180 183
 
181 184
         $request->setUri($uri);
182 185
 
@@ -191,9 +194,9 @@  discard block
 block discarded – undo
191 194
             $view = $params["action"];
192 195
 
193 196
             $this->router->setIdentifiers($module, $controller, $view);
197
+        } else {
198
+                    $this->router->setIdentifiers($module, $controller, $view);
194 199
         }
195
-        else
196
-            $this->router->setIdentifiers($module, $controller, $view);
197 200
 
198 201
         $this->router->run();
199 202
     }
Please login to merge, or discard this patch.
src/Mvc/AbstractionModule.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -80,7 +80,8 @@
 block discarded – undo
80 80
 
81 81
         $class = "module/" . $module . "/source/" . implode("/", $nm) . ".php";
82 82
 
83
-        if (file_exists($class))
84
-            include $class;
83
+        if (file_exists($class)) {
84
+                    include $class;
85
+        }
85 86
     }
86 87
 }
87 88
\ No newline at end of file
Please login to merge, or discard this patch.
src/Mvc/AbstractionController.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -168,7 +168,7 @@
 block discarded – undo
168 168
         if ($_SERVER['REQUEST_METHOD'] != 'JSON')
169 169
             throw new \LogicException("Request method is not JSON");
170 170
 
171
-        $input =  file_get_contents('php://input');
171
+        $input = file_get_contents('php://input');
172 172
         $array = explode("&", $input);
173 173
 
174 174
         $result = array();
Please login to merge, or discard this patch.
Braces   +32 added lines, -24 removed lines patch added patch discarded remove patch
@@ -150,8 +150,9 @@  discard block
 block discarded – undo
150 150
      */
151 151
     public function getPost()
152 152
     {
153
-        if ($_SERVER['REQUEST_METHOD'] == 'POST' && empty($_POST))
154
-            $_POST = json_decode(file_get_contents('php://input'), true);
153
+        if ($_SERVER['REQUEST_METHOD'] == 'POST' && empty($_POST)) {
154
+                    $_POST = json_decode(file_get_contents('php://input'), true);
155
+        }
155 156
 
156 157
         return (array) $_POST;
157 158
     }
@@ -165,8 +166,9 @@  discard block
 block discarded – undo
165 166
      */
166 167
     public function getJson()
167 168
     {
168
-        if ($_SERVER['REQUEST_METHOD'] != 'JSON')
169
-            throw new \LogicException("Request method is not JSON");
169
+        if ($_SERVER['REQUEST_METHOD'] != 'JSON') {
170
+                    throw new \LogicException("Request method is not JSON");
171
+        }
170 172
 
171 173
         $input =  file_get_contents('php://input');
172 174
         $array = explode("&", $input);
@@ -254,8 +256,9 @@  discard block
 block discarded – undo
254 256
         $this->module = new $fqn($module, $this);
255 257
 
256 258
         # detects method change inside Module.php
257
-        if (!is_null($this->getMethod()))
258
-            $method = $this->getMethod();
259
+        if (!is_null($this->getMethod())) {
260
+                    $method = $this->getMethod();
261
+        }
259 262
 
260 263
         if (!is_null($method) && $this->initExecution)
261 264
         {
@@ -265,8 +268,9 @@  discard block
 block discarded – undo
265 268
 
266 269
                 $reflection = new \ReflectionMethod($this, $method);
267 270
 
268
-                if (!$reflection->isPublic())
269
-                    throw new Exception\PageNotFoundException("The method '$method' is not public in the control class '$class'");
271
+                if (!$reflection->isPublic()) {
272
+                                    throw new Exception\PageNotFoundException("The method '$method' is not public in the control class '$class'");
273
+                }
270 274
 
271 275
                 $this->method = $method;
272 276
 
@@ -282,8 +286,7 @@  discard block
 block discarded – undo
282 286
                     $layoutManager = new Layout($layout_params);
283 287
                     $layoutManager->fromController($this);
284 288
                 }
285
-            }
286
-            else {
289
+            } else {
287 290
                 $class = __CLASS__;
288 291
                 throw new Exception\PageNotFoundException("The method '$method' doesn't exists in the control class '$class'");
289 292
             }
@@ -308,8 +311,9 @@  discard block
 block discarded – undo
308 311
     public function isXmlHttpRequest()
309 312
     {
310 313
         # non standard (HTTP_X_REQUESTED_WITH is not a part of PHP)
311
-        if (isset($_SERVER['HTTP_X_REQUESTED_WITH']))
312
-            return true;
314
+        if (isset($_SERVER['HTTP_X_REQUESTED_WITH'])) {
315
+                    return true;
316
+        }
313 317
         return false;
314 318
     }
315 319
 
@@ -320,8 +324,9 @@  discard block
 block discarded – undo
320 324
      */
321 325
     public function isPost()
322 326
     {
323
-        if ($_SERVER["REQUEST_METHOD"] == "POST")
324
-            return true;
327
+        if ($_SERVER["REQUEST_METHOD"] == "POST") {
328
+                    return true;
329
+        }
325 330
         return false;
326 331
     }
327 332
 
@@ -332,8 +337,9 @@  discard block
 block discarded – undo
332 337
      */
333 338
     public function isGet()
334 339
     {
335
-        if ($_SERVER["REQUEST_METHOD"] == "GET")
336
-            return true;
340
+        if ($_SERVER["REQUEST_METHOD"] == "GET") {
341
+                    return true;
342
+        }
337 343
         return false;
338 344
     }
339 345
 
@@ -357,10 +363,11 @@  discard block
 block discarded – undo
357 363
             $i = 1;
358 364
             foreach ($params as $item)
359 365
             {
360
-                if ($i % 2 != 0)
361
-                    $vars[] = $item;
362
-                else
363
-                    $values[] = $item;
366
+                if ($i % 2 != 0) {
367
+                                    $vars[] = $item;
368
+                } else {
369
+                                    $values[] = $item;
370
+                }
364 371
                 $i++;
365 372
             }
366 373
 
@@ -368,10 +375,11 @@  discard block
 block discarded – undo
368 375
 
369 376
             for ($i = 0; $i < $vars_count; $i++)
370 377
             {
371
-                if (array_key_exists($i, $values))
372
-                    $_GET[$vars[$i]] = $values[$i];
373
-                else
374
-                    $_GET[$vars[$i]] = '';
378
+                if (array_key_exists($i, $values)) {
379
+                                    $_GET[$vars[$i]] = $values[$i];
380
+                } else {
381
+                                    $_GET[$vars[$i]] = '';
382
+                }
375 383
             }
376 384
 
377 385
             unset($_GET["params"]);
Please login to merge, or discard this patch.
src/Mvc/Layout.php 2 patches
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -164,8 +164,8 @@  discard block
 block discarded – undo
164 164
     {
165 165
         foreach ($params as $param => $value)
166 166
         {
167
-            if (property_exists(__CLASS__, strtolower($param)) && method_exists($this, 'set'.$param))
168
-                $this->{'set'.$param}($value);
167
+            if (property_exists(__CLASS__, strtolower($param)) && method_exists($this, 'set' . $param))
168
+                $this->{'set' . $param}($value);
169 169
         }
170 170
     }
171 171
 
@@ -185,9 +185,9 @@  discard block
 block discarded – undo
185 185
 
186 186
         if ($controller->getShowView())
187 187
         {
188
-            $view = 'module/'      . $controller->getModule()->getModuleName() .
189
-                    '/source/view/'. basename(str_replace('\\','/',get_class($controller))) .
190
-                    '/'            . $controller->getMethod() . '.phtml';
188
+            $view = 'module/' . $controller->getModule()->getModuleName() .
189
+                    '/source/view/' . basename(str_replace('\\', '/', get_class($controller))) .
190
+                    '/' . $controller->getMethod() . '.phtml';
191 191
 
192 192
             $this->view = $view;
193 193
         }
Please login to merge, or discard this patch.
Braces   +22 added lines, -16 removed lines patch added patch discarded remove patch
@@ -133,8 +133,9 @@  discard block
 block discarded – undo
133 133
     {
134 134
         $config = $module->getConfig();
135 135
 
136
-        if (!array_key_exists($view, $config["view_manager"]["view_map"]) || !file_exists($config["view_manager"]["view_map"][$view]))
137
-            throw new Exception\ViewNotFoundException("The 'view' template " . $view . " does not exists");
136
+        if (!array_key_exists($view, $config["view_manager"]["view_map"]) || !file_exists($config["view_manager"]["view_map"][$view])) {
137
+                    throw new Exception\ViewNotFoundException("The 'view' template " . $view . " does not exists");
138
+        }
138 139
 
139 140
         $this->view = $config["view_manager"]["view_map"][$view];
140 141
     }
@@ -164,8 +165,9 @@  discard block
 block discarded – undo
164 165
     {
165 166
         foreach ($params as $param => $value)
166 167
         {
167
-            if (property_exists(__CLASS__, strtolower($param)) && method_exists($this, 'set'.$param))
168
-                $this->{'set'.$param}($value);
168
+            if (property_exists(__CLASS__, strtolower($param)) && method_exists($this, 'set'.$param)) {
169
+                            $this->{'set'.$param}($value);
170
+            }
169 171
         }
170 172
     }
171 173
 
@@ -194,23 +196,26 @@  discard block
 block discarded – undo
194 196
 
195 197
         if ($controller->getTerminal())
196 198
         {
197
-            if (file_exists($view))
198
-                include $view;
199
-        }
200
-        else
199
+            if (file_exists($view)) {
200
+                            include $view;
201
+            }
202
+        } else
201 203
         {
202
-            if (!is_null($this->view) && !file_exists($this->view))
203
-                throw new Exception\ViewNotFoundException("The 'view' template " . $this->view . " does not exists");
204
+            if (!is_null($this->view) && !file_exists($this->view)) {
205
+                            throw new Exception\ViewNotFoundException("The 'view' template " . $this->view . " does not exists");
206
+            }
204 207
 
205 208
             $config = $controller->getModule()->getConfig();
206 209
 
207
-            if (!array_key_exists($controller->getLayout(), $config["view_manager"]["template_map"]))
208
-                throw new Exception\PageNotFoundException("The 'template' " . $template . " was not defined in module.config.php");
210
+            if (!array_key_exists($controller->getLayout(), $config["view_manager"]["template_map"])) {
211
+                            throw new Exception\PageNotFoundException("The 'template' " . $template . " was not defined in module.config.php");
212
+            }
209 213
 
210 214
             $template = $config["view_manager"]["template_map"][$controller->getLayout()];
211 215
 
212
-            if (!file_exists($template))
213
-                throw new Exception\PageNotFoundException("The 'template' " . $template . " does not exists");
216
+            if (!file_exists($template)) {
217
+                            throw new Exception\PageNotFoundException("The 'template' " . $template . " does not exists");
218
+            }
214 219
 
215 220
             include $template;
216 221
         }
@@ -237,8 +242,9 @@  discard block
 block discarded – undo
237 242
      */
238 243
     public function content()
239 244
     {
240
-        if (!file_exists($this->view))
241
-            throw new Exception\ViewNotFoundException("The 'view' template " . $this->view . " does not exists");
245
+        if (!file_exists($this->view)) {
246
+                    throw new Exception\ViewNotFoundException("The 'view' template " . $this->view . " does not exists");
247
+        }
242 248
 
243 249
         include $this->view;
244 250
     }
Please login to merge, or discard this patch.