Passed
Branch master (800486)
by Darío
02:44
created
src/FileSystem/Shell.php 2 patches
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -93,24 +93,24 @@  discard block
 block discarded – undo
93 93
             {
94 94
                 foreach ($contents as $i)
95 95
                 {
96
-                    if (is_file($handler.'/'.$i))
96
+                    if (is_file($handler . '/' . $i))
97 97
                     {
98
-                        $allContents[] = $handler.'/'.$i;
98
+                        $allContents[] = $handler . '/' . $i;
99 99
 
100
-                        $this->buffer = $handler.'/'.$i;
100
+                        $this->buffer = $handler . '/' . $i;
101 101
                         call_user_func($fileCallback, $this);
102 102
                     }
103
-                    elseif (is_dir($handler.'/'.$i))
103
+                    elseif (is_dir($handler . '/' . $i))
104 104
                     {
105
-                        $allContents[] = $handler.'/'.$i;
105
+                        $allContents[] = $handler . '/' . $i;
106 106
 
107
-                        $this->buffer = $handler.'/'.$i;
108
-                        $this->getContents($handler.'/'.$i, $fileCallback, $dirCallback);
107
+                        $this->buffer = $handler . '/' . $i;
108
+                        $this->getContents($handler . '/' . $i, $fileCallback, $dirCallback);
109 109
 
110 110
                         $directory = scandir($handler);
111 111
 
112 112
                         if (!count($directory) < 3)
113
-                            $this->buffer = $handler.'/'.$i;
113
+                            $this->buffer = $handler . '/' . $i;
114 114
 
115 115
                         call_user_func($dirCallback, $this);
116 116
                     }
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
196 196
                 if (!empty($path))
197 197
                     if (!strlen(stristr($item, $path)) > 0)
198 198
                         continue;
199
-                if (strstr($item,'~') === false && $item != '.' && $item != '..')
199
+                if (strstr($item, '~') === false && $item != '.' && $item != '..')
200 200
                     $filesToReturn[] = $item;
201 201
             }
202 202
         }
@@ -299,7 +299,7 @@  discard block
 block discarded – undo
299 299
         if (is_dir($dest))
300 300
         {
301 301
             if (!$recursive)
302
-                copy($file, $dest.'/'.$file);
302
+                copy($file, $dest . '/' . $file);
303 303
             else {
304 304
 
305 305
                 $files = array();
@@ -318,14 +318,14 @@  discard block
 block discarded – undo
318 318
 
319 319
                     foreach ($files[1] as $item)
320 320
                     {
321
-                        if (!file_exists($dest.'/'.$item))
321
+                        if (!file_exists($dest . '/' . $item))
322 322
                             mkdir("$dest/$item", 0777, true);
323 323
                     }
324 324
 
325 325
                     foreach ($files[0] as $item)
326 326
                     {
327 327
                         if (!file_exists("$dest/$files"))
328
-                            copy($item, $dest.'/'.$item);
328
+                            copy($item, $dest . '/' . $item);
329 329
                     }
330 330
                 });
331 331
             }
@@ -350,12 +350,12 @@  discard block
 block discarded – undo
350 350
             throw new Exception("Missing parameter for mv!");
351 351
 
352 352
         if (is_dir($newfile))
353
-                $newfile .= '/'.basename($oldfile);
353
+                $newfile .= '/' . basename($oldfile);
354 354
 
355 355
         if ($oldfile == $newfile)
356 356
             throw new Exception("'$oldfile' and '$newfile' are the same file");
357 357
 
358
-        if(!rename($oldfile, $newfile))
358
+        if (!rename($oldfile, $newfile))
359 359
             return false;
360 360
 
361 361
         return true;
@@ -385,7 +385,7 @@  discard block
 block discarded – undo
385 385
         else {
386 386
             if (!is_dir($dir))
387 387
             {
388
-                if(!mkdir("$dir", 0777))
388
+                if (!mkdir("$dir", 0777))
389 389
                     return false;
390 390
             }
391 391
         }
Please login to merge, or discard this patch.
Braces   +89 added lines, -70 removed lines patch added patch discarded remove patch
@@ -83,8 +83,9 @@  discard block
 block discarded – undo
83 83
 
84 84
             foreach ($filesForHandler as $item)
85 85
             {
86
-                if ($item != '.' && $item != '..')
87
-                    $contents[] = $item;
86
+                if ($item != '.' && $item != '..') {
87
+                                    $contents[] = $item;
88
+                }
88 89
             }
89 90
 
90 91
             $allContents = $contents;
@@ -99,8 +100,7 @@  discard block
 block discarded – undo
99 100
 
100 101
                         $this->buffer = $handler.'/'.$i;
101 102
                         call_user_func($fileCallback, $this);
102
-                    }
103
-                    elseif (is_dir($handler.'/'.$i))
103
+                    } elseif (is_dir($handler.'/'.$i))
104 104
                     {
105 105
                         $allContents[] = $handler.'/'.$i;
106 106
 
@@ -109,19 +109,21 @@  discard block
 block discarded – undo
109 109
 
110 110
                         $directory = scandir($handler);
111 111
 
112
-                        if (!count($directory) < 3)
113
-                            $this->buffer = $handler.'/'.$i;
112
+                        if (!count($directory) < 3) {
113
+                                                    $this->buffer = $handler.'/'.$i;
114
+                        }
114 115
 
115 116
                         call_user_func($dirCallback, $this);
116 117
                     }
117 118
                 }
118 119
             }
120
+        } else {
121
+                    throw new Exception("The directory '$handler' does not exists");
119 122
         }
120
-        else
121
-            throw new Exception("The directory '$handler' does not exists");
122 123
 
123
-        if (!is_null($callback))
124
-            call_user_func($callback, $this);
124
+        if (!is_null($callback)) {
125
+                    call_user_func($callback, $this);
126
+        }
125 127
 
126 128
         return $allContents;
127 129
     }
@@ -133,10 +135,11 @@  discard block
 block discarded – undo
133 135
      */
134 136
     public function pwd()
135 137
     {
136
-        if (getcwd())
137
-            $this->buffer = getcwd();
138
-        else
139
-            return false;
138
+        if (getcwd()) {
139
+                    $this->buffer = getcwd();
140
+        } else {
141
+                    return false;
142
+        }
140 143
 
141 144
         return $this->buffer;
142 145
     }
@@ -155,9 +158,9 @@  discard block
 block discarded – undo
155 158
 
156 159
         $path = (is_null($path) || empty($path)) ? '.' : $path;
157 160
 
158
-        if (is_file($path))
159
-            $filesToReturn = array($path);
160
-        elseif (is_dir($path))
161
+        if (is_file($path)) {
162
+                    $filesToReturn = array($path);
163
+        } elseif (is_dir($path))
161 164
         {
162 165
             $pathIns = dir($path);
163 166
 
@@ -179,25 +182,25 @@  discard block
 block discarded – undo
179 182
                 foreach ($files as $item) {
180 183
                     $filesToReturn[] = $item;
181 184
                 }
182
-            }
183
-            else {
185
+            } else {
184 186
                 while (false !== ($item = $pathIns->read())) {
185 187
                     $filesToReturn[] = $item;
186 188
                 }
187 189
                 $pathIns->close();
188 190
             }
189
-        }
190
-        else {
191
+        } else {
191 192
 
192 193
             $contents = $this->ls();
193 194
 
194 195
             foreach ($contents as $item)
195 196
             {
196
-                if (!empty($path))
197
-                    if (!strlen(stristr($item, $path)) > 0)
197
+                if (!empty($path)) {
198
+                                    if (!strlen(stristr($item, $path)) > 0)
198 199
                         continue;
199
-                if (strstr($item,'~') === false && $item != '.' && $item != '..')
200
-                    $filesToReturn[] = $item;
200
+                }
201
+                if (strstr($item,'~') === false && $item != '.' && $item != '..') {
202
+                                    $filesToReturn[] = $item;
203
+                }
201 204
             }
202 205
         }
203 206
 
@@ -217,8 +220,9 @@  discard block
 block discarded – undo
217 220
 
218 221
         if (is_dir($path))
219 222
         {
220
-            if (chdir($moveTo))
221
-                return true;
223
+            if (chdir($moveTo)) {
224
+                            return true;
225
+            }
222 226
         }
223 227
 
224 228
         return false;
@@ -235,11 +239,13 @@  discard block
 block discarded – undo
235 239
     {
236 240
         if (file_exists($file))
237 241
         {
238
-            if (!$openFile = fopen($file, 'w+'))
239
-                return false;
242
+            if (!$openFile = fopen($file, 'w+')) {
243
+                            return false;
244
+            }
240 245
 
241
-            if (fwrite($openFile, ""))
242
-                return true;
246
+            if (fwrite($openFile, "")) {
247
+                            return true;
248
+            }
243 249
 
244 250
             fclose($openFile);
245 251
         }
@@ -259,12 +265,13 @@  discard block
 block discarded – undo
259 265
     {
260 266
         $recursive = is_null($recursive) ? false : $recursive;
261 267
 
262
-        if (is_null($file))
263
-            throw new Exception("Missing parameter for rm!");
268
+        if (is_null($file)) {
269
+                    throw new Exception("Missing parameter for rm!");
270
+        }
264 271
 
265
-        if (file_exists($file) && !$recursive)
266
-            unlink($file);
267
-        elseif (is_dir($file) && $recursive)
272
+        if (file_exists($file) && !$recursive) {
273
+                    unlink($file);
274
+        } elseif (is_dir($file) && $recursive)
268 275
         {
269 276
             $that = $this;
270 277
 
@@ -293,14 +300,15 @@  discard block
 block discarded – undo
293 300
     {
294 301
         $recursive = (is_null($recursive)) ? false : $recursive;
295 302
 
296
-        if (empty($file) || empty($dest))
297
-            throw new Exception("Missing parameters!");
303
+        if (empty($file) || empty($dest)) {
304
+                    throw new Exception("Missing parameters!");
305
+        }
298 306
 
299 307
         if (is_dir($dest))
300 308
         {
301
-            if (!$recursive)
302
-                copy($file, $dest.'/'.$file);
303
-            else {
309
+            if (!$recursive) {
310
+                            copy($file, $dest.'/'.$file);
311
+            } else {
304 312
 
305 313
                 $files = array();
306 314
                 $files[0] = array();
@@ -318,20 +326,22 @@  discard block
 block discarded – undo
318 326
 
319 327
                     foreach ($files[1] as $item)
320 328
                     {
321
-                        if (!file_exists($dest.'/'.$item))
322
-                            mkdir("$dest/$item", 0777, true);
329
+                        if (!file_exists($dest.'/'.$item)) {
330
+                                                    mkdir("$dest/$item", 0777, true);
331
+                        }
323 332
                     }
324 333
 
325 334
                     foreach ($files[0] as $item)
326 335
                     {
327
-                        if (!file_exists("$dest/$files"))
328
-                            copy($item, $dest.'/'.$item);
336
+                        if (!file_exists("$dest/$files")) {
337
+                                                    copy($item, $dest.'/'.$item);
338
+                        }
329 339
                     }
330 340
                 });
331 341
             }
342
+        } else {
343
+                    copy($file, $dest);
332 344
         }
333
-        else
334
-            copy($file, $dest);
335 345
 
336 346
         return true;
337 347
     }
@@ -346,17 +356,21 @@  discard block
 block discarded – undo
346 356
      */
347 357
     public function mv($oldfile, $newfile)
348 358
     {
349
-        if (empty($oldfile))
350
-            throw new Exception("Missing parameter for mv!");
359
+        if (empty($oldfile)) {
360
+                    throw new Exception("Missing parameter for mv!");
361
+        }
351 362
 
352
-        if (is_dir($newfile))
353
-                $newfile .= '/'.basename($oldfile);
363
+        if (is_dir($newfile)) {
364
+                        $newfile .= '/'.basename($oldfile);
365
+        }
354 366
 
355
-        if ($oldfile == $newfile)
356
-            throw new Exception("'$oldfile' and '$newfile' are the same file");
367
+        if ($oldfile == $newfile) {
368
+                    throw new Exception("'$oldfile' and '$newfile' are the same file");
369
+        }
357 370
 
358
-        if(!rename($oldfile, $newfile))
359
-            return false;
371
+        if(!rename($oldfile, $newfile)) {
372
+                    return false;
373
+        }
360 374
 
361 375
         return true;
362 376
     }
@@ -372,21 +386,24 @@  discard block
 block discarded – undo
372 386
      */
373 387
     public function mkdir($dir, $dest = null, $recursive = null)
374 388
     {
375
-        if (empty($dir))
376
-            throw new Exception("Missing parameter for mkdir!");
389
+        if (empty($dir)) {
390
+                    throw new Exception("Missing parameter for mkdir!");
391
+        }
377 392
 
378
-        if (empty($dest))
379
-            $dest = '.';
393
+        if (empty($dest)) {
394
+                    $dest = '.';
395
+        }
380 396
 
381 397
         $recursive = (is_null($recursive)) ? false : $recursive;
382 398
 
383
-        if ($recursive)
384
-            mkdir("$dest/$dir", 0777, true);
385
-        else {
399
+        if ($recursive) {
400
+                    mkdir("$dest/$dir", 0777, true);
401
+        } else {
386 402
             if (!is_dir($dir))
387 403
             {
388
-                if(!mkdir("$dir", 0777))
389
-                    return false;
404
+                if(!mkdir("$dir", 0777)) {
405
+                                    return false;
406
+                }
390 407
             }
391 408
         }
392 409
         return true;
@@ -401,12 +418,14 @@  discard block
 block discarded – undo
401 418
      */
402 419
     public function rmdir($dir)
403 420
     {
404
-        if (is_null($dir) || empty($dir))
405
-            throw new Exception("Missing parameter for rmdir!");
421
+        if (is_null($dir) || empty($dir)) {
422
+                    throw new Exception("Missing parameter for rmdir!");
423
+        }
406 424
 
407
-        if (rmdir($dir))
408
-            return true;
409
-        else
410
-            return false;
425
+        if (rmdir($dir)) {
426
+                    return true;
427
+        } else {
428
+                    return false;
429
+        }
411 430
     }
412 431
 }
413 432
\ No newline at end of file
Please login to merge, or discard this patch.
src/Db/Driver/SQLServer.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
             $exec = sqlsrv_execute($stmt);
117 117
         }
118 118
         else
119
-            $exec = $this->result = sqlsrv_query($this->dbconn, $sql, $params, array( "Scrollable" => SQLSRV_CURSOR_KEYSET ));
119
+            $exec = $this->result = sqlsrv_query($this->dbconn, $sql, $params, array("Scrollable" => SQLSRV_CURSOR_KEYSET));
120 120
 
121 121
         if ($exec === false)
122 122
         {
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
         $this->rowsAffected = sqlsrv_rows_affected($this->result);
138 138
 
139 139
         if ($this->transac_mode)
140
-            $this->transac_result = is_null($this->transac_result) ? $this->result: $this->transac_result && $this->result;
140
+            $this->transac_result = is_null($this->transac_result) ? $this->result : $this->transac_result && $this->result;
141 141
 
142 142
         return $this->result;
143 143
     }
Please login to merge, or discard this patch.
Braces   +23 added lines, -17 removed lines patch added patch discarded remove patch
@@ -31,15 +31,17 @@  discard block
 block discarded – undo
31 31
      */
32 32
     public function __construct($options)
33 33
     {
34
-        if (!array_key_exists("dbchar", $options))
35
-            $options["dbchar"] = "UTF-8";
34
+        if (!array_key_exists("dbchar", $options)) {
35
+                    $options["dbchar"] = "UTF-8";
36
+        }
36 37
 
37 38
         parent::__construct($options);
38 39
 
39 40
         $auto_connect = array_key_exists('auto_connect', $options) ? $options["auto_connect"] : true;
40 41
 
41
-        if ($auto_connect)
42
-            $this->connect();
42
+        if ($auto_connect) {
43
+                    $this->connect();
44
+        }
43 45
     }
44 46
 
45 47
     /**
@@ -52,11 +54,13 @@  discard block
 block discarded – undo
52 54
      */
53 55
     public function connect()
54 56
     {
55
-        if (!extension_loaded('sqlsrv'))
56
-            throw new \RuntimeException("The Sqlsrv extension is not loaded");
57
+        if (!extension_loaded('sqlsrv')) {
58
+                    throw new \RuntimeException("The Sqlsrv extension is not loaded");
59
+        }
57 60
 
58
-        if (!is_null($this->dbport) && !empty($this->dbport))
59
-            $this->dbhost .= ', ' . $this->dbport;
61
+        if (!is_null($this->dbport) && !empty($this->dbport)) {
62
+                    $this->dbhost .= ', ' . $this->dbport;
63
+        }
60 64
 
61 65
         $db_info = array("Database" => $this->dbname, "UID" => $this->dbuser, "PWD" => $this->dbpass, "CharacterSet" => $this->dbchar);
62 66
         $conn = sqlsrv_connect($this->dbhost, $db_info);
@@ -116,9 +120,9 @@  discard block
 block discarded – undo
116 120
             }
117 121
 
118 122
             $exec = sqlsrv_execute($stmt);
123
+        } else {
124
+                    $exec = $this->result = sqlsrv_query($this->dbconn, $sql, $params, array( "Scrollable" => SQLSRV_CURSOR_KEYSET ));
119 125
         }
120
-        else
121
-            $exec = $this->result = sqlsrv_query($this->dbconn, $sql, $params, array( "Scrollable" => SQLSRV_CURSOR_KEYSET ));
122 126
 
123 127
         if ($exec === false)
124 128
         {
@@ -138,8 +142,9 @@  discard block
 block discarded – undo
138 142
         $this->numFields = sqlsrv_num_fields($this->result);
139 143
         $this->rowsAffected = sqlsrv_rows_affected($this->result);
140 144
 
141
-        if ($this->transac_mode)
142
-            $this->transac_result = is_null($this->transac_result) ? $this->result: $this->transac_result && $this->result;
145
+        if ($this->transac_mode) {
146
+                    $this->transac_result = is_null($this->transac_result) ? $this->result: $this->transac_result && $this->result;
147
+        }
143 148
 
144 149
         return $this->result;
145 150
     }
@@ -206,9 +211,8 @@  discard block
 block discarded – undo
206 211
             {
207 212
                 $data[] = $row;
208 213
             }
209
-        }
210
-        else
211
-            /*
214
+        } else {
215
+                    /*
212 216
              * "This kind of exception should lead directly to a fix in your code"
213 217
              * So much production tests tell us this error is throwed because developers
214 218
              * execute toArray() before execute().
@@ -216,6 +220,7 @@  discard block
 block discarded – undo
216 220
              * Ref: http://php.net/manual/en/class.logicexception.php
217 221
              */
218 222
             throw new \LogicException('There are not data in the buffer!');
223
+        }
219 224
 
220 225
         $this->arrayResult = $data;
221 226
 
@@ -229,7 +234,8 @@  discard block
 block discarded – undo
229 234
      */
230 235
     public function __destruct()
231 236
     {
232
-        if ($this->dbconn)
233
-            sqlsrv_close($this->dbconn);
237
+        if ($this->dbconn) {
238
+                    sqlsrv_close($this->dbconn);
239
+        }
234 240
     }
235 241
 }
236 242
\ No newline at end of file
Please login to merge, or discard this patch.
src/Network/Socket/AbstractSocket.php 3 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
         }
122 122
 
123 123
         $this->socket = $socket;
124
-	}
124
+    }
125 125
 
126 126
     /**
127 127
      * Binds the socket
@@ -145,8 +145,8 @@  discard block
 block discarded – undo
145 145
      *
146 146
      * @return null
147 147
      */
148
-	public function close()
149
-	{
148
+    public function close()
149
+    {
150 150
         return socket_close($this->socket);
151
-	}
151
+    }
152 152
 }
153 153
\ No newline at end of file
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -108,8 +108,8 @@
 block discarded – undo
108 108
     {
109 109
         foreach ($options as $option => $value)
110 110
         {
111
-            if (property_exists(__CLASS__, strtolower($option)) && method_exists($this, 'set'.$option))
112
-            $this->{'set'.$option}($value);
111
+            if (property_exists(__CLASS__, strtolower($option)) && method_exists($this, 'set' . $option))
112
+            $this->{'set' . $option}($value);
113 113
         }
114 114
 
115 115
         if (!($socket = @socket_create(AF_INET, SOCK_STREAM, SOL_TCP)))
Please login to merge, or discard this patch.
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -108,8 +108,9 @@
 block discarded – undo
108 108
     {
109 109
         foreach ($options as $option => $value)
110 110
         {
111
-            if (property_exists(__CLASS__, strtolower($option)) && method_exists($this, 'set'.$option))
112
-            $this->{'set'.$option}($value);
111
+            if (property_exists(__CLASS__, strtolower($option)) && method_exists($this, 'set'.$option)) {
112
+                        $this->{'set'.$option}($value);
113
+            }
113 114
         }
114 115
 
115 116
         if (!($socket = @socket_create(AF_INET, SOCK_STREAM, SOL_TCP)))
Please login to merge, or discard this patch.