Passed
Push — master ( 7a2ff7...b84377 )
by Darío
02:18
created
src/Db/TableGateway/TableGateway.php 1 patch
Braces   +45 added lines, -45 removed lines patch added patch discarded remove patch
@@ -73,11 +73,11 @@  discard block
 block discarded – undo
73 73
             {
74 74
                 $k++;
75 75
 
76
-                if (is_null($value))
77
-                    $parsed_where[] = "$key IS NULL";
78
-                elseif ($value instanceof SQLFunction)
79
-                    $parsed_where[] = "$key = " . $value->getStatement();
80
-                elseif (is_array($value))
76
+                if (is_null($value)) {
77
+                                    $parsed_where[] = "$key IS NULL";
78
+                } elseif ($value instanceof SQLFunction) {
79
+                                    $parsed_where[] = "$key = " . $value->getStatement();
80
+                } elseif (is_array($value))
81 81
                 {
82 82
                     $parsed_in = [];
83 83
 
@@ -100,8 +100,7 @@  discard block
 block discarded – undo
100 100
                     }
101 101
 
102 102
                     $parsed_where[] = "$key IN (" . implode(", ", $parsed_in) . ")";
103
-                }
104
-                else
103
+                } else
105 104
                 {
106 105
                     switch ($driver)
107 106
                     {
@@ -119,9 +118,9 @@  discard block
 block discarded – undo
119 118
             }
120 119
 
121 120
             $where = "WHERE \r\n\t" . implode(" AND\r\n\t", $parsed_where);
121
+        } else {
122
+                    $where = "";
122 123
         }
123
-        else
124
-            $where = "";
125 124
 
126 125
         $table = $this->entity->getTableName();
127 126
 
@@ -144,8 +143,9 @@  discard block
 block discarded – undo
144 143
      */
145 144
     public function insert(Array $data)
146 145
     {
147
-        if (!count($data))
148
-            throw new \LogicException("Missing values for INSERT statement!");
146
+        if (!count($data)) {
147
+                    throw new \LogicException("Missing values for INSERT statement!");
148
+        }
149 149
 
150 150
         $bind_values = [];
151 151
 
@@ -168,11 +168,11 @@  discard block
 block discarded – undo
168 168
                 continue;
169 169
             }
170 170
 
171
-            if (is_null($value))
172
-                $value = "NULL";
173
-            elseif ($value instanceof SQLFunction)
174
-                $value = $value->getStatement();
175
-            else {
171
+            if (is_null($value)) {
172
+                            $value = "NULL";
173
+            } elseif ($value instanceof SQLFunction) {
174
+                            $value = $value->getStatement();
175
+            } else {
176 176
 
177 177
                 switch ($driver)
178 178
                 {
@@ -222,11 +222,13 @@  discard block
 block discarded – undo
222 222
     {
223 223
         $parsed_set = [];
224 224
 
225
-        if (!count($set))
226
-            throw new \LogicException("You cannot update rows without SET clause");
225
+        if (!count($set)) {
226
+                    throw new \LogicException("You cannot update rows without SET clause");
227
+        }
227 228
 
228
-        if (!count($where))
229
-            throw new SecurityException("You cannot update rows without WHERE clause!");
229
+        if (!count($where)) {
230
+                    throw new SecurityException("You cannot update rows without WHERE clause!");
231
+        }
230 232
 
231 233
         $bind_values = [];
232 234
 
@@ -238,11 +240,11 @@  discard block
 block discarded – undo
238 240
         {
239 241
             $k++;
240 242
 
241
-            if (is_null($value))
242
-                $parsed_set[] = "$key = NULL";
243
-            elseif ($value instanceof SQLFunction)
244
-                $parsed_set[] = "$key = " . $value->getStatement();
245
-            elseif (is_array($value))
243
+            if (is_null($value)) {
244
+                            $parsed_set[] = "$key = NULL";
245
+            } elseif ($value instanceof SQLFunction) {
246
+                            $parsed_set[] = "$key = " . $value->getStatement();
247
+            } elseif (is_array($value))
246 248
             {
247 249
                 $parsed_in = [];
248 250
 
@@ -253,8 +255,9 @@  discard block
 block discarded – undo
253 255
                         case 'Oci8':
254 256
 
255 257
                             # [POSSIBLE BUG] - To Future revision (What about non-string values ?)
256
-                            if (is_string($in_value))
257
-                                $parsed_in[] = ":$k";
258
+                            if (is_string($in_value)) {
259
+                                                            $parsed_in[] = ":$k";
260
+                            }
258 261
 
259 262
                             $bind_values[":$k"] = $in_value;
260 263
                             break;
@@ -269,8 +272,7 @@  discard block
 block discarded – undo
269 272
                 }
270 273
 
271 274
                 $parsed_set[] = "$key IN (" . implode(", ", $parsed_in) . ")";
272
-            }
273
-            else
275
+            } else
274 276
             {
275 277
                 switch ($driver)
276 278
                 {
@@ -296,11 +298,11 @@  discard block
 block discarded – undo
296 298
         {
297 299
             $k++;
298 300
 
299
-            if (is_null($value))
300
-                $parsed_where[] = "$key IS NULL";
301
-            elseif ($value instanceof SQLFunction)
302
-                $parsed_where[] = "$key = " . $value->getStatement();
303
-            elseif (is_array($value))
301
+            if (is_null($value)) {
302
+                            $parsed_where[] = "$key IS NULL";
303
+            } elseif ($value instanceof SQLFunction) {
304
+                            $parsed_where[] = "$key = " . $value->getStatement();
305
+            } elseif (is_array($value))
304 306
             {
305 307
                 $parsed_in = [];
306 308
 
@@ -323,8 +325,7 @@  discard block
 block discarded – undo
323 325
                 }
324 326
 
325 327
                 $parsed_where[] = "$key IN (" . implode(", ", $parsed_in) . ")";
326
-            }
327
-            else
328
+            } else
328 329
             {
329 330
                 switch ($driver)
330 331
                 {
@@ -376,11 +377,11 @@  discard block
 block discarded – undo
376 377
             {
377 378
                 $k++;
378 379
 
379
-                if (is_null($value))
380
-                    $parsed_where[] = "$key IS NULL";
381
-                elseif ($value instanceof SQLFunction)
382
-                    $parsed_where[] = "$key = " . $value->getStatement();
383
-                elseif (is_array($value))
380
+                if (is_null($value)) {
381
+                                    $parsed_where[] = "$key IS NULL";
382
+                } elseif ($value instanceof SQLFunction) {
383
+                                    $parsed_where[] = "$key = " . $value->getStatement();
384
+                } elseif (is_array($value))
384 385
                 {
385 386
                     $parsed_in = [];
386 387
 
@@ -403,8 +404,7 @@  discard block
 block discarded – undo
403 404
                     }
404 405
 
405 406
                     $parsed_where[] = "$key IN (" . implode(", ", $parsed_in) . ")";
406
-                }
407
-                else
407
+                } else
408 408
                 {
409 409
                     switch ($driver)
410 410
                     {
@@ -422,9 +422,9 @@  discard block
 block discarded – undo
422 422
             }
423 423
 
424 424
             $where = "\r\nWHERE \r\n\t" . implode(" AND\r\n\t", $parsed_where);
425
+        } else {
426
+                    throw new SecurityException("You cannot delete rows without WHERE clause!. Use TRUNCATE statement instead.");
425 427
         }
426
-        else
427
-            throw new SecurityException("You cannot delete rows without WHERE clause!. Use TRUNCATE statement instead.");
428 428
 
429 429
         $table = $this->entity->getTableName();
430 430
 
Please login to merge, or discard this patch.
src/Db/TableGateway/EntityAdapter.php 1 patch
Braces   +21 added lines, -16 removed lines patch added patch discarded remove patch
@@ -58,8 +58,9 @@  discard block
 block discarded – undo
58 58
     {
59 59
         $result = $this->tableGateway->select($where);
60 60
 
61
-        if (!count($result))
62
-            return $result;
61
+        if (!count($result)) {
62
+                    return $result;
63
+        }
63 64
 
64 65
         $array_result = [];
65 66
 
@@ -69,8 +70,9 @@  discard block
 block discarded – undo
69 70
 
70 71
             foreach ($row as $key => $value)
71 72
             {
72
-                if (is_string($key))
73
-                    $filtered_array[$key] = $value;
73
+                if (is_string($key)) {
74
+                                    $filtered_array[$key] = $value;
75
+                }
74 76
             }
75 77
 
76 78
             $user_entity = get_class($this->tableGateway->getEntity());
@@ -94,10 +96,11 @@  discard block
 block discarded – undo
94 96
      */
95 97
     public function insert($entity)
96 98
     {
97
-        if ($entity instanceof Entity)
98
-            $entity = get_object_vars($entity);
99
-        else if (!is_array($entity))
100
-            throw new \InvalidArgumentException("Invalid type given. Drone\Db\Entity or Array expected");
99
+        if ($entity instanceof Entity) {
100
+                    $entity = get_object_vars($entity);
101
+        } else if (!is_array($entity)) {
102
+                    throw new \InvalidArgumentException("Invalid type given. Drone\Db\Entity or Array expected");
103
+        }
101 104
 
102 105
         $this->parseEntity($entity);
103 106
 
@@ -126,14 +129,15 @@  discard block
 block discarded – undo
126 129
 
127 130
             foreach ($entity as $key => $value)
128 131
             {
129
-                if (in_array($key, $changedFields))
130
-                    $fieldsToModify[$key] = $value;
132
+                if (in_array($key, $changedFields)) {
133
+                                    $fieldsToModify[$key] = $value;
134
+                }
131 135
             }
132 136
 
133 137
             $entity = $fieldsToModify;
138
+        } else if (!is_array($entity)) {
139
+                    throw new \InvalidArgumentException("Invalid type given. Drone\Db\Entity or Array expected");
134 140
         }
135
-        else if (!is_array($entity))
136
-            throw new \InvalidArgumentException("Invalid type given. Drone\Db\Entity or Array expected");
137 141
 
138 142
         $this->parseEntity($entity);
139 143
 
@@ -152,10 +156,11 @@  discard block
 block discarded – undo
152 156
      */
153 157
     public function delete($entity)
154 158
     {
155
-        if ($entity instanceof Entity)
156
-            $entity = get_object_vars($entity);
157
-        else if (!is_array($entity))
158
-            throw new \InvalidArgumentException("Invalid type given. Drone\Db\Entity or Array expected");
159
+        if ($entity instanceof Entity) {
160
+                    $entity = get_object_vars($entity);
161
+        } else if (!is_array($entity)) {
162
+                    throw new \InvalidArgumentException("Invalid type given. Drone\Db\Entity or Array expected");
163
+        }
159 164
 
160 165
         return $this->tableGateway->delete($entity);
161 166
     }
Please login to merge, or discard this patch.
src/FileSystem/Shell.php 2 patches
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -93,24 +93,24 @@  discard block
 block discarded – undo
93 93
             {
94 94
                 foreach ($contents as $i)
95 95
                 {
96
-                    if (is_file($handler.'/'.$i))
96
+                    if (is_file($handler . '/' . $i))
97 97
                     {
98
-                        $allContents[] = $handler.'/'.$i;
98
+                        $allContents[] = $handler . '/' . $i;
99 99
 
100
-                        $this->buffer = $handler.'/'.$i;
100
+                        $this->buffer = $handler . '/' . $i;
101 101
                         call_user_func($fileCallback, $this);
102 102
                     }
103
-                    elseif (is_dir($handler.'/'.$i))
103
+                    elseif (is_dir($handler . '/' . $i))
104 104
                     {
105
-                        $allContents[] = $handler.'/'.$i;
105
+                        $allContents[] = $handler . '/' . $i;
106 106
 
107
-                        $this->buffer = $handler.'/'.$i;
108
-                        $this->getContents($handler.'/'.$i, $fileCallback, $dirCallback);
107
+                        $this->buffer = $handler . '/' . $i;
108
+                        $this->getContents($handler . '/' . $i, $fileCallback, $dirCallback);
109 109
 
110 110
                         $directory = scandir($handler);
111 111
 
112 112
                         if (!count($directory) < 3)
113
-                            $this->buffer = $handler.'/'.$i;
113
+                            $this->buffer = $handler . '/' . $i;
114 114
 
115 115
                         call_user_func($dirCallback, $this);
116 116
                     }
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
196 196
                 if (!empty($path))
197 197
                     if (!strlen(stristr($item, $path)) > 0)
198 198
                         continue;
199
-                if (strstr($item,'~') === false && $item != '.' && $item != '..')
199
+                if (strstr($item, '~') === false && $item != '.' && $item != '..')
200 200
                     $filesToReturn[] = $item;
201 201
             }
202 202
         }
@@ -299,7 +299,7 @@  discard block
 block discarded – undo
299 299
         if (is_dir($dest))
300 300
         {
301 301
             if (!$recursive)
302
-                copy($file, $dest.'/'.$file);
302
+                copy($file, $dest . '/' . $file);
303 303
             else {
304 304
 
305 305
                 $files = array();
@@ -318,14 +318,14 @@  discard block
 block discarded – undo
318 318
 
319 319
                     foreach ($files[1] as $item)
320 320
                     {
321
-                        if (!file_exists($dest.'/'.$item))
321
+                        if (!file_exists($dest . '/' . $item))
322 322
                             mkdir("$dest/$item", 0777, true);
323 323
                     }
324 324
 
325 325
                     foreach ($files[0] as $item)
326 326
                     {
327 327
                         if (!file_exists("$dest/$files"))
328
-                            copy($item, $dest.'/'.$item);
328
+                            copy($item, $dest . '/' . $item);
329 329
                     }
330 330
                 });
331 331
             }
@@ -350,12 +350,12 @@  discard block
 block discarded – undo
350 350
             throw new Exception("Missing parameter for mv!");
351 351
 
352 352
         if (is_dir($newfile))
353
-                $newfile .= '/'.basename($oldfile);
353
+                $newfile .= '/' . basename($oldfile);
354 354
 
355 355
         if ($oldfile == $newfile)
356 356
             throw new Exception("'$oldfile' and '$newfile' are the same file");
357 357
 
358
-        if(!rename($oldfile, $newfile))
358
+        if (!rename($oldfile, $newfile))
359 359
             return false;
360 360
 
361 361
         return true;
@@ -385,7 +385,7 @@  discard block
 block discarded – undo
385 385
         else {
386 386
             if (!is_dir($dir))
387 387
             {
388
-                if(!mkdir("$dir", 0777))
388
+                if (!mkdir("$dir", 0777))
389 389
                     return false;
390 390
             }
391 391
         }
Please login to merge, or discard this patch.
Braces   +89 added lines, -70 removed lines patch added patch discarded remove patch
@@ -83,8 +83,9 @@  discard block
 block discarded – undo
83 83
 
84 84
             foreach ($filesForHandler as $item)
85 85
             {
86
-                if ($item != '.' && $item != '..')
87
-                    $contents[] = $item;
86
+                if ($item != '.' && $item != '..') {
87
+                                    $contents[] = $item;
88
+                }
88 89
             }
89 90
 
90 91
             $allContents = $contents;
@@ -99,8 +100,7 @@  discard block
 block discarded – undo
99 100
 
100 101
                         $this->buffer = $handler.'/'.$i;
101 102
                         call_user_func($fileCallback, $this);
102
-                    }
103
-                    elseif (is_dir($handler.'/'.$i))
103
+                    } elseif (is_dir($handler.'/'.$i))
104 104
                     {
105 105
                         $allContents[] = $handler.'/'.$i;
106 106
 
@@ -109,19 +109,21 @@  discard block
 block discarded – undo
109 109
 
110 110
                         $directory = scandir($handler);
111 111
 
112
-                        if (!count($directory) < 3)
113
-                            $this->buffer = $handler.'/'.$i;
112
+                        if (!count($directory) < 3) {
113
+                                                    $this->buffer = $handler.'/'.$i;
114
+                        }
114 115
 
115 116
                         call_user_func($dirCallback, $this);
116 117
                     }
117 118
                 }
118 119
             }
120
+        } else {
121
+                    throw new Exception("The directory '$handler' does not exists");
119 122
         }
120
-        else
121
-            throw new Exception("The directory '$handler' does not exists");
122 123
 
123
-        if (!is_null($callback))
124
-            call_user_func($callback, $this);
124
+        if (!is_null($callback)) {
125
+                    call_user_func($callback, $this);
126
+        }
125 127
 
126 128
         return $allContents;
127 129
     }
@@ -133,10 +135,11 @@  discard block
 block discarded – undo
133 135
      */
134 136
     public function pwd()
135 137
     {
136
-        if (getcwd())
137
-            $this->buffer = getcwd();
138
-        else
139
-            return false;
138
+        if (getcwd()) {
139
+                    $this->buffer = getcwd();
140
+        } else {
141
+                    return false;
142
+        }
140 143
 
141 144
         return $this->buffer;
142 145
     }
@@ -155,9 +158,9 @@  discard block
 block discarded – undo
155 158
 
156 159
         $path = (is_null($path) || empty($path)) ? '.' : $path;
157 160
 
158
-        if (is_file($path))
159
-            $filesToReturn = array($path);
160
-        elseif (is_dir($path))
161
+        if (is_file($path)) {
162
+                    $filesToReturn = array($path);
163
+        } elseif (is_dir($path))
161 164
         {
162 165
             $pathIns = dir($path);
163 166
 
@@ -179,25 +182,25 @@  discard block
 block discarded – undo
179 182
                 foreach ($files as $item) {
180 183
                     $filesToReturn[] = $item;
181 184
                 }
182
-            }
183
-            else {
185
+            } else {
184 186
                 while (false !== ($item = $pathIns->read())) {
185 187
                     $filesToReturn[] = $item;
186 188
                 }
187 189
                 $pathIns->close();
188 190
             }
189
-        }
190
-        else {
191
+        } else {
191 192
 
192 193
             $contents = $this->ls();
193 194
 
194 195
             foreach ($contents as $item)
195 196
             {
196
-                if (!empty($path))
197
-                    if (!strlen(stristr($item, $path)) > 0)
197
+                if (!empty($path)) {
198
+                                    if (!strlen(stristr($item, $path)) > 0)
198 199
                         continue;
199
-                if (strstr($item,'~') === false && $item != '.' && $item != '..')
200
-                    $filesToReturn[] = $item;
200
+                }
201
+                if (strstr($item,'~') === false && $item != '.' && $item != '..') {
202
+                                    $filesToReturn[] = $item;
203
+                }
201 204
             }
202 205
         }
203 206
 
@@ -217,8 +220,9 @@  discard block
 block discarded – undo
217 220
 
218 221
         if (is_dir($path))
219 222
         {
220
-            if (chdir($moveTo))
221
-                return true;
223
+            if (chdir($moveTo)) {
224
+                            return true;
225
+            }
222 226
         }
223 227
 
224 228
         return false;
@@ -235,11 +239,13 @@  discard block
 block discarded – undo
235 239
     {
236 240
         if (file_exists($file))
237 241
         {
238
-            if (!$openFile = fopen($file, 'w+'))
239
-                return false;
242
+            if (!$openFile = fopen($file, 'w+')) {
243
+                            return false;
244
+            }
240 245
 
241
-            if (fwrite($openFile, ""))
242
-                return true;
246
+            if (fwrite($openFile, "")) {
247
+                            return true;
248
+            }
243 249
 
244 250
             fclose($openFile);
245 251
         }
@@ -259,12 +265,13 @@  discard block
 block discarded – undo
259 265
     {
260 266
         $recursive = is_null($recursive) ? false : $recursive;
261 267
 
262
-        if (is_null($file))
263
-            throw new Exception("Missing parameter for rm!");
268
+        if (is_null($file)) {
269
+                    throw new Exception("Missing parameter for rm!");
270
+        }
264 271
 
265
-        if (file_exists($file) && !$recursive)
266
-            unlink($file);
267
-        elseif (is_dir($file) && $recursive)
272
+        if (file_exists($file) && !$recursive) {
273
+                    unlink($file);
274
+        } elseif (is_dir($file) && $recursive)
268 275
         {
269 276
             $that = $this;
270 277
 
@@ -293,14 +300,15 @@  discard block
 block discarded – undo
293 300
     {
294 301
         $recursive = (is_null($recursive)) ? false : $recursive;
295 302
 
296
-        if (empty($file) || empty($dest))
297
-            throw new Exception("Missing parameters!");
303
+        if (empty($file) || empty($dest)) {
304
+                    throw new Exception("Missing parameters!");
305
+        }
298 306
 
299 307
         if (is_dir($dest))
300 308
         {
301
-            if (!$recursive)
302
-                copy($file, $dest.'/'.$file);
303
-            else {
309
+            if (!$recursive) {
310
+                            copy($file, $dest.'/'.$file);
311
+            } else {
304 312
 
305 313
                 $files = array();
306 314
                 $files[0] = array();
@@ -318,20 +326,22 @@  discard block
 block discarded – undo
318 326
 
319 327
                     foreach ($files[1] as $item)
320 328
                     {
321
-                        if (!file_exists($dest.'/'.$item))
322
-                            mkdir("$dest/$item", 0777, true);
329
+                        if (!file_exists($dest.'/'.$item)) {
330
+                                                    mkdir("$dest/$item", 0777, true);
331
+                        }
323 332
                     }
324 333
 
325 334
                     foreach ($files[0] as $item)
326 335
                     {
327
-                        if (!file_exists("$dest/$files"))
328
-                            copy($item, $dest.'/'.$item);
336
+                        if (!file_exists("$dest/$files")) {
337
+                                                    copy($item, $dest.'/'.$item);
338
+                        }
329 339
                     }
330 340
                 });
331 341
             }
342
+        } else {
343
+                    copy($file, $dest);
332 344
         }
333
-        else
334
-            copy($file, $dest);
335 345
 
336 346
         return true;
337 347
     }
@@ -346,17 +356,21 @@  discard block
 block discarded – undo
346 356
      */
347 357
     public function mv($oldfile, $newfile)
348 358
     {
349
-        if (empty($oldfile))
350
-            throw new Exception("Missing parameter for mv!");
359
+        if (empty($oldfile)) {
360
+                    throw new Exception("Missing parameter for mv!");
361
+        }
351 362
 
352
-        if (is_dir($newfile))
353
-                $newfile .= '/'.basename($oldfile);
363
+        if (is_dir($newfile)) {
364
+                        $newfile .= '/'.basename($oldfile);
365
+        }
354 366
 
355
-        if ($oldfile == $newfile)
356
-            throw new Exception("'$oldfile' and '$newfile' are the same file");
367
+        if ($oldfile == $newfile) {
368
+                    throw new Exception("'$oldfile' and '$newfile' are the same file");
369
+        }
357 370
 
358
-        if(!rename($oldfile, $newfile))
359
-            return false;
371
+        if(!rename($oldfile, $newfile)) {
372
+                    return false;
373
+        }
360 374
 
361 375
         return true;
362 376
     }
@@ -372,21 +386,24 @@  discard block
 block discarded – undo
372 386
      */
373 387
     public function mkdir($dir, $dest = null, $recursive = null)
374 388
     {
375
-        if (empty($dir))
376
-            throw new Exception("Missing parameter for mkdir!");
389
+        if (empty($dir)) {
390
+                    throw new Exception("Missing parameter for mkdir!");
391
+        }
377 392
 
378
-        if (empty($dest))
379
-            $dest = '.';
393
+        if (empty($dest)) {
394
+                    $dest = '.';
395
+        }
380 396
 
381 397
         $recursive = (is_null($recursive)) ? false : $recursive;
382 398
 
383
-        if ($recursive)
384
-            mkdir("$dest/$dir", 0777, true);
385
-        else {
399
+        if ($recursive) {
400
+                    mkdir("$dest/$dir", 0777, true);
401
+        } else {
386 402
             if (!is_dir($dir))
387 403
             {
388
-                if(!mkdir("$dir", 0777))
389
-                    return false;
404
+                if(!mkdir("$dir", 0777)) {
405
+                                    return false;
406
+                }
390 407
             }
391 408
         }
392 409
         return true;
@@ -401,12 +418,14 @@  discard block
 block discarded – undo
401 418
      */
402 419
     public function rmdir($dir)
403 420
     {
404
-        if (is_null($dir) || empty($dir))
405
-            throw new Exception("Missing parameter for rmdir!");
421
+        if (is_null($dir) || empty($dir)) {
422
+                    throw new Exception("Missing parameter for rmdir!");
423
+        }
406 424
 
407
-        if (rmdir($dir))
408
-            return true;
409
-        else
410
-            return false;
425
+        if (rmdir($dir)) {
426
+                    return true;
427
+        } else {
428
+                    return false;
429
+        }
411 430
     }
412 431
 }
413 432
\ No newline at end of file
Please login to merge, or discard this patch.