Drone\Mvc\ModuleFactory::create()

Complexity

Conditions	6
Paths	5

Size

Total Lines	30
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	6.5625

Importance

Changes	2
Bugs	0	Features	1

<?php
    public static function create($module, array $module_settings = [])
    {
        if (empty($module)) {
            throw new \RuntimeException("The module name must be specified");
        }

        if (!is_string($module)) {

The condition is_string($module) is always true.

            throw new \InvalidArgumentException("Invalid type given. string expected");
        }

        /*
         * Module class instantiation
         *
         * Each module must have a class called Module in her namespace. This class
         * is initilized here and can change the behavior of a controller using
         * allowExecution() or disallowExecution().
         */
        $fqn_module = "\\" . $module . "\\Module";

        if (!class_exists($fqn_module)) {
            throw new Exception\ModuleNotFoundException("The module class '$fqn_module' does not exists!");
        }

        $module = new $fqn_module($module);

        if (array_key_exists('config', $module_settings) && !is_null($module_settings["config"])) {
            $module->setConfigFile($module_settings["config"]);
        }

        return $module;

The expression return $module returns the type object which is incompatible with the documented return type null.

    }