Drone\Network\Socket\Server

Complexity

Total Complexity

10

Size/Duplication

Total Lines	102
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	read()	0	10	2
A	send()	0	10	2
B	listen()	0	47	6

<?php
/**
 * DronePHP (http://www.dronephp.com)
 *
 * @link      http://github.com/Pleets/DronePHP
 * @copyright Copyright (c) 2016-2018 Pleets. (http://www.pleets.org)
 * @license   http://www.dronephp.com/license
 * @author    Darío Rivera <fermius.us@gmail.com>
 */

namespace Drone\Network\Socket;

/**
 * Server class
 *
 * Server socket implementation
 */
class Server extends AbstractSocket
{
    /**
     * Reads a message from client
     *
     * @param resource
     * @param mixed $socket
     *
     * @throws RuntimeException
     *
     * @return string
     */
    public function read($socket)
    {
        if (($message = @socket_read($socket, 1024)) === false) {
            $errno = socket_last_error();
            $this->error($errno, socket_strerror($errno));

The method error() does not exist on Drone\Network\Socket\Server. Since you implemented __call, consider adding a @method annotation.

            throw new \RuntimeException("Could not read message from client socket");
        }

        return $message;
    }

    /**
     * Sends a message to client socket
     *
     * @param resource $socket
     * @param string $message
     *
     * @throws RuntimeException
     *
     * @return integer
     */
    public function send($socket, $message)
    {
        if (($bytes = @socket_write($socket, $message, strlen($message))) === false) {
            $errno = socket_last_error();
            $this->error($errno, socket_strerror($errno));

            throw new \RuntimeException("Could not send message to the client socket");
        }

        return $bytes;
    }

    /**
     * Sets socket to listening
     *
     * @param array $eventHandlers
     *
     * @throws RuntimeException
     *
     * @return boolean
     */
    public function listen(array $eventHandlers = [])
    {
        $event = $eventHandlers;
        $clousure = function () {
        };

        if (!array_key_exists('success', $event)) {
            $event["success"] = $clousure;
        }

        if (!array_key_exists('error', $event)) {
            $event["error"] = $clousure;
        }

        $listener = false;

The assignment to $listener is dead and can be removed.

        if (!($listener = @socket_listen($this->socket, 30))) {
            $errno = socket_last_error();
            $this->error($errno, socket_strerror($errno));

            throw new \RuntimeException("Could not set socket to listen");
        } else {
            echo "\n";
            echo "Server Started : " . date('Y-m-d H:i:s') . "\n";
            echo "Master socket  : " . $this->socket . "\n";

Are you sure $this->socket of type resource can be used in concatenation?

            echo "Listening on   : " . $this->host . " port " . $this->port . "\n\n";

            if (!($spawn = @socket_accept($this->socket))) {
                $errno = socket_last_error();
                $this->error($errno, socket_strerror($errno));

                throw new \RuntimeException("Could not accept incoming connection");
            }

            $input = $this->read($spawn);

            $input = trim($input);
            call_user_func($event["success"], $input, $this, $spawn);

            socket_close($spawn);
        }

        if (!$listener) {

The condition $listener is always true.

            call_user_func($event["error"], $this->getLastError());
        }

        return $listener;
    }
}