Drone\Network\Socket\AbstractSocket

Complexity

Total Complexity

13

Size/Duplication

Total Lines	131
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	3
Bugs	0	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	setPort()	0	3	1
A	getHost()	0	3	1
A	getPort()	0	3	1
A	getSocket()	0	3	1
A	setHost()	0	3	1
A	__construct()	0	16	5
A	close()	0	3	1
A	bind()	0	10	2

<?php
/**
 * DronePHP (http://www.dronephp.com)
 *
 * @link      http://github.com/Pleets/DronePHP
 * @copyright Copyright (c) 2016-2018 Pleets. (http://www.pleets.org)
 * @license   http://www.dronephp.com/license
 * @author    Darío Rivera <fermius.us@gmail.com>
 */

namespace Drone\Network\Socket;

/**
 * AbstractSocket class
 *
 * This class defines some standard functions to interact with sockets.
 * Client and Server behaviors must be implemented.
 */
abstract class AbstractSocket
{
    use \Drone\Error\ErrorTrait;

    /**
     * Host
     *
     * @var string
     */
    protected $host;

    /**
     * Port
     *
     * @var integer
     */
    protected $port;

    /**
     * Socket resource
     *
     * @var resource
     */
    protected $socket;

    /**
     * Returns the host attribute
     *
     * @return string
     */
    public function getHost()
    {
        return $this->host;
    }

    /**
     * Returns the port attribute
     *
     * @return integer
     */
    public function getPort()
    {
        return $this->port;
    }

    /**
     * Returns the socket attribute
     *
     * @return resource|boolean
     */
    public function getSocket()
    {
        return $this->socket;
    }

    /**
     * Sets host attribute
     *
     * @param string $host
     *
     * @return null
     */
    public function setHost($host)
    {
        $this->host = $host;
    }

    /**
     * Sets port attribute
     *
     * @param integer $port
     *
     * @return null
     */
    public function setPort($port)
    {
        $this->port = $port;
    }

    /**
     * Driver Constructor (here socket will be created!)
     *
     * All modifiable attributes (i.e. with setter method) can be passed as key
     *
     *
     * @param array $options
     * @throws RuntimeException
     */
    public function __construct($options)
    {
        foreach ($options as $option => $value) {
            if (property_exists(__CLASS__, strtolower($option)) && method_exists($this, 'set'.$option)) {
                $this->{'set'.$option}($value);
            }
        }

        if (!($socket = @socket_create(AF_INET, SOCK_STREAM, SOL_TCP))) {
            $errno = socket_last_error();
            $this->error($errno, socket_strerror($errno));

The method error() does not exist on Drone\Network\Socket\AbstractSocket. Since you implemented __call, consider adding a @method annotation.

            throw new \RuntimeException("Could not create the socket");
        }

        $this->socket = $socket;
    }

    /**
     * Binds the socket
     *
     * @return bool
     */
    public function bind()
    {
        if (!($bind = @socket_bind($this->socket, $this->host, $this->port))) {
            $errno = socket_last_error();
            $this->error($errno, socket_strerror($errno));

            return false;
        }

        return $bind;
    }

    /**
     * Closes the socket
     *
     * @return void
     */
    public function close()
    {
        return socket_close($this->socket);

Are you sure the usage of socket_close($this->socket) is correct as it seems to always return null.

    }
}