Pleets / SQLWebManager

public/js/utils/fasterjs.js

$(function(){

This code seems to be duplicated in your project.

    /**
     *  Submit forms with AJAX
     */
    $("body").delegate("form[data-role='ajax-request']", "submit", function(event)
    {
        event.preventDefault();

        var formObject = $(this);

        formObject.find("input").attr("readonly", "readonly");
        formObject.find("select").attr("readonly", "readonly");
        formObject.find("button[type='submit']").attr("disabled", "disabled");

        var url  = $(this).attr('action');
        var type = $(this).attr('method');
        var box  = $(this).attr('data-response');
        var data = $(this).attr('data-object');

        var call = eval($(this).attr('data-callback')) || {};

Calls to eval are slow and potentially dangerous, especially on untrusted code. Please consider whether there is another way to achieve your goal.

        call.complete = call.complete || new Function();

Using new Function() to create a function is slow and difficult to debug. Such functions do not create a closure. Consider using another way to define your function.

        call.success  = call.success || new Function();

Using new Function() to create a function is slow and difficult to debug. Such functions do not create a closure. Consider using another way to define your function.

        call.before   = call.before  || new Function();

Using new Function() to create a function is slow and difficult to debug. Such functions do not create a closure. Consider using another way to define your function.

        call.error    = call.error   || new Function();

Using new Function() to create a function is slow and difficult to debug. Such functions do not create a closure. Consider using another way to define your function.

        var form_data = $(this).serializeArray();

        var parsed = eval(data);

Calls to eval are slow and potentially dangerous, especially on untrusted code. Please consider whether there is another way to achieve your goal.

        for (var i in parsed)

A for in loop automatically includes the property of any prototype object, consider checking the key using hasOwnProperty.

        {
            form_data.push({ name: i, value: parsed[i] });
        }

        $.ajax({
            url: url,
            type: type,
            data: form_data,
            beforeSend: function() {
                var loader = "<div class='loader-container'><div class='loader'><span></span><span></span><span></span><span></span><span></span></div></div>";
                $(box).html(loader);
                call.before();
            },
            error: function(jqXHR, textStatus, errorThrown)
            {
                $(box).html("Error processing request!.<br />");

                var e = {};
                e.jqXHR = jqXHR;
                console.info(jqXHR);
                e.textStatus = textStatus;
                e.errorThrown = errorThrown;

                call.error(e);

                $(box).append("Error <strong>" + jqXHR.status + "</strong> - " + jqXHR.statusText + "<br />");
                $(box).append("Status: " + textStatus + "<br />");
                $(box).append("readyState: " + jqXHR.readyState + "<br />");
                $(box).append(jqXHR.responseText + "<br /><br />");
            },
            success: function(data)
            {
                $(box).html(data);
                call.success(data);
            },
            complete: function(data)
            {
                formObject.find("input").removeAttr("readonly");
                formObject.find("select").removeAttr("readonly");
                formObject.find("button[type='submit']").removeAttr("disabled");
                call.success(data);
            }
        });
    });

    /**
     *  General AJAX request
     */
    $("body").delegate(":not(form)[data-role='ajax-request']", "click", function(event)
    {
        var url  = $(this).attr('data-url');
        var type = $(this).attr('data-type');
        var box  = $(this).attr('data-response');
        var data = $(this).attr('data-object');
        var frm  = $(this).attr('data-form');

        var call = eval($(this).attr('data-callback')) || {};

Calls to eval are slow and potentially dangerous, especially on untrusted code. Please consider whether there is another way to achieve your goal.

        call.complete = call.complete   || new Function();

Using new Function() to create a function is slow and difficult to debug. Such functions do not create a closure. Consider using another way to define your function.

        call.success  = call.success || new Function();

Using new Function() to create a function is slow and difficult to debug. Such functions do not create a closure. Consider using another way to define your function.

        call.before   = call.before  || new Function();

Using new Function() to create a function is slow and difficult to debug. Such functions do not create a closure. Consider using another way to define your function.

        call.error    = call.error   || new Function();

Using new Function() to create a function is slow and difficult to debug. Such functions do not create a closure. Consider using another way to define your function.

        var form_data = $(frm).serializeArray();

        var parsed = eval(data);

Calls to eval are slow and potentially dangerous, especially on untrusted code. Please consider whether there is another way to achieve your goal.

        for (var i in parsed)

A for in loop automatically includes the property of any prototype object, consider checking the key using hasOwnProperty.

        {
            form_data.push({ name: i, value: parsed[i] });
        }

        $.ajax({
            url: url,
            type: type,
            data: form_data,
            beforeSend: function() {
                var loader = "<div class='loader-container'><div class='loader'><span></span><span></span><span></span><span></span><span></span></div></div>";
                $(box).html(loader);
                call.before();
            },
            error: function(jqXHR, textStatus, errorThrown)
            {
                event.preventDefault();

                $(box).html("Error processing request!. " + errorThrown);

                var e = {};
                e.jqXHR = jqXHR;
                e.textStatus = textStatus;
                e.errorThrown = errorThrown;

                call.error(e);
            },
            success: function(data)
            {
                $(box).html(data);
                call.success(data);
            },
            complete: function()
            {
                call.complete();
            }
        });
    });
});