Inspection of "Update README.md" - Pleets/SQLWebManager - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 5424ee...dddd00 )

by Darío

created 2018-10-25 04:24 UTC

Status

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -4,7 +4,7 @@  discard block
 block discarded – undo
 {
 	function ifdef($value, Array $array)
 	{
-		$global = __DIR__  . '/../../../config/global.config.php';
+		$global = __DIR__ . '/../../../config/global.config.php';
 
 		if (file_exists($global))
 		{
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
 				if (!$key)
 					return $in;
 
-			} while($key);
+			} while ($key);
 		}
 		else
 			return $value;
@@ -37,6 +37,6 @@  discard block
 block discarded – undo
 
 return [
 	'project' => [
-		'name' => ifdef('PROTOTYPE4', ["project", "name"]),			# The name of your project
+		'name' => ifdef('PROTOTYPE4', ["project", "name"]), # The name of your project
 	],
 ];
\ No newline at end of file

Please login to merge, or discard this patch.

config/global.config.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -2,7 +2,7 @@  discard block
 block discarded – undo
 
 return [
     'project' => [
-		'id'   => 'id6447896',              # Unique ID for the project
+		'id'   => 'id6447896', # Unique ID for the project
 		'name' => 'SQLWebManager'           # The name of your project
     ],
 	'mail' => [
@@ -10,8 +10,8 @@  discard block
 block discarded – undo
 		"host"    => ""
 	],
 	"authentication" => [
-		"method"  => "_COOKIE",				# the method to store credentials (_COOKIE, _SESSION)
-		"key"     => "session_id6448654",		# the key in the array to store credentials
+		"method"  => "_COOKIE", # the method to store credentials (_COOKIE, _SESSION)
+		"key"     => "session_id6448654", # the key in the array to store credentials
 	],
 	"database" => [
 	    /** TABLE PREFIX:

Please login to merge, or discard this patch.

module/Connections/config/user.config.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -4,7 +4,7 @@  discard block
 block discarded – undo
 {
 	function ifdef($value, Array $array)
 	{
-		$global = __DIR__  . '/../../../config/global.config.php';
+		$global = __DIR__ . '/../../../config/global.config.php';
 
 		if (file_exists($global))
 		{
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
 				if (!$key)
 					return $in;
 
-			} while($key);
+			} while ($key);
 		}
 		else
 			return $value;
@@ -37,11 +37,11 @@  discard block
 block discarded – undo
 
 return [
 	'project' => [
-		'name' => ifdef('PROJECT NAME', ["project", "name"]),			# The name of your project
+		'name' => ifdef('PROJECT NAME', ["project", "name"]), # The name of your project
 	],
 	"authentication" => [
-		"method"  => ifdef('_COOKIE', ["authentication", "method"]),		# the method to store credentials (_COOKIE, _SESSION)
-		"key"     => ifdef('session_id', ["authentication", "key"]),		# the key in the array to store credentials
+		"method"  => ifdef('_COOKIE', ["authentication", "method"]), # the method to store credentials (_COOKIE, _SESSION)
+		"key"     => ifdef('session_id', ["authentication", "key"]), # the key in the array to store credentials
 	],
 	"database" => [
 	    /** TABLE PREFIX:

Please login to merge, or discard this patch.

module/Connections/source/Controller/Tools.php 1 patch

Spacing +25 added lines, -25 removed lines patch added patch discarded remove patch

@@ -183,8 +183,8 @@  discard block
 block discarded – undo
         $data = [];
 
         # environment settings
-        $post = $this->getPost();           # catch $_POST
-        $this->setTerminal(true);           # set terminal
+        $post = $this->getPost(); # catch $_POST
+        $this->setTerminal(true); # set terminal
 
         # TRY-CATCH-BLOCK
         try {
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
                 $http = new Http();
                 $http->writeStatus($http::HTTP_METHOD_NOT_ALLOWED);
 
-                die('Error ' . $http::HTTP_METHOD_NOT_ALLOWED .' (' . $http->getStatusText($http::HTTP_METHOD_NOT_ALLOWED) . ')!!');
+                die('Error ' . $http::HTTP_METHOD_NOT_ALLOWED . ' (' . $http->getStatusText($http::HTTP_METHOD_NOT_ALLOWED) . ')!!');
             }
 
             $idenfiers = $this->getIdentifiersEntity()->select([]);
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
                         $http = new Http();
                         $http->writeStatus($http::HTTP_BAD_REQUEST);
 
-                        die('Error ' . $http::HTTP_BAD_REQUEST .' (' . $http->getStatusText($http::HTTP_BAD_REQUEST) . ')!!');
+                        die('Error ' . $http::HTTP_BAD_REQUEST . ' (' . $http->getStatusText($http::HTTP_BAD_REQUEST) . ')!!');
                     }
                 });
 
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
                         $http = new Http();
                         $http->writeStatus($http::HTTP_BAD_REQUEST);
 
-                        die('Error ' . $http::HTTP_BAD_REQUEST .' (' . $http->getStatusText($http::HTTP_BAD_REQUEST) . ')!!');
+                        die('Error ' . $http::HTTP_BAD_REQUEST . ' (' . $http->getStatusText($http::HTTP_BAD_REQUEST) . ')!!');
                     }
                 });
 
@@ -361,14 +361,14 @@  discard block
 block discarded – undo
             $http = new Http();
             $http->writeStatus($http::HTTP_METHOD_NOT_ALLOWED);
 
-            die('Error ' . $http::HTTP_METHOD_NOT_ALLOWED .' (' . $http->getStatusText($http::HTTP_METHOD_NOT_ALLOWED) . ')!!');
+            die('Error ' . $http::HTTP_METHOD_NOT_ALLOWED . ' (' . $http->getStatusText($http::HTTP_METHOD_NOT_ALLOWED) . ')!!');
         }
 
         # data to send
         $data = [];
 
-        $this->setTerminal(true);           # set terminal
-        $post = $this->getPost();           # catch $_POST
+        $this->setTerminal(true); # set terminal
+        $post = $this->getPost(); # catch $_POST
 
         $data["id"]   = $post["id"];
         $data["conn"] = $post["conn"];
@@ -390,8 +390,8 @@  discard block
 block discarded – undo
         $data = [];
 
         # environment settings
-        $post = $this->getPost();           # catch $_POST
-        $this->setTerminal(true);           # set terminal
+        $post = $this->getPost(); # catch $_POST
+        $this->setTerminal(true); # set terminal
 
         # TRY-CATCH-BLOCK
         try {
@@ -402,7 +402,7 @@  discard block
 block discarded – undo
                 $http = new Http();
                 $http->writeStatus($http::HTTP_METHOD_NOT_ALLOWED);
 
-                die('Error ' . $http::HTTP_METHOD_NOT_ALLOWED .' (' . $http->getStatusText($http::HTTP_METHOD_NOT_ALLOWED) . ')!!');
+                die('Error ' . $http::HTTP_METHOD_NOT_ALLOWED . ' (' . $http->getStatusText($http::HTTP_METHOD_NOT_ALLOWED) . ')!!');
             }
 
             # STANDARD VALIDATIONS [check needed arguments]
@@ -414,7 +414,7 @@  discard block
 block discarded – undo
                     $http = new Http();
                     $http->writeStatus($http::HTTP_BAD_REQUEST);
 
-                    die('Error ' . $http::HTTP_BAD_REQUEST .' (' . $http->getStatusText($http::HTTP_BAD_REQUEST) . ')!!');
+                    die('Error ' . $http::HTTP_BAD_REQUEST . ' (' . $http->getStatusText($http::HTTP_BAD_REQUEST) . ')!!');
                 }
             });
 
@@ -544,7 +544,7 @@  discard block
 block discarded – undo
                         $http = new Http();
                         $http->writeStatus($http::HTTP_BAD_REQUEST);
 
-                        die('Error ' . $http::HTTP_BAD_REQUEST .' (' . $http->getStatusText($http::HTTP_BAD_REQUEST) . ')!!');
+                        die('Error ' . $http::HTTP_BAD_REQUEST . ' (' . $http->getStatusText($http::HTTP_BAD_REQUEST) . ')!!');
                     }
 
                     $row_start = $post["row_start"] + $step;
@@ -697,11 +697,11 @@  discard block
 block discarded – undo
 
                             if (gettype($value) == 'object')
                             {
-                                if  (get_class($value) == 'OCI-Lob')
+                                if (get_class($value) == 'OCI-Lob')
                                 {
                                     if (($val = @$value->load()) === false)
                                     {
-                                        $val = null;   # only for default, this value is not used
+                                        $val = null; # only for default, this value is not used
                                         $column_errors[] = $column;
                                     }
 
@@ -778,8 +778,8 @@  discard block
 block discarded – undo
         $data = [];
 
         # environment settings
-        $post = $this->getPost();           # catch $_POST
-        $this->setTerminal(true);           # set terminal
+        $post = $this->getPost(); # catch $_POST
+        $this->setTerminal(true); # set terminal
 
         # TRY-CATCH-BLOCK
         try {
@@ -790,7 +790,7 @@  discard block
 block discarded – undo
                 $http = new Http();
                 $http->writeStatus($http::HTTP_METHOD_NOT_ALLOWED);
 
-                die('Error ' . $http::HTTP_METHOD_NOT_ALLOWED .' (' . $http->getStatusText($http::HTTP_METHOD_NOT_ALLOWED) . ')!!');
+                die('Error ' . $http::HTTP_METHOD_NOT_ALLOWED . ' (' . $http->getStatusText($http::HTTP_METHOD_NOT_ALLOWED) . ')!!');
             }
 
             # STANDARD VALIDATIONS [check needed arguments]
@@ -802,7 +802,7 @@  discard block
 block discarded – undo
                     $http = new Http();
                     $http->writeStatus($http::HTTP_BAD_REQUEST);
 
-                    die('Error ' . $http::HTTP_BAD_REQUEST .' (' . $http->getStatusText($http::HTTP_BAD_REQUEST) . ')!!');
+                    die('Error ' . $http::HTTP_BAD_REQUEST . ' (' . $http->getStatusText($http::HTTP_BAD_REQUEST) . ')!!');
                 }
             });
 
@@ -1085,11 +1085,11 @@  discard block
 block discarded – undo
 
                                 if (gettype($value) == 'object')
                                 {
-                                    if  (get_class($value) == 'OCI-Lob')
+                                    if (get_class($value) == 'OCI-Lob')
                                     {
                                         if (($val = @$value->load()) === false)
                                         {
-                                            $val = null;   # only for default, this value is not used
+                                            $val = null; # only for default, this value is not used
                                             $column_errors[] = $column;
                                         }
 
@@ -1111,7 +1111,7 @@  discard block
 block discarded – undo
 
                             foreach ($column_names as $column_name)
                             {
-                                $table .= "\t\t\t<td>". $row[$column_name] ."</td>\r\n";
+                                $table .= "\t\t\t<td>" . $row[$column_name] . "</td>\r\n";
                             }
 
                             $table .= "\t\t</tr>\r\n";
@@ -1153,11 +1153,11 @@  discard block
 block discarded – undo
 
                                 if (gettype($value) == 'object')
                                 {
-                                    if  (get_class($value) == 'OCI-Lob')
+                                    if (get_class($value) == 'OCI-Lob')
                                     {
                                         if (($val = @$value->load()) === false)
                                         {
-                                            $val = null;   # only for default, this value is not used
+                                            $val = null; # only for default, this value is not used
                                             $column_errors[] = $column;
                                         }
 
@@ -1258,7 +1258,7 @@  discard block
 block discarded – undo
             foreach ($errors as $errno => $error)
             {
                 $errorInformation .=
-                    "<strong style='color: #a94442'>".
+                    "<strong style='color: #a94442'>" .
                         $method
                             . "</strong>: <span style='color: #e24f4c'>{$error}</span> \n<br />";
             }

Please login to merge, or discard this patch.

		@@ -183,8 +183,8 @@ discard block
		block discarded – undo
183	183	$data = [];
184	184
185	185	# environment settings
186		- $post = $this->getPost(); # catch $_POST
187		- $this->setTerminal(true); # set terminal
	186	+ $post = $this->getPost(); # catch $_POST
	187	+ $this->setTerminal(true); # set terminal
188	188
189	189	# TRY-CATCH-BLOCK
190	190	try {
		@@ -195,7 +195,7 @@ discard block
		block discarded – undo
195	195	$http = new Http();
196	196	$http->writeStatus($http::HTTP_METHOD_NOT_ALLOWED);
197	197
198		- die('Error ' . $http::HTTP_METHOD_NOT_ALLOWED .' (' . $http->getStatusText($http::HTTP_METHOD_NOT_ALLOWED) . ')!!');
	198	+ die('Error ' . $http::HTTP_METHOD_NOT_ALLOWED . ' (' . $http->getStatusText($http::HTTP_METHOD_NOT_ALLOWED) . ')!!');
199	199	}
200	200
201	201	$idenfiers = $this->getIdentifiersEntity()->select([]);
		@@ -212,7 +212,7 @@ discard block
		block discarded – undo
212	212	$http = new Http();
213	213	$http->writeStatus($http::HTTP_BAD_REQUEST);
214	214
215		- die('Error ' . $http::HTTP_BAD_REQUEST .' (' . $http->getStatusText($http::HTTP_BAD_REQUEST) . ')!!');
	215	+ die('Error ' . $http::HTTP_BAD_REQUEST . ' (' . $http->getStatusText($http::HTTP_BAD_REQUEST) . ')!!');
216	216	}
217	217	});
218	218
		@@ -242,7 +242,7 @@ discard block
		block discarded – undo
242	242	$http = new Http();
243	243	$http->writeStatus($http::HTTP_BAD_REQUEST);
244	244
245		- die('Error ' . $http::HTTP_BAD_REQUEST .' (' . $http->getStatusText($http::HTTP_BAD_REQUEST) . ')!!');
	245	+ die('Error ' . $http::HTTP_BAD_REQUEST . ' (' . $http->getStatusText($http::HTTP_BAD_REQUEST) . ')!!');
246	246	}
247	247	});
248	248
		@@ -361,14 +361,14 @@ discard block
		block discarded – undo
361	361	$http = new Http();
362	362	$http->writeStatus($http::HTTP_METHOD_NOT_ALLOWED);
363	363
364		- die('Error ' . $http::HTTP_METHOD_NOT_ALLOWED .' (' . $http->getStatusText($http::HTTP_METHOD_NOT_ALLOWED) . ')!!');
	364	+ die('Error ' . $http::HTTP_METHOD_NOT_ALLOWED . ' (' . $http->getStatusText($http::HTTP_METHOD_NOT_ALLOWED) . ')!!');
365	365	}
366	366
367	367	# data to send
368	368	$data = [];
369	369
370		- $this->setTerminal(true); # set terminal
371		- $post = $this->getPost(); # catch $_POST
	370	+ $this->setTerminal(true); # set terminal
	371	+ $post = $this->getPost(); # catch $_POST
372	372
373	373	$data["id"] = $post["id"];
374	374	$data["conn"] = $post["conn"];
		@@ -390,8 +390,8 @@ discard block
		block discarded – undo
390	390	$data = [];
391	391
392	392	# environment settings
393		- $post = $this->getPost(); # catch $_POST
394		- $this->setTerminal(true); # set terminal
	393	+ $post = $this->getPost(); # catch $_POST
	394	+ $this->setTerminal(true); # set terminal
395	395
396	396	# TRY-CATCH-BLOCK
397	397	try {
		@@ -402,7 +402,7 @@ discard block
		block discarded – undo
402	402	$http = new Http();
403	403	$http->writeStatus($http::HTTP_METHOD_NOT_ALLOWED);
404	404
405		- die('Error ' . $http::HTTP_METHOD_NOT_ALLOWED .' (' . $http->getStatusText($http::HTTP_METHOD_NOT_ALLOWED) . ')!!');
	405	+ die('Error ' . $http::HTTP_METHOD_NOT_ALLOWED . ' (' . $http->getStatusText($http::HTTP_METHOD_NOT_ALLOWED) . ')!!');
406	406	}
407	407
408	408	# STANDARD VALIDATIONS [check needed arguments]
		@@ -414,7 +414,7 @@ discard block
		block discarded – undo
414	414	$http = new Http();
415	415	$http->writeStatus($http::HTTP_BAD_REQUEST);
416	416
417		- die('Error ' . $http::HTTP_BAD_REQUEST .' (' . $http->getStatusText($http::HTTP_BAD_REQUEST) . ')!!');
	417	+ die('Error ' . $http::HTTP_BAD_REQUEST . ' (' . $http->getStatusText($http::HTTP_BAD_REQUEST) . ')!!');
418	418	}
419	419	});
420	420
		@@ -544,7 +544,7 @@ discard block
		block discarded – undo
544	544	$http = new Http();
545	545	$http->writeStatus($http::HTTP_BAD_REQUEST);
546	546
547		- die('Error ' . $http::HTTP_BAD_REQUEST .' (' . $http->getStatusText($http::HTTP_BAD_REQUEST) . ')!!');
	547	+ die('Error ' . $http::HTTP_BAD_REQUEST . ' (' . $http->getStatusText($http::HTTP_BAD_REQUEST) . ')!!');
548	548	}
549	549
550	550	$row_start = $post["row_start"] + $step;
		@@ -697,11 +697,11 @@ discard block
		block discarded – undo
697	697
698	698	if (gettype($value) == 'object')
699	699	{
700		- if (get_class($value) == 'OCI-Lob')
	700	+ if (get_class($value) == 'OCI-Lob')
701	701	{
702	702	if (($val = @$value->load()) === false)
703	703	{
704		- $val = null; # only for default, this value is not used
	704	+ $val = null; # only for default, this value is not used
705	705	$column_errors[] = $column;
706	706	}
707	707
		@@ -778,8 +778,8 @@ discard block
		block discarded – undo
778	778	$data = [];
779	779
780	780	# environment settings
781		- $post = $this->getPost(); # catch $_POST
782		- $this->setTerminal(true); # set terminal
	781	+ $post = $this->getPost(); # catch $_POST
	782	+ $this->setTerminal(true); # set terminal
783	783
784	784	# TRY-CATCH-BLOCK
785	785	try {
		@@ -790,7 +790,7 @@ discard block
		block discarded – undo
790	790	$http = new Http();
791	791	$http->writeStatus($http::HTTP_METHOD_NOT_ALLOWED);
792	792
793		- die('Error ' . $http::HTTP_METHOD_NOT_ALLOWED .' (' . $http->getStatusText($http::HTTP_METHOD_NOT_ALLOWED) . ')!!');
	793	+ die('Error ' . $http::HTTP_METHOD_NOT_ALLOWED . ' (' . $http->getStatusText($http::HTTP_METHOD_NOT_ALLOWED) . ')!!');
794	794	}
795	795
796	796	# STANDARD VALIDATIONS [check needed arguments]
		@@ -802,7 +802,7 @@ discard block
		block discarded – undo
802	802	$http = new Http();
803	803	$http->writeStatus($http::HTTP_BAD_REQUEST);
804	804
805		- die('Error ' . $http::HTTP_BAD_REQUEST .' (' . $http->getStatusText($http::HTTP_BAD_REQUEST) . ')!!');
	805	+ die('Error ' . $http::HTTP_BAD_REQUEST . ' (' . $http->getStatusText($http::HTTP_BAD_REQUEST) . ')!!');
806	806	}
807	807	});
808	808
		@@ -1085,11 +1085,11 @@ discard block
		block discarded – undo
1085	1085
1086	1086	if (gettype($value) == 'object')
1087	1087	{
1088		- if (get_class($value) == 'OCI-Lob')
	1088	+ if (get_class($value) == 'OCI-Lob')
1089	1089	{
1090	1090	if (($val = @$value->load()) === false)
1091	1091	{
1092		- $val = null; # only for default, this value is not used
	1092	+ $val = null; # only for default, this value is not used
1093	1093	$column_errors[] = $column;
1094	1094	}
1095	1095
		@@ -1111,7 +1111,7 @@ discard block
		block discarded – undo
1111	1111
1112	1112	foreach ($column_names as $column_name)
1113	1113	{
1114		- $table .= "\t\t\t<td>". $row[$column_name] ."</td>\r\n";
	1114	+ $table .= "\t\t\t<td>" . $row[$column_name] . "</td>\r\n";
1115	1115	}
1116	1116
1117	1117	$table .= "\t\t</tr>\r\n";
		@@ -1153,11 +1153,11 @@ discard block
		block discarded – undo
1153	1153
1154	1154	if (gettype($value) == 'object')
1155	1155	{
1156		- if (get_class($value) == 'OCI-Lob')
	1156	+ if (get_class($value) == 'OCI-Lob')
1157	1157	{
1158	1158	if (($val = @$value->load()) === false)
1159	1159	{
1160		- $val = null; # only for default, this value is not used
	1160	+ $val = null; # only for default, this value is not used
1161	1161	$column_errors[] = $column;
1162	1162	}
1163	1163
		@@ -1258,7 +1258,7 @@ discard block
		block discarded – undo
1258	1258	foreach ($errors as $errno => $error)
1259	1259	{
1260	1260	$errorInformation .=
1261		- "<strong style='color: #a94442'>".
	1261	+ "<strong style='color: #a94442'>" .
1262	1262	$method
1263	1263	. "</strong>: <span style='color: #e24f4c'>{$error}</span> \n<br />";
1264	1264	}

		@@ -4,7 +4,7 @@ discard block
		block discarded – undo
4	4	{
5	5	function ifdef($value, Array $array)
6	6	{
7		- $global = __DIR__ . '/../../../config/global.config.php';
	7	+ $global = __DIR__ . '/../../../config/global.config.php';
8	8
9	9	if (file_exists($global))
10	10	{
		@@ -28,7 +28,7 @@ discard block
		block discarded – undo
28	28	if (!$key)
29	29	return $in;
30	30
31		- } while($key);
	31	+ } while ($key);
32	32	}
33	33	else
34	34	return $value;
		@@ -37,6 +37,6 @@ discard block
		block discarded – undo
37	37
38	38	return [
39	39	'project' => [
40		- 'name' => ifdef('PROTOTYPE4', ["project", "name"]), # The name of your project
	40	+ 'name' => ifdef('PROTOTYPE4', ["project", "name"]), # The name of your project
41	41	],
42	42	];
43	43	\ No newline at end of file

		@@ -2,7 +2,7 @@ discard block
		block discarded – undo
2	2
3	3	return [
4	4	'project' => [
5		- 'id' => 'id6447896', # Unique ID for the project
	5	+ 'id' => 'id6447896', # Unique ID for the project
6	6	'name' => 'SQLWebManager' # The name of your project
7	7	],
8	8	'mail' => [
		@@ -10,8 +10,8 @@ discard block
		block discarded – undo
10	10	"host" => ""
11	11	],
12	12	"authentication" => [
13		- "method" => "_COOKIE", # the method to store credentials (_COOKIE, _SESSION)
14		- "key" => "session_id6448654", # the key in the array to store credentials
	13	+ "method" => "_COOKIE", # the method to store credentials (_COOKIE, _SESSION)
	14	+ "key" => "session_id6448654", # the key in the array to store credentials
15	15	],
16	16	"database" => [
17	17	/** TABLE PREFIX:

Pleets / SQLWebManager

Push — master ( 5424ee...dddd00 )

Status

Category

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +25 added lines, -25 removed lines patch added patch discarded remove patch