| Conditions | 23 |
| Paths | 40 |
| Total Lines | 128 |
| Code Lines | 73 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 279 | protected function processBuffer() { |
||
| 280 | //\assert((\Plasma\Drivers\MySQL\Messages\MessageUtility::debug('ProtocolParser::processBuffer called') || true)); |
||
| 281 | |||
| 282 | if($this->buffer->getSize() < 4) { |
||
| 283 | //\assert((\Plasma\Drivers\MySQL\Messages\MessageUtility::debug('Not enough data received for packet header ('.$this->buffer->getSize().')') || true)); |
||
| 284 | return; |
||
| 285 | } |
||
| 286 | |||
| 287 | $buffer = clone $this->buffer; |
||
| 288 | |||
| 289 | $length = $buffer->readInt3(); |
||
| 290 | $this->sequenceID = $buffer->readInt1(); |
||
| 291 | |||
| 292 | //\assert((\Plasma\Drivers\MySQL\Messages\MessageUtility::debug('First 10 bytes: '.implode(', ', unpack('C*', \substr($this->buffer->getContents(), 0, 10)))) || true)); |
||
| 293 | //\assert((\Plasma\Drivers\MySQL\Messages\MessageUtility::debug('Read packet header length ('.$length.') and sequence ('.$this->sequenceID.')') || true)); |
||
| 294 | |||
| 295 | if($length === 0xFFFFFF) { |
||
| 296 | $this->buffer->read(($length + 4)); |
||
| 297 | $this->messageBuffer->append($buffer->read($length)); |
||
| 298 | |||
| 299 | //\assert((\Plasma\Drivers\MySQL\Messages\MessageUtility::debug('returned, 16mb packet received, waiting for the last one to arrive') || true)); |
||
| 300 | return; |
||
| 301 | } elseif($this->messageBuffer->getSize() > 0) { |
||
| 302 | $this->messageBuffer->append($buffer->read($length)); |
||
| 303 | $buffer = $this->messageBuffer; |
||
| 304 | $this->messageBuffer = new \Plasma\BinaryBuffer(); |
||
| 305 | } |
||
| 306 | |||
| 307 | if($buffer->getSize() < $length) { |
||
| 308 | //\assert((\Plasma\Drivers\MySQL\Messages\MessageUtility::debug('returned, insufficent length: '.$buffer->getSize().', '.$length.' required') || true)); |
||
| 309 | return; |
||
| 310 | } |
||
| 311 | |||
| 312 | if($length > 0) { |
||
| 313 | $this->buffer->read(($length + 4)); |
||
| 314 | $buffer->slice(0, $length); |
||
| 315 | } else { |
||
| 316 | $this->buffer->slice($buffer->getSize()); |
||
| 317 | } |
||
| 318 | |||
| 319 | if($buffer->getSize() === 0) { |
||
| 320 | //\assert((\Plasma\Drivers\MySQL\Messages\MessageUtility::debug('Buffer length is 0') || true)); |
||
| 321 | return; |
||
| 322 | } |
||
| 323 | |||
| 324 | /** @var \Plasma\Drivers\MySQL\Messages\MessageInterface $message */ |
||
| 325 | $message = null; |
||
| 326 | |||
| 327 | if($this->state === static::STATE_INIT) { |
||
| 328 | $message = new \Plasma\Drivers\MySQL\Messages\HandshakeMessage($this); |
||
| 329 | } else { |
||
| 330 | $firstChar = $buffer->read(1); |
||
| 331 | //\assert((\Plasma\Drivers\MySQL\Messages\MessageUtility::debug('Received Message char "'.$firstChar.'" (0x'.\dechex(\ord($firstChar)).') - buffer length: '.$buffer->getSize()) || true)); |
||
| 332 | |||
| 333 | $okRespID = \Plasma\Drivers\MySQL\Messages\OkResponseMessage::getID(); |
||
| 334 | $isOkMessage = ( |
||
| 335 | ( |
||
| 336 | $firstChar === $okRespID && |
||
| 337 | !($this->currentCommand instanceof \Plasma\Drivers\MySQL\Commands\StatementExecuteCommand) |
||
| 338 | ) || |
||
| 339 | ( |
||
| 340 | $firstChar === \Plasma\Drivers\MySQL\Messages\EOFMessage::getID() && |
||
| 341 | ($this->handshakeMessage->capability & \Plasma\Drivers\MySQL\CapabilityFlags::CLIENT_DEPRECATE_EOF) !== 0 |
||
| 342 | ) |
||
| 343 | ); |
||
| 344 | |||
| 345 | switch(true) { |
||
| 346 | case ($firstChar === \Plasma\Drivers\MySQL\Messages\ErrResponseMessage::getID()): |
||
| 347 | $message = new \Plasma\Drivers\MySQL\Messages\ErrResponseMessage($this); |
||
| 348 | break; |
||
| 349 | case ($this->currentCommand instanceof \Plasma\Drivers\MySQL\Commands\StatementPrepareCommand && $firstChar === $okRespID): |
||
| 350 | $message = new \Plasma\Drivers\MySQL\Messages\PrepareStatementOkMessage($this); |
||
| 351 | break; |
||
| 352 | case $isOkMessage: |
||
| 353 | $message = new \Plasma\Drivers\MySQL\Messages\OkResponseMessage($this); |
||
| 354 | $this->lastOkMessage = $message; |
||
| 355 | break; |
||
|
1 ignored issue
–
show
|
|||
| 356 | case ($firstChar === \Plasma\Drivers\MySQL\Messages\EOFMessage::getID() && $length < 6): |
||
| 357 | $message = new \Plasma\Drivers\MySQL\Messages\EOFMessage($this); |
||
| 358 | break; |
||
| 359 | default: |
||
| 360 | $buffer->prepend($firstChar); |
||
| 361 | |||
| 362 | if($this->parseCallback !== null) { |
||
| 363 | $parse = $this->parseCallback; |
||
| 364 | $this->parseCallback = null; |
||
| 365 | |||
| 366 | $caller = new \Plasma\Drivers\MySQL\ProtocolOnNextCaller($this, $buffer); |
||
| 367 | $parse($caller); |
||
| 368 | } elseif($this->currentCommand !== null) { |
||
| 369 | $command = $this->currentCommand; |
||
| 370 | |||
| 371 | $caller = new \Plasma\Drivers\MySQL\ProtocolOnNextCaller($this, $buffer); |
||
| 372 | $command->onNext($caller); |
||
| 373 | |||
| 374 | if($command->hasFinished()) { |
||
| 375 | $this->currentCommand = null; |
||
| 376 | $command->onComplete(); |
||
| 377 | } |
||
| 378 | } |
||
| 379 | |||
| 380 | //\assert((\Plasma\Drivers\MySQL\Messages\MessageUtility::debug('Left over buffer: '.$buffer->getSize()) || true)); |
||
| 381 | |||
| 382 | if($this->buffer->getSize() > 0) { |
||
| 383 | //\assert((\Plasma\Drivers\MySQL\Messages\MessageUtility::debug('Scheduling future read with '.$this->buffer->getSize().' bytes') || true)); |
||
| 384 | |||
| 385 | $this->driver->getLoop()->futureTick(function () { |
||
| 386 | $this->processBuffer(); |
||
| 387 | }); |
||
| 388 | } |
||
| 389 | |||
| 390 | return; |
||
| 391 | break; |
||
| 392 | } |
||
| 393 | } |
||
| 394 | |||
| 395 | //\assert((\Plasma\Drivers\MySQL\Messages\MessageUtility::debug('Received Message '.\get_class($message)) || true)); |
||
| 396 | |||
| 397 | $state = $message->setParserState(); |
||
| 398 | if($state !== -1) { |
||
| 399 | $this->state = $state; |
||
| 400 | } |
||
| 401 | |||
| 402 | if($message instanceof \Plasma\Drivers\MySQL\Messages\HandshakeMessage) { |
||
| 403 | $this->handshakeMessage = $message; |
||
| 404 | } |
||
| 405 | |||
| 406 | $this->handleMessage($buffer, $message); |
||
| 407 | } |
||
| 513 |