TextProtocolValues::decode() - Code Metrics - Inspection of "Text protocol fix" - PlasmaPHP/driver-mysql - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( 5074f6...8d2a16 )

by Charlotte

created 2018-11-24 13:29 UTC

TextProtocolValues::decode() B

↳ Parent: TextProtocolValues

Complexity

Conditions	11
Paths	8

Size

Total Lines	27
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	19
CRAP Score	11

Importance

Changes

Metric	Value
cc	11
eloc	19
nc	8
nop	2
dl	0
loc	27
ccs	19
cts	19
cp	1
crap	11
rs	7.3166
c	0
b	0
f	0

How to fix Complexity

<?php
/**
 * Plasma Driver MySQL component
 * Copyright 2018 PlasmaPHP, All Rights Reserved
 *
 * Website: https://github.com/PlasmaPHP
 * License: https://github.com/PlasmaPHP/driver-mysql/blob/master/LICENSE
*/

namespace Plasma\Drivers\MySQL;

/**
 * Text protocol rowset values decoder.
 * @internal
 */
class TextProtocolValues {
    /**
     * Standard decode value, if type extensions failed.
     * @param \Plasma\ColumnDefinitionInterface  $column
     * @param string|null                        $param
     * @return mixed
     * @throws \Plasma\Exception
     */
    static function decode(\Plasma\ColumnDefinitionInterface $column, $param) {
        $type = $column->getType();
        $flags = $column->getFlags();
        
        if($param !== null && ($flags & \Plasma\Drivers\MySQL\FieldFlags::ZEROFILL_FLAG) === 0) {
            switch(true) {
                case ($type === 'LONG'):

                    if(($flags & \Plasma\Drivers\MySQL\FieldFlags::UNSIGNED_FLAG) === 0 || \PHP_INT_SIZE > 4) {
                        $param = (int) $param;
                    }

                break;

                case ($type === 'LONGLONG'):

                    if(($flags & \Plasma\Drivers\MySQL\FieldFlags::UNSIGNED_FLAG) === 0 && \PHP_INT_SIZE > 4) {
                        $param = (int) $param;
                    }
                break;

                case static::isTypeTinyShortInt($type):

                    $param = (int) $param;
                break;

                case static::isTypeFloat($type):

                    $param = (float) $param;
                break;
                // Other types are taken as string
            }
        }
        
        return $param;
    }
    
    /**
     * @param string  $type
     * @return bool
     */
    static function isTypeTinyShortInt(string $type): bool {
        $types = array('TINY', 'SHORT', 'INT24');
        return \in_array($type, $types, true);
    }
    
    /**
     * @param string  $type
     * @return bool
     */
    static function isTypeFloat(string $type): bool {
        $types = array('FLOAT', 'DOUBLE');
        return \in_array($type, $types, true);
    }
}


GitHub Access Token became invalid

Push — master ( 5074f6...8d2a16 )

TextProtocolValues::decode() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

1		<?php
2		/**
3		* Plasma Driver MySQL component
4		* Copyright 2018 PlasmaPHP, All Rights Reserved
5		*
6		* Website: https://github.com/PlasmaPHP
7		* License: https://github.com/PlasmaPHP/driver-mysql/blob/master/LICENSE
8		*/
9
10		namespace Plasma\Drivers\MySQL;
11
12		/**
13		* Text protocol rowset values decoder.
14		* @internal
15		*/
16		class TextProtocolValues {
17		/**
18		* Standard decode value, if type extensions failed.
19		* @param \Plasma\ColumnDefinitionInterface $column
20		* @param string\|null $param
21		* @return mixed
22		* @throws \Plasma\Exception
23		*/
24	7	static function decode(\Plasma\ColumnDefinitionInterface $column, $param) {
25	7	$type = $column->getType();
26	7	$flags = $column->getFlags();
27
28	7	if($param !== null && ($flags & \Plasma\Drivers\MySQL\FieldFlags::ZEROFILL_FLAG) === 0) {
29		switch(true) {
30	7	case ($type === 'LONG'):
		1 ignored issue – show Coding Style introduced 2018-11-24 13:31 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 12 spaces, found 16 Loading history...
31	1	if(($flags & \Plasma\Drivers\MySQL\FieldFlags::UNSIGNED_FLAG) === 0 \|\| \PHP_INT_SIZE > 4) {
32	1	$param = (int) $param;
33		}
		1 ignored issue – show Coding Style introduced 2018-11-24 13:31 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 16 spaces, found 20 Loading history...
34	1	break;
		1 ignored issue – show Coding Style introduced 2018-11-24 13:31 UTC by Report Bug Copy Issue Report Case breaking statement indented incorrectly; expected 20 spaces, found 16 Loading history...
35	7	case ($type === 'LONGLONG'):
		1 ignored issue – show Coding Style introduced 2018-11-24 13:31 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 12 spaces, found 16 Loading history...
36	1	if(($flags & \Plasma\Drivers\MySQL\FieldFlags::UNSIGNED_FLAG) === 0 && \PHP_INT_SIZE > 4) {
37	1	$param = (int) $param;
38		}
39	1	break;
		1 ignored issue – show Coding Style introduced 2018-11-24 13:31 UTC by Report Bug Copy Issue Report Case breaking statement indented incorrectly; expected 20 spaces, found 16 Loading history...
40	7	case static::isTypeTinyShortInt($type):
		1 ignored issue – show Coding Style introduced 2018-11-24 13:31 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 12 spaces, found 16 Loading history...
41	1	$param = (int) $param;
42	1	break;
		1 ignored issue – show Coding Style introduced 2018-11-24 13:31 UTC by Report Bug Copy Issue Report Case breaking statement indented incorrectly; expected 20 spaces, found 16 Loading history...
43	6	case static::isTypeFloat($type):
		1 ignored issue – show Coding Style introduced 2018-11-24 13:31 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 12 spaces, found 16 Loading history...
44	1	$param = (float) $param;
45	1	break;
46		// Other types are taken as string
47		}
48		}
49
50	7	return $param;
51		}
52
53		/**
54		* @param string $type
55		* @return bool
56		*/
57	7	static function isTypeTinyShortInt(string $type): bool {
58	7	$types = array('TINY', 'SHORT', 'INT24');
59	7	return \in_array($type, $types, true);
60		}
61
62		/**
63		* @param string $type
64		* @return bool
65		*/
66	6	static function isTypeFloat(string $type): bool {
67	6	$types = array('FLOAT', 'DOUBLE');
68	6	return \in_array($type, $types, true);
69		}
70		}
71

PlasmaPHP / driver-mysql

GitHub Access Token became invalid

Push — master ( 5074f6...8d2a16 )

TextProtocolValues::decode() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like