Conditions | 45 |
Paths | 63 |
Total Lines | 144 |
Code Lines | 114 |
Lines | 0 |
Ratio | 0 % |
Tests | 0 |
CRAP Score | 2070 |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
221 | protected function stdDecodeBinaryValue(\Plasma\ColumnDefinitionInterface $column, \Plasma\BinaryBuffer $buffer) { |
||
222 | $flags = $column->getFlags(); |
||
223 | |||
224 | switch(true) { |
||
225 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_TINY) !== 0): |
||
1 ignored issue
–
show
|
|||
226 | $value = $buffer->readInt1(); |
||
227 | $value = $this->zeroFillInts($column, $value); |
||
228 | break; |
||
1 ignored issue
–
show
|
|||
229 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_SHORT) !== 0): |
||
1 ignored issue
–
show
|
|||
230 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_YEAR) !== 0): |
||
1 ignored issue
–
show
|
|||
231 | $value = $buffer->readInt2(); |
||
232 | $value = $this->zeroFillInts($column, $value); |
||
233 | break; |
||
1 ignored issue
–
show
|
|||
234 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_INT24) !== 0): |
||
1 ignored issue
–
show
|
|||
235 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_LONG) !== 0): |
||
1 ignored issue
–
show
|
|||
236 | $value = $buffer->readInt4(); |
||
237 | |||
238 | if(($flags & \Plasma\Drivers\MySQL\FieldFlags::UNSIGNED_FLAG) !== 0 && \PHP_INT_SIZE <= 4) { |
||
1 ignored issue
–
show
|
|||
239 | $value = \bcadd($value, '18446744073709551616'); |
||
240 | } |
||
1 ignored issue
–
show
|
|||
241 | |||
242 | $value = $this->zeroFillInts($column, $value); |
||
243 | break; |
||
1 ignored issue
–
show
|
|||
244 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_LONGLONG) !== 0): |
||
1 ignored issue
–
show
|
|||
245 | $value = $buffer->readInt8(); |
||
246 | |||
247 | if(($flags & \Plasma\Drivers\MySQL\FieldFlags::UNSIGNED_FLAG) !== 0) { |
||
1 ignored issue
–
show
|
|||
248 | $value = \bcadd($value, '18446744073709551616'); |
||
249 | } elseif(\PHP_INT_SIZE > 4) { |
||
1 ignored issue
–
show
|
|||
250 | $value = (int) $value; |
||
251 | } |
||
1 ignored issue
–
show
|
|||
252 | |||
253 | $value = $this->zeroFillInts($column, $value); |
||
254 | break; |
||
1 ignored issue
–
show
|
|||
255 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_FLOAT) !== 0): |
||
1 ignored issue
–
show
|
|||
256 | $value = $buffer->readFloat(); |
||
257 | break; |
||
1 ignored issue
–
show
|
|||
258 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_DOUBLE) !== 0): |
||
1 ignored issue
–
show
|
|||
259 | $value = $buffer->readDouble(); |
||
260 | break; |
||
1 ignored issue
–
show
|
|||
261 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_DATE) !== 0): |
||
1 ignored issue
–
show
|
|||
262 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_NEWDATE) !== 0): |
||
1 ignored issue
–
show
|
|||
263 | $length = $buffer->readIntLength(); |
||
264 | if($length > 0) { |
||
1 ignored issue
–
show
|
|||
265 | $year = $buffer->readInt2(); |
||
266 | $month = $buffer->readInt1(); |
||
267 | $day = $buffer->readInt1(); |
||
268 | |||
269 | $value = \sprintf('%d-%d-%d', $year, $month, $day); |
||
270 | } else { |
||
1 ignored issue
–
show
|
|||
271 | $value = '0000-00-00'; |
||
272 | } |
||
1 ignored issue
–
show
|
|||
273 | break; |
||
1 ignored issue
–
show
|
|||
274 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_DATETIME) !== 0): |
||
1 ignored issue
–
show
|
|||
275 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_TIMESTAMP) !== 0): |
||
1 ignored issue
–
show
|
|||
276 | $length = $buffer->readIntLength(); |
||
277 | if($length > 0) { |
||
1 ignored issue
–
show
|
|||
278 | $year = $buffer->readInt2(); |
||
279 | $month = $buffer->readInt1(); |
||
280 | $day = $buffer->readInt1(); |
||
281 | |||
282 | if($length > 4) { |
||
1 ignored issue
–
show
|
|||
283 | $hour = $buffer->readInt1(); |
||
284 | $min = $buffer->readInt1(); |
||
285 | $sec = $buffer->readInt1(); |
||
286 | } else { |
||
1 ignored issue
–
show
|
|||
287 | $hour = 0; |
||
288 | $min = 0; |
||
289 | $sec = 0; |
||
290 | } |
||
1 ignored issue
–
show
|
|||
291 | |||
292 | if($length > 7) { |
||
1 ignored issue
–
show
|
|||
293 | $micro = $buffer->readInt4(); |
||
294 | } else { |
||
1 ignored issue
–
show
|
|||
295 | $micro = 0; |
||
296 | } |
||
1 ignored issue
–
show
|
|||
297 | |||
298 | $timestamp = (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_TIMESTAMP) !== 0); |
||
299 | |||
300 | $micro = \str_pad($micro, 6, '0', \STR_PAD_LEFT); |
||
301 | $micro = ($timestamp ? $micro : \number_format($micro, 0, '', ' ')); |
||
302 | |||
303 | $value = \sprintf('%d-%d-%d %d:%d:%d'.($micro > 0 ? '.%s' : ''), $year, $month, $day, $hour, $min, $sec, $micro); |
||
304 | |||
305 | if($timestamp) { |
||
1 ignored issue
–
show
|
|||
306 | $value = \DateTime::createFromFormat('Y-m-d H:i:s'.($micro > 0 ? '.u' : ''), $value)->getTimestamp(); |
||
307 | } |
||
1 ignored issue
–
show
|
|||
308 | } else { |
||
1 ignored issue
–
show
|
|||
309 | $value = '0000-00-00 00:00:00.000 000'; |
||
310 | } |
||
1 ignored issue
–
show
|
|||
311 | break; |
||
1 ignored issue
–
show
|
|||
312 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_TIME) !== 0): |
||
1 ignored issue
–
show
|
|||
313 | $length = $buffer->readIntLength(); |
||
314 | if($length > 0) { |
||
1 ignored issue
–
show
|
|||
315 | $sign = $buffer->readInt1(); |
||
316 | $days = $buffer->readInt4(); |
||
317 | |||
318 | if($sign === 1) { |
||
1 ignored issue
–
show
|
|||
319 | $days *= -1; |
||
320 | } |
||
1 ignored issue
–
show
|
|||
321 | |||
322 | $hour = $buffer->readInt1(); |
||
323 | $min = $buffer->readInt1(); |
||
324 | $sec = $buffer->readInt1(); |
||
325 | |||
326 | if($length > 8) { |
||
1 ignored issue
–
show
|
|||
327 | $micro = $buffer->readInt4(); |
||
328 | } else { |
||
1 ignored issue
–
show
|
|||
329 | $micro = 0; |
||
330 | } |
||
1 ignored issue
–
show
|
|||
331 | |||
332 | $micro = \str_pad($micro, 6, '0', \STR_PAD_LEFT); |
||
333 | $micro = \number_format($micro, 0, '', ' '); |
||
334 | |||
335 | $value = \sprintf('%dd %d:%d:%d'.($micro > 0 ? '.%s' : ''), $days, $hour, $min, $sec, $micro); |
||
336 | } else { |
||
1 ignored issue
–
show
|
|||
337 | $value = '0d 00:00:00'; |
||
338 | } |
||
1 ignored issue
–
show
|
|||
339 | break; |
||
1 ignored issue
–
show
|
|||
340 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_STRING) !== 0): |
||
1 ignored issue
–
show
|
|||
341 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_VARCHAR) !== 0): |
||
1 ignored issue
–
show
|
|||
342 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_VAR_STRING) !== 0): |
||
1 ignored issue
–
show
|
|||
343 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_ENUM) !== 0): |
||
1 ignored issue
–
show
|
|||
344 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_SET) !== 0): |
||
1 ignored issue
–
show
|
|||
345 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_LONG_BLOB) !== 0): |
||
1 ignored issue
–
show
|
|||
346 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_MEDIUM_BLOB) !== 0): |
||
1 ignored issue
–
show
|
|||
347 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_BLOB) !== 0): |
||
1 ignored issue
–
show
|
|||
348 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_TINY_BLOB) !== 0): |
||
1 ignored issue
–
show
|
|||
349 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_GEOMETRY) !== 0): |
||
1 ignored issue
–
show
|
|||
350 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_BIT) !== 0): |
||
1 ignored issue
–
show
|
|||
351 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_DECIMAL) !== 0): |
||
1 ignored issue
–
show
|
|||
352 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_NEWDECIMAL) !== 0): |
||
1 ignored issue
–
show
|
|||
353 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_JSON) !== 0): |
||
1 ignored issue
–
show
|
|||
354 | $value = $buffer->readStringLength(); |
||
355 | break; |
||
1 ignored issue
–
show
|
|||
356 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_NULL) !== 0): |
||
1 ignored issue
–
show
|
|||
357 | $value = null; |
||
358 | break; |
||
1 ignored issue
–
show
|
|||
359 | default: |
||
1 ignored issue
–
show
|
|||
360 | throw new \InvalidArgumentException('Unknown column type (flags: '.$flags.', type: '.$column->getType().')'); |
||
361 | break; |
||
362 | } |
||
363 | |||
364 | return $value; |
||
365 | } |
||
382 |