Plasma\Drivers\MySQL\Commands\PromiseCommand

Complexity

Total Complexity

34

Size/Duplication

Total Lines	269
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

12 Methods

Rating	Name	Duplication	Size	Complexity
A	getPromise()	0	2	1
A	setParserState()	0	2	1
A	onComplete()	0	3	1
A	handleQueryOnNextCaller()	0	11	3
C	stdDecodeValue()	0	30	15
A	__construct()	0	9	1
A	parseColumnDefinition()	0	30	1
A	parseResultsetRow()	0	19	3
A	onError()	0	14	2
A	hasFinished()	0	2	1
A	handleQueryOnNextCallerColumns()	0	26	4
A	waitForCompletion()	0	2	1

<?php
/**
 * Plasma Driver MySQL component
 * Copyright 2018 PlasmaPHP, All Rights Reserved
 *
 * Website: https://github.com/PlasmaPHP
 * License: https://github.com/PlasmaPHP/driver-mysql/blob/master/LICENSE
*/

namespace Plasma\Drivers\MySQL\Commands;

/**
 * Abstract command which has a promise.
 * @internal
 */
abstract class PromiseCommand implements CommandInterface {
    use \Evenement\EventEmitterTrait;
    
    /**
     * @var \Plasma\DriverInterface
     */
    protected $driver;
    
    /**
     * @var \React\Promise\Deferred
     */
    protected $deferred;
    
    /**
     * @var mixed
     */
    protected $resolveValue;
    
    /**
     * @var bool
     */
    protected $finished = false;
    
    /**
     * Constructor.
     * @param \Plasma\DriverInterface  $driver
     */
    function __construct(\Plasma\DriverInterface $driver) {

The parameter $driver is not used and could be removed.

        $this->deferred = new \React\Promise\Deferred();
        
        $this->once('error', function (\Throwable $error) {
            $this->deferred->reject($error);
        });
        
        $this->once('end', function () {
            $this->deferred->resolve($this->resolveValue);
        });
    }
    
    /**
     * Get the encoded message for writing to the database connection.
     * @return string
     */
    abstract function getEncodedMessage(): string;
    
    /**
     * Get the promise.
     * @var \React\Promise\PromiseInterface
     */

Missing @return tag in function comment

    function getPromise(): \React\Promise\PromiseInterface {
        return $this->deferred->promise();
    }
    
    /**
     * Sets the parser state, if necessary. If not, return `-1`.
     * @return int
     */
    function setParserState(): int {
        return -1;
    }
    
    /**
     * Sets the command as completed. This state gets reported back to the user.
     * @return void
     */
    function onComplete(): void {
        $this->finished = true;
        $this->emit('end');
    }
    
    /**
     * Sets the command as errored. This state gets reported back to the user.
     * @param \Throwable  $throwable
     * @return void
     */
    function onError(\Throwable $throwable): void {
        $this->finished = true;
        
        if($this->resolveValue !== null) {
            // Workaround for getting the promise resolved AFTER receiving and processing an error packet,
            // so we would miss the error packet
            $this->driver->getLoop()->futureTick(function () use ($throwable) {
                $this->emit('error', array($throwable));
            });
            
            return;
        }
        
        $this->emit('error', array($throwable));
    }
    
    /**
     * Sends the next received value into the command.
     * @param mixed  $value
     * @return void
     */
    abstract function onNext($value): void;
    
    /**
     * Whether the command has finished.
     * @return bool
     */
    function hasFinished(): bool {
        return $this->finished;
    }
    
    /**
     * Whether this command sets the connection as busy.
     * @return bool
     */
    function waitForCompletion(): bool {
        return true;
    }
    
    /**
     * Handles query commands on next caller.
     * @param \Plasma\Drivers\MySQL\ProtocolOnNextCaller  $value
     * @return void
     */
    function handleQueryOnNextCaller(\Plasma\Drivers\MySQL\ProtocolOnNextCaller $value): void {
        $buffer = $value->getBuffer();
        $parser = $value->getParser();
        
        if($this->resolveValue !== null) {
            $row = $this->parseResultsetRow($buffer);
            $this->emit('data', array($row));
        } else {
            $field = $this->handleQueryOnNextCallerColumns($buffer, $parser);
            if($field) {

$field is of type Plasma\ColumnDefinition, thus it always evaluated to true.

                $this->fields[$field->getName()] = $field;

The property fields does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            }
        }
    }
    
    /**
     * Handles the column definitions of query commands on next caller.
     * @param \Plasma\BinaryBuffer                  $buffer
     * @param \Plasma\Drivers\MySQL\ProtocolParser  $parser
     * @return \Plasma\ColumnDefinitionInterface|null
     */
    function handleQueryOnNextCallerColumns(\Plasma\BinaryBuffer $buffer, \Plasma\Drivers\MySQL\ProtocolParser $parser): ?\Plasma\ColumnDefinitionInterface {
        if($this->fieldsCount === null) {
            $fieldCount = $buffer->readIntLength();
            
            if($fieldCount === 0xFB) {
                // Handle it on future tick, so we can cleanly finish the buffer of this call
                $this->driver->getLoop()->futureTick(function () use (&$buffer, &$parser) {
                    $localMsg = new \Plasma\Drivers\MySQL\Messages\LocalInFileRequestMessage($parser);
                    $parser->handleMessage($buffer, $localMsg);
                });
                
                return null;
            } elseif($fieldCount === 0x00) {
                $this->driver->getLoop()->futureTick(function () use (&$buffer, &$parser) {
                    $okMsg = new \Plasma\Drivers\MySQL\Messages\OkResponseMessage($parser);
                    $parser->handleMessage($buffer, $okMsg);
                });
                
                return null;
            }
            
            $this->fieldsCount = $fieldCount;

The property fieldsCount does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            return null;
        }
        
        return static::parseColumnDefinition($buffer);
    }
    
    /**
     * Parses the column definition.
     * @param \Plasma\BinaryBuffer  $buffer
     * @return \Plasma\ColumnDefinitionInterface
     */
    static function parseColumnDefinition(\Plasma\BinaryBuffer $buffer): \Plasma\ColumnDefinitionInterface {
        \Plasma\Drivers\MySQL\Messages\MessageUtility::debug('CD 5 bytes: '.implode(', ', unpack('C*', \substr($buffer->getContents(), 0, 5))));
        $buffer->readStringLength(); // catalog - always "def"
        $database = $buffer->readStringLength();
        
        $table = $buffer->readStringLength();
        $buffer->readStringLength(); // orgTable
        
        $name = $buffer->readStringLength();
        $buffer->readStringLength(); // orgName
        
        $buffer->read(1); // 0x0C
        
        $charset = $buffer->readInt2();
        $length = $buffer->readInt4();
        $type = $buffer->readInt1();
        $flags = $buffer->readInt2();
        $decimals = $buffer->readInt1();
        
        $buffer->read(2); // fillers
        
        /*if($this instanceof COM_FIELD_LIST) {
            $buffer->readStringLength();
        }*/
        
        $charset = \Plasma\Drivers\MySQL\CharacterSetFlags::CHARSET_MAP[$charset] ?? 'Unknown charset "'.$charset.'"';
        $type = \Plasma\Drivers\MySQL\FieldFlags::TYPE_MAP[$type] ?? 'Unknown type "'.$type.'"';
        $nullable = (($flags & \Plasma\Drivers\MySQL\FieldFlags::NOT_NULL_FLAG) === 0);
        
        return (new \Plasma\ColumnDefinition($database, $table, $name, $type, $charset, $length, $nullable, $flags, $decimals));

It seems like $name can also be of type null; however, parameter $name of Plasma\ColumnDefinition::__construct() does only seem to accept string, maybe add an additional type check?

It seems like $table can also be of type null; however, parameter $table of Plasma\ColumnDefinition::__construct() does only seem to accept string, maybe add an additional type check?

It seems like $database can also be of type null; however, parameter $database of Plasma\ColumnDefinition::__construct() does only seem to accept string, maybe add an additional type check?

    }
    
    /**
     * Parses the text resultset row and returns the row.
     * @param \Plasma\ColumnDefinitionInterface  $column

Doc comment for parameter $column does not match actual variable name $buffer

     * @param \Plasma\BinaryBuffer               $buffer

Superfluous parameter comment

     * @return array
     */
    protected function parseResultsetRow(\Plasma\BinaryBuffer $buffer): array {
        $row = array();
        
        /** @var \Plasma\ColumnDefinitionInterface  $column */
        foreach($this->fields as $column) {
            $rawValue = $buffer->readStringLength();
            
            try {
                $value = \Plasma\Types\TypeExtensionsManager::getManager('driver-mysql')
                    ->decodeType($column->getType(), $rawValue)
                    ->getValue();
            } catch (\Plasma\Exception $e) {
                $value = $this->stdDecodeValue($column, $rawValue);

It seems like $rawValue can also be of type null; however, parameter $param of Plasma\Drivers\MySQL\Commands\PromiseCommand::stdDecodeValue() does only seem to accept string, maybe add an additional type check?

            }
            
            $row[$column->getName()] = $value;
        }
        
        return $row;
    }
    
    /**
     * Standard decode value, if type extensions failed.
     * @param \Plasma\ColumnDefinitionInterface  $column
     * @param string                             $param
     * @return mixed
     * @throws \Plasma\Exception
     */
    protected function stdDecodeValue(\Plasma\ColumnDefinitionInterface $column, string $param) {
        $flags = $column->getFlags();
        
        if($param !== null && ($flags & \Plasma\Drivers\MySQL\FieldFlags::ZEROFILL_FLAG) === 0) {
            switch($column->getType()) {
                case \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_LONG:

Line indented incorrectly; expected 12 spaces, found 16

                    if(($flags & \Plasma\Drivers\MySQL\FieldFlags::UNSIGNED_FLAG) === 0 || \PHP_INT_SIZE > 4) {

Line indented incorrectly; expected 16 spaces, found 20

                        $param = (int) $param;
                    }

Line indented incorrectly; expected 16 spaces, found 20

                break;

Case breaking statement indented incorrectly; expected 20 spaces, found 16

                case \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_LONGLONG:

Line indented incorrectly; expected 12 spaces, found 16

                    if(($flags & \Plasma\Drivers\MySQL\FieldFlags::UNSIGNED_FLAG) === 0 && \PHP_INT_SIZE > 4) {

Line indented incorrectly; expected 16 spaces, found 20

                        $param = (int) $param;
                    }

Line indented incorrectly; expected 16 spaces, found 20

                break;

Case breaking statement indented incorrectly; expected 20 spaces, found 16

                case \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_TINY:

Line indented incorrectly; expected 12 spaces, found 16

                case \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_SHORT:

Line indented incorrectly; expected 12 spaces, found 16

                case \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_INT24:

Line indented incorrectly; expected 12 spaces, found 16

                case \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_TIMESTAMP:

Line indented incorrectly; expected 12 spaces, found 16

                    $param = (int) $param;
                break;

Case breaking statement indented incorrectly; expected 20 spaces, found 16

                case \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_FLOAT:

Line indented incorrectly; expected 12 spaces, found 16

                case \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_DOUBLE:

Line indented incorrectly; expected 12 spaces, found 16

                    $param = (float) $param;
                break;

Case breaking statement indented incorrectly; expected 20 spaces, found 16

                // Other types are taken as string
            }
        }
        
        return $param;
    }
}