Conditions | 46 |
Paths | 64 |
Total Lines | 145 |
Code Lines | 115 |
Lines | 0 |
Ratio | 0 % |
Tests | 0 |
CRAP Score | 2162 |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
209 | protected function stdDecodeBinaryValue(\Plasma\ColumnDefinitionInterface $column, \Plasma\BinaryBuffer $buffer) { |
||
210 | $flags = $column->getFlags(); |
||
211 | |||
212 | switch(true) { |
||
213 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_STRING) !== 0): |
||
214 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_VARCHAR) !== 0): |
||
215 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_VAR_STRING) !== 0): |
||
216 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_ENUM) !== 0): |
||
217 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_SET) !== 0): |
||
218 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_LONG_BLOB) !== 0): |
||
219 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_MEDIUM_BLOB) !== 0): |
||
220 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_BLOB) !== 0): |
||
221 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_TINY_BLOB) !== 0): |
||
222 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_GEOMETRY) !== 0): |
||
223 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_BIT) !== 0): |
||
224 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_DECIMAL) !== 0): |
||
225 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_NEWDECIMAL) !== 0): |
||
226 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_JSON) !== 0): |
||
227 | case ($column->getType() === 'VARSTRING'): // WTF is going on ?! flags = 0, type = VARSTRING |
||
228 | $value = $buffer->readStringLength(); |
||
229 | break; |
||
1 ignored issue
–
show
|
|||
230 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_TINY) !== 0): |
||
231 | $value = $buffer->readInt1(); |
||
232 | $value = $this->zeroFillInts($column, $value); |
||
233 | break; |
||
234 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_SHORT) !== 0): |
||
235 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_YEAR) !== 0): |
||
236 | $value = $buffer->readInt2(); |
||
237 | $value = $this->zeroFillInts($column, $value); |
||
238 | break; |
||
239 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_INT24) !== 0): |
||
240 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_LONG) !== 0): |
||
241 | $value = $buffer->readInt4(); |
||
242 | |||
243 | if(($flags & \Plasma\Drivers\MySQL\FieldFlags::UNSIGNED_FLAG) !== 0 && \PHP_INT_SIZE <= 4) { |
||
244 | $value = \bcadd($value, '18446744073709551616'); |
||
245 | } |
||
246 | |||
247 | $value = $this->zeroFillInts($column, $value); |
||
248 | break; |
||
249 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_LONGLONG) !== 0): |
||
250 | $value = $buffer->readInt8(); |
||
251 | |||
252 | if(($flags & \Plasma\Drivers\MySQL\FieldFlags::UNSIGNED_FLAG) !== 0) { |
||
253 | $value = \bcadd($value, '18446744073709551616'); |
||
254 | } elseif(\PHP_INT_SIZE > 4) { |
||
255 | $value = (int) $value; |
||
256 | } |
||
257 | |||
258 | $value = $this->zeroFillInts($column, $value); |
||
259 | break; |
||
260 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_FLOAT) !== 0): |
||
261 | $value = $buffer->readFloat(); |
||
262 | break; |
||
263 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_DOUBLE) !== 0): |
||
264 | $value = $buffer->readDouble(); |
||
265 | break; |
||
266 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_DATE) !== 0): |
||
267 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_NEWDATE) !== 0): |
||
268 | $length = $buffer->readIntLength(); |
||
269 | if($length > 0) { |
||
270 | $year = $buffer->readInt2(); |
||
271 | $month = $buffer->readInt1(); |
||
272 | $day = $buffer->readInt1(); |
||
273 | |||
274 | $value = \sprintf('%d-%d-%d', $year, $month, $day); |
||
275 | } else { |
||
276 | $value = '0000-00-00'; |
||
277 | } |
||
278 | break; |
||
1 ignored issue
–
show
|
|||
279 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_DATETIME) !== 0): |
||
280 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_TIMESTAMP) !== 0): |
||
281 | $length = $buffer->readIntLength(); |
||
282 | if($length > 0) { |
||
283 | $year = $buffer->readInt2(); |
||
284 | $month = $buffer->readInt1(); |
||
285 | $day = $buffer->readInt1(); |
||
286 | |||
287 | if($length > 4) { |
||
288 | $hour = $buffer->readInt1(); |
||
289 | $min = $buffer->readInt1(); |
||
290 | $sec = $buffer->readInt1(); |
||
291 | } else { |
||
292 | $hour = 0; |
||
293 | $min = 0; |
||
294 | $sec = 0; |
||
295 | } |
||
296 | |||
297 | if($length > 7) { |
||
298 | $micro = $buffer->readInt4(); |
||
299 | } else { |
||
300 | $micro = 0; |
||
301 | } |
||
302 | |||
303 | $timestamp = (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_TIMESTAMP) !== 0); |
||
304 | |||
305 | $micro = \str_pad($micro, 6, '0', \STR_PAD_LEFT); |
||
306 | $micro = ($timestamp ? $micro : \number_format($micro, 0, '', ' ')); |
||
307 | |||
308 | $value = \sprintf('%d-%d-%d %d:%d:%d'.($micro > 0 ? '.%s' : ''), $year, $month, $day, $hour, $min, $sec, $micro); |
||
309 | |||
310 | if($timestamp) { |
||
311 | $value = \DateTime::createFromFormat('Y-m-d H:i:s'.($micro > 0 ? '.u' : ''), $value)->getTimestamp(); |
||
312 | } |
||
313 | } else { |
||
314 | $value = '0000-00-00 00:00:00.000 000'; |
||
315 | } |
||
316 | break; |
||
317 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_TIME) !== 0): |
||
318 | $length = $buffer->readIntLength(); |
||
319 | if($length > 0) { |
||
320 | $sign = $buffer->readInt1(); |
||
321 | $days = $buffer->readInt4(); |
||
322 | |||
323 | if($sign === 1) { |
||
324 | $days *= -1; |
||
325 | } |
||
326 | |||
327 | $hour = $buffer->readInt1(); |
||
328 | $min = $buffer->readInt1(); |
||
329 | $sec = $buffer->readInt1(); |
||
330 | |||
331 | if($length > 8) { |
||
332 | $micro = $buffer->readInt4(); |
||
333 | } else { |
||
334 | $micro = 0; |
||
335 | } |
||
336 | |||
337 | $micro = \str_pad($micro, 6, '0', \STR_PAD_LEFT); |
||
338 | $micro = \number_format($micro, 0, '', ' '); |
||
339 | |||
340 | $value = \sprintf('%dd %d:%d:%d'.($micro > 0 ? '.%s' : ''), $days, $hour, $min, $sec, $micro); |
||
341 | } else { |
||
342 | $value = '0d 00:00:00'; |
||
343 | } |
||
344 | break; |
||
345 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_NULL) !== 0): |
||
346 | $value = null; |
||
347 | break; |
||
1 ignored issue
–
show
|
|||
348 | default: |
||
349 | throw new \InvalidArgumentException('Unknown column type (flags: '.$flags.', type: '.$column->getType().')'); |
||
350 | break; |
||
351 | } |
||
352 | |||
353 | return $value; |
||
354 | } |
||
371 |