| Conditions | 46 |
| Paths | 64 |
| Total Lines | 145 |
| Code Lines | 115 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 2162 |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 208 | protected function stdDecodeBinaryValue(\Plasma\ColumnDefinitionInterface $column, \Plasma\BinaryBuffer $buffer) { |
||
| 209 | $flags = $column->getFlags(); |
||
| 210 | |||
| 211 | switch(true) { |
||
| 212 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_TINY) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 213 | $value = $buffer->readInt1(); |
||
| 214 | $value = $this->zeroFillInts($column, $value); |
||
| 215 | break; |
||
|
1 ignored issue
–
show
|
|||
| 216 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_SHORT) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 217 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_YEAR) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 218 | $value = $buffer->readInt2(); |
||
| 219 | $value = $this->zeroFillInts($column, $value); |
||
| 220 | break; |
||
|
1 ignored issue
–
show
|
|||
| 221 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_INT24) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 222 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_LONG) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 223 | $value = $buffer->readInt4(); |
||
| 224 | |||
| 225 | if(($flags & \Plasma\Drivers\MySQL\FieldFlags::UNSIGNED_FLAG) !== 0 && \PHP_INT_SIZE <= 4) { |
||
|
1 ignored issue
–
show
|
|||
| 226 | $value = \bcadd($value, '18446744073709551616'); |
||
| 227 | } |
||
|
1 ignored issue
–
show
|
|||
| 228 | |||
| 229 | $value = $this->zeroFillInts($column, $value); |
||
| 230 | break; |
||
|
1 ignored issue
–
show
|
|||
| 231 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_LONGLONG) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 232 | $value = $buffer->readInt8(); |
||
| 233 | |||
| 234 | if(($flags & \Plasma\Drivers\MySQL\FieldFlags::UNSIGNED_FLAG) !== 0) { |
||
|
1 ignored issue
–
show
|
|||
| 235 | $value = \bcadd($value, '18446744073709551616'); |
||
| 236 | } elseif(\PHP_INT_SIZE > 4) { |
||
|
1 ignored issue
–
show
|
|||
| 237 | $value = (int) $value; |
||
| 238 | } |
||
|
1 ignored issue
–
show
|
|||
| 239 | |||
| 240 | $value = $this->zeroFillInts($column, $value); |
||
| 241 | break; |
||
|
1 ignored issue
–
show
|
|||
| 242 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_FLOAT) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 243 | $value = $buffer->readFloat(); |
||
| 244 | break; |
||
|
1 ignored issue
–
show
|
|||
| 245 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_DOUBLE) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 246 | $value = $buffer->readDouble(); |
||
| 247 | break; |
||
|
1 ignored issue
–
show
|
|||
| 248 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_DATE) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 249 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_NEWDATE) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 250 | $length = $buffer->readIntLength(); |
||
| 251 | if($length > 0) { |
||
|
1 ignored issue
–
show
|
|||
| 252 | $year = $buffer->readInt2(); |
||
| 253 | $month = $buffer->readInt1(); |
||
| 254 | $day = $buffer->readInt1(); |
||
| 255 | |||
| 256 | $value = \sprintf('%d-%d-%d', $year, $month, $day); |
||
| 257 | } else { |
||
|
1 ignored issue
–
show
|
|||
| 258 | $value = '0000-00-00'; |
||
| 259 | } |
||
|
1 ignored issue
–
show
|
|||
| 260 | break; |
||
|
1 ignored issue
–
show
|
|||
| 261 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_DATETIME) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 262 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_TIMESTAMP) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 263 | $length = $buffer->readIntLength(); |
||
| 264 | if($length > 0) { |
||
|
1 ignored issue
–
show
|
|||
| 265 | $year = $buffer->readInt2(); |
||
| 266 | $month = $buffer->readInt1(); |
||
| 267 | $day = $buffer->readInt1(); |
||
| 268 | |||
| 269 | if($length > 4) { |
||
|
1 ignored issue
–
show
|
|||
| 270 | $hour = $buffer->readInt1(); |
||
| 271 | $min = $buffer->readInt1(); |
||
| 272 | $sec = $buffer->readInt1(); |
||
| 273 | } else { |
||
|
1 ignored issue
–
show
|
|||
| 274 | $hour = 0; |
||
| 275 | $min = 0; |
||
| 276 | $sec = 0; |
||
| 277 | } |
||
|
1 ignored issue
–
show
|
|||
| 278 | |||
| 279 | if($length > 7) { |
||
|
1 ignored issue
–
show
|
|||
| 280 | $micro = $buffer->readInt4(); |
||
| 281 | } else { |
||
|
1 ignored issue
–
show
|
|||
| 282 | $micro = 0; |
||
| 283 | } |
||
|
1 ignored issue
–
show
|
|||
| 284 | |||
| 285 | $timestamp = (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_TIMESTAMP) !== 0); |
||
| 286 | |||
| 287 | $micro = \str_pad($micro, 6, '0', \STR_PAD_LEFT); |
||
| 288 | $micro = ($timestamp ? $micro : \number_format($micro, 0, '', ' ')); |
||
| 289 | |||
| 290 | $value = \sprintf('%d-%d-%d %d:%d:%d'.($micro > 0 ? '.%s' : ''), $year, $month, $day, $hour, $min, $sec, $micro); |
||
| 291 | |||
| 292 | if($timestamp) { |
||
|
1 ignored issue
–
show
|
|||
| 293 | $value = \DateTime::createFromFormat('Y-m-d H:i:s'.($micro > 0 ? '.u' : ''), $value)->getTimestamp(); |
||
| 294 | } |
||
|
1 ignored issue
–
show
|
|||
| 295 | } else { |
||
|
1 ignored issue
–
show
|
|||
| 296 | $value = '0000-00-00 00:00:00.000 000'; |
||
| 297 | } |
||
|
1 ignored issue
–
show
|
|||
| 298 | break; |
||
|
1 ignored issue
–
show
|
|||
| 299 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_TIME) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 300 | $length = $buffer->readIntLength(); |
||
| 301 | if($length > 0) { |
||
|
1 ignored issue
–
show
|
|||
| 302 | $sign = $buffer->readInt1(); |
||
| 303 | $days = $buffer->readInt4(); |
||
| 304 | |||
| 305 | if($sign === 1) { |
||
|
1 ignored issue
–
show
|
|||
| 306 | $days *= -1; |
||
| 307 | } |
||
|
1 ignored issue
–
show
|
|||
| 308 | |||
| 309 | $hour = $buffer->readInt1(); |
||
| 310 | $min = $buffer->readInt1(); |
||
| 311 | $sec = $buffer->readInt1(); |
||
| 312 | |||
| 313 | if($length > 8) { |
||
|
1 ignored issue
–
show
|
|||
| 314 | $micro = $buffer->readInt4(); |
||
| 315 | } else { |
||
|
1 ignored issue
–
show
|
|||
| 316 | $micro = 0; |
||
| 317 | } |
||
|
1 ignored issue
–
show
|
|||
| 318 | |||
| 319 | $micro = \str_pad($micro, 6, '0', \STR_PAD_LEFT); |
||
| 320 | $micro = \number_format($micro, 0, '', ' '); |
||
| 321 | |||
| 322 | $value = \sprintf('%dd %d:%d:%d'.($micro > 0 ? '.%s' : ''), $days, $hour, $min, $sec, $micro); |
||
| 323 | } else { |
||
|
1 ignored issue
–
show
|
|||
| 324 | $value = '0d 00:00:00'; |
||
| 325 | } |
||
|
1 ignored issue
–
show
|
|||
| 326 | break; |
||
|
1 ignored issue
–
show
|
|||
| 327 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_NULL) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 328 | $value = null; |
||
| 329 | break; |
||
|
1 ignored issue
–
show
|
|||
| 330 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_STRING) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 331 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_VARCHAR) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 332 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_VAR_STRING) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 333 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_ENUM) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 334 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_SET) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 335 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_LONG_BLOB) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 336 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_MEDIUM_BLOB) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 337 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_BLOB) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 338 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_TINY_BLOB) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 339 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_GEOMETRY) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 340 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_BIT) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 341 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_DECIMAL) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 342 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_NEWDECIMAL) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 343 | case (($flags & \Plasma\Drivers\MySQL\FieldFlags::FIELD_TYPE_JSON) !== 0): |
||
|
1 ignored issue
–
show
|
|||
| 344 | case ($column->getType() === 'VARSTRING'): // WTF is going on ?! flags = 0, type = VARSTRING |
||
|
1 ignored issue
–
show
|
|||
| 345 | $value = $buffer->readStringLength(); |
||
| 346 | break; |
||
|
1 ignored issue
–
show
|
|||
| 347 | default: |
||
|
1 ignored issue
–
show
|
|||
| 348 | throw new \InvalidArgumentException('Unknown column type (flags: '.$flags.', type: '.$column->getType().')'); |
||
| 349 | break; |
||
| 350 | } |
||
| 351 | |||
| 352 | return $value; |
||
| 353 | } |
||
| 370 |