Issues in BlocksUtility.php (master) - Issues in master - Pixelneat/silverstripe-content-blocks - Measure and Improve Code Quality continuously with Scrutinizer

Issues (159)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/utilities/BlocksUtility.php (5 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * @author      Donatas Navidonskis <[email protected]>
 * @since       2017
 * @class       BlocksUtility
 * @description Utilities for module of Content Blocks.
 */
class BlocksUtility extends Object {
namespace YourVendor;

class YourClass { }

    /**
     * Patterns to parse video's id on different providers.
     *
     * @var array
     * @config
     */
    private static $patterns = [
        'youtube' => '/^(?:http(?:s)?:\/\/)?(?:www\.)?(?:m\.)?(?:youtu\.be\/|youtube\.com\/(?:(?:watch)?\?(?:.*&)?v(?:i)?=|(?:embed|v|vi|user)\/))([^\?&\"\'>]+)/',
        'vimeo'   => '/https?:\/\/(?:www\.|player\.)?vimeo.com\/(?:channels\/(?:\w+\/)?|groups\/([^\/]*)\/videos\/|album\/(\d+)\/video\/|video\/|)(\d+)(?:$|\/|\?)/',
    ];

    /**
     * Parse video's id of the given URL address.
     *
     * @param string $url      | url address to the video
     * @param string $provider | default: youtube (supports - youtube, vimeo)
     *
     * @return string
     * @throws ProviderNotFound
     */
    public static function parse_video_id($url, $provider = 'youtube') {
        switch (strtolower($provider)) {
            case 'youtube':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

                if (preg_match(static::config()->patterns['youtube'], $url, $matches)) {
                    return $matches[1];
                }

                break;

            case 'vimeo':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

                if (preg_match(static::config()->patterns['vimeo'], $url, $matches)) {
                    return $matches[3];
                }

                break;
        }

        throw new ProviderNotFound('Provider not found when parsing video id by given url');
    }

    /**
     * Get localized answers example 0 - No, 1 - Yes. This mostly using
     * for drop down fields.
     *
     * @return array
     */
    public static function localized_answers() {
        return [
            0 => _t('BlocksUtility.NO', 'No'),
            1 => _t('BlocksUtility.YES', 'Yes'),
        ];
    }
}

1		<?php
2
3		/**
4		* @author Donatas Navidonskis <[email protected]>
5		* @since 2017
6		* @class BlocksUtility
7		* @description Utilities for module of Content Blocks.
8		*/
9		class BlocksUtility extends Object {
		0 ignored issues – show Coding Style Compatibility introduced 2017-05-04 14:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
10
11		/**
12		* Patterns to parse video's id on different providers.
13		*
14		* @var array
15		* @config
16		*/
17		private static $patterns = [
18		'youtube' => '/^(?:http(?:s)?:\/\/)?(?:www\.)?(?:m\.)?(?:youtu\.be\/\|youtube\.com\/(?:(?:watch)?\?(?:.*&)?v(?:i)?=\|(?:embed\|v\|vi\|user)\/))([^\?&\"\'>]+)/',
19		'vimeo' => '/https?:\/\/(?:www\.\|player\.)?vimeo.com\/(?:channels\/(?:\w+\/)?\|groups\/([^\/]*)\/videos\/\|album\/(\d+)\/video\/\|video\/\|)(\d+)(?:$\|\/\|\?)/',
20		];
21
22		/**
23		* Parse video's id of the given URL address.
24		*
25		* @param string $url \| url address to the video
26		* @param string $provider \| default: youtube (supports - youtube, vimeo)
27		*
28		* @return string
29		* @throws ProviderNotFound
30		*/
31		public static function parse_video_id($url, $provider = 'youtube') {
32		switch (strtolower($provider)) {
33	View Code Duplication	case 'youtube':
		0 ignored issues – show Duplication introduced 2017-05-04 14:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style introduced 2017-05-04 14:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
34
35		if (preg_match(static::config()->patterns['youtube'], $url, $matches)) {
36		return $matches[1];
37		}
38
39		break;
40
41	View Code Duplication	case 'vimeo':
		0 ignored issues – show Duplication introduced 2017-05-04 14:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style introduced 2017-05-04 14:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
42
43		if (preg_match(static::config()->patterns['vimeo'], $url, $matches)) {
44		return $matches[3];
45		}
46
47		break;
48		}
49
50		throw new ProviderNotFound('Provider not found when parsing video id by given url');
51		}
52
53		/**
54		* Get localized answers example 0 - No, 1 - Yes. This mostly using
55		* for drop down fields.
56		*
57		* @return array
58		*/
59		public static function localized_answers() {
60		return [
61		0 => _t('BlocksUtility.NO', 'No'),
62		1 => _t('BlocksUtility.YES', 'Yes'),
63		];
64		}
65		}

Pixelneat / silverstripe-content-blocks

Issues (159)

Security Analysis not enabled

code/utilities/BlocksUtility.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like