BaseSliderItem

Complexity

Total Complexity

7

Size/Duplication

Total Lines	108
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	4

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	singular_name()	0	3	1
A	plural_name()	0	3	1
A	summaryFields()	0	6	1
A	getSliderType()	0	3	1
A	getCMSFields()	0	17	1
A	fieldLabels()	0	10	1
A	forTemplate()	0	5	1

<?php

/**
 * @author    Donatas Navidonskis <donatas@navidonskis.com>
 * @since     2017
 * @class     BaseSliderItem
 *
 * @property int    BlockID
 * @property int    SortOrder
 * @property string Title
 * @property string Content
 *
 * @method SliderBlock Block
 */
class BaseSliderItem extends \DataObject {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

    /**
     * @var array
     * @config
     */
    private static $db = [

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        'Title'     => 'Varchar',
        'Content'   => 'HTMLText',
        'SortOrder' => 'Int',
    ];

    /**
     * @var array
     * @config
     */
    private static $has_one = [

Consider using a different property name as you override a private property of the parent class.

The property $has_one is not used and could be removed.

        'Block' => 'SliderBlock',
    ];

    /**
     * The default sort expression. This will be inserted in the ORDER BY
     * clause of a SQL query if no other sort expression is provided.
     *
     * @var string
     * @config
     */
    private static $default_sort = 'SortOrder ASC';

Consider using a different property name as you override a private property of the parent class.

The property $default_sort is not used and could be removed.

    /**
     * @return string
     */
    public function singular_name() {
        return _t('SliderItem.SINGULARNAME', 'Slider');
    }

    /**
     * @return string
     */
    public function plural_name() {
        return _t('SliderItem.PLURALNAME', 'Sliders');
    }

    /**
     * Default summary fields within localized label title's.
     *
     * @return array
     */
    public function summaryFields() {
        return [
            'Title'      => $this->fieldLabel('Title'),
            'SliderType' => $this->fieldLabel('SliderType'),
        ];
    }

    /**
     * @return string
     */
    public function getSliderType() {
        return $this->singular_name();
    }

    /**
     * @return \FieldList
     */
    public function getCMSFields() {
        $fields = parent::getCMSFields();
        $fields->removeByName(['SortOrder', 'Title', 'Content']);
        $fields->findOrMakeTab('Root.Media', $this->fieldLabel('Media'));

        $fields->addFieldsToTab('Root.Main', [
            \TextField::create('Title', $this->fieldLabel('Title')),
            $contentField = \HtmlEditorField::create('Content', $this->fieldLabel('Content')),
        ]);

        $contentField
            ->setRows(15);

        $this->extend('updateCMSFields', $fields);

        return $fields;
    }

    /**
     * @param bool $includeRelations
     *
     * @return array
     */
    public function fieldLabels($includeRelations = true) {
        return array_merge(parent::fieldLabels($includeRelations), [
            'Title'      => _t('SliderItem.TITLE', 'Title'),
            'Content'    => _t('SliderItem.CONTENT', 'Content'),
            'Picture'    => _t('SliderItem.PICTURE', 'Picture'),
            'Media'      => _t('SliderItem.MEDIA', 'Media'),
            'Video'      => _t('SliderItem.VIDEO', 'Video'),
            'SliderType' => _t('SliderItem.SLIDER_TYPE', 'Slider type'),
        ]);
    }

    /**
     * @return \HTMLText
     */
    public function forTemplate() {
        return $this->renderWith(
            sprintf("%s_%s", $this->Block()->ClassName, $this->ClassName)

The method Block does not exist on object<BaseSliderItem>? Since you implemented __call, maybe consider adding a @method annotation.

        );
    }
}