modules\blog\admin\controller\AdminCategory

Complexity

Total Complexity

10

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	1
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	getTestCategoryExist()	0	14	3
B	setCategoriesArticle()	0	12	5
A	setUpdateCategoriesArticle()	0	7	1

<?php
	namespace modules\blog\admin\controller;
	
	
	use core\App;
	
	class AdminCategory {
		
		
		//-------------------------- BUILDER ----------------------------------------------------------------------------//
		public function __construct() {
			
		}
		//-------------------------- END BUILDER ----------------------------------------------------------------------------//
		
		
		//-------------------------- GETTER ----------------------------------------------------------------------------//
		/**
		 * @param $name
		 * @return bool
		 * test if a category exist
		 */
		private function getTestCategoryExist($name) {
			$dbc = App::getDb();
			
			$query = $dbc->select()->from("_blog_category")->where("category", "=", $name)->get();
			
			if (count($query) > 0) {
				foreach ($query as $obj) {
					
					return $obj->ID_category;
				}
			}
			
			return false;
		}
		//-------------------------- END GETTER ----------------------------------------------------------------------------//
		
		
		//-------------------------- SETTER ----------------------------------------------------------------------------//
		/**
		 * @param $categories
		 * @param $id_article
		 * add list of categories to an article
		 */
		public function setCategoriesArticle($categories, $id_article) {
			$dbc = App::getDb();
			
			$count = count($categories);
			if ((is_array($categories)) && ($count > 0)) {
				for ($i=0 ; $i<$count ; $i++) {
					if ($this->getTestCategoryExist($categories[$i]) != false) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison !== instead.

						$dbc->insert("ID_category", $this->getTestCategoryExist($categories[$i]))->insert("ID_article", $id_article)->into("_blog_article_category")->set();
					}
				}
			}
		}
		
		/**
		 * @param $categories
		 * @param $id_article
		 * function to update catgories, in first step delete all categories and reinsert it after
		 */
		public function setUpdateCategoriesArticle($categories, $id_article) {
			$dbc = App::getDb();
			
			$dbc->delete()->from("_blog_article_category")->where("ID_article", "=", $id_article)->del();
			
			$this->setCategoriesArticle($categories, $id_article);
		}
		//-------------------------- END SETTER ----------------------------------------------------------------------------//
	}