View GitHub Repository ribs-module-blog

Schedule Inspection
Subscribe
Completed
Push — master ( bb4209...07fbdf )
by Anthony
02:31
created

Article::getLastArticle()   A

↳ Parent: Article

Complexity

Conditions 4
Paths 3

Size

Total Lines 18
Code Lines 11

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
c 0
b 0
f 0
dl 0
loc 18
rs 9.2
cc 4
eloc 11
nc 3
nop 0
1 
<?php
2 
	namespace modules\blog\app\controller;
3
4
5 
	use core\App;
6
7 
	class Article {
8
9
10 
		//-------------------------- BUILDER ----------------------------------------------------------------------------//
11 
		public function __construct() {
12
13 
		}
14 
		//-------------------------- END BUILDER ----------------------------------------------------------------------------//
15
16
17 
		//-------------------------- GETTER ----------------------------------------------------------------------------//
18 
		public function getLastArticle() {
19 
			$dbc = App::getDb();
20
21 
			$query = $dbc->select()->from("_blog_article")->limit(0, 5)->get();
22
23 
			if ((is_array($query)) && (count($query) > 0)) {
24 
				foreach ($query as $obj) {
25 
					$articles[] = [
0 ignored issues
– show
Coding Style Comprehensibility introduced by
$articles was never initialized. Although not strictly required by PHP, it is generally a good practice to add $articles = array(); before regardless.

Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.

Let’s take a look at an example:

foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

As you can see in this example, the array $myArray is initialized the first time when the foreach loop is entered. You can also see that the value of the bar key is only written conditionally; thus, its value might result from a previous iteration.

This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.

Loading history...
26 
						"id_article" => $obj->ID_article,
27 
						"title" => $obj->title,
28 
						"article" => $obj->article,
29 
						"publication_date" => $obj->publication_date
30 
					];
31 
				}
32
33 
				App::setValues(["blog" => $articles]);
0 ignored issues
– show
Bug introduced by
The variable $articles does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    if (isset($x)) { // Make sure it's always set.
        echo $x;
    }
}

  2. Define a default value for the variable:

    function myFunction($a) {
    $x = ''; // Set a default which gets overridden for certain paths.
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    echo $x;
}

  3. Add a value for the missing path:

    function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;

        // We add support for the missing case.
        default:
            $x = '';
            break;
    }

    echo $x;
}
Loading history...
34 
			}
35 
		}
36 
		//-------------------------- END GETTER ----------------------------------------------------------------------------//
37
38
39 
		//-------------------------- SETTER ----------------------------------------------------------------------------//
40 
		//-------------------------- END SETTER ----------------------------------------------------------------------------//
41 
	}