AdminInscription - Code Metrics - Inspection of "update RedirectError to simplify it" - Piou-piou/ribs-framework - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 200816...5d47f4 )

by Anthony

created 2016-03-21 10:50 UTC

AdminInscription A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	92
Duplicated Lines	34.78 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	4
Bugs	1	Features	0

Metric	Value
wmc	9
c	4
b	1
f	0
lcom	1
cbo	4
dl	32
loc	92
rs	10

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getAccesAdministration()	0	3	1
A	getidListeDroitAcces()	0	3	1
A	setVerifAccesAdministration()	16	16	3
A	setVerifListeDroitAcces()	16	16	3
A	setInscrireUtilisateur()	0	21	1

How to fix Duplicated Code

<?php
	namespace core\admin\inscription;
	use core\App;
	use core\auth\Encrypt;
	use core\auth\Inscription;

	class AdminInscription extends Inscription {
		protected $acces_administration;
		protected $id_liste_droit_acces;
		
		
		//-------------------------- CONSTRUCTEUR ----------------------------------------------------------------------------//
		//-------------------------- FIN CONSTRUCTEUR ----------------------------------------------------------------------------//
		
		
		//-------------------------- GETTER ----------------------------------------------------------------------------//
		public function getAccesAdministration() {
			return $this->acces_administration;
		}
		public function getidListeDroitAcces() {
			return $this->id_liste_droit_acces;
		}
		//-------------------------- FIN GETTER ----------------------------------------------------------------------------//
		

		//-------------------------- SETTER ----------------------------------------------------------------------------//
		/**
		 * vient de la partie admin n du site pages gestion-comptes/creer-utilisateur
		 * @param $value
		 * @param null $required
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
		 * @return bool
		 */
		protected function setVerifAccesAdministration($value) {

			//on verifie que la valeur est bien un int
			//test avec le required, si le champe est vide et que le required est != null on return fa	lse sinon on va tester
			if ($this->getTestInt($value) === true) {
				$this->acces_administration = $value;
				return true;
			}
			else if ($this->getTestInt($value) === false) {
				$this->erreur .= "<li>Le champs accès administration n'est pas au bon format</li>";
				return false;
			}
			else {
				return true;
			}

		}

		/**
		 * vient de la partie admin du site pages gestion-comptes/creer-utilisateur
		 * @param $value
		 * @param null $required
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
		 * @return bool
		 */
		protected function setVerifListeDroitAcces($value) {

			//on verifie que la valeur est bien un int
			//test avec le required, si le champe est vide et que le required est != null on return fa	lse sinon on va tester
			if ($this->getTestInt($value) === true) {
				$this->id_liste_droit_acces = $value;
				return true;
			}
			else if ($this->getTestInt($value) === false) {
				$this->erreur .= "<li>Le champs accès administration n'est pas au bon format</li>";
				return false;
			}
			else {
				return true;
			}

		}

		/**
		 * si tous les test concernant le formulaire sont passés on inscrit le user
		 */
		public function setInscrireUtilisateur() {
			$dbc = App::getDb();

			$value = array(
				"pseudo" => $this->pseudo,
				"nom" => $this->nom,
				"prenom" => $this->prenom,
				"mail" => $this->mail,
				"mdp" => Encrypt::setEncryptMdp($this->mdp),
				"mdp_params" => Encrypt::getParams(),
				"last_change_mdp" => date("Y-m-d"),
				"img_profil" => "profil/defaut.png",
				"img_profil_blog" => "profil/defaut_blog.png",
				"valide" => 1,
				"acces_admin" => $this->acces_administration,
				"liste_droit" => $this->id_liste_droit_acces
			);


			$dbc->prepare("INSERT INTO identite (pseudo, nom, prenom, mail, mdp, mdp_params, last_change_mdp, img_profil, img_profil_blog, valide, acces_admin, liste_droit) VALUES (:pseudo, :nom, :prenom, :mail, :mdp, :mdp_params, :last_change_mdp, :img_profil, :img_profil_blog, :valide, :acces_admin, :liste_droit)", $value);
		}
		//-------------------------- FIN SETTER ----------------------------------------------------------------------------//
	}

1		<?php
2		namespace core\admin\inscription;
3		use core\App;
4		use core\auth\Encrypt;
5		use core\auth\Inscription;
6
7		class AdminInscription extends Inscription {
8		protected $acces_administration;
9		protected $id_liste_droit_acces;
10
11
12		//-------------------------- CONSTRUCTEUR ----------------------------------------------------------------------------//
13		//-------------------------- FIN CONSTRUCTEUR ----------------------------------------------------------------------------//
14
15
16		//-------------------------- GETTER ----------------------------------------------------------------------------//
17		public function getAccesAdministration() {
18		return $this->acces_administration;
19		}
20		public function getidListeDroitAcces() {
21		return $this->id_liste_droit_acces;
22		}
23		//-------------------------- FIN GETTER ----------------------------------------------------------------------------//
24
25
26		//-------------------------- SETTER ----------------------------------------------------------------------------//
27		/**
28		* vient de la partie admin n du site pages gestion-comptes/creer-utilisateur
29		* @param $value
30		* @param null $required
		0 ignored issues – show Bug introduced 2016-03-21 10:52 UTC by Report Bug Copy Issue Report There is no parameter named `$required`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
31		* @return bool
32		*/
33	View Code Duplication	protected function setVerifAccesAdministration($value) {
		0 ignored issues – show Duplication introduced 2016-03-16 10:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
34		//on verifie que la valeur est bien un int
35		//test avec le required, si le champe est vide et que le required est != null on return fa lse sinon on va tester
36		if ($this->getTestInt($value) === true) {
37		$this->acces_administration = $value;
38		return true;
39		}
40		else if ($this->getTestInt($value) === false) {
41		$this->erreur .= "<li>Le champs accès administration n'est pas au bon format</li>";
42		return false;
43		}
44		else {
45		return true;
46		}
47
48		}
49
50		/**
51		* vient de la partie admin du site pages gestion-comptes/creer-utilisateur
52		* @param $value
53		* @param null $required
		0 ignored issues – show Bug introduced 2016-03-21 10:52 UTC by Report Bug Copy Issue Report There is no parameter named `$required`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
54		* @return bool
55		*/
56	View Code Duplication	protected function setVerifListeDroitAcces($value) {
		0 ignored issues – show Duplication introduced 2016-03-21 10:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
57		//on verifie que la valeur est bien un int
58		//test avec le required, si le champe est vide et que le required est != null on return fa lse sinon on va tester
59		if ($this->getTestInt($value) === true) {
60		$this->id_liste_droit_acces = $value;
61		return true;
62		}
63		else if ($this->getTestInt($value) === false) {
64		$this->erreur .= "<li>Le champs accès administration n'est pas au bon format</li>";
65		return false;
66		}
67		else {
68		return true;
69		}
70
71		}
72
73		/**
74		* si tous les test concernant le formulaire sont passés on inscrit le user
75		*/
76		public function setInscrireUtilisateur() {
77		$dbc = App::getDb();
78
79		$value = array(
80		"pseudo" => $this->pseudo,
81		"nom" => $this->nom,
82		"prenom" => $this->prenom,
83		"mail" => $this->mail,
84		"mdp" => Encrypt::setEncryptMdp($this->mdp),
85		"mdp_params" => Encrypt::getParams(),
86		"last_change_mdp" => date("Y-m-d"),
87		"img_profil" => "profil/defaut.png",
88		"img_profil_blog" => "profil/defaut_blog.png",
89		"valide" => 1,
90		"acces_admin" => $this->acces_administration,
91		"liste_droit" => $this->id_liste_droit_acces
92		);
93
94
95		$dbc->prepare("INSERT INTO identite (pseudo, nom, prenom, mail, mdp, mdp_params, last_change_mdp, img_profil, img_profil_blog, valide, acces_admin, liste_droit) VALUES (:pseudo, :nom, :prenom, :mail, :mdp, :mdp_params, :last_change_mdp, :img_profil, :img_profil_blog, :valide, :acces_admin, :liste_droit)", $value);
96		}
97		//-------------------------- FIN SETTER ----------------------------------------------------------------------------//
98		}

Piou-piou / ribs-framework

Push — master ( 200816...5d47f4 )

AdminInscription A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like