Piou-piou /
ribs-framework
Complex classes like Database often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Database, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 7 | class Database {
|
||
| 8 | private $db_type; |
||
| 9 | private $db_name; |
||
| 10 | private $db_user; |
||
| 11 | private $db_pass; |
||
| 12 | private $db_host; |
||
| 13 | private $dbc; |
||
| 14 | |||
| 15 | //pour le query builder |
||
| 16 | private $req_beginning; |
||
| 17 | private $champs = []; |
||
| 18 | private $value = []; |
||
| 19 | private $conditions = []; |
||
| 20 | private $table = []; |
||
| 21 | |||
| 22 | |||
| 23 | |||
| 24 | //-------------------------- CONSTRUCTEUR ----------------------------------------------------------------------------// |
||
| 25 | public function __construct($db_type, $db_name, $db_user, $db_pass, $db_host) {
|
||
| 32 | //-------------------------- FIN CONSTRUCTEUR ----------------------------------------------------------------------------// |
||
| 33 | |||
| 34 | |||
| 35 | |||
| 36 | //-------------------------- GETTER ----------------------------------------------------------------------------// |
||
| 37 | /** |
||
| 38 | * function qui fait la connexion a la bdd ne peu etre appelee que dans la classe |
||
| 39 | * @return PDO |
||
| 40 | */ |
||
| 41 | private function getPdo() {
|
||
| 49 | //-------------------------- FIN GETTER ----------------------------------------------------------------------------// |
||
| 50 | |||
| 51 | //-------------------------- FUNCTION QUI FONT DES REQUETES SUR LA BDD --------------------------------------------// |
||
| 52 | /** |
||
| 53 | * effectue une requete en selectr dans la BDD, si ok on renvoit les donnees sinon on renvoi une erreur |
||
| 54 | * @param $req |
||
| 55 | * @return array |
||
| 56 | */ |
||
| 57 | public function query($req) {
|
||
| 68 | |||
| 69 | /** |
||
| 70 | * fonction qui prepare une requete et qui l'envoi, marche pour insert et update et delete |
||
| 71 | * @param $req -> la req a executer |
||
| 72 | * @param $value -> le ou les tableaux de valeurs |
||
| 73 | */ |
||
| 74 | public function prepare($req, $value) {
|
||
| 95 | |||
| 96 | /** |
||
| 97 | * pour savoir si une valeur sur un champ précis existe deja en bdd, renvoi true si vrai |
||
| 98 | * @param $table |
||
| 99 | * @param $champ |
||
| 100 | * @param $value |
||
| 101 | * @return boolean|null |
||
| 102 | */ |
||
| 103 | public function rechercherEgalite($table, $champ, $value, $id_table = null, $id = null) {
|
||
| 122 | //-------------------------- FIN FUNCTION QUI FONT DES REQUETES SUR LA BDD --------------------------------------------// |
||
| 123 | |||
| 124 | |||
| 125 | /** |
||
| 126 | * tester si une table dans la base donnee existe |
||
| 127 | * @param string $table definit la table pour laquelle on doit tester l'existance |
||
| 128 | * @return boolean |
||
| 129 | */ |
||
| 130 | public function TestTableExist($table) {
|
||
| 140 | |||
| 141 | public function quote($quote) {
|
||
| 144 | |||
| 145 | public function lastInsertId() {
|
||
| 148 | |||
| 149 | |||
| 150 | |||
| 151 | //-------------------------- QUERY BUILDER in construction no test have been done --------------------------------------------// |
||
| 152 | /** |
||
| 153 | * @param string $champs |
||
| 154 | * @return $this |
||
| 155 | * |
||
| 156 | * pour initialisé une requete avec un select |
||
| 157 | */ |
||
| 158 | public function select($champs = "*") {
|
||
| 164 | |||
| 165 | /** |
||
| 166 | * @param $champ |
||
| 167 | * @param $value |
||
| 168 | * @return $this |
||
| 169 | * |
||
| 170 | * fonction qui permet de préparer les champs et la valeur qui y sera associée |
||
| 171 | */ |
||
| 172 | public function insert($champ, $value) {
|
||
| 179 | |||
| 180 | /** |
||
| 181 | * @param $champ |
||
| 182 | * @param $value |
||
| 183 | * @return $this |
||
| 184 | */ |
||
| 185 | public function update($champ, $value) {
|
||
| 192 | |||
| 193 | /** |
||
| 194 | * @return $this |
||
| 195 | * |
||
| 196 | * fonction qui initialise un delete en base de donnée |
||
| 197 | */ |
||
| 198 | public function delete() {
|
||
| 203 | |||
| 204 | /** |
||
| 205 | * @param $champ |
||
| 206 | * @param $value |
||
| 207 | * |
||
| 208 | * fonction qui se cahrge d'ajouter les valeurs et les champs si non null dans leurs |
||
| 209 | * tableaux respectifs (appellée dans this->insert et this->update |
||
| 210 | */ |
||
| 211 | private function add($champ, $value) {
|
||
| 217 | |||
| 218 | /** |
||
| 219 | * @param $table |
||
| 220 | * @return $this |
||
| 221 | * |
||
| 222 | * pour initialiser la les listes des tables ou il faudra aler chercher les données |
||
| 223 | */ |
||
| 224 | public function from($table) {
|
||
| 229 | |||
| 230 | /** |
||
| 231 | * @param $table |
||
| 232 | * |
||
| 233 | * pour initialiser la table dans laquelle on va insérer les données |
||
| 234 | */ |
||
| 235 | public function into($table) {
|
||
| 240 | |||
| 241 | /** |
||
| 242 | * @param $champ |
||
| 243 | * @param $cond |
||
| 244 | * @param $champ_test |
||
| 245 | * @param null $closure |
||
| 246 | * @return $this |
||
| 247 | * |
||
| 248 | * pour intialiser la ou les clauses where d'une requete |
||
| 249 | */ |
||
| 250 | public function where($champ, $cond, $champ_test, $closure = null) {
|
||
| 260 | |||
| 261 | /** |
||
| 262 | * @return array |
||
| 263 | * |
||
| 264 | * fonction qui permet de récupérer un select fait sur une table |
||
| 265 | */ |
||
| 266 | public function get() {
|
||
| 276 | |||
| 277 | /** |
||
| 278 | * fonction utlisée pour terminer un insert ou un update dans la base de données |
||
| 279 | */ |
||
| 280 | public function set() {
|
||
| 298 | |||
| 299 | /** |
||
| 300 | * fonction utilisée pour finir un delete |
||
| 301 | */ |
||
| 302 | public function del() {
|
||
| 312 | |||
| 313 | /** |
||
| 314 | * fonction qui détruit toutes les variables utilisées. |
||
| 315 | */ |
||
| 316 | private function unsetQueryBuilder() {
|
||
| 323 | } |
Loading history...
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using
empty(..)or! empty(...)instead.