Piou-piou /
ribs-framework
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 3 | class Querybuilder {
|
||
| 4 | protected $req_beginning; |
||
| 5 | protected $champs = []; |
||
| 6 | protected $value = []; |
||
| 7 | protected $conditions = []; |
||
| 8 | protected $table = []; |
||
| 9 | |||
| 10 | |||
| 11 | //-------------------------- QUERY BUILDER in construction no test have been done --------------------------------------------// |
||
| 12 | /** |
||
| 13 | * @param string $champs |
||
| 14 | * @return $this |
||
| 15 | * |
||
| 16 | * pour initialisé une requete avec un select |
||
| 17 | */ |
||
| 18 | public function select($champs = "*") {
|
||
| 24 | |||
| 25 | /** |
||
| 26 | * @param $champ |
||
| 27 | * @param $value |
||
| 28 | * @return $this |
||
| 29 | * |
||
| 30 | * fonction qui permet de préparer les champs et la valeur qui y sera associée |
||
| 31 | */ |
||
| 32 | public function insert($champ, $value) {
|
||
| 39 | |||
| 40 | /** |
||
| 41 | * @param $champ |
||
| 42 | * @param $value |
||
| 43 | * @return $this |
||
| 44 | */ |
||
| 45 | public function update($champ, $value) {
|
||
| 52 | |||
| 53 | /** |
||
| 54 | * @return $this |
||
| 55 | * |
||
| 56 | * fonction qui initialise un delete en base de donnée |
||
| 57 | */ |
||
| 58 | public function delete() {
|
||
| 63 | |||
| 64 | /** |
||
| 65 | * @param $champ |
||
| 66 | * @param $value |
||
| 67 | * |
||
| 68 | * fonction qui se cahrge d'ajouter les valeurs et les champs si non null dans leurs |
||
| 69 | * tableaux respectifs (appellée dans this->insert et this->update |
||
| 70 | */ |
||
| 71 | private function add($champ, $value) {
|
||
| 77 | |||
| 78 | /** |
||
| 79 | * @param $table |
||
| 80 | * @return $this |
||
| 81 | * |
||
| 82 | * pour initialiser la les listes des tables ou il faudra aler chercher les données |
||
| 83 | */ |
||
| 84 | public function from($table) {
|
||
| 89 | |||
| 90 | /** |
||
| 91 | * @param $table |
||
| 92 | * |
||
| 93 | * pour initialiser la table dans laquelle on va insérer les données |
||
| 94 | */ |
||
| 95 | public function into($table) {
|
||
| 100 | |||
| 101 | /** |
||
| 102 | * @param $champ |
||
| 103 | * @param $cond |
||
| 104 | * @param $champ_test |
||
| 105 | * @param null $closure |
||
| 106 | * @return $this |
||
| 107 | * |
||
| 108 | * pour intialiser la ou les clauses where d'une requete |
||
| 109 | */ |
||
| 110 | View Code Duplication | public function where($champ, $cond, $champ_test, $closure = null) {
|
|
| 120 | |||
| 121 | /** |
||
| 122 | * @return array |
||
| 123 | * |
||
| 124 | * fonction qui permet de récupérer un select fait sur une table |
||
| 125 | */ |
||
| 126 | View Code Duplication | public function get() {
|
|
| 136 | |||
| 137 | /** |
||
| 138 | * fonction utlisée pour terminer un insert ou un update dans la base de données |
||
| 139 | */ |
||
| 140 | View Code Duplication | public function set() {
|
|
| 159 | |||
| 160 | /** |
||
| 161 | * fonction utilisée pour finir un delete |
||
| 162 | */ |
||
| 163 | View Code Duplication | public function del() {
|
|
| 173 | |||
| 174 | /** |
||
| 175 | * fonction qui détruit toutes les variables utilisées. |
||
| 176 | */ |
||
| 177 | View Code Duplication | private function unsetQueryBuilder() {
|
|
| 184 | } |
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.