Piou-piou / ribs-framework

libs/ckfinder/core/connector/php/php4/Core/Registry.php

Doc Comments +2 added lines, -2 removed lines

@@ -51,7 +51,7 @@ 
      * Set value
      *
      * @param string $key
-     * @param mixed $obj
+     * @param string $obj
      * @access public
      */
     function set($key, $obj)
@@ -63,7 +63,7 @@ 
      * Get value
      *
      * @param string $key
-     * @return mixed
+     * @return string
      * @access public
      */
     function get($key)

Indentation +42 added lines, -42 removed lines

@@ -27,49 +27,49 @@
  */
 class CKFinder_Connector_Core_Registry
 {
-    /**
-     * Arrat that stores all values
-     *
-     * @var array
-     * @access private
-     */
-    var $_store = array();
+	/**
+	 * Arrat that stores all values
+	 *
+	 * @var array
+	 * @access private
+	 */
+	var $_store = array();
 
-    /**
-     * Chacke if value has been set
-     *
-     * @param string $key
-     * @return boolean
-     * @access private
-     */
-    function isValid($key)
-    {
-        return array_key_exists($key, $this->_store);
-    }
+	/**
+	 * Chacke if value has been set
+	 *
+	 * @param string $key
+	 * @return boolean
+	 * @access private
+	 */
+	function isValid($key)
+	{
+		return array_key_exists($key, $this->_store);
+	}
 
-    /**
-     * Set value
-     *
-     * @param string $key
-     * @param mixed $obj
-     * @access public
-     */
-    function set($key, $obj)
-    {
-        $this->_store[$key] = $obj;
-    }
+	/**
+	 * Set value
+	 *
+	 * @param string $key
+	 * @param mixed $obj
+	 * @access public
+	 */
+	function set($key, $obj)
+	{
+		$this->_store[$key] = $obj;
+	}
 
-    /**
-     * Get value
-     *
-     * @param string $key
-     * @return mixed
-     * @access public
-     */
-    function get($key)
-    {
-    	if ($this->isValid($key)) {
-    	    return $this->_store[$key];
-    	}
-    }
+	/**
+	 * Get value
+	 *
+	 * @param string $key
+	 * @return mixed
+	 * @access public
+	 */
+	function get($key)
+	{
+		if ($this->isValid($key)) {
+			return $this->_store[$key];
+		}
+	}
 }

Braces +3 added lines, -1 removed lines

@@ -10,7 +10,9 @@
  * modifying or distribute this file or part of its contents. The contents of
  * this file is part of the Source Code of CKFinder.
  */
-if (!defined('IN_CKFINDER')) exit;
+if (!defined('IN_CKFINDER')) {
+	exit;
+}
 
 /**
  * @package CKFinder

libs/ckfinder/core/connector/php/php4/Core/ResourceTypeConfig.php

Doc Comments +1 added lines, -2 removed lines

@@ -221,7 +221,6 @@ 
      * If allowed extensions are defined, return false if extension isn't on allowed list.
      *
      * @access public
-     * @param string $extension extension
      * @param boolean $renameIfRequired whether try to rename file or not
      * @return boolean
      */
@@ -314,8 +313,8 @@ 
      * Check given path
      * Return true if path contains folder name that matches hidden folder names list
      *
-     * @param string $folderName
      * @access public
+     * @param string $path
      * @return boolean
      */
     function checkIsHiddenPath($path)

Indentation +321 added lines, -321 removed lines

@@ -27,325 +27,325 @@
  */
 class CKFinder_Connector_Core_ResourceTypeConfig
 {
-    /**
-     * Resource name
-     *
-     * @var string
-     * @access private
-     */
-    var $_name = "";
-    /**
-     * Resource url
-     *
-     * @var string
-     * @access private
-     */
-    var $_url = "";
-    /**
-     * Directory path on a server
-     *
-     * @var string
-     * @access private
-     */
-    var $_directory = "";
-    /**
-     * Max size
-     *
-     * @var unknown_type
-     * @access private
-     */
-    var $_maxSize = 0;
-    /**
-     * Array with allowed extensions
-     *
-     * @var array[]string
-     * @access private
-     */
-    var $_allowedExtensions = array();
-    /**
-     * Array with denied extensions
-     *
-     * @var array[]string
-     * @access private
-     */
-    var $_deniedExtensions = array();
-    /**
-     * used for CKFinder_Connector_Core_Config object caching
-     *
-     * @var CKFinder_Connector_Core_Config
-     * @access private
-     */
-    var $_config;
-
-    /**
-     * Get ResourceType configuration
-     *
-     * @param string $resourceTypeNode
-     * @return array
-     *
-     */
-    function CKFinder_Connector_Core_ResourceTypeConfig($resourceTypeNode)
-    {
-        if (isset($resourceTypeNode["name"])) {
-            $this->_name = $resourceTypeNode["name"];
-        }
-
-        if (isset($resourceTypeNode["url"])) {
-            $this->_url = $resourceTypeNode["url"];
-        }
-
-        if (!strlen($this->_url)) {
-            $this->_url = "/";
-        }
-        else if(substr($this->_url,-1,1) != "/") {
-            $this->_url .= "/";
-        }
-
-        if (isset($resourceTypeNode["maxSize"])) {
-            $this->_maxSize = CKFinder_Connector_Utils_Misc::returnBytes((string)$resourceTypeNode["maxSize"]);
-        }
-
-        if (isset($resourceTypeNode["directory"])) {
-            $this->_directory = $resourceTypeNode["directory"];
-        }
-
-        if (!strlen($this->_directory)) {
-            $this->_directory = resolveUrl($this->_url);
-        }
-
-        if (isset($resourceTypeNode["allowedExtensions"])) {
-            if (is_array($resourceTypeNode["allowedExtensions"])) {
-                foreach ($resourceTypeNode["allowedExtensions"] as $e) {
-                    $this->_allowedExtensions[] = strtolower(trim((string)$e));
-                }
-            }
-            else {
-                $resourceTypeNode["allowedExtensions"] = trim((string)$resourceTypeNode["allowedExtensions"]);
-                if (strlen($resourceTypeNode["allowedExtensions"])) {
-                    $extensions = explode(",", $resourceTypeNode["allowedExtensions"]);
-                    foreach ($extensions as $e) {
-                        $this->_allowedExtensions[] = strtolower(trim($e));
-                    }
-                }
-            }
-        }
-
-        if (isset($resourceTypeNode["deniedExtensions"])) {
-            if (is_array($resourceTypeNode["deniedExtensions"])) {
-
-                foreach ($resourceTypeNode["deniedExtensions"] as $extension) {
-                    $this->_deniedExtensions[] = strtolower(trim((string)$e));
-                }
-            }
-            else {
-                $resourceTypeNode["deniedExtensions"] = trim((string)$resourceTypeNode["deniedExtensions"]);
-                if (strlen($resourceTypeNode["deniedExtensions"])) {
-                    $extensions = explode(",", $resourceTypeNode["deniedExtensions"]);
-                    foreach ($extensions as $e) {
-                        $this->_deniedExtensions[] = strtolower(trim($e));
-                    }
-                }
-            }
-        }
-    }
-
-    /**
-     * Get name
-     *
-     * @access public
-     * @return string
-     */
-    function getName()
-    {
-        return $this->_name;
-    }
-
-    /**
-     * Get url
-     *
-     * @access public
-     * @return string
-     */
-    function getUrl()
-    {
-        return $this->_url;
-    }
-
-    /**
-     * Get directory
-     *
-     * @access public
-     * @return string
-     */
-    function getDirectory()
-    {
-        return $this->_directory;
-    }
-
-    /**
-     * Get max size
-     *
-     * @access public
-     * @return int
-     */
-    function getMaxSize()
-    {
-        return $this->_maxSize;
-    }
-
-    /**
-     * Get allowed extensions
-     *
-     * @access public
-     * @return array[]string
-     */
-    function getAllowedExtensions()
-    {
-        return $this->_allowedExtensions;
-    }
-
-    /**
-     * Get denied extensions
-     *
-     * @access public
-     * @return array[]string
-     */
-    function getDeniedExtensions()
-    {
-        return $this->_deniedExtensions;
-    }
-
-    /**
-     * Check extension, return true if file name is valid.
-     * Return false if extension is on denied list.
-     * If allowed extensions are defined, return false if extension isn't on allowed list.
-     *
-     * @access public
-     * @param string $extension extension
-     * @param boolean $renameIfRequired whether try to rename file or not
-     * @return boolean
-     */
-    function checkExtension(&$fileName, $renameIfRequired = true)
-    {
-        if (strpos($fileName, '.') === false) {
-            return true;
-        }
-
-        if (is_null($this->_config)) {
-            $this->_config =& CKFinder_Connector_Core_Factory::getInstance("Core_Config");
-        }
-
-        $toCheck = array();
-
-        if ($this->_config->getCheckDoubleExtension()) {
-            $pieces = explode('.', $fileName);
-
-            // First, check the last extension (ex. in file.php.jpg, the "jpg").
-            if ( !$this->checkSingleExtension( $pieces[sizeof($pieces)-1] ) ) {
-                return false;
-            }
-
-            if ($renameIfRequired) {
-                // Check the other extensions, rebuilding the file name. If an extension is
-                // not allowed, replace the dot with an underscore.
-                $fileName = $pieces[0] ;
-                for ($i=1; $i<sizeof($pieces)-1; $i++) {
-                    $fileName .= $this->checkSingleExtension( $pieces[$i] ) ? '.' : '_' ;
-                    $fileName .= $pieces[$i];
-                }
-
-                // Add the last extension to the final name.
-                $fileName .= '.' . $pieces[sizeof($pieces)-1] ;
-            }
-        }
-        else {
-            // Check only the last extension (ex. in file.php.jpg, only "jpg").
-            return $this->checkSingleExtension( substr($fileName, strrpos($fileName,'.')+1) );
-        }
-
-        return true;
-    }
-
-    /**
-     * Check given folder name
-     * Return true if folder name matches hidden folder names list
-     *
-     * @param string $folderName
-     * @access public
-     * @return boolean
-     */
-    function checkIsHiddenFolder($folderName)
-    {
-        if (is_null($this->_config)) {
-            $this->_config =& CKFinder_Connector_Core_Factory::getInstance("Core_Config");
-        }
-
-        $regex = $this->_config->getHideFoldersRegex();
-        if ($regex) {
-            return preg_match($regex, $folderName);
-        }
-
-        return false;
-    }
-
-    /**
-     * Check given file name
-     * Return true if file name matches hidden file names list
-     *
-     * @param string $fileName
-     * @access public
-     * @return boolean
-     */
-    function checkIsHiddenFile($fileName)
-    {
-        if (is_null($this->_config)) {
-            $this->_config =& CKFinder_Connector_Core_Factory::getInstance("Core_Config");
-        }
-
-        $regex = $this->_config->getHideFilesRegex();
-        if ($regex) {
-            return preg_match($regex, $fileName);
-        }
-
-        return false;
-    }
-
-    /**
-     * Check given path
-     * Return true if path contains folder name that matches hidden folder names list
-     *
-     * @param string $folderName
-     * @access public
-     * @return boolean
-     */
-    function checkIsHiddenPath($path)
-    {
-        $_clientPathParts = explode("/", trim($path, "/"));
-        if ($_clientPathParts) {
-            foreach ($_clientPathParts as $_part) {
-                if ($this->checkIsHiddenFolder($_part)) {
-                    return true;
-                }
-            }
-        }
-
-        return false;
-    }
-
-    function checkSingleExtension($extension)
-    {
-        $extension = strtolower(ltrim($extension,'.'));
-
-        if (sizeof($this->_deniedExtensions)) {
-            if (in_array($extension, $this->_deniedExtensions)) {
-                return false;
-            }
-        }
-
-        if (sizeof($this->_allowedExtensions)) {
-            return in_array($extension, $this->_allowedExtensions);
-        }
-
-        return true;
-    }
+	/**
+	 * Resource name
+	 *
+	 * @var string
+	 * @access private
+	 */
+	var $_name = "";
+	/**
+	 * Resource url
+	 *
+	 * @var string
+	 * @access private
+	 */
+	var $_url = "";
+	/**
+	 * Directory path on a server
+	 *
+	 * @var string
+	 * @access private
+	 */
+	var $_directory = "";
+	/**
+	 * Max size
+	 *
+	 * @var unknown_type
+	 * @access private
+	 */
+	var $_maxSize = 0;
+	/**
+	 * Array with allowed extensions
+	 *
+	 * @var array[]string
+	 * @access private
+	 */
+	var $_allowedExtensions = array();
+	/**
+	 * Array with denied extensions
+	 *
+	 * @var array[]string
+	 * @access private
+	 */
+	var $_deniedExtensions = array();
+	/**
+	 * used for CKFinder_Connector_Core_Config object caching
+	 *
+	 * @var CKFinder_Connector_Core_Config
+	 * @access private
+	 */
+	var $_config;
+
+	/**
+	 * Get ResourceType configuration
+	 *
+	 * @param string $resourceTypeNode
+	 * @return array
+	 *
+	 */
+	function CKFinder_Connector_Core_ResourceTypeConfig($resourceTypeNode)
+	{
+		if (isset($resourceTypeNode["name"])) {
+			$this->_name = $resourceTypeNode["name"];
+		}
+
+		if (isset($resourceTypeNode["url"])) {
+			$this->_url = $resourceTypeNode["url"];
+		}
+
+		if (!strlen($this->_url)) {
+			$this->_url = "/";
+		}
+		else if(substr($this->_url,-1,1) != "/") {
+			$this->_url .= "/";
+		}
+
+		if (isset($resourceTypeNode["maxSize"])) {
+			$this->_maxSize = CKFinder_Connector_Utils_Misc::returnBytes((string)$resourceTypeNode["maxSize"]);
+		}
+
+		if (isset($resourceTypeNode["directory"])) {
+			$this->_directory = $resourceTypeNode["directory"];
+		}
+
+		if (!strlen($this->_directory)) {
+			$this->_directory = resolveUrl($this->_url);
+		}
+
+		if (isset($resourceTypeNode["allowedExtensions"])) {
+			if (is_array($resourceTypeNode["allowedExtensions"])) {
+				foreach ($resourceTypeNode["allowedExtensions"] as $e) {
+					$this->_allowedExtensions[] = strtolower(trim((string)$e));
+				}
+			}
+			else {
+				$resourceTypeNode["allowedExtensions"] = trim((string)$resourceTypeNode["allowedExtensions"]);
+				if (strlen($resourceTypeNode["allowedExtensions"])) {
+					$extensions = explode(",", $resourceTypeNode["allowedExtensions"]);
+					foreach ($extensions as $e) {
+						$this->_allowedExtensions[] = strtolower(trim($e));
+					}
+				}
+			}
+		}
+
+		if (isset($resourceTypeNode["deniedExtensions"])) {
+			if (is_array($resourceTypeNode["deniedExtensions"])) {
+
+				foreach ($resourceTypeNode["deniedExtensions"] as $extension) {
+					$this->_deniedExtensions[] = strtolower(trim((string)$e));
+				}
+			}
+			else {
+				$resourceTypeNode["deniedExtensions"] = trim((string)$resourceTypeNode["deniedExtensions"]);
+				if (strlen($resourceTypeNode["deniedExtensions"])) {
+					$extensions = explode(",", $resourceTypeNode["deniedExtensions"]);
+					foreach ($extensions as $e) {
+						$this->_deniedExtensions[] = strtolower(trim($e));
+					}
+				}
+			}
+		}
+	}
+
+	/**
+	 * Get name
+	 *
+	 * @access public
+	 * @return string
+	 */
+	function getName()
+	{
+		return $this->_name;
+	}
+
+	/**
+	 * Get url
+	 *
+	 * @access public
+	 * @return string
+	 */
+	function getUrl()
+	{
+		return $this->_url;
+	}
+
+	/**
+	 * Get directory
+	 *
+	 * @access public
+	 * @return string
+	 */
+	function getDirectory()
+	{
+		return $this->_directory;
+	}
+
+	/**
+	 * Get max size
+	 *
+	 * @access public
+	 * @return int
+	 */
+	function getMaxSize()
+	{
+		return $this->_maxSize;
+	}
+
+	/**
+	 * Get allowed extensions
+	 *
+	 * @access public
+	 * @return array[]string
+	 */
+	function getAllowedExtensions()
+	{
+		return $this->_allowedExtensions;
+	}
+
+	/**
+	 * Get denied extensions
+	 *
+	 * @access public
+	 * @return array[]string
+	 */
+	function getDeniedExtensions()
+	{
+		return $this->_deniedExtensions;
+	}
+
+	/**
+	 * Check extension, return true if file name is valid.
+	 * Return false if extension is on denied list.
+	 * If allowed extensions are defined, return false if extension isn't on allowed list.
+	 *
+	 * @access public
+	 * @param string $extension extension
+	 * @param boolean $renameIfRequired whether try to rename file or not
+	 * @return boolean
+	 */
+	function checkExtension(&$fileName, $renameIfRequired = true)
+	{
+		if (strpos($fileName, '.') === false) {
+			return true;
+		}
+
+		if (is_null($this->_config)) {
+			$this->_config =& CKFinder_Connector_Core_Factory::getInstance("Core_Config");
+		}
+
+		$toCheck = array();
+
+		if ($this->_config->getCheckDoubleExtension()) {
+			$pieces = explode('.', $fileName);
+
+			// First, check the last extension (ex. in file.php.jpg, the "jpg").
+			if ( !$this->checkSingleExtension( $pieces[sizeof($pieces)-1] ) ) {
+				return false;
+			}
+
+			if ($renameIfRequired) {
+				// Check the other extensions, rebuilding the file name. If an extension is
+				// not allowed, replace the dot with an underscore.
+				$fileName = $pieces[0] ;
+				for ($i=1; $i<sizeof($pieces)-1; $i++) {
+					$fileName .= $this->checkSingleExtension( $pieces[$i] ) ? '.' : '_' ;
+					$fileName .= $pieces[$i];
+				}
+
+				// Add the last extension to the final name.
+				$fileName .= '.' . $pieces[sizeof($pieces)-1] ;
+			}
+		}
+		else {
+			// Check only the last extension (ex. in file.php.jpg, only "jpg").
+			return $this->checkSingleExtension( substr($fileName, strrpos($fileName,'.')+1) );
+		}
+
+		return true;
+	}
+
+	/**
+	 * Check given folder name
+	 * Return true if folder name matches hidden folder names list
+	 *
+	 * @param string $folderName
+	 * @access public
+	 * @return boolean
+	 */
+	function checkIsHiddenFolder($folderName)
+	{
+		if (is_null($this->_config)) {
+			$this->_config =& CKFinder_Connector_Core_Factory::getInstance("Core_Config");
+		}
+
+		$regex = $this->_config->getHideFoldersRegex();
+		if ($regex) {
+			return preg_match($regex, $folderName);
+		}
+
+		return false;
+	}
+
+	/**
+	 * Check given file name
+	 * Return true if file name matches hidden file names list
+	 *
+	 * @param string $fileName
+	 * @access public
+	 * @return boolean
+	 */
+	function checkIsHiddenFile($fileName)
+	{
+		if (is_null($this->_config)) {
+			$this->_config =& CKFinder_Connector_Core_Factory::getInstance("Core_Config");
+		}
+
+		$regex = $this->_config->getHideFilesRegex();
+		if ($regex) {
+			return preg_match($regex, $fileName);
+		}
+
+		return false;
+	}
+
+	/**
+	 * Check given path
+	 * Return true if path contains folder name that matches hidden folder names list
+	 *
+	 * @param string $folderName
+	 * @access public
+	 * @return boolean
+	 */
+	function checkIsHiddenPath($path)
+	{
+		$_clientPathParts = explode("/", trim($path, "/"));
+		if ($_clientPathParts) {
+			foreach ($_clientPathParts as $_part) {
+				if ($this->checkIsHiddenFolder($_part)) {
+					return true;
+				}
+			}
+		}
+
+		return false;
+	}
+
+	function checkSingleExtension($extension)
+	{
+		$extension = strtolower(ltrim($extension,'.'));
+
+		if (sizeof($this->_deniedExtensions)) {
+			if (in_array($extension, $this->_deniedExtensions)) {
+				return false;
+			}
+		}
+
+		if (sizeof($this->_allowedExtensions)) {
+			return in_array($extension, $this->_allowedExtensions);
+		}
+
+		return true;
+	}
 }

Spacing +11 added lines, -11 removed lines

@@ -97,7 +97,7 @@ 
         if (!strlen($this->_url)) {
             $this->_url = "/";
         }
-        else if(substr($this->_url,-1,1) != "/") {
+        else if (substr($this->_url, -1, 1) != "/") {
             $this->_url .= "/";
         }
 
@@ -232,7 +232,7 @@ 
         }
 
         if (is_null($this->_config)) {
-            $this->_config =& CKFinder_Connector_Core_Factory::getInstance("Core_Config");
+            $this->_config = & CKFinder_Connector_Core_Factory::getInstance("Core_Config");
         }
 
         $toCheck = array();
@@ -241,26 +241,26 @@ 
             $pieces = explode('.', $fileName);
 
             // First, check the last extension (ex. in file.php.jpg, the "jpg").
-            if ( !$this->checkSingleExtension( $pieces[sizeof($pieces)-1] ) ) {
+            if (!$this->checkSingleExtension($pieces[sizeof($pieces) - 1])) {
                 return false;
             }
 
             if ($renameIfRequired) {
                 // Check the other extensions, rebuilding the file name. If an extension is
                 // not allowed, replace the dot with an underscore.
-                $fileName = $pieces[0] ;
-                for ($i=1; $i<sizeof($pieces)-1; $i++) {
-                    $fileName .= $this->checkSingleExtension( $pieces[$i] ) ? '.' : '_' ;
+                $fileName = $pieces[0];
+                for ($i = 1; $i < sizeof($pieces) - 1; $i++) {
+                    $fileName .= $this->checkSingleExtension($pieces[$i]) ? '.' : '_';
                     $fileName .= $pieces[$i];
                 }
 
                 // Add the last extension to the final name.
-                $fileName .= '.' . $pieces[sizeof($pieces)-1] ;
+                $fileName .= '.'.$pieces[sizeof($pieces) - 1];
             }
         }
         else {
             // Check only the last extension (ex. in file.php.jpg, only "jpg").
-            return $this->checkSingleExtension( substr($fileName, strrpos($fileName,'.')+1) );
+            return $this->checkSingleExtension(substr($fileName, strrpos($fileName, '.') + 1));
         }
 
         return true;
@@ -277,7 +277,7 @@ 
     function checkIsHiddenFolder($folderName)
     {
         if (is_null($this->_config)) {
-            $this->_config =& CKFinder_Connector_Core_Factory::getInstance("Core_Config");
+            $this->_config = & CKFinder_Connector_Core_Factory::getInstance("Core_Config");
         }
 
         $regex = $this->_config->getHideFoldersRegex();
@@ -299,7 +299,7 @@ 
     function checkIsHiddenFile($fileName)
     {
         if (is_null($this->_config)) {
-            $this->_config =& CKFinder_Connector_Core_Factory::getInstance("Core_Config");
+            $this->_config = & CKFinder_Connector_Core_Factory::getInstance("Core_Config");
         }
 
         $regex = $this->_config->getHideFilesRegex();
@@ -334,7 +334,7 @@ 
 
     function checkSingleExtension($extension)
     {
-        $extension = strtolower(ltrim($extension,'.'));
+        $extension = strtolower(ltrim($extension, '.'));
 
         if (sizeof($this->_deniedExtensions)) {
             if (in_array($extension, $this->_deniedExtensions)) {

Braces +7 added lines, -9 removed lines

@@ -10,7 +10,9 @@ 
  * modifying or distribute this file or part of its contents. The contents of
  * this file is part of the Source Code of CKFinder.
  */
-if (!defined('IN_CKFINDER')) exit;
+if (!defined('IN_CKFINDER')) {
+	exit;
+}
 
 /**
  * @package CKFinder
@@ -96,8 +98,7 @@ 
 
         if (!strlen($this->_url)) {
             $this->_url = "/";
-        }
-        else if(substr($this->_url,-1,1) != "/") {
+        } else if(substr($this->_url,-1,1) != "/") {
             $this->_url .= "/";
         }
 
@@ -118,8 +119,7 @@ 
                 foreach ($resourceTypeNode["allowedExtensions"] as $e) {
                     $this->_allowedExtensions[] = strtolower(trim((string)$e));
                 }
-            }
-            else {
+            } else {
                 $resourceTypeNode["allowedExtensions"] = trim((string)$resourceTypeNode["allowedExtensions"]);
                 if (strlen($resourceTypeNode["allowedExtensions"])) {
                     $extensions = explode(",", $resourceTypeNode["allowedExtensions"]);
@@ -136,8 +136,7 @@ 
                 foreach ($resourceTypeNode["deniedExtensions"] as $extension) {
                     $this->_deniedExtensions[] = strtolower(trim((string)$e));
                 }
-            }
-            else {
+            } else {
                 $resourceTypeNode["deniedExtensions"] = trim((string)$resourceTypeNode["deniedExtensions"]);
                 if (strlen($resourceTypeNode["deniedExtensions"])) {
                     $extensions = explode(",", $resourceTypeNode["deniedExtensions"]);
@@ -257,8 +256,7 @@ 
                 // Add the last extension to the final name.
                 $fileName .= '.' . $pieces[sizeof($pieces)-1] ;
             }
-        }
-        else {
+        } else {
             // Check only the last extension (ex. in file.php.jpg, only "jpg").
             return $this->checkSingleExtension( substr($fileName, strrpos($fileName,'.')+1) );
         }

libs/ckfinder/core/connector/php/php4/ErrorHandler/FileUpload.php

Doc Comments +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
      * Throw file upload error, return true if error has been thrown, false if error has been catched
      *
      * @param int $number
-     * @param string $text
+     * @param string $exit
      * @access public
      */
     function throwError($number, $uploaded = false, $exit = true) {

Indentation +37 added lines, -37 removed lines

@@ -32,50 +32,50 @@
  */
 class CKFinder_Connector_ErrorHandler_FileUpload extends CKFinder_Connector_ErrorHandler_Base
 {
-    /**
-     * Throw file upload error, return true if error has been thrown, false if error has been catched
-     *
-     * @param int $number
-     * @param string $text
-     * @access public
-     */
-    function throwError($number, $uploaded = false, $exit = true) {
-        if ($this->_catchAllErrors || in_array($number, $this->_skipErrorsArray)) {
-            return false;
-        }
+	/**
+	 * Throw file upload error, return true if error has been thrown, false if error has been catched
+	 *
+	 * @param int $number
+	 * @param string $text
+	 * @access public
+	 */
+	function throwError($number, $uploaded = false, $exit = true) {
+		if ($this->_catchAllErrors || in_array($number, $this->_skipErrorsArray)) {
+			return false;
+		}
 
-        $oRegistry = & CKFinder_Connector_Core_Factory :: getInstance("Core_Registry");
-        $sFileName = $oRegistry->get("FileUpload_fileName");
-        $sFileUrl = $oRegistry->get("FileUpload_url");
+		$oRegistry = & CKFinder_Connector_Core_Factory :: getInstance("Core_Registry");
+		$sFileName = $oRegistry->get("FileUpload_fileName");
+		$sFileUrl = $oRegistry->get("FileUpload_url");
 
-        header('Content-Type: text/html; charset=utf-8');
+		header('Content-Type: text/html; charset=utf-8');
 
-        $errorMessage = CKFinder_Connector_Utils_Misc :: getErrorMessage($number, $sFileName);
-        if (!$uploaded) {
-            $sFileName = "";
-        }
+		$errorMessage = CKFinder_Connector_Utils_Misc :: getErrorMessage($number, $sFileName);
+		if (!$uploaded) {
+			$sFileName = "";
+		}
 
-        echo "<script type=\"text/javascript\">";
+		echo "<script type=\"text/javascript\">";
 
-        if (!empty($_GET['CKFinderFuncNum'])) {
-            $errorMessage = CKFinder_Connector_Utils_Misc::getErrorMessage($number, $sFileName);
+		if (!empty($_GET['CKFinderFuncNum'])) {
+			$errorMessage = CKFinder_Connector_Utils_Misc::getErrorMessage($number, $sFileName);
 
-            if (!$uploaded) {
-                $sFileUrl = "";
-                $sFileName = "";
-            }
+			if (!$uploaded) {
+				$sFileUrl = "";
+				$sFileName = "";
+			}
 
-            $funcNum = preg_replace("/[^0-9]/", "", $_GET['CKFinderFuncNum']);
-            echo "window.parent.CKFinder.tools.callFunction($funcNum, '" . str_replace("'", "\\'", $sFileUrl . $sFileName) . "', '" .str_replace("'", "\\'", $errorMessage). "');";
-        }
-        else {
-            echo "window.parent.OnUploadCompleted('" . str_replace("'", "\\'", $sFileName) . "', '" . str_replace("'", "\\'", $errorMessage) . "') ;";
-        }
+			$funcNum = preg_replace("/[^0-9]/", "", $_GET['CKFinderFuncNum']);
+			echo "window.parent.CKFinder.tools.callFunction($funcNum, '" . str_replace("'", "\\'", $sFileUrl . $sFileName) . "', '" .str_replace("'", "\\'", $errorMessage). "');";
+		}
+		else {
+			echo "window.parent.OnUploadCompleted('" . str_replace("'", "\\'", $sFileName) . "', '" . str_replace("'", "\\'", $errorMessage) . "') ;";
+		}
 
-        echo "</script>";
+		echo "</script>";
 
-        if ($exit) {
-            exit;
-        }
-    }
+		if ($exit) {
+			exit;
+		}
+	}
 }

Spacing +3 added lines, -3 removed lines

@@ -21,7 +21,7 @@ 
 /**
  * Include base error handling class
  */
-require_once CKFINDER_CONNECTOR_LIB_DIR . "/ErrorHandler/Base.php";
+require_once CKFINDER_CONNECTOR_LIB_DIR."/ErrorHandler/Base.php";
 
 /**
  * File upload error handler
@@ -66,10 +66,10 @@ 
             }
 
             $funcNum = preg_replace("/[^0-9]/", "", $_GET['CKFinderFuncNum']);
-            echo "window.parent.CKFinder.tools.callFunction($funcNum, '" . str_replace("'", "\\'", $sFileUrl . $sFileName) . "', '" .str_replace("'", "\\'", $errorMessage). "');";
+            echo "window.parent.CKFinder.tools.callFunction($funcNum, '".str_replace("'", "\\'", $sFileUrl.$sFileName)."', '".str_replace("'", "\\'", $errorMessage)."');";
         }
         else {
-            echo "window.parent.OnUploadCompleted('" . str_replace("'", "\\'", $sFileName) . "', '" . str_replace("'", "\\'", $errorMessage) . "') ;";
+            echo "window.parent.OnUploadCompleted('".str_replace("'", "\\'", $sFileName)."', '".str_replace("'", "\\'", $errorMessage)."') ;";
         }
 
         echo "</script>";

Braces +4 added lines, -3 removed lines

@@ -10,7 +10,9 @@ 
  * modifying or distribute this file or part of its contents. The contents of
  * this file is part of the Source Code of CKFinder.
  */
-if (!defined('IN_CKFINDER')) exit;
+if (!defined('IN_CKFINDER')) {
+	exit;
+}
 
 /**
  * @package CKFinder
@@ -67,8 +69,7 @@ 
 
             $funcNum = preg_replace("/[^0-9]/", "", $_GET['CKFinderFuncNum']);
             echo "window.parent.CKFinder.tools.callFunction($funcNum, '" . str_replace("'", "\\'", $sFileUrl . $sFileName) . "', '" .str_replace("'", "\\'", $errorMessage). "');";
-        }
-        else {
+        } else {
             echo "window.parent.OnUploadCompleted('" . str_replace("'", "\\'", $sFileName) . "', '" . str_replace("'", "\\'", $errorMessage) . "') ;";
         }
 

libs/ckfinder/core/connector/php/php4/ErrorHandler/QuickUpload.php

Doc Comments +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
      * Throw file upload error, return true if error has been thrown, false if error has been catched
      *
      * @param int $number
-     * @param string $text
+     * @param string $exit
      * @access public
      */
     function throwError($number, $uploaded = false, $exit = true) {

Indentation +37 added lines, -37 removed lines

@@ -32,52 +32,52 @@
  */
 class CKFinder_Connector_ErrorHandler_QuickUpload extends CKFinder_Connector_ErrorHandler_Base
 {
-    /**
-     * Throw file upload error, return true if error has been thrown, false if error has been catched
-     *
-     * @param int $number
-     * @param string $text
-     * @access public
-     */
-    function throwError($number, $uploaded = false, $exit = true) {
-        if ($this->_catchAllErrors || in_array($number, $this->_skipErrorsArray)) {
-            return false;
-        }
+	/**
+	 * Throw file upload error, return true if error has been thrown, false if error has been catched
+	 *
+	 * @param int $number
+	 * @param string $text
+	 * @access public
+	 */
+	function throwError($number, $uploaded = false, $exit = true) {
+		if ($this->_catchAllErrors || in_array($number, $this->_skipErrorsArray)) {
+			return false;
+		}
 
-        $oRegistry = & CKFinder_Connector_Core_Factory :: getInstance("Core_Registry");
-        $sFileName = $oRegistry->get("FileUpload_fileName");
-        $sFileUrl = $oRegistry->get("FileUpload_url");
+		$oRegistry = & CKFinder_Connector_Core_Factory :: getInstance("Core_Registry");
+		$sFileName = $oRegistry->get("FileUpload_fileName");
+		$sFileUrl = $oRegistry->get("FileUpload_url");
 
-        header('Content-Type: text/html; charset=utf-8');
+		header('Content-Type: text/html; charset=utf-8');
 
 		/**
 		 * echo <script> is not called before CKFinder_Connector_Utils_Misc::getErrorMessage
 		 * because PHP has problems with including files that contain BOM character.
 		 * Having BOM character after <script> tag causes a javascript error.
 		 */
-        echo "<script type=\"text/javascript\">";
-        if (!empty($_GET['CKEditor'])) {
-            $errorMessage = CKFinder_Connector_Utils_Misc::getErrorMessage($number, $sFileName);
+		echo "<script type=\"text/javascript\">";
+		if (!empty($_GET['CKEditor'])) {
+			$errorMessage = CKFinder_Connector_Utils_Misc::getErrorMessage($number, $sFileName);
 
-            if (!$uploaded) {
-                $sFileUrl = "";
-                $sFileName = "";
-            }
+			if (!$uploaded) {
+				$sFileUrl = "";
+				$sFileName = "";
+			}
 
-            $funcNum = preg_replace("/[^0-9]/", "", $_GET['CKEditorFuncNum']);
-            echo "window.parent.CKEDITOR.tools.callFunction($funcNum, '" . str_replace("'", "\\'", $sFileUrl . $sFileName) . "', '" .str_replace("'", "\\'", $errorMessage). "');";
-        }
-        else {
-            if (!$uploaded) {
-                echo "window.parent.OnUploadCompleted(" . $number . ", '', '', '') ;";
-            } else {
-                echo "window.parent.OnUploadCompleted(" . $number . ", '" . str_replace("'", "\\'", $sFileUrl . $sFileName) . "', '" . str_replace("'", "\\'", $sFileName) . "', '') ;";
-            }
-        }
-        echo "</script>";
+			$funcNum = preg_replace("/[^0-9]/", "", $_GET['CKEditorFuncNum']);
+			echo "window.parent.CKEDITOR.tools.callFunction($funcNum, '" . str_replace("'", "\\'", $sFileUrl . $sFileName) . "', '" .str_replace("'", "\\'", $errorMessage). "');";
+		}
+		else {
+			if (!$uploaded) {
+				echo "window.parent.OnUploadCompleted(" . $number . ", '', '', '') ;";
+			} else {
+				echo "window.parent.OnUploadCompleted(" . $number . ", '" . str_replace("'", "\\'", $sFileUrl . $sFileName) . "', '" . str_replace("'", "\\'", $sFileName) . "', '') ;";
+			}
+		}
+		echo "</script>";
 
-        if ($exit) {
-            exit;
-        }
-    }
+		if ($exit) {
+			exit;
+		}
+	}
 }

Spacing +4 added lines, -4 removed lines

@@ -21,7 +21,7 @@ 
 /**
  * Include base error handling class
  */
-require_once CKFINDER_CONNECTOR_LIB_DIR . "/ErrorHandler/Base.php";
+require_once CKFINDER_CONNECTOR_LIB_DIR."/ErrorHandler/Base.php";
 
 /**
  * File upload error handler
@@ -65,13 +65,13 @@ 
             }
 
             $funcNum = preg_replace("/[^0-9]/", "", $_GET['CKEditorFuncNum']);
-            echo "window.parent.CKEDITOR.tools.callFunction($funcNum, '" . str_replace("'", "\\'", $sFileUrl . $sFileName) . "', '" .str_replace("'", "\\'", $errorMessage). "');";
+            echo "window.parent.CKEDITOR.tools.callFunction($funcNum, '".str_replace("'", "\\'", $sFileUrl.$sFileName)."', '".str_replace("'", "\\'", $errorMessage)."');";
         }
         else {
             if (!$uploaded) {
-                echo "window.parent.OnUploadCompleted(" . $number . ", '', '', '') ;";
+                echo "window.parent.OnUploadCompleted(".$number.", '', '', '') ;";
             } else {
-                echo "window.parent.OnUploadCompleted(" . $number . ", '" . str_replace("'", "\\'", $sFileUrl . $sFileName) . "', '" . str_replace("'", "\\'", $sFileName) . "', '') ;";
+                echo "window.parent.OnUploadCompleted(".$number.", '".str_replace("'", "\\'", $sFileUrl.$sFileName)."', '".str_replace("'", "\\'", $sFileName)."', '') ;";
             }
         }
         echo "</script>";

Braces +4 added lines, -3 removed lines

@@ -10,7 +10,9 @@ 
  * modifying or distribute this file or part of its contents. The contents of
  * this file is part of the Source Code of CKFinder.
  */
-if (!defined('IN_CKFINDER')) exit;
+if (!defined('IN_CKFINDER')) {
+	exit;
+}
 
 /**
  * @package CKFinder
@@ -66,8 +68,7 @@ 
 
             $funcNum = preg_replace("/[^0-9]/", "", $_GET['CKEditorFuncNum']);
             echo "window.parent.CKEDITOR.tools.callFunction($funcNum, '" . str_replace("'", "\\'", $sFileUrl . $sFileName) . "', '" .str_replace("'", "\\'", $errorMessage). "');";
-        }
-        else {
+        } else {
             if (!$uploaded) {
                 echo "window.parent.OnUploadCompleted(" . $number . ", '', '', '') ;";
             } else {

libs/ckfinder/core/connector/php/php4/Utils/FileSystem.php

Doc Comments +3 added lines, -5 removed lines

@@ -135,7 +135,7 @@ 
      * PHP4 Scandir
      * @static
      * @access public
-     * @param $directory directory name
+     * @param string $directory directory name
     */
     function php4_scandir($directory)
     {
@@ -404,7 +404,6 @@ 
      * @static
      * @access public
      * @param string $dir
-     * @param int $mode
      * @return boolean
      */
     function createDirectoryRecursively($dir)
@@ -454,7 +453,7 @@ 
      * @static
      * @access public
      * @param string $filePath absolute path to file
-     * @return boolean
+     * @return string
     */
     function detectHtml($filePath)
     {
@@ -515,8 +514,7 @@ 
      * @access public
      * @param string $filePath absolute path to file
      * @param string $extension file extension
-     * @param integer $detectionLevel 0 = none, 1 = use getimagesize for images, 2 = use DetectHtml for images
-     * @return boolean
+     * @return string
     */
     function isImageValid($filePath, $extension)
     {

Indentation +523 added lines, -523 removed lines

@@ -26,220 +26,220 @@ 
 class CKFinder_Connector_Utils_FileSystem
 {
 
-    /**
-     * This function behaves similar to System.IO.Path.Combine in C#, the only diffrenece is that it also accepts null values and treat them as empty string
-     *
-     * @static
-     * @access public
-     * @param string $path1 first path
-     * @param string $path2 scecond path
-     * @return string
-     */
-    function combinePaths($path1, $path2)
-    {
-        if (is_null($path1))  {
-            $path1 = "";
-        }
-        if (is_null($path2))  {
-            $path2 = "";
-        }
-        if (!strlen($path2)) {
-            if (strlen($path1)) {
-                $_lastCharP1 = substr($path1, -1, 1);
-                if ($_lastCharP1 != "/" && $_lastCharP1 != "\\") {
-                    $path1 .= DIRECTORY_SEPARATOR;
-                }
-            }
-        }
-        else {
-            $_firstCharP2 = substr($path2, 0, 1);
-            if (strlen($path1)) {
-                if (strpos($path2, $path1)===0) {
-                    return $path2;
-                }
-                $_lastCharP1 = substr($path1, -1, 1);
-                if ($_lastCharP1 != "/" && $_lastCharP1 != "\\" && $_firstCharP2 != "/" && $_firstCharP2 != "\\") {
-                    $path1 .= DIRECTORY_SEPARATOR;
-                }
-            }
-            else {
-                return $path2;
-            }
-        }
-        return $path1 . $path2;
-    }
-
-    /**
-     * Check whether $fileName is a valid file name, return true on success
-     *
-     * @static
-     * @access public
-     * @param string $fileName
-     * @return boolean
-     */
-    function checkFileName($fileName)
-    {
-        if (is_null($fileName) || !strlen($fileName) || substr($fileName,-1,1)=="." || false!==strpos($fileName, "..")) {
-            return false;
-        }
-
-        if (preg_match(CKFINDER_REGEX_INVALID_FILE, $fileName)) {
-            return false;
-        }
-
-        return true;
-    }
-
-    /**
-     * Unlink file/folder
-     *
-     * @static
-     * @access public
-     * @param string $path
-     * @return boolean
-     */
-    function unlink($path)
-    {
-        /*    make sure the path exists    */
-        if(!file_exists($path)) {
-            return false;
-        }
-
-        /*    If it is a file or link, just delete it    */
-        if(is_file($path) || is_link($path)) {
-            return @unlink($path);
-        }
-
-        /*    Scan the dir and recursively unlink    */
-        $files = CKFinder_Connector_Utils_FileSystem::php4_scandir($path);
-        if ($files) {
-            foreach($files as $filename)
-            {
-                if ($filename == '.' || $filename == '..') {
-                    continue;
-                }
-                $file = str_replace('//','/',$path.'/'.$filename);
-                CKFinder_Connector_Utils_FileSystem::unlink($file);
-            }
-        }
-
-        /*    Remove the parent dir    */
-        if(!@rmdir($path)) {
-            return false;
-        }
-
-        return true;
-    }
-
-    /**
-     * PHP4 Scandir
-     * @static
-     * @access public
-     * @param $directory directory name
-    */
-    function php4_scandir($directory)
-    {
-        if (!is_dir($directory) || (false === $fh = @opendir($directory))) {
-            return false;
-        }
-
-        $files = array ();
-        while (false !== ($filename = readdir($fh))) {
-            $files[] = $filename;
-        }
-
-        closedir($fh);
-
-        return $files;
-    }
-
-    /**
-     * Return file name without extension (without dot & last part after dot)
-     *
-     * @static
-     * @access public
-     * @param string $fileName
-     * @return string
-     */
-    function getFileNameWithoutExtension($fileName)
-    {
-        $dotPos = strrpos( $fileName, '.' );
-        if (false === $dotPos) {
-            return $fileName;
-        }
-
-        return substr($fileName, 0, $dotPos);
-    }
-
-    /**
-     * Get file extension (only last part - e.g. extension of file.foo.bar.jpg = jpg)
-     *
-     * @static
-     * @access public
-     * @param string $fileName
-     * @return string
-     */
-    function getExtension( $fileName )
-    {
-        $dotPos = strrpos( $fileName, '.' );
-        if (false === $dotPos) {
-            return "";
-        }
-
-        return substr( $fileName, strrpos( $fileName, '.' ) +1 ) ;
-    }
-
-    /**
+	/**
+	 * This function behaves similar to System.IO.Path.Combine in C#, the only diffrenece is that it also accepts null values and treat them as empty string
+	 *
+	 * @static
+	 * @access public
+	 * @param string $path1 first path
+	 * @param string $path2 scecond path
+	 * @return string
+	 */
+	function combinePaths($path1, $path2)
+	{
+		if (is_null($path1))  {
+			$path1 = "";
+		}
+		if (is_null($path2))  {
+			$path2 = "";
+		}
+		if (!strlen($path2)) {
+			if (strlen($path1)) {
+				$_lastCharP1 = substr($path1, -1, 1);
+				if ($_lastCharP1 != "/" && $_lastCharP1 != "\\") {
+					$path1 .= DIRECTORY_SEPARATOR;
+				}
+			}
+		}
+		else {
+			$_firstCharP2 = substr($path2, 0, 1);
+			if (strlen($path1)) {
+				if (strpos($path2, $path1)===0) {
+					return $path2;
+				}
+				$_lastCharP1 = substr($path1, -1, 1);
+				if ($_lastCharP1 != "/" && $_lastCharP1 != "\\" && $_firstCharP2 != "/" && $_firstCharP2 != "\\") {
+					$path1 .= DIRECTORY_SEPARATOR;
+				}
+			}
+			else {
+				return $path2;
+			}
+		}
+		return $path1 . $path2;
+	}
+
+	/**
+	 * Check whether $fileName is a valid file name, return true on success
+	 *
+	 * @static
+	 * @access public
+	 * @param string $fileName
+	 * @return boolean
+	 */
+	function checkFileName($fileName)
+	{
+		if (is_null($fileName) || !strlen($fileName) || substr($fileName,-1,1)=="." || false!==strpos($fileName, "..")) {
+			return false;
+		}
+
+		if (preg_match(CKFINDER_REGEX_INVALID_FILE, $fileName)) {
+			return false;
+		}
+
+		return true;
+	}
+
+	/**
+	 * Unlink file/folder
+	 *
+	 * @static
+	 * @access public
+	 * @param string $path
+	 * @return boolean
+	 */
+	function unlink($path)
+	{
+		/*    make sure the path exists    */
+		if(!file_exists($path)) {
+			return false;
+		}
+
+		/*    If it is a file or link, just delete it    */
+		if(is_file($path) || is_link($path)) {
+			return @unlink($path);
+		}
+
+		/*    Scan the dir and recursively unlink    */
+		$files = CKFinder_Connector_Utils_FileSystem::php4_scandir($path);
+		if ($files) {
+			foreach($files as $filename)
+			{
+				if ($filename == '.' || $filename == '..') {
+					continue;
+				}
+				$file = str_replace('//','/',$path.'/'.$filename);
+				CKFinder_Connector_Utils_FileSystem::unlink($file);
+			}
+		}
+
+		/*    Remove the parent dir    */
+		if(!@rmdir($path)) {
+			return false;
+		}
+
+		return true;
+	}
+
+	/**
+	 * PHP4 Scandir
+	 * @static
+	 * @access public
+	 * @param $directory directory name
+	 */
+	function php4_scandir($directory)
+	{
+		if (!is_dir($directory) || (false === $fh = @opendir($directory))) {
+			return false;
+		}
+
+		$files = array ();
+		while (false !== ($filename = readdir($fh))) {
+			$files[] = $filename;
+		}
+
+		closedir($fh);
+
+		return $files;
+	}
+
+	/**
+	 * Return file name without extension (without dot & last part after dot)
+	 *
+	 * @static
+	 * @access public
+	 * @param string $fileName
+	 * @return string
+	 */
+	function getFileNameWithoutExtension($fileName)
+	{
+		$dotPos = strrpos( $fileName, '.' );
+		if (false === $dotPos) {
+			return $fileName;
+		}
+
+		return substr($fileName, 0, $dotPos);
+	}
+
+	/**
+	 * Get file extension (only last part - e.g. extension of file.foo.bar.jpg = jpg)
+	 *
+	 * @static
+	 * @access public
+	 * @param string $fileName
+	 * @return string
+	 */
+	function getExtension( $fileName )
+	{
+		$dotPos = strrpos( $fileName, '.' );
+		if (false === $dotPos) {
+			return "";
+		}
+
+		return substr( $fileName, strrpos( $fileName, '.' ) +1 ) ;
+	}
+
+	/**
 	 * Read file, split it into small chunks and send it to the browser
 	 *
-     * @static
-     * @access public
+	 * @static
+	 * @access public
 	 * @param string $filename
 	 * @return boolean
 	 */
-    function readfileChunked($filename)
-    {
-        $chunksize = 1024 * 10; // how many bytes per chunk
-
-        $handle = fopen($filename, 'rb');
-        if ($handle === false) {
-            return false;
-        }
-        while (!feof($handle)) {
-            echo fread($handle, $chunksize);
-            @ob_flush();
-            flush();
-            @set_time_limit(8);
-        }
-        fclose($handle);
-        return true;
-    }
-
-    /**
-    * Replace accented UTF-8 characters by unaccented ASCII-7 "equivalents".
-    * The purpose of this function is to replace characters commonly found in Latin
-    * alphabets with something more or less equivalent from the ASCII range. This can
-    * be useful for converting a UTF-8 to something ready for a filename, for example.
-    * Following the use of this function, you would probably also pass the string
-    * through utf8_strip_non_ascii to clean out any other non-ASCII chars
-    *
-    * For a more complete implementation of transliteration, see the utf8_to_ascii package
-    * available from the phputf8 project downloads:
-    * http://prdownloads.sourceforge.net/phputf8
-    *
-    * @param string UTF-8 string
-    * @param string UTF-8 with accented characters replaced by ASCII chars
-    * @return string accented chars replaced with ascii equivalents
-    * @author Andreas Gohr <andi@splitbrain.org>
-    * @see http://sourceforge.net/projects/phputf8/
-    */
-    function convertToAscii($str)
-    {
-        static $UTF8_LOWER_ACCENTS = NULL;
-        static $UTF8_UPPER_ACCENTS = NULL;
-
-        if ( is_null($UTF8_LOWER_ACCENTS) ) {
-            $UTF8_LOWER_ACCENTS = array(
+	function readfileChunked($filename)
+	{
+		$chunksize = 1024 * 10; // how many bytes per chunk
+
+		$handle = fopen($filename, 'rb');
+		if ($handle === false) {
+			return false;
+		}
+		while (!feof($handle)) {
+			echo fread($handle, $chunksize);
+			@ob_flush();
+			flush();
+			@set_time_limit(8);
+		}
+		fclose($handle);
+		return true;
+	}
+
+	/**
+	 * Replace accented UTF-8 characters by unaccented ASCII-7 "equivalents".
+	 * The purpose of this function is to replace characters commonly found in Latin
+	 * alphabets with something more or less equivalent from the ASCII range. This can
+	 * be useful for converting a UTF-8 to something ready for a filename, for example.
+	 * Following the use of this function, you would probably also pass the string
+	 * through utf8_strip_non_ascii to clean out any other non-ASCII chars
+	 *
+	 * For a more complete implementation of transliteration, see the utf8_to_ascii package
+	 * available from the phputf8 project downloads:
+	 * http://prdownloads.sourceforge.net/phputf8
+	 *
+	 * @param string UTF-8 string
+	 * @param string UTF-8 with accented characters replaced by ASCII chars
+	 * @return string accented chars replaced with ascii equivalents
+	 * @author Andreas Gohr <andi@splitbrain.org>
+	 * @see http://sourceforge.net/projects/phputf8/
+	 */
+	function convertToAscii($str)
+	{
+		static $UTF8_LOWER_ACCENTS = NULL;
+		static $UTF8_UPPER_ACCENTS = NULL;
+
+		if ( is_null($UTF8_LOWER_ACCENTS) ) {
+			$UTF8_LOWER_ACCENTS = array(
   'à' => 'a', 'ô' => 'o', 'ď' => 'd', 'ḟ' => 'f', 'ë' => 'e', 'š' => 's', 'ơ' => 'o',
   'ß' => 'ss', 'ă' => 'a', 'ř' => 'r', 'ț' => 't', 'ň' => 'n', 'ā' => 'a', 'ķ' => 'k',
   'ŝ' => 's', 'ỳ' => 'y', 'ņ' => 'n', 'ĺ' => 'l', 'ħ' => 'h', 'ṗ' => 'p', 'ó' => 'o',
@@ -255,17 +255,17 @@ 
   'â' => 'a', 'ľ' => 'l', 'ẅ' => 'w', 'ż' => 'z', 'ī' => 'i', 'ã' => 'a', 'ġ' => 'g',
   'ṁ' => 'm', 'ō' => 'o', 'ĩ' => 'i', 'ù' => 'u', 'į' => 'i', 'ź' => 'z', 'á' => 'a',
   'û' => 'u', 'þ' => 'th', 'ð' => 'dh', 'æ' => 'ae', 'µ' => 'u', 'ĕ' => 'e',
-            );
-        }
+			);
+		}
 
-        $str = str_replace(
-                array_keys($UTF8_LOWER_ACCENTS),
-                array_values($UTF8_LOWER_ACCENTS),
-                $str
-            );
+		$str = str_replace(
+				array_keys($UTF8_LOWER_ACCENTS),
+				array_values($UTF8_LOWER_ACCENTS),
+				$str
+			);
 
-        if ( is_null($UTF8_UPPER_ACCENTS) ) {
-            $UTF8_UPPER_ACCENTS = array(
+		if ( is_null($UTF8_UPPER_ACCENTS) ) {
+			$UTF8_UPPER_ACCENTS = array(
   'À' => 'A', 'Ô' => 'O', 'Ď' => 'D', 'Ḟ' => 'F', 'Ë' => 'E', 'Š' => 'S', 'Ơ' => 'O',
   'Ă' => 'A', 'Ř' => 'R', 'Ț' => 'T', 'Ň' => 'N', 'Ā' => 'A', 'Ķ' => 'K',
   'Ŝ' => 'S', 'Ỳ' => 'Y', 'Ņ' => 'N', 'Ĺ' => 'L', 'Ħ' => 'H', 'Ṗ' => 'P', 'Ó' => 'O',
@@ -281,309 +281,309 @@ 
   'Â' => 'A', 'Ľ' => 'L', 'Ẅ' => 'W', 'Ż' => 'Z', 'Ī' => 'I', 'Ã' => 'A', 'Ġ' => 'G',
   'Ṁ' => 'M', 'Ō' => 'O', 'Ĩ' => 'I', 'Ù' => 'U', 'Į' => 'I', 'Ź' => 'Z', 'Á' => 'A',
   'Û' => 'U', 'Þ' => 'Th', 'Ð' => 'Dh', 'Æ' => 'Ae', 'Ĕ' => 'E',
-            );
-        }
-        $str = str_replace(
-                array_keys($UTF8_UPPER_ACCENTS),
-                array_values($UTF8_UPPER_ACCENTS),
-                $str
-            );
-        return $str;
-    }
-
-    /**
-     * Convert file name from UTF-8 to system encoding
-     *
-     * @static
-     * @access public
-     * @param string $fileName
-     * @return string
-     */
-    function convertToFilesystemEncoding($fileName)
-    {
-        $_config =& CKFinder_Connector_Core_Factory::getInstance("Core_Config");
-        $encoding = $_config->getFilesystemEncoding();
-        if (is_null($encoding) || strcasecmp($encoding, "UTF-8") == 0 || strcasecmp($encoding, "UTF8") == 0) {
-            return $fileName;
-        }
-
-        if (!function_exists("iconv")) {
-            if (strcasecmp($encoding, "ISO-8859-1") == 0 || strcasecmp($encoding, "ISO8859-1") == 0 || strcasecmp($encoding, "Latin1") == 0) {
-                return str_replace("\0", "_", utf8_decode($fileName));
-            } else if (function_exists('mb_convert_encoding')) {
-
-                $encoded = @mb_convert_encoding($fileName, $encoding, 'UTF-8');
-                if (@mb_strlen($fileName, "UTF-8") != @mb_strlen($encoded, $encoding)) {
-                    return str_replace("\0", "_", preg_replace("/[^[:ascii:]]/u","_",$fileName));
-                }
-                else {
-                    return str_replace("\0", "_", $encoded);
-                }
-            } else {
-                return str_replace("\0", "_", preg_replace("/[^[:ascii:]]/u","_",$fileName));
-            }
-        }
-
-        $converted = @iconv("UTF-8", $encoding . "//IGNORE//TRANSLIT", $fileName);
-        if ($converted === false) {
-            return str_replace("\0", "_", preg_replace("/[^[:ascii:]]/u","_",$fileName));
-        }
-
-        return $converted;
-    }
-
-    /**
-     * Convert file name from system encoding into UTF-8
-     *
-     * @static
-     * @access public
-     * @param string $fileName
-     * @return string
-     */
-    function convertToConnectorEncoding($fileName)
-    {
-        $_config =& CKFinder_Connector_Core_Factory::getInstance("Core_Config");
-        $encoding = $_config->getFilesystemEncoding();
-        if (is_null($encoding) || strcasecmp($encoding, "UTF-8") == 0 || strcasecmp($encoding, "UTF8") == 0) {
-            return $fileName;
-        }
-
-        if (!function_exists("iconv")) {
-            if (strcasecmp($encoding, "ISO-8859-1") == 0 || strcasecmp($encoding, "ISO8859-1") == 0 || strcasecmp($encoding, "Latin1") == 0) {
-                return utf8_encode($fileName);
-            } else {
-                return $fileName;
-            }
-        }
-
-        $converted = @iconv($encoding, "UTF-8", $fileName);
-
-        if ($converted === false) {
-            return $fileName;
-        }
-
-        return $converted;
-    }
-
-    /**
-     * Find document root
-     *
-     * @return string
-     * @access public
-     */
-    function getDocumentRootPath()
-    {
-        /**
-         * The absolute pathname of the currently executing script.
-         * Notatka: If a script is executed with the CLI, as a relative path, such as file.php or ../file.php,
-         * $_SERVER['SCRIPT_FILENAME'] will contain the relative path specified by the user.
-         */
-        if (isset($_SERVER['SCRIPT_FILENAME'])) {
-            $sRealPath = dirname($_SERVER['SCRIPT_FILENAME']);
-        }
-        else {
-            /**
-             * realpath — Returns canonicalized absolute pathname
-             */
-            $sRealPath = realpath( './' ) ;
-        }
-
-        /**
-         * The filename of the currently executing script, relative to the document root.
-         * For instance, $_SERVER['PHP_SELF'] in a script at the address http://example.com/test.php/foo.bar
-         * would be /test.php/foo.bar.
-         */
-        $sSelfPath = dirname($_SERVER['PHP_SELF']);
-
-        return substr($sRealPath, 0, strlen($sRealPath) - strlen($sSelfPath));
-    }
-
-    /**
-     * Create directory recursively
-     *
-     * @static
-     * @access public
-     * @param string $dir
-     * @param int $mode
-     * @return boolean
-     */
-    function createDirectoryRecursively($dir)
-    {
-        if (is_dir($dir)) {
-            return true;
-        }
-
-        //attempt to create directory
-        $_config =& CKFinder_Connector_Core_Factory::getInstance("Core_Config");
-        if ($perms = $_config->getChmodFolders()) {
-            $oldUmask = umask(0);
-            $bCreated = @mkdir($dir, $perms);
-            umask($oldUmask);
-        }
-        else {
-            $bCreated = @mkdir($dir);
-        }
-
-        if ($bCreated) {
-            return true;
-        }
-
-        //failed to create directory, perhaps we need to create parent directories first
-        if (!CKFinder_Connector_Utils_FileSystem::createDirectoryRecursively(dirname($dir))) {
-            return false;
-        }
-
-        //parent directories created successfully, let's try to create directory once again
-        if ($perms) {
-            $old_umask = umask(0);
-            $result = @mkdir($dir, $perms);
-            umask($old_umask);
-        }
-        else {
-            $result = @mkdir($dir);
-        }
-
-        return $result;
-    }
-
-    /**
-     * Detect HTML in the first KB to prevent against potential security issue with
-     * IE/Safari/Opera file type auto detection bug.
-     * Returns true if file contain insecure HTML code at the beginning.
-     *
-     * @static
-     * @access public
-     * @param string $filePath absolute path to file
-     * @return boolean
-    */
-    function detectHtml($filePath)
-    {
-        $fp = @fopen($filePath, 'rb');
-        if ( $fp === false || !flock( $fp, LOCK_SH ) ) {
-            return -1 ;
-        }
-        $chunk = fread($fp, 1024);
-        flock( $fp, LOCK_UN ) ;
-        fclose($fp);
-
-        $chunk = strtolower($chunk);
-
-        if (!$chunk) {
-            return false;
-        }
-
-        $chunk = trim($chunk);
-
-        if (preg_match("/<!DOCTYPE\W*X?HTML/sim", $chunk)) {
-            return true;
-        }
-
-        $tags = array('<body', '<head', '<html', '<img', '<pre', '<script', '<table', '<title');
-
-        foreach( $tags as $tag ) {
-            if(false !== strpos($chunk, $tag)) {
-                return true ;
-            }
-        }
-
-        //type = javascript
-        if (preg_match('!type\s*=\s*[\'"]?\s*(?:\w*/)?(?:ecma|java)!sim', $chunk)) {
-            return true ;
-        }
-
-        //href = javascript
-        //src = javascript
-        //data = javascript
-        if (preg_match('!(?:href|src|data)\s*=\s*[\'"]?\s*(?:ecma|java)script:!sim',$chunk)) {
-            return true ;
-        }
-
-        //url(javascript
-        if (preg_match('!url\s*\(\s*[\'"]?\s*(?:ecma|java)script:!sim', $chunk)) {
-            return true ;
-        }
-
-        return false ;
-    }
-
-    /**
-     * Check file content.
-     * Currently this function validates only image files.
-     * Returns false if file is invalid.
-     *
-     * @static
-     * @access public
-     * @param string $filePath absolute path to file
-     * @param string $extension file extension
-     * @param integer $detectionLevel 0 = none, 1 = use getimagesize for images, 2 = use DetectHtml for images
-     * @return boolean
-    */
-    function isImageValid($filePath, $extension)
-    {
-        if (!@is_readable($filePath)) {
-            return -1;
-        }
-
-        $imageCheckExtensions = array('gif', 'jpeg', 'jpg', 'png', 'psd', 'bmp', 'tiff');
-
-        // version_compare is available since PHP4 >= 4.0.7
-        if ( function_exists( 'version_compare' ) ) {
-            $sCurrentVersion = phpversion();
-            if ( version_compare( $sCurrentVersion, "4.2.0" ) >= 0 ) {
-                $imageCheckExtensions[] = "tiff";
-                $imageCheckExtensions[] = "tif";
-            }
-            if ( version_compare( $sCurrentVersion, "4.3.0" ) >= 0 ) {
-                $imageCheckExtensions[] = "swc";
-            }
-            if ( version_compare( $sCurrentVersion, "4.3.2" ) >= 0 ) {
-                $imageCheckExtensions[] = "jpc";
-                $imageCheckExtensions[] = "jp2";
-                $imageCheckExtensions[] = "jpx";
-                $imageCheckExtensions[] = "jb2";
-                $imageCheckExtensions[] = "xbm";
-                $imageCheckExtensions[] = "wbmp";
-            }
-        }
-
-        if ( !in_array( $extension, $imageCheckExtensions ) ) {
-            return true;
-        }
-
-        if ( @getimagesize( $filePath ) === false ) {
-            return false ;
-        }
-
-        return true;
-    }
-
-    /**
-     * Returns true if directory is not empty
-     *
-     * @access public
-     * @static
-     * @param string $serverPath
-     * @return boolean
-     */
-    function hasChildren($serverPath)
-    {
-        if (!is_dir($serverPath) || (false === $fh = @opendir($serverPath))) {
-            return false;
-        }
-
-        $hasChildren = false;
-        while (false !== ($filename = readdir($fh))) {
-            if ($filename == '.' || $filename == '..') {
-                continue;
-            } else if (is_dir($serverPath . DIRECTORY_SEPARATOR . $filename)) {
-                //we have found valid directory
-                $hasChildren = true;
-                break;
-            }
-        }
-
-        closedir($fh);
-
-        return $hasChildren;
-    }
+			);
+		}
+		$str = str_replace(
+				array_keys($UTF8_UPPER_ACCENTS),
+				array_values($UTF8_UPPER_ACCENTS),
+				$str
+			);
+		return $str;
+	}
+
+	/**
+	 * Convert file name from UTF-8 to system encoding
+	 *
+	 * @static
+	 * @access public
+	 * @param string $fileName
+	 * @return string
+	 */
+	function convertToFilesystemEncoding($fileName)
+	{
+		$_config =& CKFinder_Connector_Core_Factory::getInstance("Core_Config");
+		$encoding = $_config->getFilesystemEncoding();
+		if (is_null($encoding) || strcasecmp($encoding, "UTF-8") == 0 || strcasecmp($encoding, "UTF8") == 0) {
+			return $fileName;
+		}
+
+		if (!function_exists("iconv")) {
+			if (strcasecmp($encoding, "ISO-8859-1") == 0 || strcasecmp($encoding, "ISO8859-1") == 0 || strcasecmp($encoding, "Latin1") == 0) {
+				return str_replace("\0", "_", utf8_decode($fileName));
+			} else if (function_exists('mb_convert_encoding')) {
+
+				$encoded = @mb_convert_encoding($fileName, $encoding, 'UTF-8');
+				if (@mb_strlen($fileName, "UTF-8") != @mb_strlen($encoded, $encoding)) {
+					return str_replace("\0", "_", preg_replace("/[^[:ascii:]]/u","_",$fileName));
+				}
+				else {
+					return str_replace("\0", "_", $encoded);
+				}
+			} else {
+				return str_replace("\0", "_", preg_replace("/[^[:ascii:]]/u","_",$fileName));
+			}
+		}
+
+		$converted = @iconv("UTF-8", $encoding . "//IGNORE//TRANSLIT", $fileName);
+		if ($converted === false) {
+			return str_replace("\0", "_", preg_replace("/[^[:ascii:]]/u","_",$fileName));
+		}
+
+		return $converted;
+	}
+
+	/**
+	 * Convert file name from system encoding into UTF-8
+	 *
+	 * @static
+	 * @access public
+	 * @param string $fileName
+	 * @return string
+	 */
+	function convertToConnectorEncoding($fileName)
+	{
+		$_config =& CKFinder_Connector_Core_Factory::getInstance("Core_Config");
+		$encoding = $_config->getFilesystemEncoding();
+		if (is_null($encoding) || strcasecmp($encoding, "UTF-8") == 0 || strcasecmp($encoding, "UTF8") == 0) {
+			return $fileName;
+		}
+
+		if (!function_exists("iconv")) {
+			if (strcasecmp($encoding, "ISO-8859-1") == 0 || strcasecmp($encoding, "ISO8859-1") == 0 || strcasecmp($encoding, "Latin1") == 0) {
+				return utf8_encode($fileName);
+			} else {
+				return $fileName;
+			}
+		}
+
+		$converted = @iconv($encoding, "UTF-8", $fileName);
+
+		if ($converted === false) {
+			return $fileName;
+		}
+
+		return $converted;
+	}
+
+	/**
+	 * Find document root
+	 *
+	 * @return string
+	 * @access public
+	 */
+	function getDocumentRootPath()
+	{
+		/**
+		 * The absolute pathname of the currently executing script.
+		 * Notatka: If a script is executed with the CLI, as a relative path, such as file.php or ../file.php,
+		 * $_SERVER['SCRIPT_FILENAME'] will contain the relative path specified by the user.
+		 */
+		if (isset($_SERVER['SCRIPT_FILENAME'])) {
+			$sRealPath = dirname($_SERVER['SCRIPT_FILENAME']);
+		}
+		else {
+			/**
+			 * realpath — Returns canonicalized absolute pathname
+			 */
+			$sRealPath = realpath( './' ) ;
+		}
+
+		/**
+		 * The filename of the currently executing script, relative to the document root.
+		 * For instance, $_SERVER['PHP_SELF'] in a script at the address http://example.com/test.php/foo.bar
+		 * would be /test.php/foo.bar.
+		 */
+		$sSelfPath = dirname($_SERVER['PHP_SELF']);
+
+		return substr($sRealPath, 0, strlen($sRealPath) - strlen($sSelfPath));
+	}
+
+	/**
+	 * Create directory recursively
+	 *
+	 * @static
+	 * @access public
+	 * @param string $dir
+	 * @param int $mode
+	 * @return boolean
+	 */
+	function createDirectoryRecursively($dir)
+	{
+		if (is_dir($dir)) {
+			return true;
+		}
+
+		//attempt to create directory
+		$_config =& CKFinder_Connector_Core_Factory::getInstance("Core_Config");
+		if ($perms = $_config->getChmodFolders()) {
+			$oldUmask = umask(0);
+			$bCreated = @mkdir($dir, $perms);
+			umask($oldUmask);
+		}
+		else {
+			$bCreated = @mkdir($dir);
+		}
+
+		if ($bCreated) {
+			return true;
+		}
+
+		//failed to create directory, perhaps we need to create parent directories first
+		if (!CKFinder_Connector_Utils_FileSystem::createDirectoryRecursively(dirname($dir))) {
+			return false;
+		}
+
+		//parent directories created successfully, let's try to create directory once again
+		if ($perms) {
+			$old_umask = umask(0);
+			$result = @mkdir($dir, $perms);
+			umask($old_umask);
+		}
+		else {
+			$result = @mkdir($dir);
+		}
+
+		return $result;
+	}
+
+	/**
+	 * Detect HTML in the first KB to prevent against potential security issue with
+	 * IE/Safari/Opera file type auto detection bug.
+	 * Returns true if file contain insecure HTML code at the beginning.
+	 *
+	 * @static
+	 * @access public
+	 * @param string $filePath absolute path to file
+	 * @return boolean
+	 */
+	function detectHtml($filePath)
+	{
+		$fp = @fopen($filePath, 'rb');
+		if ( $fp === false || !flock( $fp, LOCK_SH ) ) {
+			return -1 ;
+		}
+		$chunk = fread($fp, 1024);
+		flock( $fp, LOCK_UN ) ;
+		fclose($fp);
+
+		$chunk = strtolower($chunk);
+
+		if (!$chunk) {
+			return false;
+		}
+
+		$chunk = trim($chunk);
+
+		if (preg_match("/<!DOCTYPE\W*X?HTML/sim", $chunk)) {
+			return true;
+		}
+
+		$tags = array('<body', '<head', '<html', '<img', '<pre', '<script', '<table', '<title');
+
+		foreach( $tags as $tag ) {
+			if(false !== strpos($chunk, $tag)) {
+				return true ;
+			}
+		}
+
+		//type = javascript
+		if (preg_match('!type\s*=\s*[\'"]?\s*(?:\w*/)?(?:ecma|java)!sim', $chunk)) {
+			return true ;
+		}
+
+		//href = javascript
+		//src = javascript
+		//data = javascript
+		if (preg_match('!(?:href|src|data)\s*=\s*[\'"]?\s*(?:ecma|java)script:!sim',$chunk)) {
+			return true ;
+		}
+
+		//url(javascript
+		if (preg_match('!url\s*\(\s*[\'"]?\s*(?:ecma|java)script:!sim', $chunk)) {
+			return true ;
+		}
+
+		return false ;
+	}
+
+	/**
+	 * Check file content.
+	 * Currently this function validates only image files.
+	 * Returns false if file is invalid.
+	 *
+	 * @static
+	 * @access public
+	 * @param string $filePath absolute path to file
+	 * @param string $extension file extension
+	 * @param integer $detectionLevel 0 = none, 1 = use getimagesize for images, 2 = use DetectHtml for images
+	 * @return boolean
+	 */
+	function isImageValid($filePath, $extension)
+	{
+		if (!@is_readable($filePath)) {
+			return -1;
+		}
+
+		$imageCheckExtensions = array('gif', 'jpeg', 'jpg', 'png', 'psd', 'bmp', 'tiff');
+
+		// version_compare is available since PHP4 >= 4.0.7
+		if ( function_exists( 'version_compare' ) ) {
+			$sCurrentVersion = phpversion();
+			if ( version_compare( $sCurrentVersion, "4.2.0" ) >= 0 ) {
+				$imageCheckExtensions[] = "tiff";
+				$imageCheckExtensions[] = "tif";
+			}
+			if ( version_compare( $sCurrentVersion, "4.3.0" ) >= 0 ) {
+				$imageCheckExtensions[] = "swc";
+			}
+			if ( version_compare( $sCurrentVersion, "4.3.2" ) >= 0 ) {
+				$imageCheckExtensions[] = "jpc";
+				$imageCheckExtensions[] = "jp2";
+				$imageCheckExtensions[] = "jpx";
+				$imageCheckExtensions[] = "jb2";
+				$imageCheckExtensions[] = "xbm";
+				$imageCheckExtensions[] = "wbmp";
+			}
+		}
+
+		if ( !in_array( $extension, $imageCheckExtensions ) ) {
+			return true;
+		}
+
+		if ( @getimagesize( $filePath ) === false ) {
+			return false ;
+		}
+
+		return true;
+	}
+
+	/**
+	 * Returns true if directory is not empty
+	 *
+	 * @access public
+	 * @static
+	 * @param string $serverPath
+	 * @return boolean
+	 */
+	function hasChildren($serverPath)
+	{
+		if (!is_dir($serverPath) || (false === $fh = @opendir($serverPath))) {
+			return false;
+		}
+
+		$hasChildren = false;
+		while (false !== ($filename = readdir($fh))) {
+			if ($filename == '.' || $filename == '..') {
+				continue;
+			} else if (is_dir($serverPath . DIRECTORY_SEPARATOR . $filename)) {
+				//we have found valid directory
+				$hasChildren = true;
+				break;
+			}
+		}
+
+		closedir($fh);
+
+		return $hasChildren;
+	}
 }

Spacing +44 added lines, -44 removed lines

@@ -37,10 +37,10 @@ 
      */
     function combinePaths($path1, $path2)
     {
-        if (is_null($path1))  {
+        if (is_null($path1)) {
             $path1 = "";
         }
-        if (is_null($path2))  {
+        if (is_null($path2)) {
             $path2 = "";
         }
         if (!strlen($path2)) {
@@ -54,7 +54,7 @@ 
         else {
             $_firstCharP2 = substr($path2, 0, 1);
             if (strlen($path1)) {
-                if (strpos($path2, $path1)===0) {
+                if (strpos($path2, $path1) === 0) {
                     return $path2;
                 }
                 $_lastCharP1 = substr($path1, -1, 1);
@@ -66,7 +66,7 @@ 
                 return $path2;
             }
         }
-        return $path1 . $path2;
+        return $path1.$path2;
     }
 
     /**
@@ -79,7 +79,7 @@ 
      */
     function checkFileName($fileName)
     {
-        if (is_null($fileName) || !strlen($fileName) || substr($fileName,-1,1)=="." || false!==strpos($fileName, "..")) {
+        if (is_null($fileName) || !strlen($fileName) || substr($fileName, -1, 1) == "." || false !== strpos($fileName, "..")) {
             return false;
         }
 
@@ -101,30 +101,30 @@ 
     function unlink($path)
     {
         /*    make sure the path exists    */
-        if(!file_exists($path)) {
+        if (!file_exists($path)) {
             return false;
         }
 
         /*    If it is a file or link, just delete it    */
-        if(is_file($path) || is_link($path)) {
+        if (is_file($path) || is_link($path)) {
             return @unlink($path);
         }
 
         /*    Scan the dir and recursively unlink    */
         $files = CKFinder_Connector_Utils_FileSystem::php4_scandir($path);
         if ($files) {
-            foreach($files as $filename)
+            foreach ($files as $filename)
             {
                 if ($filename == '.' || $filename == '..') {
                     continue;
                 }
-                $file = str_replace('//','/',$path.'/'.$filename);
+                $file = str_replace('//', '/', $path.'/'.$filename);
                 CKFinder_Connector_Utils_FileSystem::unlink($file);
             }
         }
 
         /*    Remove the parent dir    */
-        if(!@rmdir($path)) {
+        if (!@rmdir($path)) {
             return false;
         }
 
@@ -143,7 +143,7 @@ 
             return false;
         }
 
-        $files = array ();
+        $files = array();
         while (false !== ($filename = readdir($fh))) {
             $files[] = $filename;
         }
@@ -163,7 +163,7 @@ 
      */
     function getFileNameWithoutExtension($fileName)
     {
-        $dotPos = strrpos( $fileName, '.' );
+        $dotPos = strrpos($fileName, '.');
         if (false === $dotPos) {
             return $fileName;
         }
@@ -179,14 +179,14 @@ 
      * @param string $fileName
      * @return string
      */
-    function getExtension( $fileName )
+    function getExtension($fileName)
     {
-        $dotPos = strrpos( $fileName, '.' );
+        $dotPos = strrpos($fileName, '.');
         if (false === $dotPos) {
             return "";
         }
 
-        return substr( $fileName, strrpos( $fileName, '.' ) +1 ) ;
+        return substr($fileName, strrpos($fileName, '.') + 1);
     }
 
     /**
@@ -238,7 +238,7 @@ 
         static $UTF8_LOWER_ACCENTS = NULL;
         static $UTF8_UPPER_ACCENTS = NULL;
 
-        if ( is_null($UTF8_LOWER_ACCENTS) ) {
+        if (is_null($UTF8_LOWER_ACCENTS)) {
             $UTF8_LOWER_ACCENTS = array(
   'à' => 'a', 'ô' => 'o', 'ď' => 'd', 'ḟ' => 'f', 'ë' => 'e', 'š' => 's', 'ơ' => 'o',
   'ß' => 'ss', 'ă' => 'a', 'ř' => 'r', 'ț' => 't', 'ň' => 'n', 'ā' => 'a', 'ķ' => 'k',
@@ -264,7 +264,7 @@ 
                 $str
             );
 
-        if ( is_null($UTF8_UPPER_ACCENTS) ) {
+        if (is_null($UTF8_UPPER_ACCENTS)) {
             $UTF8_UPPER_ACCENTS = array(
   'À' => 'A', 'Ô' => 'O', 'Ď' => 'D', 'Ḟ' => 'F', 'Ë' => 'E', 'Š' => 'S', 'Ơ' => 'O',
   'Ă' => 'A', 'Ř' => 'R', 'Ț' => 'T', 'Ň' => 'N', 'Ā' => 'A', 'Ķ' => 'K',
@@ -301,7 +301,7 @@ 
      */
     function convertToFilesystemEncoding($fileName)
     {
-        $_config =& CKFinder_Connector_Core_Factory::getInstance("Core_Config");
+        $_config = & CKFinder_Connector_Core_Factory::getInstance("Core_Config");
         $encoding = $_config->getFilesystemEncoding();
         if (is_null($encoding) || strcasecmp($encoding, "UTF-8") == 0 || strcasecmp($encoding, "UTF8") == 0) {
             return $fileName;
@@ -314,19 +314,19 @@ 
 
                 $encoded = @mb_convert_encoding($fileName, $encoding, 'UTF-8');
                 if (@mb_strlen($fileName, "UTF-8") != @mb_strlen($encoded, $encoding)) {
-                    return str_replace("\0", "_", preg_replace("/[^[:ascii:]]/u","_",$fileName));
+                    return str_replace("\0", "_", preg_replace("/[^[:ascii:]]/u", "_", $fileName));
                 }
                 else {
                     return str_replace("\0", "_", $encoded);
                 }
             } else {
-                return str_replace("\0", "_", preg_replace("/[^[:ascii:]]/u","_",$fileName));
+                return str_replace("\0", "_", preg_replace("/[^[:ascii:]]/u", "_", $fileName));
             }
         }
 
-        $converted = @iconv("UTF-8", $encoding . "//IGNORE//TRANSLIT", $fileName);
+        $converted = @iconv("UTF-8", $encoding."//IGNORE//TRANSLIT", $fileName);
         if ($converted === false) {
-            return str_replace("\0", "_", preg_replace("/[^[:ascii:]]/u","_",$fileName));
+            return str_replace("\0", "_", preg_replace("/[^[:ascii:]]/u", "_", $fileName));
         }
 
         return $converted;
@@ -342,7 +342,7 @@ 
      */
     function convertToConnectorEncoding($fileName)
     {
-        $_config =& CKFinder_Connector_Core_Factory::getInstance("Core_Config");
+        $_config = & CKFinder_Connector_Core_Factory::getInstance("Core_Config");
         $encoding = $_config->getFilesystemEncoding();
         if (is_null($encoding) || strcasecmp($encoding, "UTF-8") == 0 || strcasecmp($encoding, "UTF8") == 0) {
             return $fileName;
@@ -385,7 +385,7 @@ 
             /**
              * realpath — Returns canonicalized absolute pathname
              */
-            $sRealPath = realpath( './' ) ;
+            $sRealPath = realpath('./');
         }
 
         /**
@@ -414,7 +414,7 @@ 
         }
 
         //attempt to create directory
-        $_config =& CKFinder_Connector_Core_Factory::getInstance("Core_Config");
+        $_config = & CKFinder_Connector_Core_Factory::getInstance("Core_Config");
         if ($perms = $_config->getChmodFolders()) {
             $oldUmask = umask(0);
             $bCreated = @mkdir($dir, $perms);
@@ -459,11 +459,11 @@ 
     function detectHtml($filePath)
     {
         $fp = @fopen($filePath, 'rb');
-        if ( $fp === false || !flock( $fp, LOCK_SH ) ) {
-            return -1 ;
+        if ($fp === false || !flock($fp, LOCK_SH)) {
+            return -1;
         }
         $chunk = fread($fp, 1024);
-        flock( $fp, LOCK_UN ) ;
+        flock($fp, LOCK_UN);
         fclose($fp);
 
         $chunk = strtolower($chunk);
@@ -480,30 +480,30 @@ 
 
         $tags = array('<body', '<head', '<html', '<img', '<pre', '<script', '<table', '<title');
 
-        foreach( $tags as $tag ) {
-            if(false !== strpos($chunk, $tag)) {
-                return true ;
+        foreach ($tags as $tag) {
+            if (false !== strpos($chunk, $tag)) {
+                return true;
             }
         }
 
         //type = javascript
         if (preg_match('!type\s*=\s*[\'"]?\s*(?:\w*/)?(?:ecma|java)!sim', $chunk)) {
-            return true ;
+            return true;
         }
 
         //href = javascript
         //src = javascript
         //data = javascript
-        if (preg_match('!(?:href|src|data)\s*=\s*[\'"]?\s*(?:ecma|java)script:!sim',$chunk)) {
-            return true ;
+        if (preg_match('!(?:href|src|data)\s*=\s*[\'"]?\s*(?:ecma|java)script:!sim', $chunk)) {
+            return true;
         }
 
         //url(javascript
         if (preg_match('!url\s*\(\s*[\'"]?\s*(?:ecma|java)script:!sim', $chunk)) {
-            return true ;
+            return true;
         }
 
-        return false ;
+        return false;
     }
 
     /**
@@ -527,16 +527,16 @@ 
         $imageCheckExtensions = array('gif', 'jpeg', 'jpg', 'png', 'psd', 'bmp', 'tiff');
 
         // version_compare is available since PHP4 >= 4.0.7
-        if ( function_exists( 'version_compare' ) ) {
+        if (function_exists('version_compare')) {
             $sCurrentVersion = phpversion();
-            if ( version_compare( $sCurrentVersion, "4.2.0" ) >= 0 ) {
+            if (version_compare($sCurrentVersion, "4.2.0") >= 0) {
                 $imageCheckExtensions[] = "tiff";
                 $imageCheckExtensions[] = "tif";
             }
-            if ( version_compare( $sCurrentVersion, "4.3.0" ) >= 0 ) {
+            if (version_compare($sCurrentVersion, "4.3.0") >= 0) {
                 $imageCheckExtensions[] = "swc";
             }
-            if ( version_compare( $sCurrentVersion, "4.3.2" ) >= 0 ) {
+            if (version_compare($sCurrentVersion, "4.3.2") >= 0) {
                 $imageCheckExtensions[] = "jpc";
                 $imageCheckExtensions[] = "jp2";
                 $imageCheckExtensions[] = "jpx";
@@ -546,12 +546,12 @@ 
             }
         }
 
-        if ( !in_array( $extension, $imageCheckExtensions ) ) {
+        if (!in_array($extension, $imageCheckExtensions)) {
             return true;
         }
 
-        if ( @getimagesize( $filePath ) === false ) {
-            return false ;
+        if (@getimagesize($filePath) === false) {
+            return false;
         }
 
         return true;
@@ -575,7 +575,7 @@ 
         while (false !== ($filename = readdir($fh))) {
             if ($filename == '.' || $filename == '..') {
                 continue;
-            } else if (is_dir($serverPath . DIRECTORY_SEPARATOR . $filename)) {
+            } else if (is_dir($serverPath.DIRECTORY_SEPARATOR.$filename)) {
                 //we have found valid directory
                 $hasChildren = true;
                 break;

Braces +9 added lines, -13 removed lines

@@ -10,7 +10,9 @@ 
 * modifying or distribute this file or part of its contents. The contents of
 * this file is part of the Source Code of CKFinder.
 */
-if (!defined('IN_CKFINDER')) exit;
+if (!defined('IN_CKFINDER')) {
+	exit;
+}
 
 /**
  * @package CKFinder
@@ -50,8 +52,7 @@ 
                     $path1 .= DIRECTORY_SEPARATOR;
                 }
             }
-        }
-        else {
+        } else {
             $_firstCharP2 = substr($path2, 0, 1);
             if (strlen($path1)) {
                 if (strpos($path2, $path1)===0) {
@@ -61,8 +62,7 @@ 
                 if ($_lastCharP1 != "/" && $_lastCharP1 != "\\" && $_firstCharP2 != "/" && $_firstCharP2 != "\\") {
                     $path1 .= DIRECTORY_SEPARATOR;
                 }
-            }
-            else {
+            } else {
                 return $path2;
             }
         }
@@ -315,8 +315,7 @@ 
                 $encoded = @mb_convert_encoding($fileName, $encoding, 'UTF-8');
                 if (@mb_strlen($fileName, "UTF-8") != @mb_strlen($encoded, $encoding)) {
                     return str_replace("\0", "_", preg_replace("/[^[:ascii:]]/u","_",$fileName));
-                }
-                else {
+                } else {
                     return str_replace("\0", "_", $encoded);
                 }
             } else {
@@ -380,8 +379,7 @@ 
          */
         if (isset($_SERVER['SCRIPT_FILENAME'])) {
             $sRealPath = dirname($_SERVER['SCRIPT_FILENAME']);
-        }
-        else {
+        } else {
             /**
              * realpath — Returns canonicalized absolute pathname
              */
@@ -419,8 +417,7 @@ 
             $oldUmask = umask(0);
             $bCreated = @mkdir($dir, $perms);
             umask($oldUmask);
-        }
-        else {
+        } else {
             $bCreated = @mkdir($dir);
         }
 
@@ -438,8 +435,7 @@ 
             $old_umask = umask(0);
             $result = @mkdir($dir, $perms);
             umask($old_umask);
-        }
-        else {
+        } else {
             $result = @mkdir($dir);
         }
 

libs/ckfinder/core/connector/php/php4/Utils/Misc.php

Doc Comments +3 added lines, -1 removed lines

@@ -25,6 +25,9 @@ 
  */
 class CKFinder_Connector_Utils_Misc
 {
+    /**
+     * @param integer $number
+     */
     function getErrorMessage($number, $arg = "") {
         $langCode = 'en';
         if (!empty($_GET['langCode']) && preg_match("/^[a-z\-]+$/", $_GET['langCode'])) {
@@ -113,7 +116,6 @@ 
      *
      * @static
      * @access public
-     * @param string $filename
      * @return boolean
      */
     function setMemoryForImage($imageWidth, $imageHeight, $imageBits, $imageChannels)

Indentation +341 added lines, -341 removed lines

@@ -25,345 +25,345 @@
  */
 class CKFinder_Connector_Utils_Misc
 {
-    function getErrorMessage($number, $arg = "") {
-        $langCode = 'en';
-        if (!empty($_GET['langCode']) && preg_match("/^[a-z\-]+$/", $_GET['langCode'])) {
-            if (file_exists(CKFINDER_CONNECTOR_LANG_PATH . "/" . $_GET['langCode'] . ".php"))
-                $langCode = $_GET['langCode'];
-        }
-        include CKFINDER_CONNECTOR_LANG_PATH . "/" . $langCode . ".php";
-        if ($number) {
-            if (!empty ($GLOBALS['CKFLang']['Errors'][$number])) {
-                $errorMessage = str_replace("%1", $arg, $GLOBALS['CKFLang']['Errors'][$number]);
-            } else {
-                $errorMessage = str_replace("%1", $number, $GLOBALS['CKFLang']['ErrorUnknown']);
-            }
-        } else {
-            $errorMessage = "";
-        }
-        return $errorMessage;
-    }
-
-    /**
-     * Convert any value to boolean, strings like "false", "FalSE" and "off" are also considered as false
-     *
-     * @static
-     * @access public
-     * @param mixed $value
-     * @return boolean
-     */
-    function booleanValue($value)
-    {
-        if (strcasecmp("false", $value) == 0 || strcasecmp("off", $value) == 0 || !$value) {
-            return false;
-        } else {
-            return true;
-        }
-    }
-
-    /**
-     * @link http://pl.php.net/manual/en/function.imagecopyresampled.php
-     * replacement to imagecopyresampled that will deliver results that are almost identical except MUCH faster (very typically 30 times faster)
-     *
-     * @static
-     * @access public
-     * @param string $dst_image
-     * @param string $src_image
-     * @param int $dst_x
-     * @param int $dst_y
-     * @param int $src_x
-     * @param int $src_y
-     * @param int $dst_w
-     * @param int $dst_h
-     * @param int $src_w
-     * @param int $src_h
-     * @param int $quality
-     * @return boolean
-     */
-    function fastImageCopyResampled (&$dst_image, $src_image, $dst_x, $dst_y, $src_x, $src_y, $dst_w, $dst_h, $src_w, $src_h, $quality = 3)
-    {
-        if (empty($src_image) || empty($dst_image)) {
-            return false;
-        }
-
-        if ($quality <= 1) {
-            $temp = imagecreatetruecolor ($dst_w + 1, $dst_h + 1);
-            imagecopyresized ($temp, $src_image, $dst_x, $dst_y, $src_x, $src_y, $dst_w + 1, $dst_h + 1, $src_w, $src_h);
-            imagecopyresized ($dst_image, $temp, 0, 0, 0, 0, $dst_w, $dst_h, $dst_w, $dst_h);
-            imagedestroy ($temp);
-
-        } elseif ($quality < 5 && (($dst_w * $quality) < $src_w || ($dst_h * $quality) < $src_h)) {
-            $tmp_w = $dst_w * $quality;
-            $tmp_h = $dst_h * $quality;
-            $temp = imagecreatetruecolor ($tmp_w + 1, $tmp_h + 1);
-            imagecopyresized ($temp, $src_image, 0, 0, $src_x, $src_y, $tmp_w + 1, $tmp_h + 1, $src_w, $src_h);
-            imagecopyresampled ($dst_image, $temp, $dst_x, $dst_y, 0, 0, $dst_w, $dst_h, $tmp_w, $tmp_h);
-            imagedestroy ($temp);
-
-        } else {
-            imagecopyresampled ($dst_image, $src_image, $dst_x, $dst_y, $src_x, $src_y, $dst_w, $dst_h, $src_w, $src_h);
-        }
-
-        return true;
-    }
-
-    /**
-     * @link http://pl.php.net/manual/pl/function.imagecreatefromjpeg.php
-     * function posted by e dot a dot schultz at gmail dot com
-     *
-     * @static
-     * @access public
-     * @param string $filename
-     * @return boolean
-     */
-    function setMemoryForImage($imageWidth, $imageHeight, $imageBits, $imageChannels)
-    {
-        $MB = 1048576;  // number of bytes in 1M
-        $K64 = 65536;    // number of bytes in 64K
-        $TWEAKFACTOR = 2.4;  // Or whatever works for you
-        $memoryNeeded = round( ( $imageWidth * $imageHeight
-        * $imageBits
-        * $imageChannels / 8
-        + $K64
-        ) * $TWEAKFACTOR
-        ) + 3*$MB;
-
-        //ini_get('memory_limit') only works if compiled with "--enable-memory-limit" also
-        //Default memory limit is 8MB so well stick with that.
-        //To find out what yours is, view your php.ini file.
-        $memoryLimit = CKFinder_Connector_Utils_Misc::returnBytes(@ini_get('memory_limit'))/$MB;
-        if (!$memoryLimit) {
-            $memoryLimit = 8;
-        }
-
-        $memoryLimitMB = $memoryLimit * $MB;
-        if (function_exists('memory_get_usage')) {
-            if (memory_get_usage() + $memoryNeeded > $memoryLimitMB) {
-                $newLimit = $memoryLimit + ceil( ( memory_get_usage()
-                + $memoryNeeded
-                - $memoryLimitMB
-                ) / $MB
-                );
-                if (@ini_set( 'memory_limit', $newLimit . 'M' ) === false) {
-                    return false;
-                }
-            }
-        } else {
-            if ($memoryNeeded + 3*$MB > $memoryLimitMB) {
-                $newLimit = $memoryLimit + ceil(( 3*$MB
-                + $memoryNeeded
-                - $memoryLimitMB
-                ) / $MB
-                );
-                if (false === @ini_set( 'memory_limit', $newLimit . 'M' )) {
-                    return false;
-                }
-            }
-        }
-        return true;
-    }
-
-    /**
-     * convert shorthand php.ini notation into bytes, much like how the PHP source does it
-     * @link http://pl.php.net/manual/en/function.ini-get.php
-     *
-     * @static
-     * @access public
-     * @param string $val
-     * @return int
-     */
-    function returnBytes($val)
-    {
-        $val = trim($val);
-        if (!$val) {
-            return 0;
-        }
-        $last = strtolower($val[strlen($val)-1]);
-        switch($last) {
-            // The 'G' modifier is available since PHP 5.1.0
-            case 'g':
-                $val *= 1024;
-            case 'm':
-                $val *= 1024;
-            case 'k':
-                $val *= 1024;
-        }
-
-        return $val;
-    }
-
-    /**
-    * Checks if a value exists in an array (case insensitive)
-    *
-    * @static
-    * @access public
-    * @param string $needle
-    * @param array $haystack
-    * @return boolean
-    */
-    function inArrayCaseInsensitive($needle, $haystack)
-    {
-        if (!$haystack || !is_array($haystack)) {
-            return false;
-        }
-        $lcase = array();
-        foreach ($haystack as $key => $val) {
-            $lcase[$key] = strtolower($val);
-        }
-        return in_array($needle, $lcase);
-    }
-
-    /**
-    * UTF-8 compatible version of basename()
-    *
-    * @static
-    * @access public
-    * @param string $file
-    * @return string
-    */
-    function mbBasename($file)
-    {
-        $explode = explode('/', str_replace("\\", "/", $file));
-        return end($explode);
-    }
-
-    /**
-    * Source: http://pl.php.net/imagecreate
-    * (optimized for speed and memory usage, but yet not very efficient)
-    *
-    * @static
-    * @access public
-    * @param string $filename
-    * @return resource
-    */
-    function imageCreateFromBmp($filename)
-    {
-        //20 seconds seems to be a reasonable value to not kill a server and process images up to 1680x1050
-        @set_time_limit(20);
-
-        if (false === ($f1 = fopen($filename, "rb"))) {
-            return false;
-        }
-
-        $FILE = unpack("vfile_type/Vfile_size/Vreserved/Vbitmap_offset", fread($f1, 14));
-        if ($FILE['file_type'] != 19778) {
-            return false;
-        }
-
-        $BMP = unpack('Vheader_size/Vwidth/Vheight/vplanes/vbits_per_pixel'.
-        '/Vcompression/Vsize_bitmap/Vhoriz_resolution'.
-        '/Vvert_resolution/Vcolors_used/Vcolors_important', fread($f1, 40));
-
-        $BMP['colors'] = pow(2,$BMP['bits_per_pixel']);
-
-        if ($BMP['size_bitmap'] == 0) {
-            $BMP['size_bitmap'] = $FILE['file_size'] - $FILE['bitmap_offset'];
-        }
-
-        $BMP['bytes_per_pixel'] = $BMP['bits_per_pixel']/8;
-        $BMP['bytes_per_pixel2'] = ceil($BMP['bytes_per_pixel']);
-        $BMP['decal'] = ($BMP['width']*$BMP['bytes_per_pixel']/4);
-        $BMP['decal'] -= floor($BMP['width']*$BMP['bytes_per_pixel']/4);
-        $BMP['decal'] = 4-(4*$BMP['decal']);
-
-        if ($BMP['decal'] == 4) {
-            $BMP['decal'] = 0;
-        }
-
-        $PALETTE = array();
-        if ($BMP['colors'] < 16777216) {
-            $PALETTE = unpack('V'.$BMP['colors'], fread($f1, $BMP['colors']*4));
-        }
-
-        //2048x1536px@24bit don't even try to process larger files as it will probably fail
-        if ($BMP['size_bitmap'] > 3 * 2048 * 1536) {
-            return false;
-        }
-
-        $IMG = fread($f1, $BMP['size_bitmap']);
-        fclose($f1);
-        $VIDE = chr(0);
-
-        $res = imagecreatetruecolor($BMP['width'],$BMP['height']);
-        $P = 0;
-        $Y = $BMP['height']-1;
-
-        $line_length = $BMP['bytes_per_pixel']*$BMP['width'];
-
-        if ($BMP['bits_per_pixel'] == 24) {
-            while ($Y >= 0)
-            {
-                $X=0;
-                $temp = unpack( "C*", substr($IMG, $P, $line_length));
-
-                while ($X < $BMP['width'])
-                {
-                    $offset = $X*3;
-                    imagesetpixel($res, $X++, $Y, ($temp[$offset+3] << 16) + ($temp[$offset+2] << 8) + $temp[$offset+1]);
-                }
-                $Y--;
-                $P += $line_length + $BMP['decal'];
-            }
-        }
-        elseif ($BMP['bits_per_pixel'] == 8)
-        {
-            while ($Y >= 0)
-            {
-                $X=0;
-
-                $temp = unpack( "C*", substr($IMG, $P, $line_length));
-
-                while ($X < $BMP['width'])
-                {
-                    imagesetpixel($res, $X++, $Y, $PALETTE[$temp[$X] +1]);
-                }
-                $Y--;
-                $P += $line_length + $BMP['decal'];
-            }
-        }
-        elseif ($BMP['bits_per_pixel'] == 4)
-        {
-            while ($Y >= 0)
-            {
-                $X=0;
-                $i = 1;
-                $low = true;
-
-                $temp = unpack( "C*", substr($IMG, $P, $line_length));
-
-                while ($X < $BMP['width'])
-                {
-                    if ($low) {
-                        $index = $temp[$i] >> 4;
-                    }
-                    else {
-                        $index = $temp[$i++] & 0x0F;
-                    }
-                    $low = !$low;
-
-                    imagesetpixel($res, $X++, $Y, $PALETTE[$index +1]);
-                }
-                $Y--;
-                $P += $line_length + $BMP['decal'];
-            }
-        }
-        elseif ($BMP['bits_per_pixel'] == 1)
-        {
-            $COLOR = unpack("n",$VIDE.substr($IMG,floor($P),1));
-            if     (($P*8)%8 == 0) $COLOR[1] =  $COLOR[1]        >>7;
-            elseif (($P*8)%8 == 1) $COLOR[1] = ($COLOR[1] & 0x40)>>6;
-            elseif (($P*8)%8 == 2) $COLOR[1] = ($COLOR[1] & 0x20)>>5;
-            elseif (($P*8)%8 == 3) $COLOR[1] = ($COLOR[1] & 0x10)>>4;
-            elseif (($P*8)%8 == 4) $COLOR[1] = ($COLOR[1] & 0x8)>>3;
-            elseif (($P*8)%8 == 5) $COLOR[1] = ($COLOR[1] & 0x4)>>2;
-            elseif (($P*8)%8 == 6) $COLOR[1] = ($COLOR[1] & 0x2)>>1;
-            elseif (($P*8)%8 == 7) $COLOR[1] = ($COLOR[1] & 0x1);
-            $COLOR[1] = $PALETTE[$COLOR[1]+1];
-        }
-        else {
-            return false;
-        }
-
-        return $res;
-    }
+	function getErrorMessage($number, $arg = "") {
+		$langCode = 'en';
+		if (!empty($_GET['langCode']) && preg_match("/^[a-z\-]+$/", $_GET['langCode'])) {
+			if (file_exists(CKFINDER_CONNECTOR_LANG_PATH . "/" . $_GET['langCode'] . ".php"))
+				$langCode = $_GET['langCode'];
+		}
+		include CKFINDER_CONNECTOR_LANG_PATH . "/" . $langCode . ".php";
+		if ($number) {
+			if (!empty ($GLOBALS['CKFLang']['Errors'][$number])) {
+				$errorMessage = str_replace("%1", $arg, $GLOBALS['CKFLang']['Errors'][$number]);
+			} else {
+				$errorMessage = str_replace("%1", $number, $GLOBALS['CKFLang']['ErrorUnknown']);
+			}
+		} else {
+			$errorMessage = "";
+		}
+		return $errorMessage;
+	}
+
+	/**
+	 * Convert any value to boolean, strings like "false", "FalSE" and "off" are also considered as false
+	 *
+	 * @static
+	 * @access public
+	 * @param mixed $value
+	 * @return boolean
+	 */
+	function booleanValue($value)
+	{
+		if (strcasecmp("false", $value) == 0 || strcasecmp("off", $value) == 0 || !$value) {
+			return false;
+		} else {
+			return true;
+		}
+	}
+
+	/**
+	 * @link http://pl.php.net/manual/en/function.imagecopyresampled.php
+	 * replacement to imagecopyresampled that will deliver results that are almost identical except MUCH faster (very typically 30 times faster)
+	 *
+	 * @static
+	 * @access public
+	 * @param string $dst_image
+	 * @param string $src_image
+	 * @param int $dst_x
+	 * @param int $dst_y
+	 * @param int $src_x
+	 * @param int $src_y
+	 * @param int $dst_w
+	 * @param int $dst_h
+	 * @param int $src_w
+	 * @param int $src_h
+	 * @param int $quality
+	 * @return boolean
+	 */
+	function fastImageCopyResampled (&$dst_image, $src_image, $dst_x, $dst_y, $src_x, $src_y, $dst_w, $dst_h, $src_w, $src_h, $quality = 3)
+	{
+		if (empty($src_image) || empty($dst_image)) {
+			return false;
+		}
+
+		if ($quality <= 1) {
+			$temp = imagecreatetruecolor ($dst_w + 1, $dst_h + 1);
+			imagecopyresized ($temp, $src_image, $dst_x, $dst_y, $src_x, $src_y, $dst_w + 1, $dst_h + 1, $src_w, $src_h);
+			imagecopyresized ($dst_image, $temp, 0, 0, 0, 0, $dst_w, $dst_h, $dst_w, $dst_h);
+			imagedestroy ($temp);
+
+		} elseif ($quality < 5 && (($dst_w * $quality) < $src_w || ($dst_h * $quality) < $src_h)) {
+			$tmp_w = $dst_w * $quality;
+			$tmp_h = $dst_h * $quality;
+			$temp = imagecreatetruecolor ($tmp_w + 1, $tmp_h + 1);
+			imagecopyresized ($temp, $src_image, 0, 0, $src_x, $src_y, $tmp_w + 1, $tmp_h + 1, $src_w, $src_h);
+			imagecopyresampled ($dst_image, $temp, $dst_x, $dst_y, 0, 0, $dst_w, $dst_h, $tmp_w, $tmp_h);
+			imagedestroy ($temp);
+
+		} else {
+			imagecopyresampled ($dst_image, $src_image, $dst_x, $dst_y, $src_x, $src_y, $dst_w, $dst_h, $src_w, $src_h);
+		}
+
+		return true;
+	}
+
+	/**
+	 * @link http://pl.php.net/manual/pl/function.imagecreatefromjpeg.php
+	 * function posted by e dot a dot schultz at gmail dot com
+	 *
+	 * @static
+	 * @access public
+	 * @param string $filename
+	 * @return boolean
+	 */
+	function setMemoryForImage($imageWidth, $imageHeight, $imageBits, $imageChannels)
+	{
+		$MB = 1048576;  // number of bytes in 1M
+		$K64 = 65536;    // number of bytes in 64K
+		$TWEAKFACTOR = 2.4;  // Or whatever works for you
+		$memoryNeeded = round( ( $imageWidth * $imageHeight
+		* $imageBits
+		* $imageChannels / 8
+		+ $K64
+		) * $TWEAKFACTOR
+		) + 3*$MB;
+
+		//ini_get('memory_limit') only works if compiled with "--enable-memory-limit" also
+		//Default memory limit is 8MB so well stick with that.
+		//To find out what yours is, view your php.ini file.
+		$memoryLimit = CKFinder_Connector_Utils_Misc::returnBytes(@ini_get('memory_limit'))/$MB;
+		if (!$memoryLimit) {
+			$memoryLimit = 8;
+		}
+
+		$memoryLimitMB = $memoryLimit * $MB;
+		if (function_exists('memory_get_usage')) {
+			if (memory_get_usage() + $memoryNeeded > $memoryLimitMB) {
+				$newLimit = $memoryLimit + ceil( ( memory_get_usage()
+				+ $memoryNeeded
+				- $memoryLimitMB
+				) / $MB
+				);
+				if (@ini_set( 'memory_limit', $newLimit . 'M' ) === false) {
+					return false;
+				}
+			}
+		} else {
+			if ($memoryNeeded + 3*$MB > $memoryLimitMB) {
+				$newLimit = $memoryLimit + ceil(( 3*$MB
+				+ $memoryNeeded
+				- $memoryLimitMB
+				) / $MB
+				);
+				if (false === @ini_set( 'memory_limit', $newLimit . 'M' )) {
+					return false;
+				}
+			}
+		}
+		return true;
+	}
+
+	/**
+	 * convert shorthand php.ini notation into bytes, much like how the PHP source does it
+	 * @link http://pl.php.net/manual/en/function.ini-get.php
+	 *
+	 * @static
+	 * @access public
+	 * @param string $val
+	 * @return int
+	 */
+	function returnBytes($val)
+	{
+		$val = trim($val);
+		if (!$val) {
+			return 0;
+		}
+		$last = strtolower($val[strlen($val)-1]);
+		switch($last) {
+			// The 'G' modifier is available since PHP 5.1.0
+			case 'g':
+				$val *= 1024;
+			case 'm':
+				$val *= 1024;
+			case 'k':
+				$val *= 1024;
+		}
+
+		return $val;
+	}
+
+	/**
+	 * Checks if a value exists in an array (case insensitive)
+	 *
+	 * @static
+	 * @access public
+	 * @param string $needle
+	 * @param array $haystack
+	 * @return boolean
+	 */
+	function inArrayCaseInsensitive($needle, $haystack)
+	{
+		if (!$haystack || !is_array($haystack)) {
+			return false;
+		}
+		$lcase = array();
+		foreach ($haystack as $key => $val) {
+			$lcase[$key] = strtolower($val);
+		}
+		return in_array($needle, $lcase);
+	}
+
+	/**
+	 * UTF-8 compatible version of basename()
+	 *
+	 * @static
+	 * @access public
+	 * @param string $file
+	 * @return string
+	 */
+	function mbBasename($file)
+	{
+		$explode = explode('/', str_replace("\\", "/", $file));
+		return end($explode);
+	}
+
+	/**
+	 * Source: http://pl.php.net/imagecreate
+	 * (optimized for speed and memory usage, but yet not very efficient)
+	 *
+	 * @static
+	 * @access public
+	 * @param string $filename
+	 * @return resource
+	 */
+	function imageCreateFromBmp($filename)
+	{
+		//20 seconds seems to be a reasonable value to not kill a server and process images up to 1680x1050
+		@set_time_limit(20);
+
+		if (false === ($f1 = fopen($filename, "rb"))) {
+			return false;
+		}
+
+		$FILE = unpack("vfile_type/Vfile_size/Vreserved/Vbitmap_offset", fread($f1, 14));
+		if ($FILE['file_type'] != 19778) {
+			return false;
+		}
+
+		$BMP = unpack('Vheader_size/Vwidth/Vheight/vplanes/vbits_per_pixel'.
+		'/Vcompression/Vsize_bitmap/Vhoriz_resolution'.
+		'/Vvert_resolution/Vcolors_used/Vcolors_important', fread($f1, 40));
+
+		$BMP['colors'] = pow(2,$BMP['bits_per_pixel']);
+
+		if ($BMP['size_bitmap'] == 0) {
+			$BMP['size_bitmap'] = $FILE['file_size'] - $FILE['bitmap_offset'];
+		}
+
+		$BMP['bytes_per_pixel'] = $BMP['bits_per_pixel']/8;
+		$BMP['bytes_per_pixel2'] = ceil($BMP['bytes_per_pixel']);
+		$BMP['decal'] = ($BMP['width']*$BMP['bytes_per_pixel']/4);
+		$BMP['decal'] -= floor($BMP['width']*$BMP['bytes_per_pixel']/4);
+		$BMP['decal'] = 4-(4*$BMP['decal']);
+
+		if ($BMP['decal'] == 4) {
+			$BMP['decal'] = 0;
+		}
+
+		$PALETTE = array();
+		if ($BMP['colors'] < 16777216) {
+			$PALETTE = unpack('V'.$BMP['colors'], fread($f1, $BMP['colors']*4));
+		}
+
+		//2048x1536px@24bit don't even try to process larger files as it will probably fail
+		if ($BMP['size_bitmap'] > 3 * 2048 * 1536) {
+			return false;
+		}
+
+		$IMG = fread($f1, $BMP['size_bitmap']);
+		fclose($f1);
+		$VIDE = chr(0);
+
+		$res = imagecreatetruecolor($BMP['width'],$BMP['height']);
+		$P = 0;
+		$Y = $BMP['height']-1;
+
+		$line_length = $BMP['bytes_per_pixel']*$BMP['width'];
+
+		if ($BMP['bits_per_pixel'] == 24) {
+			while ($Y >= 0)
+			{
+				$X=0;
+				$temp = unpack( "C*", substr($IMG, $P, $line_length));
+
+				while ($X < $BMP['width'])
+				{
+					$offset = $X*3;
+					imagesetpixel($res, $X++, $Y, ($temp[$offset+3] << 16) + ($temp[$offset+2] << 8) + $temp[$offset+1]);
+				}
+				$Y--;
+				$P += $line_length + $BMP['decal'];
+			}
+		}
+		elseif ($BMP['bits_per_pixel'] == 8)
+		{
+			while ($Y >= 0)
+			{
+				$X=0;
+
+				$temp = unpack( "C*", substr($IMG, $P, $line_length));
+
+				while ($X < $BMP['width'])
+				{
+					imagesetpixel($res, $X++, $Y, $PALETTE[$temp[$X] +1]);
+				}
+				$Y--;
+				$P += $line_length + $BMP['decal'];
+			}
+		}
+		elseif ($BMP['bits_per_pixel'] == 4)
+		{
+			while ($Y >= 0)
+			{
+				$X=0;
+				$i = 1;
+				$low = true;
+
+				$temp = unpack( "C*", substr($IMG, $P, $line_length));
+
+				while ($X < $BMP['width'])
+				{
+					if ($low) {
+						$index = $temp[$i] >> 4;
+					}
+					else {
+						$index = $temp[$i++] & 0x0F;
+					}
+					$low = !$low;
+
+					imagesetpixel($res, $X++, $Y, $PALETTE[$index +1]);
+				}
+				$Y--;
+				$P += $line_length + $BMP['decal'];
+			}
+		}
+		elseif ($BMP['bits_per_pixel'] == 1)
+		{
+			$COLOR = unpack("n",$VIDE.substr($IMG,floor($P),1));
+			if     (($P*8)%8 == 0) $COLOR[1] =  $COLOR[1]        >>7;
+			elseif (($P*8)%8 == 1) $COLOR[1] = ($COLOR[1] & 0x40)>>6;
+			elseif (($P*8)%8 == 2) $COLOR[1] = ($COLOR[1] & 0x20)>>5;
+			elseif (($P*8)%8 == 3) $COLOR[1] = ($COLOR[1] & 0x10)>>4;
+			elseif (($P*8)%8 == 4) $COLOR[1] = ($COLOR[1] & 0x8)>>3;
+			elseif (($P*8)%8 == 5) $COLOR[1] = ($COLOR[1] & 0x4)>>2;
+			elseif (($P*8)%8 == 6) $COLOR[1] = ($COLOR[1] & 0x2)>>1;
+			elseif (($P*8)%8 == 7) $COLOR[1] = ($COLOR[1] & 0x1);
+			$COLOR[1] = $PALETTE[$COLOR[1]+1];
+		}
+		else {
+			return false;
+		}
+
+		return $res;
+	}
 }

Spacing +54 added lines, -54 removed lines

@@ -28,10 +28,10 @@ 
     function getErrorMessage($number, $arg = "") {
         $langCode = 'en';
         if (!empty($_GET['langCode']) && preg_match("/^[a-z\-]+$/", $_GET['langCode'])) {
-            if (file_exists(CKFINDER_CONNECTOR_LANG_PATH . "/" . $_GET['langCode'] . ".php"))
+            if (file_exists(CKFINDER_CONNECTOR_LANG_PATH."/".$_GET['langCode'].".php"))
                 $langCode = $_GET['langCode'];
         }
-        include CKFINDER_CONNECTOR_LANG_PATH . "/" . $langCode . ".php";
+        include CKFINDER_CONNECTOR_LANG_PATH."/".$langCode.".php";
         if ($number) {
             if (!empty ($GLOBALS['CKFLang']['Errors'][$number])) {
                 $errorMessage = str_replace("%1", $arg, $GLOBALS['CKFLang']['Errors'][$number]);
@@ -80,28 +80,28 @@ 
      * @param int $quality
      * @return boolean
      */
-    function fastImageCopyResampled (&$dst_image, $src_image, $dst_x, $dst_y, $src_x, $src_y, $dst_w, $dst_h, $src_w, $src_h, $quality = 3)
+    function fastImageCopyResampled(&$dst_image, $src_image, $dst_x, $dst_y, $src_x, $src_y, $dst_w, $dst_h, $src_w, $src_h, $quality = 3)
     {
         if (empty($src_image) || empty($dst_image)) {
             return false;
         }
 
         if ($quality <= 1) {
-            $temp = imagecreatetruecolor ($dst_w + 1, $dst_h + 1);
-            imagecopyresized ($temp, $src_image, $dst_x, $dst_y, $src_x, $src_y, $dst_w + 1, $dst_h + 1, $src_w, $src_h);
-            imagecopyresized ($dst_image, $temp, 0, 0, 0, 0, $dst_w, $dst_h, $dst_w, $dst_h);
-            imagedestroy ($temp);
+            $temp = imagecreatetruecolor($dst_w + 1, $dst_h + 1);
+            imagecopyresized($temp, $src_image, $dst_x, $dst_y, $src_x, $src_y, $dst_w + 1, $dst_h + 1, $src_w, $src_h);
+            imagecopyresized($dst_image, $temp, 0, 0, 0, 0, $dst_w, $dst_h, $dst_w, $dst_h);
+            imagedestroy($temp);
 
         } elseif ($quality < 5 && (($dst_w * $quality) < $src_w || ($dst_h * $quality) < $src_h)) {
             $tmp_w = $dst_w * $quality;
             $tmp_h = $dst_h * $quality;
-            $temp = imagecreatetruecolor ($tmp_w + 1, $tmp_h + 1);
-            imagecopyresized ($temp, $src_image, 0, 0, $src_x, $src_y, $tmp_w + 1, $tmp_h + 1, $src_w, $src_h);
-            imagecopyresampled ($dst_image, $temp, $dst_x, $dst_y, 0, 0, $dst_w, $dst_h, $tmp_w, $tmp_h);
-            imagedestroy ($temp);
+            $temp = imagecreatetruecolor($tmp_w + 1, $tmp_h + 1);
+            imagecopyresized($temp, $src_image, 0, 0, $src_x, $src_y, $tmp_w + 1, $tmp_h + 1, $src_w, $src_h);
+            imagecopyresampled($dst_image, $temp, $dst_x, $dst_y, 0, 0, $dst_w, $dst_h, $tmp_w, $tmp_h);
+            imagedestroy($temp);
 
         } else {
-            imagecopyresampled ($dst_image, $src_image, $dst_x, $dst_y, $src_x, $src_y, $dst_w, $dst_h, $src_w, $src_h);
+            imagecopyresampled($dst_image, $src_image, $dst_x, $dst_y, $src_x, $src_y, $dst_w, $dst_h, $src_w, $src_h);
         }
 
         return true;
@@ -118,20 +118,20 @@ 
      */
     function setMemoryForImage($imageWidth, $imageHeight, $imageBits, $imageChannels)
     {
-        $MB = 1048576;  // number of bytes in 1M
-        $K64 = 65536;    // number of bytes in 64K
-        $TWEAKFACTOR = 2.4;  // Or whatever works for you
-        $memoryNeeded = round( ( $imageWidth * $imageHeight
+        $MB = 1048576; // number of bytes in 1M
+        $K64 = 65536; // number of bytes in 64K
+        $TWEAKFACTOR = 2.4; // Or whatever works for you
+        $memoryNeeded = round(($imageWidth * $imageHeight
         * $imageBits
         * $imageChannels / 8
         + $K64
         ) * $TWEAKFACTOR
-        ) + 3*$MB;
+        ) + 3 * $MB;
 
         //ini_get('memory_limit') only works if compiled with "--enable-memory-limit" also
         //Default memory limit is 8MB so well stick with that.
         //To find out what yours is, view your php.ini file.
-        $memoryLimit = CKFinder_Connector_Utils_Misc::returnBytes(@ini_get('memory_limit'))/$MB;
+        $memoryLimit = CKFinder_Connector_Utils_Misc::returnBytes(@ini_get('memory_limit')) / $MB;
         if (!$memoryLimit) {
             $memoryLimit = 8;
         }
@@ -139,23 +139,23 @@ 
         $memoryLimitMB = $memoryLimit * $MB;
         if (function_exists('memory_get_usage')) {
             if (memory_get_usage() + $memoryNeeded > $memoryLimitMB) {
-                $newLimit = $memoryLimit + ceil( ( memory_get_usage()
+                $newLimit = $memoryLimit + ceil((memory_get_usage()
                 + $memoryNeeded
                 - $memoryLimitMB
                 ) / $MB
                 );
-                if (@ini_set( 'memory_limit', $newLimit . 'M' ) === false) {
+                if (@ini_set('memory_limit', $newLimit.'M') === false) {
                     return false;
                 }
             }
         } else {
-            if ($memoryNeeded + 3*$MB > $memoryLimitMB) {
-                $newLimit = $memoryLimit + ceil(( 3*$MB
+            if ($memoryNeeded + 3 * $MB > $memoryLimitMB) {
+                $newLimit = $memoryLimit + ceil((3 * $MB
                 + $memoryNeeded
                 - $memoryLimitMB
                 ) / $MB
                 );
-                if (false === @ini_set( 'memory_limit', $newLimit . 'M' )) {
+                if (false === @ini_set('memory_limit', $newLimit.'M')) {
                     return false;
                 }
             }
@@ -178,8 +178,8 @@ 
         if (!$val) {
             return 0;
         }
-        $last = strtolower($val[strlen($val)-1]);
-        switch($last) {
+        $last = strtolower($val[strlen($val) - 1]);
+        switch ($last) {
             // The 'G' modifier is available since PHP 5.1.0
             case 'g':
                 $val *= 1024;
@@ -254,17 +254,17 @@ 
         '/Vcompression/Vsize_bitmap/Vhoriz_resolution'.
         '/Vvert_resolution/Vcolors_used/Vcolors_important', fread($f1, 40));
 
-        $BMP['colors'] = pow(2,$BMP['bits_per_pixel']);
+        $BMP['colors'] = pow(2, $BMP['bits_per_pixel']);
 
         if ($BMP['size_bitmap'] == 0) {
             $BMP['size_bitmap'] = $FILE['file_size'] - $FILE['bitmap_offset'];
         }
 
-        $BMP['bytes_per_pixel'] = $BMP['bits_per_pixel']/8;
+        $BMP['bytes_per_pixel'] = $BMP['bits_per_pixel'] / 8;
         $BMP['bytes_per_pixel2'] = ceil($BMP['bytes_per_pixel']);
-        $BMP['decal'] = ($BMP['width']*$BMP['bytes_per_pixel']/4);
-        $BMP['decal'] -= floor($BMP['width']*$BMP['bytes_per_pixel']/4);
-        $BMP['decal'] = 4-(4*$BMP['decal']);
+        $BMP['decal'] = ($BMP['width'] * $BMP['bytes_per_pixel'] / 4);
+        $BMP['decal'] -= floor($BMP['width'] * $BMP['bytes_per_pixel'] / 4);
+        $BMP['decal'] = 4 - (4 * $BMP['decal']);
 
         if ($BMP['decal'] == 4) {
             $BMP['decal'] = 0;
@@ -272,7 +272,7 @@ 
 
         $PALETTE = array();
         if ($BMP['colors'] < 16777216) {
-            $PALETTE = unpack('V'.$BMP['colors'], fread($f1, $BMP['colors']*4));
+            $PALETTE = unpack('V'.$BMP['colors'], fread($f1, $BMP['colors'] * 4));
         }
 
         //2048x1536px@24bit don't even try to process larger files as it will probably fail
@@ -284,22 +284,22 @@ 
         fclose($f1);
         $VIDE = chr(0);
 
-        $res = imagecreatetruecolor($BMP['width'],$BMP['height']);
+        $res = imagecreatetruecolor($BMP['width'], $BMP['height']);
         $P = 0;
-        $Y = $BMP['height']-1;
+        $Y = $BMP['height'] - 1;
 
-        $line_length = $BMP['bytes_per_pixel']*$BMP['width'];
+        $line_length = $BMP['bytes_per_pixel'] * $BMP['width'];
 
         if ($BMP['bits_per_pixel'] == 24) {
             while ($Y >= 0)
             {
-                $X=0;
-                $temp = unpack( "C*", substr($IMG, $P, $line_length));
+                $X = 0;
+                $temp = unpack("C*", substr($IMG, $P, $line_length));
 
                 while ($X < $BMP['width'])
                 {
-                    $offset = $X*3;
-                    imagesetpixel($res, $X++, $Y, ($temp[$offset+3] << 16) + ($temp[$offset+2] << 8) + $temp[$offset+1]);
+                    $offset = $X * 3;
+                    imagesetpixel($res, $X++, $Y, ($temp[$offset + 3] << 16) + ($temp[$offset + 2] << 8) + $temp[$offset + 1]);
                 }
                 $Y--;
                 $P += $line_length + $BMP['decal'];
@@ -309,13 +309,13 @@ 
         {
             while ($Y >= 0)
             {
-                $X=0;
+                $X = 0;
 
-                $temp = unpack( "C*", substr($IMG, $P, $line_length));
+                $temp = unpack("C*", substr($IMG, $P, $line_length));
 
                 while ($X < $BMP['width'])
                 {
-                    imagesetpixel($res, $X++, $Y, $PALETTE[$temp[$X] +1]);
+                    imagesetpixel($res, $X++, $Y, $PALETTE[$temp[$X] + 1]);
                 }
                 $Y--;
                 $P += $line_length + $BMP['decal'];
@@ -325,11 +325,11 @@ 
         {
             while ($Y >= 0)
             {
-                $X=0;
+                $X = 0;
                 $i = 1;
                 $low = true;
 
-                $temp = unpack( "C*", substr($IMG, $P, $line_length));
+                $temp = unpack("C*", substr($IMG, $P, $line_length));
 
                 while ($X < $BMP['width'])
                 {
@@ -341,7 +341,7 @@ 
                     }
                     $low = !$low;
 
-                    imagesetpixel($res, $X++, $Y, $PALETTE[$index +1]);
+                    imagesetpixel($res, $X++, $Y, $PALETTE[$index + 1]);
                 }
                 $Y--;
                 $P += $line_length + $BMP['decal'];
@@ -349,16 +349,16 @@ 
         }
         elseif ($BMP['bits_per_pixel'] == 1)
         {
-            $COLOR = unpack("n",$VIDE.substr($IMG,floor($P),1));
-            if     (($P*8)%8 == 0) $COLOR[1] =  $COLOR[1]        >>7;
-            elseif (($P*8)%8 == 1) $COLOR[1] = ($COLOR[1] & 0x40)>>6;
-            elseif (($P*8)%8 == 2) $COLOR[1] = ($COLOR[1] & 0x20)>>5;
-            elseif (($P*8)%8 == 3) $COLOR[1] = ($COLOR[1] & 0x10)>>4;
-            elseif (($P*8)%8 == 4) $COLOR[1] = ($COLOR[1] & 0x8)>>3;
-            elseif (($P*8)%8 == 5) $COLOR[1] = ($COLOR[1] & 0x4)>>2;
-            elseif (($P*8)%8 == 6) $COLOR[1] = ($COLOR[1] & 0x2)>>1;
-            elseif (($P*8)%8 == 7) $COLOR[1] = ($COLOR[1] & 0x1);
-            $COLOR[1] = $PALETTE[$COLOR[1]+1];
+            $COLOR = unpack("n", $VIDE.substr($IMG, floor($P), 1));
+            if (($P * 8) % 8 == 0) $COLOR[1] = $COLOR[1] >> 7;
+            elseif (($P * 8) % 8 == 1) $COLOR[1] = ($COLOR[1] & 0x40) >> 6;
+            elseif (($P * 8) % 8 == 2) $COLOR[1] = ($COLOR[1] & 0x20) >> 5;
+            elseif (($P * 8) % 8 == 3) $COLOR[1] = ($COLOR[1] & 0x10) >> 4;
+            elseif (($P * 8) % 8 == 4) $COLOR[1] = ($COLOR[1] & 0x8) >> 3;
+            elseif (($P * 8) % 8 == 5) $COLOR[1] = ($COLOR[1] & 0x4) >> 2;
+            elseif (($P * 8) % 8 == 6) $COLOR[1] = ($COLOR[1] & 0x2) >> 1;
+            elseif (($P * 8) % 8 == 7) $COLOR[1] = ($COLOR[1] & 0x1);
+            $COLOR[1] = $PALETTE[$COLOR[1] + 1];
         }
         else {
             return false;

Braces +28 added lines, -21 removed lines

@@ -10,7 +10,9 @@ 
  * modifying or distribute this file or part of its contents. The contents of
  * this file is part of the Source Code of CKFinder.
  */
-if (!defined('IN_CKFINDER')) exit;
+if (!defined('IN_CKFINDER')) {
+	exit;
+}
 
 /**
  * @package CKFinder
@@ -28,8 +30,9 @@ 
     function getErrorMessage($number, $arg = "") {
         $langCode = 'en';
         if (!empty($_GET['langCode']) && preg_match("/^[a-z\-]+$/", $_GET['langCode'])) {
-            if (file_exists(CKFINDER_CONNECTOR_LANG_PATH . "/" . $_GET['langCode'] . ".php"))
-                $langCode = $_GET['langCode'];
+            if (file_exists(CKFINDER_CONNECTOR_LANG_PATH . "/" . $_GET['langCode'] . ".php")) {
+                            $langCode = $_GET['langCode'];
+            }
         }
         include CKFINDER_CONNECTOR_LANG_PATH . "/" . $langCode . ".php";
         if ($number) {
@@ -304,8 +307,7 @@ 
                 $Y--;
                 $P += $line_length + $BMP['decal'];
             }
-        }
-        elseif ($BMP['bits_per_pixel'] == 8)
+        } elseif ($BMP['bits_per_pixel'] == 8)
         {
             while ($Y >= 0)
             {
@@ -320,8 +322,7 @@ 
                 $Y--;
                 $P += $line_length + $BMP['decal'];
             }
-        }
-        elseif ($BMP['bits_per_pixel'] == 4)
+        } elseif ($BMP['bits_per_pixel'] == 4)
         {
             while ($Y >= 0)
             {
@@ -335,8 +336,7 @@ 
                 {
                     if ($low) {
                         $index = $temp[$i] >> 4;
-                    }
-                    else {
+                    } else {
                         $index = $temp[$i++] & 0x0F;
                     }
                     $low = !$low;
@@ -346,21 +346,28 @@ 
                 $Y--;
                 $P += $line_length + $BMP['decal'];
             }
-        }
-        elseif ($BMP['bits_per_pixel'] == 1)
+        } elseif ($BMP['bits_per_pixel'] == 1)
         {
             $COLOR = unpack("n",$VIDE.substr($IMG,floor($P),1));
-            if     (($P*8)%8 == 0) $COLOR[1] =  $COLOR[1]        >>7;
-            elseif (($P*8)%8 == 1) $COLOR[1] = ($COLOR[1] & 0x40)>>6;
-            elseif (($P*8)%8 == 2) $COLOR[1] = ($COLOR[1] & 0x20)>>5;
-            elseif (($P*8)%8 == 3) $COLOR[1] = ($COLOR[1] & 0x10)>>4;
-            elseif (($P*8)%8 == 4) $COLOR[1] = ($COLOR[1] & 0x8)>>3;
-            elseif (($P*8)%8 == 5) $COLOR[1] = ($COLOR[1] & 0x4)>>2;
-            elseif (($P*8)%8 == 6) $COLOR[1] = ($COLOR[1] & 0x2)>>1;
-            elseif (($P*8)%8 == 7) $COLOR[1] = ($COLOR[1] & 0x1);
+            if     (($P*8)%8 == 0) {
+            	$COLOR[1] =  $COLOR[1]        >>7;
+            } elseif (($P*8)%8 == 1) {
+            	$COLOR[1] = ($COLOR[1] & 0x40)>>6;
+            } elseif (($P*8)%8 == 2) {
+            	$COLOR[1] = ($COLOR[1] & 0x20)>>5;
+            } elseif (($P*8)%8 == 3) {
+            	$COLOR[1] = ($COLOR[1] & 0x10)>>4;
+            } elseif (($P*8)%8 == 4) {
+            	$COLOR[1] = ($COLOR[1] & 0x8)>>3;
+            } elseif (($P*8)%8 == 5) {
+            	$COLOR[1] = ($COLOR[1] & 0x4)>>2;
+            } elseif (($P*8)%8 == 6) {
+            	$COLOR[1] = ($COLOR[1] & 0x2)>>1;
+            } elseif (($P*8)%8 == 7) {
+            	$COLOR[1] = ($COLOR[1] & 0x1);
+            }
             $COLOR[1] = $PALETTE[$COLOR[1]+1];
-        }
-        else {
+        } else {
             return false;
         }
 

libs/ckfinder/core/connector/php/php4/Utils/XmlNode.php

Doc Comments -3 removed lines

@@ -107,7 +107,6 @@ 
     /**
      * Set element value
      *
-     * @param string $name
      * @param string $value
      * @access public
      */
@@ -119,8 +118,6 @@ 
     /**
      * Get element value
      *
-     * @param string $name
-     * @param string $value
      * @access public
      */
     function getValue()

Indentation +154 added lines, -154 removed lines

@@ -27,158 +27,158 @@
  */
 class Ckfinder_Connector_Utils_XmlNode
 {
-    /**
-     * Array that stores XML attributes
-     *
-     * @access private
-     * @var array
-     */
-    var $_attributes = array();
-    /**
-     * Array that stores child nodes
-     *
-     * @access private
-     * @var array
-     */
-    var $_childNodes = array();
-    /**
-     * Node name
-     *
-     * @access private
-     * @var string
-     */
-    var $_name;
-    /**
-     * Node value
-     *
-     * @access private
-     * @var string
-     */
-    var $_value;
-
-    /**
-     * Create new node
-     *
-     * @param string $nodeName node name
-     * @param string $nodeValue node value
-     * @return Ckfinder_Connector_Utils_XmlNode
-     */
-    function Ckfinder_Connector_Utils_XmlNode($nodeName, $nodeValue = null)
-    {
-        $this->_name = $nodeName;
-        if (!is_null($nodeValue)) {
-            $this->_value = $nodeValue;
-        }
-    }
-
-    function &getChild($name)
-    {
-        foreach ($this->_childNodes as $i => $node) {
-            if ($node->_name == $name) {
-                return $this->_childNodes[$i];
-            }
-        }
-        return null;
-    }
-
-    /**
-     * Add attribute
-     *
-     * @param string $name
-     * @param string $value
-     * @access public
-     */
-    function addAttribute($name, $value)
-    {
-        $this->_attributes[$name] = $value;
-    }
-
-    /**
-     * Get attribute value
-     *
-     * @param string $name
-     * @access public
-     */
-    function getAttribute($name)
-    {
-        return $this->_attributes[$name];
-    }
-
-    /**
-     * Set element value
-     *
-     * @param string $name
-     * @param string $value
-     * @access public
-     */
-    function setValue($value)
-    {
-        $this->_value = $value;
-    }
-
-    /**
-     * Get element value
-     *
-     * @param string $name
-     * @param string $value
-     * @access public
-     */
-    function getValue()
-    {
-        return $this->_value;
-    }
-
-    /**
-     * Adds new child at the end of the children
-     *
-     * @param Ckfinder_Connector_Utils_XmlNode $node
-     * @access public
-     */
-    function addChild(&$node)
-    {
-        $this->_childNodes[] =& $node;
-    }
-
-    /**
-     * Return a well-formed XML string based on Ckfinder_Connector_Utils_XmlNode element
-     *
-     * @return string
-     * @access public
-     */
-    function asXML()
-    {
-        $ret = "<" . $this->_name;
-
-        //print Attributes
-        if (sizeof($this->_attributes)>0) {
-            foreach ($this->_attributes as $_name => $_value) {
-                $ret .= " " . $_name . '="' . htmlspecialchars($_value) . '"';
-            }
-        }
-
-        //if there is nothing more
-        if (is_null($this->_value) && !sizeof($this->_childNodes)) {
-            $ret .= " />";
-            return $ret;
-        }
-
-        //close opening tag
-        $ret .= ">";
-
-        //print value
-        if (!is_null($this->_value)) {
-            $ret .= htmlspecialchars($this->_value);
-        }
-
-        //print child nodes
-        if (sizeof($this->_childNodes)>0) {
-            foreach ($this->_childNodes as $_node) {
-                $ret .= $_node->asXml();
-            }
-        }
-
-        $ret .= "</" . $this->_name . ">";
-
-        return $ret;
-    }
+	/**
+	 * Array that stores XML attributes
+	 *
+	 * @access private
+	 * @var array
+	 */
+	var $_attributes = array();
+	/**
+	 * Array that stores child nodes
+	 *
+	 * @access private
+	 * @var array
+	 */
+	var $_childNodes = array();
+	/**
+	 * Node name
+	 *
+	 * @access private
+	 * @var string
+	 */
+	var $_name;
+	/**
+	 * Node value
+	 *
+	 * @access private
+	 * @var string
+	 */
+	var $_value;
+
+	/**
+	 * Create new node
+	 *
+	 * @param string $nodeName node name
+	 * @param string $nodeValue node value
+	 * @return Ckfinder_Connector_Utils_XmlNode
+	 */
+	function Ckfinder_Connector_Utils_XmlNode($nodeName, $nodeValue = null)
+	{
+		$this->_name = $nodeName;
+		if (!is_null($nodeValue)) {
+			$this->_value = $nodeValue;
+		}
+	}
+
+	function &getChild($name)
+	{
+		foreach ($this->_childNodes as $i => $node) {
+			if ($node->_name == $name) {
+				return $this->_childNodes[$i];
+			}
+		}
+		return null;
+	}
+
+	/**
+	 * Add attribute
+	 *
+	 * @param string $name
+	 * @param string $value
+	 * @access public
+	 */
+	function addAttribute($name, $value)
+	{
+		$this->_attributes[$name] = $value;
+	}
+
+	/**
+	 * Get attribute value
+	 *
+	 * @param string $name
+	 * @access public
+	 */
+	function getAttribute($name)
+	{
+		return $this->_attributes[$name];
+	}
+
+	/**
+	 * Set element value
+	 *
+	 * @param string $name
+	 * @param string $value
+	 * @access public
+	 */
+	function setValue($value)
+	{
+		$this->_value = $value;
+	}
+
+	/**
+	 * Get element value
+	 *
+	 * @param string $name
+	 * @param string $value
+	 * @access public
+	 */
+	function getValue()
+	{
+		return $this->_value;
+	}
+
+	/**
+	 * Adds new child at the end of the children
+	 *
+	 * @param Ckfinder_Connector_Utils_XmlNode $node
+	 * @access public
+	 */
+	function addChild(&$node)
+	{
+		$this->_childNodes[] =& $node;
+	}
+
+	/**
+	 * Return a well-formed XML string based on Ckfinder_Connector_Utils_XmlNode element
+	 *
+	 * @return string
+	 * @access public
+	 */
+	function asXML()
+	{
+		$ret = "<" . $this->_name;
+
+		//print Attributes
+		if (sizeof($this->_attributes)>0) {
+			foreach ($this->_attributes as $_name => $_value) {
+				$ret .= " " . $_name . '="' . htmlspecialchars($_value) . '"';
+			}
+		}
+
+		//if there is nothing more
+		if (is_null($this->_value) && !sizeof($this->_childNodes)) {
+			$ret .= " />";
+			return $ret;
+		}
+
+		//close opening tag
+		$ret .= ">";
+
+		//print value
+		if (!is_null($this->_value)) {
+			$ret .= htmlspecialchars($this->_value);
+		}
+
+		//print child nodes
+		if (sizeof($this->_childNodes)>0) {
+			foreach ($this->_childNodes as $_node) {
+				$ret .= $_node->asXml();
+			}
+		}
+
+		$ret .= "</" . $this->_name . ">";
+
+		return $ret;
+	}
 }

Spacing +6 added lines, -6 removed lines

@@ -136,7 +136,7 @@ 
      */
     function addChild(&$node)
     {
-        $this->_childNodes[] =& $node;
+        $this->_childNodes[] = & $node;
     }
 
     /**
@@ -147,12 +147,12 @@ 
      */
     function asXML()
     {
-        $ret = "<" . $this->_name;
+        $ret = "<".$this->_name;
 
         //print Attributes
-        if (sizeof($this->_attributes)>0) {
+        if (sizeof($this->_attributes) > 0) {
             foreach ($this->_attributes as $_name => $_value) {
-                $ret .= " " . $_name . '="' . htmlspecialchars($_value) . '"';
+                $ret .= " ".$_name.'="'.htmlspecialchars($_value).'"';
             }
         }
 
@@ -171,13 +171,13 @@ 
         }
 
         //print child nodes
-        if (sizeof($this->_childNodes)>0) {
+        if (sizeof($this->_childNodes) > 0) {
             foreach ($this->_childNodes as $_node) {
                 $ret .= $_node->asXml();
             }
         }
 
-        $ret .= "</" . $this->_name . ">";
+        $ret .= "</".$this->_name.">";
 
         return $ret;
     }

Braces +3 added lines, -1 removed lines

@@ -10,7 +10,9 @@
  * modifying or distribute this file or part of its contents. The contents of
  * this file is part of the Source Code of CKFinder.
  */
-if (!defined('IN_CKFINDER')) exit;
+if (!defined('IN_CKFINDER')) {
+	exit;
+}
 
 /**
  * @package CKFinder

libs/ckfinder/core/connector/php/php5/CommandHandler/CopyFiles.php

Doc Comments +4 added lines

@@ -243,6 +243,10 @@
         }
     }
 
+    /**
+     * @param integer $errorCode
+     * @param string $path
+     */
     private function appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path)
     {
         $oErrorNode = new CKFinder_Connector_Utils_XmlNode("Error");

Indentation +220 added lines, -220 removed lines

@@ -32,224 +32,224 @@
  */
 class CKFinder_Connector_CommandHandler_CopyFiles extends CKFinder_Connector_CommandHandler_XmlCommandHandlerBase
 {
-    /**
-     * Command name
-     *
-     * @access private
-     * @var string
-     */
-    private $command = "CopyFiles";
-
-
-    /**
-     * handle request and build XML
-     * @access protected
-     *
-     */
-    protected function buildXml()
-    {
-        if (empty($_POST['CKFinderCommand']) || $_POST['CKFinderCommand'] != 'true') {
-            $this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_INVALID_REQUEST);
-        }
-
-        $clientPath = $this->_currentFolder->getClientPath();
-        $sServerDir = $this->_currentFolder->getServerPath();
-        $currentResourceTypeConfig = $this->_currentFolder->getResourceTypeConfig();
-        $_config =& CKFinder_Connector_Core_Factory::getInstance("Core_Config");
-        $_aclConfig = $_config->getAccessControlConfig();
-        $aclMasks = array();
-        $_resourceTypeConfig = array();
-
-        if (!$this->_currentFolder->checkAcl(CKFINDER_CONNECTOR_ACL_FILE_RENAME | CKFINDER_CONNECTOR_ACL_FILE_UPLOAD | CKFINDER_CONNECTOR_ACL_FILE_DELETE)) {
-            $this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_UNAUTHORIZED);
-        }
-
-        // Create the "Errors" node.
-        $oErrorsNode = new CKFinder_Connector_Utils_XmlNode("Errors");
-        $errorCode = CKFINDER_CONNECTOR_ERROR_NONE;
-        $copied = 0;
-        $copiedAll = 0;
-        if (!empty($_POST['copied'])) {
-            $copiedAll = intval($_POST['copied']);
-        }
-        $checkedPaths = array();
-
-        $oCopyFilesNode = new Ckfinder_Connector_Utils_XmlNode("CopyFiles");
-
-        if (!empty($_POST['files']) && is_array($_POST['files'])) {
-            foreach ($_POST['files'] as $index => $arr) {
-                if (empty($arr['name'])) {
-                    continue;
-                }
-                if (!isset($arr['name'], $arr['type'], $arr['folder'])) {
-                    $this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_INVALID_REQUEST);
-                }
-
-                // file name
-                $name = CKFinder_Connector_Utils_FileSystem::convertToFilesystemEncoding($arr['name']);
-                // resource type
-                $type = $arr['type'];
-                // client path
-                $path = CKFinder_Connector_Utils_FileSystem::convertToFilesystemEncoding($arr['folder']);
-                // options
-                $options = (!empty($arr['options'])) ? $arr['options'] : '';
-
-                $destinationFilePath = $sServerDir.$name;
-
-                // check #1 (path)
-                if (!CKFinder_Connector_Utils_FileSystem::checkFileName($name) || preg_match(CKFINDER_REGEX_INVALID_PATH, $path)) {
-                    $this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_INVALID_REQUEST);
-                }
-
-                // get resource type config for current file
-                if (!isset($_resourceTypeConfig[$type])) {
-                    $_resourceTypeConfig[$type] = $_config->getResourceTypeConfig($type);
-                }
-
-                // check #2 (resource type)
-                if (is_null($_resourceTypeConfig[$type])) {
-                    $this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_INVALID_REQUEST);
-                }
-
-                // check #3 (extension)
-                if (!$_resourceTypeConfig[$type]->checkExtension($name, false)) {
-                    $errorCode = CKFINDER_CONNECTOR_ERROR_INVALID_EXTENSION;
-                    $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
-                    continue;
-                }
-
-                // check #4 (extension) - when moving to another resource type, double check extension
-                if ($currentResourceTypeConfig->getName() != $type) {
-                    if (!$currentResourceTypeConfig->checkExtension($name, false)) {
-                        $errorCode = CKFINDER_CONNECTOR_ERROR_INVALID_EXTENSION;
-                        $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
-                        continue;
-                    }
-                }
-
-                // check #5 (hidden folders)
-                // cache results
-                if (empty($checkedPaths[$path])) {
-                    $checkedPaths[$path] = true;
-
-                    if ($_resourceTypeConfig[$type]->checkIsHiddenPath($path)) {
-                        $this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_INVALID_REQUEST);
-                    }
-                }
-
-                $sourceFilePath = $_resourceTypeConfig[$type]->getDirectory().$path.$name;
-
-                // check #6 (hidden file name)
-                if ($currentResourceTypeConfig->checkIsHiddenFile($name)) {
-                    $this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_INVALID_REQUEST);
-                }
-
-                // check #7 (Access Control, need file view permission to source files)
-                if (!isset($aclMasks[$type."@".$path])) {
-                    $aclMasks[$type."@".$path] = $_aclConfig->getComputedMask($type, $path);
-                }
-
-                $isAuthorized = (($aclMasks[$type."@".$path] & CKFINDER_CONNECTOR_ACL_FILE_VIEW) == CKFINDER_CONNECTOR_ACL_FILE_VIEW);
-                if (!$isAuthorized) {
-                    $this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_UNAUTHORIZED);
-                }
-
-                // check #8 (invalid file name)
-                if (!file_exists($sourceFilePath) || !is_file($sourceFilePath)) {
-                    $errorCode = CKFINDER_CONNECTOR_ERROR_FILE_NOT_FOUND;
-                    $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
-                    continue;
-                }
-
-                // check #9 (max size)
-                if ($currentResourceTypeConfig->getName() != $type) {
-                    $maxSize = $currentResourceTypeConfig->getMaxSize();
-                    $fileSize = filesize($sourceFilePath);
-                    if ($maxSize && $fileSize>$maxSize) {
-                        $errorCode = CKFINDER_CONNECTOR_ERROR_UPLOADED_TOO_BIG;
-                        $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
-                        continue;
-                    }
-                }
-
-                //$overwrite
-                // finally, no errors so far, we may attempt to copy a file
-                // protection against copying files to itself
-                if ($sourceFilePath == $destinationFilePath) {
-                    $errorCode = CKFINDER_CONNECTOR_ERROR_SOURCE_AND_TARGET_PATH_EQUAL;
-                    $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
-                    continue;
-                }
-                // check if file exists if we don't force overwriting
-                else if (file_exists($destinationFilePath) && strpos($options, "overwrite") === false) {
-                    if (strpos($options, "autorename") !== false) {
-                        $iCounter = 1;
-                        while (true)
-                        {
-                            $fileName = CKFinder_Connector_Utils_FileSystem::getFileNameWithoutExtension($name) .
-                                "(" . $iCounter . ")" . "." .
-                                CKFinder_Connector_Utils_FileSystem::getExtension($name);
-
-                            $destinationFilePath = $sServerDir.$fileName;
-                            if (!file_exists($destinationFilePath)) {
-                                break;
-                            }
-                            else {
-                                $iCounter++;
-                            }
-                        }
-                        if (!@copy($sourceFilePath, $destinationFilePath)) {
-                            $errorCode = CKFINDER_CONNECTOR_ERROR_ACCESS_DENIED;
-                            $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
-                            continue;
-                        }
-                        else {
-                            $copied++;
-                        }
-                    }
-                    else {
-                        $errorCode = CKFINDER_CONNECTOR_ERROR_ALREADY_EXIST;
-                        $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
-                        continue;
-                    }
-                }
-                // copy() overwrites without warning
-                else {
-                    if (!@copy($sourceFilePath, $destinationFilePath)) {
-                        $errorCode = CKFINDER_CONNECTOR_ERROR_ACCESS_DENIED;
-                        $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
-                        continue;
-                    }
-                    else {
-                        $copied++;
-                    }
-                }
-            }
-        }
-
-        $this->_connectorNode->addChild($oCopyFilesNode);
-        if ($errorCode != CKFINDER_CONNECTOR_ERROR_NONE) {
-            $this->_connectorNode->addChild($oErrorsNode);
-        }
-        $oCopyFilesNode->addAttribute("copied", $copied);
-        $oCopyFilesNode->addAttribute("copiedTotal", $copiedAll + $copied);
-
-        /**
-         * Note: actually we could have more than one error.
-         * This is just a flag for CKFinder interface telling it to check all errors.
-         */
-        if ($errorCode != CKFINDER_CONNECTOR_ERROR_NONE) {
-            $this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_COPY_FAILED);
-        }
-    }
-
-    private function appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path)
-    {
-        $oErrorNode = new CKFinder_Connector_Utils_XmlNode("Error");
-        $oErrorNode->addAttribute("code", $errorCode);
-        $oErrorNode->addAttribute("name", CKFinder_Connector_Utils_FileSystem::convertToConnectorEncoding($name));
-        $oErrorNode->addAttribute("type", $type);
-        $oErrorNode->addAttribute("folder", $path);
-        $oErrorsNode->addChild($oErrorNode);
-    }
+	/**
+	 * Command name
+	 *
+	 * @access private
+	 * @var string
+	 */
+	private $command = "CopyFiles";
+
+
+	/**
+	 * handle request and build XML
+	 * @access protected
+	 *
+	 */
+	protected function buildXml()
+	{
+		if (empty($_POST['CKFinderCommand']) || $_POST['CKFinderCommand'] != 'true') {
+			$this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_INVALID_REQUEST);
+		}
+
+		$clientPath = $this->_currentFolder->getClientPath();
+		$sServerDir = $this->_currentFolder->getServerPath();
+		$currentResourceTypeConfig = $this->_currentFolder->getResourceTypeConfig();
+		$_config =& CKFinder_Connector_Core_Factory::getInstance("Core_Config");
+		$_aclConfig = $_config->getAccessControlConfig();
+		$aclMasks = array();
+		$_resourceTypeConfig = array();
+
+		if (!$this->_currentFolder->checkAcl(CKFINDER_CONNECTOR_ACL_FILE_RENAME | CKFINDER_CONNECTOR_ACL_FILE_UPLOAD | CKFINDER_CONNECTOR_ACL_FILE_DELETE)) {
+			$this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_UNAUTHORIZED);
+		}
+
+		// Create the "Errors" node.
+		$oErrorsNode = new CKFinder_Connector_Utils_XmlNode("Errors");
+		$errorCode = CKFINDER_CONNECTOR_ERROR_NONE;
+		$copied = 0;
+		$copiedAll = 0;
+		if (!empty($_POST['copied'])) {
+			$copiedAll = intval($_POST['copied']);
+		}
+		$checkedPaths = array();
+
+		$oCopyFilesNode = new Ckfinder_Connector_Utils_XmlNode("CopyFiles");
+
+		if (!empty($_POST['files']) && is_array($_POST['files'])) {
+			foreach ($_POST['files'] as $index => $arr) {
+				if (empty($arr['name'])) {
+					continue;
+				}
+				if (!isset($arr['name'], $arr['type'], $arr['folder'])) {
+					$this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_INVALID_REQUEST);
+				}
+
+				// file name
+				$name = CKFinder_Connector_Utils_FileSystem::convertToFilesystemEncoding($arr['name']);
+				// resource type
+				$type = $arr['type'];
+				// client path
+				$path = CKFinder_Connector_Utils_FileSystem::convertToFilesystemEncoding($arr['folder']);
+				// options
+				$options = (!empty($arr['options'])) ? $arr['options'] : '';
+
+				$destinationFilePath = $sServerDir.$name;
+
+				// check #1 (path)
+				if (!CKFinder_Connector_Utils_FileSystem::checkFileName($name) || preg_match(CKFINDER_REGEX_INVALID_PATH, $path)) {
+					$this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_INVALID_REQUEST);
+				}
+
+				// get resource type config for current file
+				if (!isset($_resourceTypeConfig[$type])) {
+					$_resourceTypeConfig[$type] = $_config->getResourceTypeConfig($type);
+				}
+
+				// check #2 (resource type)
+				if (is_null($_resourceTypeConfig[$type])) {
+					$this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_INVALID_REQUEST);
+				}
+
+				// check #3 (extension)
+				if (!$_resourceTypeConfig[$type]->checkExtension($name, false)) {
+					$errorCode = CKFINDER_CONNECTOR_ERROR_INVALID_EXTENSION;
+					$this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
+					continue;
+				}
+
+				// check #4 (extension) - when moving to another resource type, double check extension
+				if ($currentResourceTypeConfig->getName() != $type) {
+					if (!$currentResourceTypeConfig->checkExtension($name, false)) {
+						$errorCode = CKFINDER_CONNECTOR_ERROR_INVALID_EXTENSION;
+						$this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
+						continue;
+					}
+				}
+
+				// check #5 (hidden folders)
+				// cache results
+				if (empty($checkedPaths[$path])) {
+					$checkedPaths[$path] = true;
+
+					if ($_resourceTypeConfig[$type]->checkIsHiddenPath($path)) {
+						$this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_INVALID_REQUEST);
+					}
+				}
+
+				$sourceFilePath = $_resourceTypeConfig[$type]->getDirectory().$path.$name;
+
+				// check #6 (hidden file name)
+				if ($currentResourceTypeConfig->checkIsHiddenFile($name)) {
+					$this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_INVALID_REQUEST);
+				}
+
+				// check #7 (Access Control, need file view permission to source files)
+				if (!isset($aclMasks[$type."@".$path])) {
+					$aclMasks[$type."@".$path] = $_aclConfig->getComputedMask($type, $path);
+				}
+
+				$isAuthorized = (($aclMasks[$type."@".$path] & CKFINDER_CONNECTOR_ACL_FILE_VIEW) == CKFINDER_CONNECTOR_ACL_FILE_VIEW);
+				if (!$isAuthorized) {
+					$this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_UNAUTHORIZED);
+				}
+
+				// check #8 (invalid file name)
+				if (!file_exists($sourceFilePath) || !is_file($sourceFilePath)) {
+					$errorCode = CKFINDER_CONNECTOR_ERROR_FILE_NOT_FOUND;
+					$this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
+					continue;
+				}
+
+				// check #9 (max size)
+				if ($currentResourceTypeConfig->getName() != $type) {
+					$maxSize = $currentResourceTypeConfig->getMaxSize();
+					$fileSize = filesize($sourceFilePath);
+					if ($maxSize && $fileSize>$maxSize) {
+						$errorCode = CKFINDER_CONNECTOR_ERROR_UPLOADED_TOO_BIG;
+						$this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
+						continue;
+					}
+				}
+
+				//$overwrite
+				// finally, no errors so far, we may attempt to copy a file
+				// protection against copying files to itself
+				if ($sourceFilePath == $destinationFilePath) {
+					$errorCode = CKFINDER_CONNECTOR_ERROR_SOURCE_AND_TARGET_PATH_EQUAL;
+					$this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
+					continue;
+				}
+				// check if file exists if we don't force overwriting
+				else if (file_exists($destinationFilePath) && strpos($options, "overwrite") === false) {
+					if (strpos($options, "autorename") !== false) {
+						$iCounter = 1;
+						while (true)
+						{
+							$fileName = CKFinder_Connector_Utils_FileSystem::getFileNameWithoutExtension($name) .
+								"(" . $iCounter . ")" . "." .
+								CKFinder_Connector_Utils_FileSystem::getExtension($name);
+
+							$destinationFilePath = $sServerDir.$fileName;
+							if (!file_exists($destinationFilePath)) {
+								break;
+							}
+							else {
+								$iCounter++;
+							}
+						}
+						if (!@copy($sourceFilePath, $destinationFilePath)) {
+							$errorCode = CKFINDER_CONNECTOR_ERROR_ACCESS_DENIED;
+							$this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
+							continue;
+						}
+						else {
+							$copied++;
+						}
+					}
+					else {
+						$errorCode = CKFINDER_CONNECTOR_ERROR_ALREADY_EXIST;
+						$this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
+						continue;
+					}
+				}
+				// copy() overwrites without warning
+				else {
+					if (!@copy($sourceFilePath, $destinationFilePath)) {
+						$errorCode = CKFINDER_CONNECTOR_ERROR_ACCESS_DENIED;
+						$this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
+						continue;
+					}
+					else {
+						$copied++;
+					}
+				}
+			}
+		}
+
+		$this->_connectorNode->addChild($oCopyFilesNode);
+		if ($errorCode != CKFINDER_CONNECTOR_ERROR_NONE) {
+			$this->_connectorNode->addChild($oErrorsNode);
+		}
+		$oCopyFilesNode->addAttribute("copied", $copied);
+		$oCopyFilesNode->addAttribute("copiedTotal", $copiedAll + $copied);
+
+		/**
+		 * Note: actually we could have more than one error.
+		 * This is just a flag for CKFinder interface telling it to check all errors.
+		 */
+		if ($errorCode != CKFINDER_CONNECTOR_ERROR_NONE) {
+			$this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_COPY_FAILED);
+		}
+	}
+
+	private function appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path)
+	{
+		$oErrorNode = new CKFinder_Connector_Utils_XmlNode("Error");
+		$oErrorNode->addAttribute("code", $errorCode);
+		$oErrorNode->addAttribute("name", CKFinder_Connector_Utils_FileSystem::convertToConnectorEncoding($name));
+		$oErrorNode->addAttribute("type", $type);
+		$oErrorNode->addAttribute("folder", $path);
+		$oErrorsNode->addChild($oErrorNode);
+	}
 }

Spacing +5 added lines, -5 removed lines

@@ -21,7 +21,7 @@ 
 /**
  * Include base XML command handler
  */
-require_once CKFINDER_CONNECTOR_LIB_DIR . "/CommandHandler/XmlCommandHandlerBase.php";
+require_once CKFINDER_CONNECTOR_LIB_DIR."/CommandHandler/XmlCommandHandlerBase.php";
 
 /**
  * Handle CopyFiles command
@@ -55,7 +55,7 @@ 
         $clientPath = $this->_currentFolder->getClientPath();
         $sServerDir = $this->_currentFolder->getServerPath();
         $currentResourceTypeConfig = $this->_currentFolder->getResourceTypeConfig();
-        $_config =& CKFinder_Connector_Core_Factory::getInstance("Core_Config");
+        $_config = & CKFinder_Connector_Core_Factory::getInstance("Core_Config");
         $_aclConfig = $_config->getAccessControlConfig();
         $aclMasks = array();
         $_resourceTypeConfig = array();
@@ -165,7 +165,7 @@ 
                 if ($currentResourceTypeConfig->getName() != $type) {
                     $maxSize = $currentResourceTypeConfig->getMaxSize();
                     $fileSize = filesize($sourceFilePath);
-                    if ($maxSize && $fileSize>$maxSize) {
+                    if ($maxSize && $fileSize > $maxSize) {
                         $errorCode = CKFINDER_CONNECTOR_ERROR_UPLOADED_TOO_BIG;
                         $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
                         continue;
@@ -186,8 +186,8 @@ 
                         $iCounter = 1;
                         while (true)
                         {
-                            $fileName = CKFinder_Connector_Utils_FileSystem::getFileNameWithoutExtension($name) .
-                                "(" . $iCounter . ")" . "." .
+                            $fileName = CKFinder_Connector_Utils_FileSystem::getFileNameWithoutExtension($name).
+                                "(".$iCounter.")".".".
                                 CKFinder_Connector_Utils_FileSystem::getExtension($name);
 
                             $destinationFilePath = $sServerDir.$fileName;

Braces +7 added lines, -9 removed lines

@@ -10,7 +10,9 @@ 
  * modifying or distribute this file or part of its contents. The contents of
  * this file is part of the Source Code of CKFinder.
  */
-if (!defined('IN_CKFINDER')) exit;
+if (!defined('IN_CKFINDER')) {
+	exit;
+}
 
 /**
  * @package CKFinder
@@ -193,8 +195,7 @@ 
                             $destinationFilePath = $sServerDir.$fileName;
                             if (!file_exists($destinationFilePath)) {
                                 break;
-                            }
-                            else {
+                            } else {
                                 $iCounter++;
                             }
                         }
@@ -202,12 +203,10 @@ 
                             $errorCode = CKFINDER_CONNECTOR_ERROR_ACCESS_DENIED;
                             $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
                             continue;
-                        }
-                        else {
+                        } else {
                             $copied++;
                         }
-                    }
-                    else {
+                    } else {
                         $errorCode = CKFINDER_CONNECTOR_ERROR_ALREADY_EXIST;
                         $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
                         continue;
@@ -219,8 +218,7 @@ 
                         $errorCode = CKFINDER_CONNECTOR_ERROR_ACCESS_DENIED;
                         $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
                         continue;
-                    }
-                    else {
+                    } else {
                         $copied++;
                     }
                 }

libs/ckfinder/core/connector/php/php5/CommandHandler/MoveFiles.php

Doc Comments +4 added lines

@@ -259,6 +259,10 @@
         }
     }
 
+    /**
+     * @param integer $errorCode
+     * @param string $path
+     */
     private function appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path)
     {
         $oErrorNode = new CKFinder_Connector_Utils_XmlNode("Error");

Indentation +209 added lines, -209 removed lines

@@ -32,240 +32,240 @@
  */
 class CKFinder_Connector_CommandHandler_MoveFiles extends CKFinder_Connector_CommandHandler_XmlCommandHandlerBase
 {
-    /**
-     * Command name
-     *
-     * @access private
-     * @var string
-     */
-    private $command = "MoveFiles";
+	/**
+	 * Command name
+	 *
+	 * @access private
+	 * @var string
+	 */
+	private $command = "MoveFiles";
 
 
-    /**
-     * handle request and build XML
-     * @access protected
-     *
-     */
-    protected function buildXml()
-    {
-        if (empty($_POST['CKFinderCommand']) || $_POST['CKFinderCommand'] != 'true') {
-            $this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_INVALID_REQUEST);
-        }
+	/**
+	 * handle request and build XML
+	 * @access protected
+	 *
+	 */
+	protected function buildXml()
+	{
+		if (empty($_POST['CKFinderCommand']) || $_POST['CKFinderCommand'] != 'true') {
+			$this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_INVALID_REQUEST);
+		}
 
-        $clientPath = $this->_currentFolder->getClientPath();
-        $sServerDir = $this->_currentFolder->getServerPath();
-        $currentResourceTypeConfig = $this->_currentFolder->getResourceTypeConfig();
-        $_config =& CKFinder_Connector_Core_Factory::getInstance("Core_Config");
-        $_aclConfig = $_config->getAccessControlConfig();
-        $aclMasks = array();
-        $_resourceTypeConfig = array();
+		$clientPath = $this->_currentFolder->getClientPath();
+		$sServerDir = $this->_currentFolder->getServerPath();
+		$currentResourceTypeConfig = $this->_currentFolder->getResourceTypeConfig();
+		$_config =& CKFinder_Connector_Core_Factory::getInstance("Core_Config");
+		$_aclConfig = $_config->getAccessControlConfig();
+		$aclMasks = array();
+		$_resourceTypeConfig = array();
 
-        if (!$this->_currentFolder->checkAcl(CKFINDER_CONNECTOR_ACL_FILE_RENAME | CKFINDER_CONNECTOR_ACL_FILE_UPLOAD | CKFINDER_CONNECTOR_ACL_FILE_DELETE)) {
-            $this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_UNAUTHORIZED);
-        }
+		if (!$this->_currentFolder->checkAcl(CKFINDER_CONNECTOR_ACL_FILE_RENAME | CKFINDER_CONNECTOR_ACL_FILE_UPLOAD | CKFINDER_CONNECTOR_ACL_FILE_DELETE)) {
+			$this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_UNAUTHORIZED);
+		}
 
-        // Create the "Errors" node.
-        $oErrorsNode = new CKFinder_Connector_Utils_XmlNode("Errors");
-        $errorCode = CKFINDER_CONNECTOR_ERROR_NONE;
-        $moved = 0;
-        $movedAll = 0;
-        if (!empty($_POST['moved'])) {
-            $movedAll = intval($_POST['moved']);
-        }
-        $checkedPaths = array();
+		// Create the "Errors" node.
+		$oErrorsNode = new CKFinder_Connector_Utils_XmlNode("Errors");
+		$errorCode = CKFINDER_CONNECTOR_ERROR_NONE;
+		$moved = 0;
+		$movedAll = 0;
+		if (!empty($_POST['moved'])) {
+			$movedAll = intval($_POST['moved']);
+		}
+		$checkedPaths = array();
 
-        $oMoveFilesNode = new Ckfinder_Connector_Utils_XmlNode("MoveFiles");
+		$oMoveFilesNode = new Ckfinder_Connector_Utils_XmlNode("MoveFiles");
 
-        if (!empty($_POST['files']) && is_array($_POST['files'])) {
-            foreach ($_POST['files'] as $index => $arr) {
-                if (empty($arr['name'])) {
-                    continue;
-                }
-                if (!isset($arr['name'], $arr['type'], $arr['folder'])) {
-                    $this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_INVALID_REQUEST);
-                }
+		if (!empty($_POST['files']) && is_array($_POST['files'])) {
+			foreach ($_POST['files'] as $index => $arr) {
+				if (empty($arr['name'])) {
+					continue;
+				}
+				if (!isset($arr['name'], $arr['type'], $arr['folder'])) {
+					$this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_INVALID_REQUEST);
+				}
 
-                // file name
-                $name = CKFinder_Connector_Utils_FileSystem::convertToFilesystemEncoding($arr['name']);
-                // resource type
-                $type = $arr['type'];
-                // client path
-                $path = CKFinder_Connector_Utils_FileSystem::convertToFilesystemEncoding($arr['folder']);
-                // options
-                $options = (!empty($arr['options'])) ? $arr['options'] : '';
+				// file name
+				$name = CKFinder_Connector_Utils_FileSystem::convertToFilesystemEncoding($arr['name']);
+				// resource type
+				$type = $arr['type'];
+				// client path
+				$path = CKFinder_Connector_Utils_FileSystem::convertToFilesystemEncoding($arr['folder']);
+				// options
+				$options = (!empty($arr['options'])) ? $arr['options'] : '';
 
-                $destinationFilePath = $sServerDir.$name;
+				$destinationFilePath = $sServerDir.$name;
 
-                // check #1 (path)
-                if (!CKFinder_Connector_Utils_FileSystem::checkFileName($name) || preg_match(CKFINDER_REGEX_INVALID_PATH, $path)) {
-                    $this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_INVALID_REQUEST);
-                }
+				// check #1 (path)
+				if (!CKFinder_Connector_Utils_FileSystem::checkFileName($name) || preg_match(CKFINDER_REGEX_INVALID_PATH, $path)) {
+					$this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_INVALID_REQUEST);
+				}
 
-                // get resource type config for current file
-                if (!isset($_resourceTypeConfig[$type])) {
-                    $_resourceTypeConfig[$type] = $_config->getResourceTypeConfig($type);
-                }
+				// get resource type config for current file
+				if (!isset($_resourceTypeConfig[$type])) {
+					$_resourceTypeConfig[$type] = $_config->getResourceTypeConfig($type);
+				}
 
-                // check #2 (resource type)
-                if (is_null($_resourceTypeConfig[$type])) {
-                    $this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_INVALID_REQUEST);
-                }
+				// check #2 (resource type)
+				if (is_null($_resourceTypeConfig[$type])) {
+					$this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_INVALID_REQUEST);
+				}
 
-                // check #3 (extension)
-                if (!$_resourceTypeConfig[$type]->checkExtension($name, false)) {
-                    $errorCode = CKFINDER_CONNECTOR_ERROR_INVALID_EXTENSION;
-                    $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
-                    continue;
-                }
+				// check #3 (extension)
+				if (!$_resourceTypeConfig[$type]->checkExtension($name, false)) {
+					$errorCode = CKFINDER_CONNECTOR_ERROR_INVALID_EXTENSION;
+					$this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
+					continue;
+				}
 
-                // check #4 (extension) - when moving to another resource type, double check extension
-                if ($currentResourceTypeConfig->getName() != $type) {
-                    if (!$currentResourceTypeConfig->checkExtension($name, false)) {
-                        $errorCode = CKFINDER_CONNECTOR_ERROR_INVALID_EXTENSION;
-                        $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
-                        continue;
-                    }
-                }
+				// check #4 (extension) - when moving to another resource type, double check extension
+				if ($currentResourceTypeConfig->getName() != $type) {
+					if (!$currentResourceTypeConfig->checkExtension($name, false)) {
+						$errorCode = CKFINDER_CONNECTOR_ERROR_INVALID_EXTENSION;
+						$this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
+						continue;
+					}
+				}
 
-                // check #5 (hidden folders)
-                // cache results
-                if (empty($checkedPaths[$path])) {
-                    $checkedPaths[$path] = true;
+				// check #5 (hidden folders)
+				// cache results
+				if (empty($checkedPaths[$path])) {
+					$checkedPaths[$path] = true;
 
-                    if ($_resourceTypeConfig[$type]->checkIsHiddenPath($path)) {
-                        $this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_INVALID_REQUEST);
-                    }
-                }
+					if ($_resourceTypeConfig[$type]->checkIsHiddenPath($path)) {
+						$this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_INVALID_REQUEST);
+					}
+				}
 
-                $sourceFilePath = $_resourceTypeConfig[$type]->getDirectory().$path.$name;
+				$sourceFilePath = $_resourceTypeConfig[$type]->getDirectory().$path.$name;
 
-                // check #6 (hidden file name)
-                if ($currentResourceTypeConfig->checkIsHiddenFile($name)) {
-                    $this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_INVALID_REQUEST);
-                }
+				// check #6 (hidden file name)
+				if ($currentResourceTypeConfig->checkIsHiddenFile($name)) {
+					$this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_INVALID_REQUEST);
+				}
 
-                // check #7 (Access Control, need file view permission to source files)
-                if (!isset($aclMasks[$type."@".$path])) {
-                    $aclMasks[$type."@".$path] = $_aclConfig->getComputedMask($type, $path);
-                }
+				// check #7 (Access Control, need file view permission to source files)
+				if (!isset($aclMasks[$type."@".$path])) {
+					$aclMasks[$type."@".$path] = $_aclConfig->getComputedMask($type, $path);
+				}
 
-                $isAuthorized = (($aclMasks[$type."@".$path] & CKFINDER_CONNECTOR_ACL_FILE_VIEW) == CKFINDER_CONNECTOR_ACL_FILE_VIEW);
-                if (!$isAuthorized) {
-                    $this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_UNAUTHORIZED);
-                }
+				$isAuthorized = (($aclMasks[$type."@".$path] & CKFINDER_CONNECTOR_ACL_FILE_VIEW) == CKFINDER_CONNECTOR_ACL_FILE_VIEW);
+				if (!$isAuthorized) {
+					$this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_UNAUTHORIZED);
+				}
 
-                // check #8 (invalid file name)
-                if (!file_exists($sourceFilePath) || !is_file($sourceFilePath)) {
-                    $errorCode = CKFINDER_CONNECTOR_ERROR_FILE_NOT_FOUND;
-                    $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
-                    continue;
-                }
+				// check #8 (invalid file name)
+				if (!file_exists($sourceFilePath) || !is_file($sourceFilePath)) {
+					$errorCode = CKFINDER_CONNECTOR_ERROR_FILE_NOT_FOUND;
+					$this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
+					continue;
+				}
 
-                // check #9 (max size)
-                if ($currentResourceTypeConfig->getName() != $type) {
-                    $maxSize = $currentResourceTypeConfig->getMaxSize();
-                    $fileSize = filesize($sourceFilePath);
-                    if ($maxSize && $fileSize>$maxSize) {
-                        $errorCode = CKFINDER_CONNECTOR_ERROR_UPLOADED_TOO_BIG;
-                        $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
-                        continue;
-                    }
-                }
+				// check #9 (max size)
+				if ($currentResourceTypeConfig->getName() != $type) {
+					$maxSize = $currentResourceTypeConfig->getMaxSize();
+					$fileSize = filesize($sourceFilePath);
+					if ($maxSize && $fileSize>$maxSize) {
+						$errorCode = CKFINDER_CONNECTOR_ERROR_UPLOADED_TOO_BIG;
+						$this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
+						continue;
+					}
+				}
 
-                //$overwrite
-                // finally, no errors so far, we may attempt to copy a file
-                // protection against copying files to itself
-                if ($sourceFilePath == $destinationFilePath) {
-                    $errorCode = CKFINDER_CONNECTOR_ERROR_SOURCE_AND_TARGET_PATH_EQUAL;
-                    $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
-                    continue;
-                }
-                // check if file exists if we don't force overwriting
-                else if (file_exists($destinationFilePath)) {
-                    if (strpos($options, "overwrite") !== false) {
-                        if (!@unlink($destinationFilePath)) {
-                            $errorCode = CKFINDER_CONNECTOR_ERROR_ACCESS_DENIED;
-                            $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
-                            continue;
-                        }
-                        else {
-                            if (!@rename($sourceFilePath, $destinationFilePath)) {
-                                $errorCode = CKFINDER_CONNECTOR_ERROR_ACCESS_DENIED;
-                                $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
-                                continue;
-                            }
-                            else {
-                                $moved++;
-                            }
-                        }
-                    }
-                    else if (strpos($options, "autorename") !== false) {
-                        $iCounter = 1;
-                        while (true)
-                        {
-                            $fileName = CKFinder_Connector_Utils_FileSystem::getFileNameWithoutExtension($name) .
-                                "(" . $iCounter . ")" . "." .
-                                CKFinder_Connector_Utils_FileSystem::getExtension($name);
+				//$overwrite
+				// finally, no errors so far, we may attempt to copy a file
+				// protection against copying files to itself
+				if ($sourceFilePath == $destinationFilePath) {
+					$errorCode = CKFINDER_CONNECTOR_ERROR_SOURCE_AND_TARGET_PATH_EQUAL;
+					$this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
+					continue;
+				}
+				// check if file exists if we don't force overwriting
+				else if (file_exists($destinationFilePath)) {
+					if (strpos($options, "overwrite") !== false) {
+						if (!@unlink($destinationFilePath)) {
+							$errorCode = CKFINDER_CONNECTOR_ERROR_ACCESS_DENIED;
+							$this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
+							continue;
+						}
+						else {
+							if (!@rename($sourceFilePath, $destinationFilePath)) {
+								$errorCode = CKFINDER_CONNECTOR_ERROR_ACCESS_DENIED;
+								$this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
+								continue;
+							}
+							else {
+								$moved++;
+							}
+						}
+					}
+					else if (strpos($options, "autorename") !== false) {
+						$iCounter = 1;
+						while (true)
+						{
+							$fileName = CKFinder_Connector_Utils_FileSystem::getFileNameWithoutExtension($name) .
+								"(" . $iCounter . ")" . "." .
+								CKFinder_Connector_Utils_FileSystem::getExtension($name);
 
-                            $destinationFilePath = $sServerDir.$fileName;
-                            if (!file_exists($destinationFilePath)) {
-                                break;
-                            }
-                            else {
-                                $iCounter++;
-                            }
-                        }
-                        if (!@rename($sourceFilePath, $destinationFilePath)) {
-                            $errorCode = CKFINDER_CONNECTOR_ERROR_ACCESS_DENIED;
-                            $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
-                            continue;
-                        }
-                        else {
-                            $moved++;
-                        }
-                    }
-                    else {
-                        $errorCode = CKFINDER_CONNECTOR_ERROR_ALREADY_EXIST;
-                        $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
-                        continue;
-                    }
-                }
-                else {
-                    if (!@rename($sourceFilePath, $destinationFilePath)) {
-                        $errorCode = CKFINDER_CONNECTOR_ERROR_ACCESS_DENIED;
-                        $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
-                        continue;
-                    }
-                    else {
-                        $moved++;
-                    }
-                }
-            }
-        }
+							$destinationFilePath = $sServerDir.$fileName;
+							if (!file_exists($destinationFilePath)) {
+								break;
+							}
+							else {
+								$iCounter++;
+							}
+						}
+						if (!@rename($sourceFilePath, $destinationFilePath)) {
+							$errorCode = CKFINDER_CONNECTOR_ERROR_ACCESS_DENIED;
+							$this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
+							continue;
+						}
+						else {
+							$moved++;
+						}
+					}
+					else {
+						$errorCode = CKFINDER_CONNECTOR_ERROR_ALREADY_EXIST;
+						$this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
+						continue;
+					}
+				}
+				else {
+					if (!@rename($sourceFilePath, $destinationFilePath)) {
+						$errorCode = CKFINDER_CONNECTOR_ERROR_ACCESS_DENIED;
+						$this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
+						continue;
+					}
+					else {
+						$moved++;
+					}
+				}
+			}
+		}
 
-        $this->_connectorNode->addChild($oMoveFilesNode);
-        if ($errorCode != CKFINDER_CONNECTOR_ERROR_NONE) {
-            $this->_connectorNode->addChild($oErrorsNode);
-        }
-        $oMoveFilesNode->addAttribute("moved", $moved);
-        $oMoveFilesNode->addAttribute("movedTotal", $movedAll + $moved);
+		$this->_connectorNode->addChild($oMoveFilesNode);
+		if ($errorCode != CKFINDER_CONNECTOR_ERROR_NONE) {
+			$this->_connectorNode->addChild($oErrorsNode);
+		}
+		$oMoveFilesNode->addAttribute("moved", $moved);
+		$oMoveFilesNode->addAttribute("movedTotal", $movedAll + $moved);
 
-        /**
-         * Note: actually we could have more than one error.
-         * This is just a flag for CKFinder interface telling it to check all errors.
-         */
-        if ($errorCode != CKFINDER_CONNECTOR_ERROR_NONE) {
-            $this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_MOVE_FAILED);
-        }
-    }
+		/**
+		 * Note: actually we could have more than one error.
+		 * This is just a flag for CKFinder interface telling it to check all errors.
+		 */
+		if ($errorCode != CKFINDER_CONNECTOR_ERROR_NONE) {
+			$this->_errorHandler->throwError(CKFINDER_CONNECTOR_ERROR_MOVE_FAILED);
+		}
+	}
 
-    private function appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path)
-    {
-        $oErrorNode = new CKFinder_Connector_Utils_XmlNode("Error");
-        $oErrorNode->addAttribute("code", $errorCode);
-        $oErrorNode->addAttribute("name", CKFinder_Connector_Utils_FileSystem::convertToConnectorEncoding($name));
-        $oErrorNode->addAttribute("type", $type);
-        $oErrorNode->addAttribute("folder", $path);
-        $oErrorsNode->addChild($oErrorNode);
-    }
+	private function appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path)
+	{
+		$oErrorNode = new CKFinder_Connector_Utils_XmlNode("Error");
+		$oErrorNode->addAttribute("code", $errorCode);
+		$oErrorNode->addAttribute("name", CKFinder_Connector_Utils_FileSystem::convertToConnectorEncoding($name));
+		$oErrorNode->addAttribute("type", $type);
+		$oErrorNode->addAttribute("folder", $path);
+		$oErrorsNode->addChild($oErrorNode);
+	}
 }

Spacing +5 added lines, -5 removed lines

@@ -21,7 +21,7 @@ 
 /**
  * Include base XML command handler
  */
-require_once CKFINDER_CONNECTOR_LIB_DIR . "/CommandHandler/XmlCommandHandlerBase.php";
+require_once CKFINDER_CONNECTOR_LIB_DIR."/CommandHandler/XmlCommandHandlerBase.php";
 
 /**
  * Handle MoveFiles command
@@ -55,7 +55,7 @@ 
         $clientPath = $this->_currentFolder->getClientPath();
         $sServerDir = $this->_currentFolder->getServerPath();
         $currentResourceTypeConfig = $this->_currentFolder->getResourceTypeConfig();
-        $_config =& CKFinder_Connector_Core_Factory::getInstance("Core_Config");
+        $_config = & CKFinder_Connector_Core_Factory::getInstance("Core_Config");
         $_aclConfig = $_config->getAccessControlConfig();
         $aclMasks = array();
         $_resourceTypeConfig = array();
@@ -165,7 +165,7 @@ 
                 if ($currentResourceTypeConfig->getName() != $type) {
                     $maxSize = $currentResourceTypeConfig->getMaxSize();
                     $fileSize = filesize($sourceFilePath);
-                    if ($maxSize && $fileSize>$maxSize) {
+                    if ($maxSize && $fileSize > $maxSize) {
                         $errorCode = CKFINDER_CONNECTOR_ERROR_UPLOADED_TOO_BIG;
                         $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
                         continue;
@@ -203,8 +203,8 @@ 
                         $iCounter = 1;
                         while (true)
                         {
-                            $fileName = CKFinder_Connector_Utils_FileSystem::getFileNameWithoutExtension($name) .
-                                "(" . $iCounter . ")" . "." .
+                            $fileName = CKFinder_Connector_Utils_FileSystem::getFileNameWithoutExtension($name).
+                                "(".$iCounter.")".".".
                                 CKFinder_Connector_Utils_FileSystem::getExtension($name);
 
                             $destinationFilePath = $sServerDir.$fileName;

Braces +11 added lines, -17 removed lines

@@ -10,7 +10,9 @@ 
  * modifying or distribute this file or part of its contents. The contents of
  * this file is part of the Source Code of CKFinder.
  */
-if (!defined('IN_CKFINDER')) exit;
+if (!defined('IN_CKFINDER')) {
+	exit;
+}
 
 /**
  * @package CKFinder
@@ -187,19 +189,16 @@ 
                             $errorCode = CKFINDER_CONNECTOR_ERROR_ACCESS_DENIED;
                             $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
                             continue;
-                        }
-                        else {
+                        } else {
                             if (!@rename($sourceFilePath, $destinationFilePath)) {
                                 $errorCode = CKFINDER_CONNECTOR_ERROR_ACCESS_DENIED;
                                 $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
                                 continue;
-                            }
-                            else {
+                            } else {
                                 $moved++;
                             }
                         }
-                    }
-                    else if (strpos($options, "autorename") !== false) {
+                    } else if (strpos($options, "autorename") !== false) {
                         $iCounter = 1;
                         while (true)
                         {
@@ -210,8 +209,7 @@ 
                             $destinationFilePath = $sServerDir.$fileName;
                             if (!file_exists($destinationFilePath)) {
                                 break;
-                            }
-                            else {
+                            } else {
                                 $iCounter++;
                             }
                         }
@@ -219,24 +217,20 @@ 
                             $errorCode = CKFINDER_CONNECTOR_ERROR_ACCESS_DENIED;
                             $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
                             continue;
-                        }
-                        else {
+                        } else {
                             $moved++;
                         }
-                    }
-                    else {
+                    } else {
                         $errorCode = CKFINDER_CONNECTOR_ERROR_ALREADY_EXIST;
                         $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
                         continue;
                     }
-                }
-                else {
+                } else {
                     if (!@rename($sourceFilePath, $destinationFilePath)) {
                         $errorCode = CKFINDER_CONNECTOR_ERROR_ACCESS_DENIED;
                         $this->appendErrorNode($oErrorsNode, $errorCode, $name, $type, $path);
                         continue;
-                    }
-                    else {
+                    } else {
                         $moved++;
                     }
                 }