Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | class RouterModule { |
||
9 | //varaibles de base de config |
||
10 | private $controller; |
||
11 | private $erreur; |
||
12 | private $parametre; |
||
13 | private $module; //varialbe qui contiendra le nom d'un module |
||
14 | private $page; |
||
15 | private $admin; //permet de savoir si on est dans l'administration du site ou pas et de charger lebon router |
||
16 | |||
17 | |||
18 | //-------------------------- GETTER ----------------------------------------------------------------------------// |
||
19 | //pour les parametres du getUrl ++ getAction ++ getController |
||
20 | public function getParametre() { |
||
26 | public function getModule() { |
||
27 | return $this->module; |
||
28 | } |
||
29 | public function getController() { |
||
32 | public function getErreur() { |
||
33 | return $this->erreur; |
||
35 | |||
36 | private function getAllModules() { |
||
50 | |||
51 | /** |
||
52 | * @param $url |
||
53 | * @param null $admin |
||
54 | * @return string |
||
55 | * Permets de générer l'url pour aller charger la page concernee pour le module blog |
||
56 | * appele également l'actoin à effectur dans la page |
||
57 | */ |
||
58 | public function getUrl($url, $admin = "app") { |
||
59 | $explode = explode("/", $url); |
||
60 | $count = count($explode); |
||
61 | $debut_url = ""; |
||
62 | $centre_url = ""; |
||
63 | |||
64 | for ($i = 0; $i < $count; $i++) { |
||
65 | if (in_array($explode[$i], $this->getAllModules())) { |
||
66 | $this->module = $explode[$i]; |
||
67 | $debut_url = $explode[$i]; |
||
68 | } |
||
69 | else if ($i >= 1) { |
||
70 | $centre_url[] = $explode[$i]; |
||
71 | } |
||
72 | } |
||
73 | $centre_url = $this->setPathFile($debut_url, $centre_url, $admin); |
||
74 | $this->admin = $admin; |
||
75 | $this->setActionPage(); |
||
76 | |||
77 | return $centre_url."/".$this->parametre; |
||
78 | } |
||
79 | |||
80 | /** |
||
81 | * fonction qui permet de tester qu'une route existe bien |
||
82 | * appellee dans redirectError.class.php |
||
83 | * @param $url |
||
84 | */ |
||
85 | View Code Duplication | public function getRouteModuleExist($url) { |
|
99 | |||
100 | /** |
||
101 | * @param $url |
||
102 | * @param $url_test |
||
103 | * @return bool |
||
104 | */ |
||
105 | private function getTestUrlExist($url, $url_test) { |
||
116 | //-------------------------- FIN GETTER ----------------------------------------------------------------------------// |
||
117 | |||
118 | |||
119 | |||
120 | //-------------------------- SETTER ----------------------------------------------------------------------------// |
||
121 | /** |
||
122 | * @param $debut_url |
||
123 | * @param $centre_url |
||
124 | * @param $admin |
||
125 | * @return array|string |
||
126 | */ |
||
127 | private function setPathFile($debut_url, $centre_url, $admin) { |
||
148 | |||
149 | /** |
||
150 | * Fonction qui va se charger en focntion $this->page et de $this->action d'appeler la fonctoin qui va bien |
||
151 | * fontction appelee dans getUrl() |
||
152 | */ |
||
153 | private function setActionPage() { |
||
162 | //-------------------------- FIN SETTER ----------------------------------------------------------------------------// |
||
163 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.