Unite - Code Metrics - Inspection of "update units now show caracteristics in attack, de..." - Piou-piou/Ruined-World - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( f99231...67efd0 )

by Anthony

created 2016-12-10 20:55 UTC

Unite A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	80
Duplicated Lines	11.25 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	11
lcom	1
cbo	1
dl	9
loc	80
rs	10
c	2
b	0
f	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	9	9	4
B	getCaracteristiqueUnite()	0	29	5
A	getUnitePossibleRecruter()	0	12	2

How to fix Duplicated Code

<?php
	
	namespace modules\bataille\app\controller;
	
	
	class Unite {
		private $coef_unite;


		
		//-------------------------- BUILDER ----------------------------------------------------------------------------//
		public function __construct() {

			$dbc1 = Bataille::getDb();

			$query = $dbc1->select("coef_niveau_unite")->from("configuration")->where("ID_configuration", "=", 1)->get();

			if ((is_array($query)) && (count($query) == 1)) {
				foreach ($query as $obj) $this->coef_unite = $obj->coef_niveau_unite;
			}
		}
		//-------------------------- END BUILDER ----------------------------------------------------------------------------//
		
		
		//-------------------------- GETTER ----------------------------------------------------------------------------//

		/**
		 * @param $unite
		 * @param $niveau
		 * @param $type
		 * @return array
		 * récupère les caractéristiques de l'unité en fonction de son niveau
		 */
		private function getCaracteristiqueUnite($unite, $niveau, $type) {
			$dbc1 = Bataille::getDb();

			$query = $dbc1->select()
				->from("unites")
				->where("nom", "=", $unite, "AND")
				->where("type", "=", $type, "")
				->get();

			if ((is_array($query)) && (count($query) == 1)) {
				foreach ($query as $obj) {
					$base_carac = unserialize($obj->caracteristique);
				}

				$coef = $this->coef_unite*$niveau;

				if ($niveau == 1) $coef = 1;

				return [
					"attaque" => round($base_carac["attaque"]*$coef),
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
					"defense" => round($base_carac["defense"]*$coef),
					"resistance" => round($base_carac["resistance"]*$coef),
					"vitesse" => $base_carac["vitesse"]
				];
			}
			else {
				return [];
			}
		}

		/**
		 * @param $type
		 * fonction qui permet de récupérer les unités qu'i est possible de recruter en fonction
		 * du type (batiment sur lequel on a cliqué)
		 */
		public function getUnitePossibleRecruter($type) {
			//on recup toutes les unites deja recherchée donc que l'on peut faire
			$unites = Bataille::getCentreRecherche()->getAllRechercheType($type);

			//recupérer les caractéristiques de l'unité en question
			for ($i=0 ; $i<count($unites) ; $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
				$unites[$i]["caracteristique"] = $this->getCaracteristiqueUnite($unites[$i]["recherche"], $unites[$i]["niveau"], $type);
			}

			//si pas d'unites encore recherchees on renvoit un array juste avec 0 dedans
			Bataille::setValues(["unites" => $unites]);
		}
		//-------------------------- END GETTER ----------------------------------------------------------------------------//
		
		
		//-------------------------- SETTER ----------------------------------------------------------------------------//
		//-------------------------- END SETTER ----------------------------------------------------------------------------//    
	}

1		<?php
2
3		namespace modules\bataille\app\controller;
4
5
6		class Unite {
7		private $coef_unite;
8
9
10
11		//-------------------------- BUILDER ----------------------------------------------------------------------------//
12	View Code Duplication	public function __construct() {
		0 ignored issues – show Duplication introduced 2016-12-10 20:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
13		$dbc1 = Bataille::getDb();
14
15		$query = $dbc1->select("coef_niveau_unite")->from("configuration")->where("ID_configuration", "=", 1)->get();
16
17		if ((is_array($query)) && (count($query) == 1)) {
18		foreach ($query as $obj) $this->coef_unite = $obj->coef_niveau_unite;
19		}
20		}
21		//-------------------------- END BUILDER ----------------------------------------------------------------------------//
22
23
24		//-------------------------- GETTER ----------------------------------------------------------------------------//
25
26		/**
27		* @param $unite
28		* @param $niveau
29		* @param $type
30		* @return array
31		* récupère les caractéristiques de l'unité en fonction de son niveau
32		*/
33		private function getCaracteristiqueUnite($unite, $niveau, $type) {
34		$dbc1 = Bataille::getDb();
35
36		$query = $dbc1->select()
37		->from("unites")
38		->where("nom", "=", $unite, "AND")
39		->where("type", "=", $type, "")
40		->get();
41
42		if ((is_array($query)) && (count($query) == 1)) {
43		foreach ($query as $obj) {
44		$base_carac = unserialize($obj->caracteristique);
45		}
46
47		$coef = $this->coef_unite*$niveau;
48
49		if ($niveau == 1) $coef = 1;
50
51		return [
52		"attaque" => round($base_carac["attaque"]*$coef),
		0 ignored issues – show Bug introduced 2016-12-10 20:57 UTC by Report Bug Copy Issue Report The variable `$base_carac` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
53		"defense" => round($base_carac["defense"]*$coef),
54		"resistance" => round($base_carac["resistance"]*$coef),
55		"vitesse" => $base_carac["vitesse"]
56		];
57		}
58		else {
59		return [];
60		}
61		}
62
63		/**
64		* @param $type
65		* fonction qui permet de récupérer les unités qu'i est possible de recruter en fonction
66		* du type (batiment sur lequel on a cliqué)
67		*/
68		public function getUnitePossibleRecruter($type) {
69		//on recup toutes les unites deja recherchée donc que l'on peut faire
70		$unites = Bataille::getCentreRecherche()->getAllRechercheType($type);
71
72		//recupérer les caractéristiques de l'unité en question
73		for ($i=0 ; $i<count($unites) ; $i++) {
		0 ignored issues – show Performance Best Practice introduced 2016-12-10 20:57 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
74		$unites[$i]["caracteristique"] = $this->getCaracteristiqueUnite($unites[$i]["recherche"], $unites[$i]["niveau"], $type);
75		}
76
77		//si pas d'unites encore recherchees on renvoit un array juste avec 0 dedans
78		Bataille::setValues(["unites" => $unites]);
79		}
80		//-------------------------- END GETTER ----------------------------------------------------------------------------//
81
82
83		//-------------------------- SETTER ----------------------------------------------------------------------------//
84		//-------------------------- END SETTER ----------------------------------------------------------------------------//
85		}

Piou-piou / Ruined-World

Push — master ( f99231...67efd0 )

Unite A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Duplication Side-by-Side

Filter issues like