Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | class Profil { |
||
9 | private $vacances; |
||
10 | |||
11 | //-------------------------- BUILDER ----------------------------------------------------------------------------// |
||
12 | public function __construct() { |
||
28 | //-------------------------- END BUILDER ----------------------------------------------------------------------------// |
||
29 | |||
30 | |||
31 | //-------------------------- GETTER ----------------------------------------------------------------------------// |
||
32 | public function getVacances(){ |
||
35 | |||
36 | /** |
||
37 | * @return string |
||
38 | * fonction qui test si le compte est en mode vacances ou pas |
||
39 | */ |
||
40 | public function getTestModeVacances() { |
||
57 | |||
58 | /** |
||
59 | * @return string |
||
60 | * fonction qui renvoi la durée depuis lquelle le compte est en vacances |
||
61 | */ |
||
62 | public function getDureeVacances() { |
||
70 | //-------------------------- END GETTER ----------------------------------------------------------------------------// |
||
71 | |||
72 | |||
73 | //-------------------------- SETTER ----------------------------------------------------------------------------// |
||
74 | /** |
||
75 | * fonction qui permet d'activer le mode vacances |
||
76 | */ |
||
77 | public static function setActiverModeVacances() { |
||
82 | |||
83 | /** |
||
84 | * fonction qui permet de finir le mode vacances |
||
85 | */ |
||
86 | View Code Duplication | public function setDesactiverModeVacances() { |
|
96 | //-------------------------- END SETTER ----------------------------------------------------------------------------// |
||
97 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.