modules\bataille\app\controller\Batiment::getBatimentAConstruire()

Complexity

Conditions	21
Paths	88

Size

Total Lines	123
Code Lines	77

Duplication

Lines	24
Ratio	19.51 %

Importance

Changes

0

<?php
		public function getBatimentAConstruire() {
			$dbc = App::getDb();
			$dbc1 = Bataille::getDb();
			$batiment_construit = [];
			$batiment_construire = [];

			//recuperation des batiments deja construit dans la base
			$query = $dbc->select("nom_batiment_sql")
				->select("nom_batiment")
				->select("niveau")
				->from("_bataille_batiment")
				->where("ID_base", "=", Bataille::getIdBase())
				->get();

			if ((is_array($query)) && (count($query) > 0)) {
				foreach ($query as $obj) {
					$batiment_construit[] = $obj->nom_batiment_sql;
				}
			}

			//recuperation de la liste complete des batiments
			$query = $dbc1->select("nom_table")->select("nom")->from("liste_batiment")->where("actif", "=", 1)->get();
			if ((is_array($query)) && (count($query) > 0)) {
				foreach ($query as $obj) {
					$all_batiment[] = $obj->nom_table;

$all_batiment was never initialized. Although not strictly required by PHP, it is generally a good practice to add $all_batiment = array(); before regardless.

					$all_batiment_nom[] = $obj->nom;

$all_batiment_nom was never initialized. Although not strictly required by PHP, it is generally a good practice to add $all_batiment_nom = array(); before regardless.

				}

				$c_all_batiment = count($all_batiment);

The variable $all_batiment does not seem to be defined for all execution paths leading up to this point.

			}

			//boucle qui recupere en tableau le champ pour_construire d'un batiment
			//et compare la liste des batiments qu'il faut pour construire le batiment
			//a ceux qui sont deja construit dans la base
			//si tous les batments qu'il faut son batis on autorise la construction du batiment
			for ($i=0 ; $i<$c_all_batiment ; $i++) {

The variable $c_all_batiment does not seem to be defined for all execution paths leading up to this point.

				if (!in_array($all_batiment[$i], $batiment_construit)) {
					$query = $dbc1->select("pour_construire")
						->select("temps_construction")
						->from($all_batiment[$i])
						->where("ID_".$all_batiment[$i], "=", 1)
						->get();

					if ((is_array($query)) && (count($query) > 0)) {
						foreach ($query as $obj) {
							if ($obj->pour_construire != null) {
								$pour_construire = unserialize($obj->pour_construire);
							}
							else {
								$pour_construire = [];
							}

							$temps_construction = gmdate("H:i:s", round($obj->temps_construction-($obj->temps_construction*Bataille::getBatiment()->getNiveauBatiment("centre_commandement")/100)));
							$taille_batiment = $this->getTailleBatiment($all_batiment[$i]);
						}
					}


					if (count($pour_construire) == 1) {
						if (in_array($pour_construire[0][1], $batiment_construit)) {
							if ($pour_construire[0][2] <= $this->getNiveauBatiment($pour_construire[0][1])) {

The variable $pour_construire does not seem to be defined for all execution paths leading up to this point.

								$ressource = $this->getRessourceConstruireBatiment($all_batiment[$i], 0);

								$batiment_construire[] = [
									"nom_batiment_sql" => $all_batiment[$i],
									"nom_batiment" => $all_batiment_nom[$i],

The variable $all_batiment_nom does not seem to be defined for all execution paths leading up to this point.

									"ressource" => $ressource,
									"temps_construction" => $temps_construction,

The variable $temps_construction does not seem to be defined for all execution paths leading up to this point.

									"width" => $taille_batiment[0],

The variable $taille_batiment does not seem to be defined for all execution paths leading up to this point.

									"height" => $taille_batiment[1]
								];
							}
						}
					}
					else if (count($pour_construire) > 1) {
						$ok_construction = false;
						//test si tous les batiments sont construits et on le niveau nécéssaire
						for ($j=0 ; $j<count($pour_construire) ; $j++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

							if (in_array($pour_construire[$j][1], $batiment_construit)) {
								if ($pour_construire[$j][2] <= $this->getNiveauBatiment($pour_construire[$j][1])) {
									$ok_construction = true;
								}
								else {
									$ok_construction = false;
									break;
								}
							}
							else {
								$ok_construction = false;
								break;
							}
						}

						//si ok on affiche le batiment
						if ($ok_construction === true) {

This code seems to be duplicated across your project.

							$ressource = $this->getRessourceConstruireBatiment($all_batiment[$i], 0);

							$batiment_construire[] = [
								"nom_batiment_sql" => $all_batiment[$i],
								"nom_batiment" => $all_batiment_nom[$i],
								"ressource" => $ressource,
								"temps_construction" => $temps_construction,
								"width" => $taille_batiment[0],
								"height" => $taille_batiment[1]
							];
						}
					}
					else {

This code seems to be duplicated across your project.

						$ressource = $this->getRessourceConstruireBatiment($all_batiment[$i], 0);

						$batiment_construire[] = [
							"nom_batiment_sql" => $all_batiment[$i],
							"nom_batiment" => $all_batiment_nom[$i],
							"ressource" => $ressource,
							"temps_construction" => $temps_construction,
							"width" => $taille_batiment[0],
							"height" => $taille_batiment[1]
						];
					}
				}
			}
			Bataille::setValues(["batiments_construire" => $batiment_construire]);
		}
		
	}