CentreRecherche - Code Metrics - Inspection of "update centre recherche to fomat better informatio..." - Piou-piou/Ruined-World - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 41afcc...1faf28 )

by Anthony

created 2016-12-19 14:39 UTC

CentreRecherche A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	107
Duplicated Lines	26.17 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
wmc	17
c	4
b	0
f	0
lcom	0
cbo	3
dl	28
loc	107
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
C	__construct()	18	65	13
A	getAllRechercheType()	10	18	4

How to fix Duplicated Code

<?php
	/**
	 * Created by PhpStorm.
	 * User: anthony
	 * Date: 08/12/2016
	 * Time: 20:44
	 */
	
	namespace modules\bataille\app\controller;
	
	
	use core\App;

	class CentreRecherche {
		private $coef_centre;
		
		
		//-------------------------- BUILDER ----------------------------------------------------------------------------//
		public function __construct() {
			$dbc = App::getDb();
			$dbc1 = Bataille::getDb();

			$query = $dbc1->select("coef_centre_recherche")->from("configuration")->where("ID_configuration", "=", 1)->get();

			if ((is_array($query)) && (count($query) == 1)) {
				foreach ($query as $obj) $this->coef_centre = $obj->coef_centre_recherche;
			}

			$query = $dbc->select()->from("_bataille_centre_recherche")->where("ID_base", "=", Bataille::getIdBase())->get();

			if ((is_array($query)) && (count($query) > 0)) {

				foreach ($query as $obj) {
					$recherche_base[] = [
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
						"recherche" => $obj->recherche,
						"niveau" => $obj->niveau,
						"type" => $obj->type
					];
				}
			}

			$query = $dbc1->select()->from("recherche")
				->where("niveau_centre", "<=", Bataille::getBatiment()->getNiveauBatiment("centre_recherche"))
				->get();

			if ((is_array($query)) && (count($query) > 0)) {

				foreach ($query as $obj) {
					$all_recherche[] = [
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
						"recherche" => $obj->recherche,
						"type" => $obj->type,
						"cout" => unserialize($obj->cout)
					];
				}
			}

			$count = count($all_recherche);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

			for ($i=0 ; $i<$count ; $i++) {
				if ((in_array($all_recherche[$i]["recherche"], $recherche_base[$i]))) {
					$niveau = $recherche_base[$i]["niveau"];
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
					if ($niveau == 1) $this->coef_centre = 1;

					$all_recherche[$i]["cout"] = [
						"eau" => $all_recherche[$i]["cout"]["eau"]*($this->coef_centre*$niveau),
						"electricite" => $all_recherche[$i]["cout"]["electricite"]*($this->coef_centre*$niveau),
						"fer" => $all_recherche[$i]["cout"]["fer"]*($this->coef_centre*$niveau),
						"fuel" => $all_recherche[$i]["cout"]["fuel"]*($this->coef_centre*$niveau)
					];
					$ameliorer = true;
				}
				else {
					$ameliorer = false;
				}

				$centre_recherche[] = [
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
					"recherche" => $all_recherche[$i]["recherche"],
					"type" => $all_recherche[$i]["type"],
					"cout" => $all_recherche[$i]["cout"],
					"ameliorer" => $ameliorer
				];
			}

			Bataille::setValues(["centre_recherche" => $centre_recherche]);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		}
		//-------------------------- END BUILDER ----------------------------------------------------------------------------//
		
		
		
		//-------------------------- GETTER ----------------------------------------------------------------------------//
		/**
		 * @param $type
		 * @return array|int
		 * permet de renvoyer toutes es recherches déjà effectuées pour notre base en fonction
		 * d'un type donné
		 */
		public function getAllRechercheType($type) {
			$dbc = App::getDb();

			$query = $dbc->select()->from("_bataille_centre_recherche")->where("type", "=", $type)->get();

			if ((is_array($query)) && (count($query) > 0)) {

				foreach ($query as $obj) {
					$recherche[] = [
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
						"niveau" => $obj->niveau,
						"recherche" => $obj->recherche
					];
				}

				return $recherche;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
			}

			return 0;
		}
		//-------------------------- END GETTER ----------------------------------------------------------------------------//
		
		
		
		//-------------------------- SETTER ----------------------------------------------------------------------------//
		//-------------------------- END SETTER ----------------------------------------------------------------------------//
		
	}

1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: anthony
5		* Date: 08/12/2016
6		* Time: 20:44
7		*/
8
9		namespace modules\bataille\app\controller;
10
11
12		use core\App;
13
14		class CentreRecherche {
15		private $coef_centre;
16
17
18		//-------------------------- BUILDER ----------------------------------------------------------------------------//
19		public function __construct() {
20		$dbc = App::getDb();
21		$dbc1 = Bataille::getDb();
22
23		$query = $dbc1->select("coef_centre_recherche")->from("configuration")->where("ID_configuration", "=", 1)->get();
24
25		if ((is_array($query)) && (count($query) == 1)) {
26		foreach ($query as $obj) $this->coef_centre = $obj->coef_centre_recherche;
27		}
28
29		$query = $dbc->select()->from("_bataille_centre_recherche")->where("ID_base", "=", Bataille::getIdBase())->get();
30
31	View Code Duplication	if ((is_array($query)) && (count($query) > 0)) {
		0 ignored issues – show Duplication introduced 2016-12-19 14:41 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
32		foreach ($query as $obj) {
33		$recherche_base[] = [
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-12-16 18:51 UTC by Report Bug Copy Issue Report `$recherche_base` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$recherche_base = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
34		"recherche" => $obj->recherche,
35		"niveau" => $obj->niveau,
36		"type" => $obj->type
37		];
38		}
39		}
40
41		$query = $dbc1->select()->from("recherche")
42		->where("niveau_centre", "<=", Bataille::getBatiment()->getNiveauBatiment("centre_recherche"))
43		->get();
44
45	View Code Duplication	if ((is_array($query)) && (count($query) > 0)) {
		0 ignored issues – show Duplication introduced 2016-12-19 14:41 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
46		foreach ($query as $obj) {
47		$all_recherche[] = [
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-12-16 18:51 UTC by Report Bug Copy Issue Report `$all_recherche` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$all_recherche = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
48		"recherche" => $obj->recherche,
49		"type" => $obj->type,
50		"cout" => unserialize($obj->cout)
51		];
52		}
53		}
54
55		$count = count($all_recherche);
		0 ignored issues – show Bug introduced 2016-12-16 18:51 UTC by Report Bug Copy Issue Report The variable `$all_recherche` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
56
57		for ($i=0 ; $i<$count ; $i++) {
58		if ((in_array($all_recherche[$i]["recherche"], $recherche_base[$i]))) {
59		$niveau = $recherche_base[$i]["niveau"];
		0 ignored issues – show Bug introduced 2016-12-19 14:41 UTC by Report Bug Copy Issue Report The variable `$recherche_base` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
60		if ($niveau == 1) $this->coef_centre = 1;
61
62		$all_recherche[$i]["cout"] = [
63		"eau" => $all_recherche[$i]["cout"]["eau"]($this->coef_centre$niveau),
64		"electricite" => $all_recherche[$i]["cout"]["electricite"]($this->coef_centre$niveau),
65		"fer" => $all_recherche[$i]["cout"]["fer"]($this->coef_centre$niveau),
66		"fuel" => $all_recherche[$i]["cout"]["fuel"]($this->coef_centre$niveau)
67		];
68		$ameliorer = true;
69		}
70		else {
71		$ameliorer = false;
72		}
73
74		$centre_recherche[] = [
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-12-19 14:41 UTC by Report Bug Copy Issue Report `$centre_recherche` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$centre_recherche = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
75		"recherche" => $all_recherche[$i]["recherche"],
76		"type" => $all_recherche[$i]["type"],
77		"cout" => $all_recherche[$i]["cout"],
78		"ameliorer" => $ameliorer
79		];
80		}
81
82		Bataille::setValues(["centre_recherche" => $centre_recherche]);
		0 ignored issues – show Bug introduced 2016-12-19 14:41 UTC by Report Bug Copy Issue Report The variable `$centre_recherche` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
83		}
84		//-------------------------- END BUILDER ----------------------------------------------------------------------------//
85
86
87
88		//-------------------------- GETTER ----------------------------------------------------------------------------//
89		/**
90		* @param $type
91		* @return array\|int
92		* permet de renvoyer toutes es recherches déjà effectuées pour notre base en fonction
93		* d'un type donné
94		*/
95		public function getAllRechercheType($type) {
96		$dbc = App::getDb();
97
98		$query = $dbc->select()->from("_bataille_centre_recherche")->where("type", "=", $type)->get();
99
100	View Code Duplication	if ((is_array($query)) && (count($query) > 0)) {
		0 ignored issues – show Duplication introduced 2016-12-19 14:41 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
101		foreach ($query as $obj) {
102		$recherche[] = [
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-12-08 20:48 UTC by Report Bug Copy Issue Report `$recherche` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$recherche = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
103		"niveau" => $obj->niveau,
104		"recherche" => $obj->recherche
105		];
106		}
107
108		return $recherche;
		0 ignored issues – show Bug introduced 2016-12-08 20:48 UTC by Report Bug Copy Issue Report The variable `$recherche` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
109		}
110
111		return 0;
112		}
113		//-------------------------- END GETTER ----------------------------------------------------------------------------//
114
115
116
117		//-------------------------- SETTER ----------------------------------------------------------------------------//
118		//-------------------------- END SETTER ----------------------------------------------------------------------------//
119
120		}

Piou-piou / Ruined-World

Push — master ( 41afcc...1faf28 )

CentreRecherche A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like