Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 8 | class RouterModule { |
||
| 9 | //varaibles de base de config |
||
| 10 | private $controller; |
||
| 11 | private $erreur; |
||
| 12 | private $parametre; |
||
| 13 | private $module; //varialbe qui contiendra le nom d'un module |
||
| 14 | private $page; |
||
| 15 | |||
| 16 | |||
| 17 | //-------------------------- GETTER ----------------------------------------------------------------------------// |
||
| 18 | //pour les parametres du getUrl ++ getAction ++ getController |
||
| 19 | public function getParametre() { |
||
| 34 | |||
| 35 | View Code Duplication | private function getAllModules() { |
|
| 49 | |||
| 50 | /** |
||
| 51 | * Permets de générer l'url pour aller charger la page concernee pour le module blog |
||
| 52 | * appele également l'actoin à effectur dans la page |
||
| 53 | * @param $url |
||
| 54 | * @return string |
||
| 55 | */ |
||
| 56 | public function getUrl($url) { |
||
| 99 | |||
| 100 | /** |
||
| 101 | * fonction qui permet de tester qu'une route existe bien |
||
| 102 | * appellee dans redirectError.class.php |
||
| 103 | * @param $url |
||
| 104 | */ |
||
| 105 | public function getRouteModuleExist($url) { |
||
| 121 | //-------------------------- FIN GETTER ----------------------------------------------------------------------------// |
||
| 122 | |||
| 123 | |||
| 124 | |||
| 125 | //-------------------------- SETTER ----------------------------------------------------------------------------// |
||
| 126 | /** |
||
| 127 | * Fonction qui va se charger en focntion $this->page et de $this->action d'appeler la fonctoin qui va bien |
||
| 128 | * fontction appelee dans getUrl() |
||
| 129 | */ |
||
| 130 | private function setActionPage() { |
||
| 135 | //-------------------------- FIN SETTER ----------------------------------------------------------------------------// |
||
| 136 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.