Inspection of "begin recruting army in caserne" - Piou-piou/Ruined-World - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 369f5f...26dd04 )

by Anthony

created 2016-12-07 16:37 UTC

Status

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -14,7 +14,7 @@  discard block
 block discarded – undo
 
 
 		//-------------------------- GETTER ----------------------------------------------------------------------------//
-		public function getBatiments(){
+		public function getBatiments() {
 		    return $this->batiments;
 		}
 
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
 
 			$nombre_emplacement = Bataille::getNombreEmplacementBase();
 
-			for ($i=1 ; $i<($nombre_emplacement+1) ; $i++) {
+			for ($i = 1; $i < ($nombre_emplacement + 1); $i++) {
 				$query = $dbc->select()->from("_bataille_batiment")->where("ID_base", "=", Bataille::getIdBase(), "AND")
 					->where("emplacement", "=", $i)
 					->orderBy("emplacement")

Please login to merge, or discard this patch.

admin/views/template/principal.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -9,7 +9,7 @@  discard block
 block discarded – undo
 		<link rel="stylesheet" type="text/css" href="<?=LIBSWEBROOT?>reset_css/reset.css">
 		<link rel="stylesheet" type="text/css" href="<?=WEBROOT?>admin/views/template/css/style.css">
 		<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/2.2.0/jquery.min.js"></script>
-		<?php require_once(ROOT."admin/views/template/js/menu.php");?>
+		<?php require_once(ROOT."admin/views/template/js/menu.php"); ?>
 
 		<!-- Les librairies utlisées -->
 		<link rel="stylesheet" type="text/css" href="<?=LIBSWEBROOT?>popup/css/style.css">
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
 	</head>
 	<?=\core\HTML\flashmessage\FlashMessage::getFlash(); ?>
 	<body>
-		<nav class="menu <?php if (($_SESSION["menu_plie".CLEF_SITE] == "deplie") || (!isset($_SESSION["menu_plie".CLEF_SITE]))):?>active<?php endif;?>">
+		<nav class="menu <?php if (($_SESSION["menu_plie".CLEF_SITE] == "deplie") || (!isset($_SESSION["menu_plie".CLEF_SITE]))):?>active<?php endif; ?>">
 			<div class="titre">
 				<h1>Ribs V2.3.5.6</h1>
 				<i class="fa fa-bars"></i>
@@ -41,14 +41,14 @@  discard block
 block discarded – undo
 										<a href="<?=ADMWEBROOT?>notifications"><i class="fa fa-bell  <?php if ($admin->getNotification() == 1):?> animated infinite swing<?php endif; ?>"></i></a>
 									</div>
 								</div>
-							<?php endif;?>
+							<?php endif; ?>
 							<?php if (($droit_acces->getSuperAdmin() == 1) || ($droit_acces->getDroitAccesPage("configuration/mon-compte"))):?>
 								<div class="colonne">
 									<div class="config">
 										<a href="<?=ADMWEBROOT?>configuration/index"><i class="fa fa-gear"></i></a>
 									</div>
 								</div>
-							<?php endif;?>
+							<?php endif; ?>
 							<div class="colonne">
 								<div class="logout">
 									<a href="<?=WEBROOT?>administrator/controller/core/auth/connexion/logout"><i class="fa fa-sign-out animated activate swing infinite"></i></a>
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
 							<ul>
 								<?php if ($droit_acces->getDroitAccesAction("CREATION COMPTE ADMIN")):?>
 									<li><i class="fa fa-user"></i><a href="<?=ADMWEBROOT?>gestion-comptes/creer-utilisateur">Créer un utilisateur</a></li>
-								<?php endif;?>
+								<?php endif; ?>
 							</ul>
 						</li>
 					<?php endif; ?>

Please login to merge, or discard this patch.

admin/views/gestion-contenus/inline.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -17,7 +17,7 @@  discard block
 block discarded – undo
 <button id="supprimer-page-contenu" type="button" class="submit-contenu supprimer-page supprimer open-popup" popup="supprimer-page" href="<?=ADMWEBROOT?>gestion-contenus/modifier-contenu?id=<?=$id_page_courante?>"><i class="fa fa-times"></i>Annuler</button>
 
 
-<?php if ($config->getResponsive() == 1){?>
+<?php if ($config->getResponsive() == 1) {?>
 	<link rel="stylesheet" type="text/css" href="<?=WEBROOT?>admin/views/template/css/foundation-inline.css">
 <?php }?>
 <link rel="stylesheet" type="text/css" href="<?=TPLWEBROOT?>css/page.css">
@@ -33,13 +33,13 @@  discard block
 block discarded – undo
 <script>
 	CKEDITOR.disableAutoInline = true;
 
-	<?php for($i=0 ; $i<$bloc_editable ; $i++):?>
+	<?php for ($i = 0; $i < $bloc_editable; $i++):?>
 		$(document).ready(function() {
 			console.log("editor<?=$i?>");
 			$("#editor<?=$i?>").attr("contenteditable", true);
 		})
 		var editor<?=$i?> = CKEDITOR.inline("editor<?=$i?>", { customConfig: "<?=WEBROOT?>config/config_ckeditor.js" });
 		CKFinder.setupCKEditor( editor<?=$i?>, "<?=LIBSWEBROOT?>ckfinder/" );
-	<?php endfor;?>
+	<?php endfor; ?>
 </script>
-<?php require_once(ROOT."admin/views/gestion-contenus/js/inline.php");?>
\ No newline at end of file
+<?php require_once(ROOT."admin/views/gestion-contenus/js/inline.php"); ?>
\ No newline at end of file

Please login to merge, or discard this patch.

admin/controller/ckeditor.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -2,5 +2,5 @@
 block discarded – undo
 	include_once(ROOT.'libs/ckeditor/ckeditor.php');
 	require_once(ROOT.'libs/ckfinder/ckfinder.php');
 	$ckeditor = new CKEditor();
-	$ckeditor->basePath	= WEBROOT.'libs/ckeditor/';
+	$ckeditor->basePath = WEBROOT.'libs/ckeditor/';
 	CKFinder::SetupCKEditor($ckeditor, WEBROOT.'libs/ckfinder/');
\ No newline at end of file

Please login to merge, or discard this patch.

core/HTML/flashmessage/FlashMessage.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -44,7 +44,7 @@
 block discarded – undo
 					//definit le chemin sachant que l'on part de index.php
 					$chemin = str_replace("\\", "/", str_replace("index.php", "", $_SERVER['SCRIPT_NAME']).__NAMESPACE__."/view/");
 				}
-				else if  (strstr($_SERVER['SCRIPT_NAME'], "installation.php")) {
+				else if (strstr($_SERVER['SCRIPT_NAME'], "installation.php")) {
 					//definit le chemin sachant que l'on part de admin.php
 					$chemin = str_replace("\\", "/", str_replace("installation.php", "", $_SERVER['SCRIPT_NAME']).__NAMESPACE__."/view/");
 				}

Please login to merge, or discard this patch.

core/modules/RouterModule.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -22,7 +22,7 @@
 block discarded – undo
 		public function getPage() {
 			return $this->page;
 		}
-		public function getModule(){
+		public function getModule() {
 		    return $this->module;
 		}
 		public function getController() {

Please login to merge, or discard this patch.

core/admin/navigation/AdminNavigation.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -5,20 +5,20 @@
 block discarded – undo
 	use core\HTML\flashmessage\FlashMessage;
 	use core\Navigation;
 
-	class AdminNavigation extends Navigation{
+	class AdminNavigation extends Navigation {
 
 		public function setOrdreNavigation($nav) {
 			$dbc = App::getDb();
 			$count_nav = count($nav);
 
-			for ($i=0 ; $i<$count_nav ; $i++) {
+			for ($i = 0; $i < $count_nav; $i++) {
 				$lien = explode(".", $nav[$i]);
 
 				if ($lien[1] == "page") {
-					$dbc->update("ordre", $i+1)->from("navigation")->where("ID_page", "=", $lien[0])->set();
+					$dbc->update("ordre", $i + 1)->from("navigation")->where("ID_page", "=", $lien[0])->set();
 				}
 				else {
-					$dbc->update("ordre", $i+1)->from("navigation")->where("ID_module", "=", $lien[0])->set();
+					$dbc->update("ordre", $i + 1)->from("navigation")->where("ID_module", "=", $lien[0])->set();
 				}
 			}
 

Please login to merge, or discard this patch.

core/admin/contenus/gestion/contenus_inline.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -2,7 +2,7 @@
 block discarded – undo
 	$gestion_contenu = new \core\admin\contenus\GestionContenus();
 	$droit_acces = new \core\admin\droitsacces\DroitAcces();
 
-	if ((($droit_acces->getDroitAccesContenu("GESTION CONTENU PAGE", $_POST['id_page']) == true) &&  ($droit_acces->getModifContenu() != 0)) || ($droit_acces->getSuperAdmin() == 1)) {
+	if ((($droit_acces->getDroitAccesContenu("GESTION CONTENU PAGE", $_POST['id_page']) == true) && ($droit_acces->getModifContenu() != 0)) || ($droit_acces->getSuperAdmin() == 1)) {
 
 		$gestion_contenu->setModifierContenu($_POST['id_page'], $_POST['contenu']);
 

Please login to merge, or discard this patch.

modules/messagerie/app/controller/Messagerie.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -76,10 +76,10 @@  discard block
 block discarded – undo
 		public function getMessage() {
 			return $this->message;
 		}
-		public function getDateMessage(){
+		public function getDateMessage() {
 		    return $this->date_message;
 		}
-		public function getUrl(){
+		public function getUrl() {
 		    return $this->url;
 		}
 		public function getIdExpediteur() {
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
 		public function getPseudoReceveur() {
 			return $this->pseudo_receveur;
 		}
-		public function getValues(){
+		public function getValues() {
 		    return ["messagerie" => $this->values];
 		}
 
@@ -291,7 +291,7 @@  discard block
 block discarded – undo
 				$destinataires = explode(",", $destinataire);
 				$c = count($destinataires);
 
-				for ($i=0 ; $i<$c ; $i++) {
+				for ($i = 0; $i < $c; $i++) {
 					if ($this->getIdIdentiteExist($destinataires[$i]) !== false) {
 						$destinataires[] = $this->getIdIdentiteExist($destinataires[$i]);
 					}

Please login to merge, or discard this patch.

		@@ -44,7 +44,7 @@
		block discarded – undo
44	44	//definit le chemin sachant que l'on part de index.php
45	45	$chemin = str_replace("\\", "/", str_replace("index.php", "", $_SERVER['SCRIPT_NAME']).__NAMESPACE__."/view/");
46	46	}
47		- else if (strstr($_SERVER['SCRIPT_NAME'], "installation.php")) {
	47	+ else if (strstr($_SERVER['SCRIPT_NAME'], "installation.php")) {
48	48	//definit le chemin sachant que l'on part de admin.php
49	49	$chemin = str_replace("\\", "/", str_replace("installation.php", "", $_SERVER['SCRIPT_NAME']).__NAMESPACE__."/view/");
50	50	}

		@@ -76,10 +76,10 @@ discard block
		block discarded – undo
76	76	public function getMessage() {
77	77	return $this->message;
78	78	}
79		- public function getDateMessage(){
	79	+ public function getDateMessage() {
80	80	return $this->date_message;
81	81	}
82		- public function getUrl(){
	82	+ public function getUrl() {
83	83	return $this->url;
84	84	}
85	85	public function getIdExpediteur() {
		@@ -94,7 +94,7 @@ discard block
		block discarded – undo
94	94	public function getPseudoReceveur() {
95	95	return $this->pseudo_receveur;
96	96	}
97		- public function getValues(){
	97	+ public function getValues() {
98	98	return ["messagerie" => $this->values];
99	99	}
100	100
		@@ -291,7 +291,7 @@ discard block
		block discarded – undo
291	291	$destinataires = explode(",", $destinataire);
292	292	$c = count($destinataires);
293	293
294		- for ($i=0 ; $i<$c ; $i++) {
	294	+ for ($i = 0; $i < $c; $i++) {
295	295	if ($this->getIdIdentiteExist($destinataires[$i]) !== false) {
296	296	$destinataires[] = $this->getIdIdentiteExist($destinataires[$i]);
297	297	}

		@@ -14,7 +14,7 @@ discard block
		block discarded – undo
14	14
15	15
16	16	//-------------------------- GETTER ----------------------------------------------------------------------------//
17		- public function getBatiments(){
	17	+ public function getBatiments() {
18	18	return $this->batiments;
19	19	}
20	20
		@@ -66,7 +66,7 @@ discard block
		block discarded – undo
66	66
67	67	$nombre_emplacement = Bataille::getNombreEmplacementBase();
68	68
69		- for ($i=1 ; $i<($nombre_emplacement+1) ; $i++) {
	69	+ for ($i = 1; $i < ($nombre_emplacement + 1); $i++) {
70	70	$query = $dbc->select()->from("_bataille_batiment")->where("ID_base", "=", Bataille::getIdBase(), "AND")
71	71	->where("emplacement", "=", $i)
72	72	->orderBy("emplacement")

		@@ -9,7 +9,7 @@ discard block
		block discarded – undo
9	9	<link rel="stylesheet" type="text/css" href="<?=LIBSWEBROOT?>reset_css/reset.css">
10	10	<link rel="stylesheet" type="text/css" href="<?=WEBROOT?>admin/views/template/css/style.css">
11	11	<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/2.2.0/jquery.min.js"></script>
12		- <?php require_once(ROOT."admin/views/template/js/menu.php");?>
	12	+ <?php require_once(ROOT."admin/views/template/js/menu.php"); ?>
13	13
14	14	<!-- Les librairies utlisées -->
15	15	<link rel="stylesheet" type="text/css" href="<?=LIBSWEBROOT?>popup/css/style.css">
		@@ -19,7 +19,7 @@ discard block
		block discarded – undo
19	19	</head>
20	20	<?=\core\HTML\flashmessage\FlashMessage::getFlash(); ?>
21	21	<body>
22		- <nav class="menu <?php if (($_SESSION["menu_plie".CLEF_SITE] == "deplie") \|\| (!isset($_SESSION["menu_plie".CLEF_SITE]))):?>active<?php endif;?>">
	22	+ <nav class="menu <?php if (($_SESSION["menu_plie".CLEF_SITE] == "deplie") \|\| (!isset($_SESSION["menu_plie".CLEF_SITE]))):?>active<?php endif; ?>">
23	23	<div class="titre">
24	24	<h1>Ribs V2.3.5.6</h1>
25	25	<i class="fa fa-bars"></i>
		@@ -41,14 +41,14 @@ discard block
		block discarded – undo
41	41	<a href="<?=ADMWEBROOT?>notifications"><i class="fa fa-bell <?php if ($admin->getNotification() == 1):?> animated infinite swing<?php endif; ?>"></i></a>
42	42	</div>
43	43	</div>
44		- <?php endif;?>
	44	+ <?php endif; ?>
45	45	<?php if (($droit_acces->getSuperAdmin() == 1) \|\| ($droit_acces->getDroitAccesPage("configuration/mon-compte"))):?>
46	46	<div class="colonne">
47	47	<div class="config">
48	48	<a href="<?=ADMWEBROOT?>configuration/index"><i class="fa fa-gear"></i></a>
49	49	</div>
50	50	</div>
51		- <?php endif;?>
	51	+ <?php endif; ?>
52	52	<div class="colonne">
53	53	<div class="logout">
54	54	<a href="<?=WEBROOT?>administrator/controller/core/auth/connexion/logout"><i class="fa fa-sign-out animated activate swing infinite"></i></a>
		@@ -67,7 +67,7 @@ discard block
		block discarded – undo
67	67	<ul>
68	68	<?php if ($droit_acces->getDroitAccesAction("CREATION COMPTE ADMIN")):?>
69	69	<li><i class="fa fa-user"></i><a href="<?=ADMWEBROOT?>gestion-comptes/creer-utilisateur">Créer un utilisateur</a></li>
70		- <?php endif;?>
	70	+ <?php endif; ?>
71	71	</ul>
72	72	</li>
73	73	<?php endif; ?>

		@@ -17,7 +17,7 @@ discard block
		block discarded – undo
17	17	<button id="supprimer-page-contenu" type="button" class="submit-contenu supprimer-page supprimer open-popup" popup="supprimer-page" href="<?=ADMWEBROOT?>gestion-contenus/modifier-contenu?id=<?=$id_page_courante?>"><i class="fa fa-times"></i>Annuler</button>
18	18
19	19
20		-<?php if ($config->getResponsive() == 1){?>
	20	+<?php if ($config->getResponsive() == 1) {?>
21	21	<link rel="stylesheet" type="text/css" href="<?=WEBROOT?>admin/views/template/css/foundation-inline.css">
22	22	<?php }?>
23	23	<link rel="stylesheet" type="text/css" href="<?=TPLWEBROOT?>css/page.css">
		@@ -33,13 +33,13 @@ discard block
		block discarded – undo
33	33	<script>
34	34	CKEDITOR.disableAutoInline = true;
35	35
36		- <?php for($i=0 ; $i<$bloc_editable ; $i++):?>
	36	+ <?php for ($i = 0; $i < $bloc_editable; $i++):?>
37	37	$(document).ready(function() {
38	38	console.log("editor<?=$i?>");
39	39	$("#editor<?=$i?>").attr("contenteditable", true);
40	40	})
41	41	var editor<?=$i?> = CKEDITOR.inline("editor<?=$i?>", { customConfig: "<?=WEBROOT?>config/config_ckeditor.js" });
42	42	CKFinder.setupCKEditor( editor<?=$i?>, "<?=LIBSWEBROOT?>ckfinder/" );
43		- <?php endfor;?>
	43	+ <?php endfor; ?>
44	44	</script>
45		-<?php require_once(ROOT."admin/views/gestion-contenus/js/inline.php");?>
46	45	\ No newline at end of file
	46	+<?php require_once(ROOT."admin/views/gestion-contenus/js/inline.php"); ?>
47	47	\ No newline at end of file

		@@ -2,5 +2,5 @@
		block discarded – undo
2	2	include_once(ROOT.'libs/ckeditor/ckeditor.php');
3	3	require_once(ROOT.'libs/ckfinder/ckfinder.php');
4	4	$ckeditor = new CKEditor();
5		- $ckeditor->basePath = WEBROOT.'libs/ckeditor/';
	5	+ $ckeditor->basePath = WEBROOT.'libs/ckeditor/';
6	6	CKFinder::SetupCKEditor($ckeditor, WEBROOT.'libs/ckfinder/');
7	7	\ No newline at end of file

		@@ -22,7 +22,7 @@
		block discarded – undo
22	22	public function getPage() {
23	23	return $this->page;
24	24	}
25		- public function getModule(){
	25	+ public function getModule() {
26	26	return $this->module;
27	27	}
28	28	public function getController() {

		@@ -5,20 +5,20 @@
		block discarded – undo
5	5	use core\HTML\flashmessage\FlashMessage;
6	6	use core\Navigation;
7	7
8		- class AdminNavigation extends Navigation{
	8	+ class AdminNavigation extends Navigation {
9	9
10	10	public function setOrdreNavigation($nav) {
11	11	$dbc = App::getDb();
12	12	$count_nav = count($nav);
13	13
14		- for ($i=0 ; $i<$count_nav ; $i++) {
	14	+ for ($i = 0; $i < $count_nav; $i++) {
15	15	$lien = explode(".", $nav[$i]);
16	16
17	17	if ($lien[1] == "page") {
18		- $dbc->update("ordre", $i+1)->from("navigation")->where("ID_page", "=", $lien[0])->set();
	18	+ $dbc->update("ordre", $i + 1)->from("navigation")->where("ID_page", "=", $lien[0])->set();
19	19	}
20	20	else {
21		- $dbc->update("ordre", $i+1)->from("navigation")->where("ID_module", "=", $lien[0])->set();
	21	+ $dbc->update("ordre", $i + 1)->from("navigation")->where("ID_module", "=", $lien[0])->set();
22	22	}
23	23	}
24	24

		@@ -2,7 +2,7 @@
		block discarded – undo
2	2	$gestion_contenu = new \core\admin\contenus\GestionContenus();
3	3	$droit_acces = new \core\admin\droitsacces\DroitAcces();
4	4
5		- if ((($droit_acces->getDroitAccesContenu("GESTION CONTENU PAGE", $_POST['id_page']) == true) && ($droit_acces->getModifContenu() != 0)) \|\| ($droit_acces->getSuperAdmin() == 1)) {
	5	+ if ((($droit_acces->getDroitAccesContenu("GESTION CONTENU PAGE", $_POST['id_page']) == true) && ($droit_acces->getModifContenu() != 0)) \|\| ($droit_acces->getSuperAdmin() == 1)) {
6	6
7	7	$gestion_contenu->setModifierContenu($_POST['id_page'], $_POST['contenu']);
8	8

Piou-piou / Ruined-World

Push — master ( 369f5f...26dd04 )

Status

Category

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch