Bataille - Code Metrics - Inspection of "Merged develop into master" - Piou-piou/Ruined-World - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 78d9ba...e105a7 )

by Anthony

created 2017-01-31 20:20 UTC

Bataille C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	290
Duplicated Lines	0 %

Coupling/Cohesion

Components	9
Dependencies	6

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
wmc	44
c	3
b	0
f	0
lcom	9
cbo	6
dl	0
loc	290
rs	5.7402

20 Methods

Rating	Name	Size	Complexity
A	__construct()	3	1
A	getValues()	3	1
A	getRessource()	7	2
A	getBase()	7	2
A	getBatiment()	7	2
A	getUnite()	7	2
A	getCentreRecherche()	7	2
A	getMissionsAleatoire()	7	2
A	getDb()	8	2
A	getIdIdentite()	3	1
A	getIdBase()	9	2
A	getFirstBase()	13	4
A	getPosistionBase()	19	2
A	getToday()	4	1
A	getTestAssezRessourceBase()	15	2
A	getDureeTrajet()	14	1
B	getNation()	20	6
A	getBaseExistPosition()	14	4
A	getParam()	9	4
A	setValues()	3	1

How to fix Complexity

<?php
	namespace modules\bataille\app\controller;
	use core\App;
	use core\database\Database;

	class Bataille {
		private static $ressource;
		private static $base;
		private static $batiment;
		private static $unite;
		private static $centre_recherche;
		private static $missions_aleatoire;
		private static $database;
		private static $nation;

		private static $id_base;

		public static $values = [];

		
		//-------------------------- BUILDER ----------------------------------------------------------------------------//
		public function __construct() {

		}
		//-------------------------- END BUILDER ----------------------------------------------------------------------------//
		
		
		
		//-------------------------- GETTER ----------------------------------------------------------------------------//
		/**
		 * @return array
		 * get array of all values wich will be used in the page
		 */
		public static function getValues() {
			return ["bataille" => self::$values];
		}

		//initilisation of all classes of battle
		//initialisation of Ressource class
		public static function getRessource() {
			if (self::$ressource == null) {
				self::$ressource = new Ressource();
			}

			return self::$ressource;
		}

		//initialisation of Base class
		public static function getBase() {
			if (self::$base == null) {
				self::$base = new Base();
			}

			return self::$base;
		}

		//initialisation of Batiment class
		public static function getBatiment() {
			if (self::$batiment == null) {
				self::$batiment = new Batiment();
			}

			return self::$batiment;
		}

		//initialisation of Batiment class
		public static function getUnite() {
			if (self::$unite == null) {
				self::$unite = new Unite();
			}

			return self::$unite;
		}

		//initialisation of CentreRecherche class
		public static function getCentreRecherche() {
			if (self::$centre_recherche == null) {
				self::$centre_recherche = new CentreRecherche();
			}

			return self::$centre_recherche;
		}
		
		//initialisation of MissionsAleatoire class
		public static function getMissionsAleatoire() {
			if (self::$missions_aleatoire == null) {
				self::$missions_aleatoire = new MissionsAleatoire();
			}
			
			return self::$missions_aleatoire;
		}

		//initialisation of Database Core connexion
		public static function getDb() {
			require_once("config.config.php");
			
			if (self::$database == null) {
				self::$database = new Database($type_co, $dbname, $dbuser, $dbpass, $dbhost);

			}
			return self::$database;
		}

		/**
		 * @return mixe
		 * récupère l'ID_identité du joueur
		 */
		public static function getIdIdentite() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
			return $_SESSION['idlogin'.CLEF_SITE];
		}

		/**
		 * @return mixed
		 * renvoi l'id_base du joueur
		 */
		public static function getIdBase() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
			if (self::$id_base == null) {
				self::$id_base = $_SESSION['id_base'];

				return self::$id_base;
			}

			return self::$id_base;
		}

		/**
		 * @return mixed
		 * renvoi le premier ID_base du joueur (première base et base princ du joueur)
		 */
		public static function getFirstBase() {
			$dbc = App::getDb();

			$query = $dbc->select("ID_base")->from("_bataille_base")
				->where("ID_identite", "=", self::getIdIdentite())
				->orderBy("ID_base")
				->limit(0, 1)
				->get();

			if ((is_array($query)) && (count($query) == 1)) {
				foreach ($query as $obj) return $obj->ID_base;
			}
		}

		/**
		 * @param $id_base
		 * @return array
		 * fonction qui renvoi les posisitons en x et y d'une base
		 */
		private static function getPosistionBase($id_base) {
			$dbc = App::getDb();
			
			$posx = 0;
			$posy = 0;

			$query = $dbc->select("posx")
				->select("posy")
				->from("_bataille_base")
				->where("ID_base", "=", $id_base)
				->get();

			foreach ($query as $obj) {
				$posx = $obj->posx;
				$posy = $obj->posy;
			}

			return ["posx" => $posx, "posy" => $posy];
		}

		/**
		 * @return int
		 * return now timestamp
		 */
		public static function getToday() {
			$today = new \DateTime();
			return $today->getTimestamp();
		}

		/**
		 * @param string $nom_ressource
		 * @param $ressource
		 * @return array
		 * fonction qui permet de renvyer la couleur rouge si pas assez de ressource pour construire le batiment
		 * ou pour creer une unité...
		 */
		public static function getTestAssezRessourceBase($nom_ressource, $ressource) {
			$f = "get".ucfirst($nom_ressource);

			if ($ressource > Bataille::getRessource()->$f()) {
				return [
					"ressource" => $ressource,
					"class" => "rouge"
				];
			}

			return [
				"ressource" => $ressource,
				"class" => ""
			];
		}
		
		/**
		 * @param $id_base
		 * @param integer $vitesse = vitesse de l'unité en question
		 * @return number
		 * fonction qui renvoi le temps de trajet entre la base du joueur et une autre base en secondes
		 */
		public static function getDureeTrajet($id_base, $vitesse = 1) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
			//récupération de la posisiotn de la base du joueur + la base sur laquelle on a cliqué
			$base_joueur = self::getPosistionBase($_SESSION['id_base']);
			$base_autre = self::getPosistionBase($id_base);
			
			//calcul des distances séparant les deux bases en x et y
			//cette dstance sera multipliée par 15 sur x et y puis ajoutée pour avoir le temps du trajte en seconde
			$calc_x = abs($base_joueur['posx']-$base_autre['posx']);
			$calc_y = abs($base_joueur['posy']-$base_autre['posy']);
			
			$temps_voyage = (($calc_x*70)+($calc_y*70))/$vitesse;
			
			return $temps_voyage;
		}

		/**
		 * @param null $id_identite
		 * get nation of a player
		 */
		public static function getNation($id_identite = null) {
			$dbc = App::getDb();

			if (($id_identite === null) && (self::$nation == null)) {
				$id_identite = Bataille::getIdIdentite();
			}

			$query = $dbc->select("nation")
				->from("identite")
				->from("_bataille_nation")
				->where("identite.ID_identite", "=", $id_identite, "AND")
				->where("identite.ID_identite", "=", "_bataille_nation.ID_identite", "", true)
				->get();

			if ((is_array($query)) && (count($query) > 0)) {
				foreach ($query as $obj) {
					self::setValues(["nation" => $obj->nation]);
				}
			}
		}

		/**
		 * @param $posx
		 * @param $posy
		 * @return int
		 * fonction qui renvoi un ID_base en fonction de sa posx et posy et 0 si base inexistante
		 */
		public static function getBaseExistPosition($posx, $posy) {
			$dbc = App::getDb();

			$query = $dbc->select("ID_base")->from("_bataille_base")
				->where("posx", "=", $posx, "AND")
				->where("posy", "=", $posy)
				->get();

			if ((is_array($query)) && (count($query) == 1)) {
				foreach ($query as $obj) return $obj->ID_base;
			}

			return 0;
		}

		/**
		 * @param string $param
		 * @return mixed
		 * fonction qui sert à récupérer un parametre spécifique pour un batiment
		 * par exemple la vitesse d'un marchand ou  le nombred'emplacment de la base
		 */
		public static function getParam($param) {
			$dbc = self::getDb();

			$query = $dbc->select($param)->from("configuration")->where("ID_configuration", "=", 1)->get();

			if ((is_array($query)) && (count($query) == 1)) {
				foreach ($query as $obj) return $obj->$param;
			}
		}
		//-------------------------- END GETTER ----------------------------------------------------------------------------//
		
		
		
		//-------------------------- SETTER ----------------------------------------------------------------------------//
		/**
		 * @param $values
		 * can set values while keep older infos
		 */
		public static function setValues($values) {
			Bataille::$values = array_merge(Bataille::$values, $values);
		}
		//-------------------------- END SETTER ----------------------------------------------------------------------------//
	}

1			<?php
2			namespace modules\bataille\app\controller;
3			use core\App;
4			use core\database\Database;
5
6			class Bataille {
7			private static $ressource;
8			private static $base;
9			private static $batiment;
10			private static $unite;
11			private static $centre_recherche;
12			private static $missions_aleatoire;
13			private static $database;
14			private static $nation;
15
16			private static $id_base;
17
18			public static $values = [];
19
20
21			//-------------------------- BUILDER ----------------------------------------------------------------------------//
22			public function __construct() {
23
24			}
25			//-------------------------- END BUILDER ----------------------------------------------------------------------------//
26
27
28
29			//-------------------------- GETTER ----------------------------------------------------------------------------//
30			/**
31			* @return array
32			* get array of all values wich will be used in the page
33			*/
34			public static function getValues() {
35			return ["bataille" => self::$values];
36			}
37
38			//initilisation of all classes of battle
39			//initialisation of Ressource class
40			public static function getRessource() {
41			if (self::$ressource == null) {
42			self::$ressource = new Ressource();
43			}
44
45			return self::$ressource;
46			}
47
48			//initialisation of Base class
49			public static function getBase() {
50			if (self::$base == null) {
51			self::$base = new Base();
52			}
53
54			return self::$base;
55			}
56
57			//initialisation of Batiment class
58			public static function getBatiment() {
59			if (self::$batiment == null) {
60			self::$batiment = new Batiment();
61			}
62
63			return self::$batiment;
64			}
65
66			//initialisation of Batiment class
67			public static function getUnite() {
68			if (self::$unite == null) {
69			self::$unite = new Unite();
70			}
71
72			return self::$unite;
73			}
74
75			//initialisation of CentreRecherche class
76			public static function getCentreRecherche() {
77			if (self::$centre_recherche == null) {
78			self::$centre_recherche = new CentreRecherche();
79			}
80
81			return self::$centre_recherche;
82			}
83
84			//initialisation of MissionsAleatoire class
85			public static function getMissionsAleatoire() {
86			if (self::$missions_aleatoire == null) {
87			self::$missions_aleatoire = new MissionsAleatoire();
88			}
89
90			return self::$missions_aleatoire;
91			}
92
93			//initialisation of Database Core connexion
94			public static function getDb() {
95			require_once("config.config.php");
96
97			if (self::$database == null) {
98			self::$database = new Database($type_co, $dbname, $dbuser, $dbpass, $dbhost);
			0 ignored issues – show Bug introduced 2017-01-17 11:02 UTC by Report Bug Copy Issue Report The variable `$type_co` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Bug introduced 2017-01-17 11:02 UTC by Report Bug Copy Issue Report The variable `$dbname` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Bug introduced 2017-01-17 11:02 UTC by Report Bug Copy Issue Report The variable `$dbuser` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Bug introduced 2017-01-17 11:02 UTC by Report Bug Copy Issue Report The variable `$dbpass` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Bug introduced 2017-01-17 11:02 UTC by Report Bug Copy Issue Report The variable `$dbhost` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
99			}
100			return self::$database;
101			}
102
103			/**
104			* @return mixe
105			* récupère l'ID_identité du joueur
106			*/
107			public static function getIdIdentite() {
			0 ignored issues – show Coding Style introduced 2016-10-31 15:39 UTC by Report Bug Copy Issue Report `getIdIdentite` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
108			return $_SESSION['idlogin'.CLEF_SITE];
109			}
110
111			/**
112			* @return mixed
113			* renvoi l'id_base du joueur
114			*/
115			public static function getIdBase() {
			0 ignored issues – show Coding Style introduced 2016-10-31 15:39 UTC by Report Bug Copy Issue Report `getIdBase` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
116			if (self::$id_base == null) {
117			self::$id_base = $_SESSION['id_base'];
118
119			return self::$id_base;
120			}
121
122			return self::$id_base;
123			}
124
125			/**
126			* @return mixed
127			* renvoi le premier ID_base du joueur (première base et base princ du joueur)
128			*/
129			public static function getFirstBase() {
130			$dbc = App::getDb();
131
132			$query = $dbc->select("ID_base")->from("_bataille_base")
133			->where("ID_identite", "=", self::getIdIdentite())
134			->orderBy("ID_base")
135			->limit(0, 1)
136			->get();
137
138			if ((is_array($query)) && (count($query) == 1)) {
139			foreach ($query as $obj) return $obj->ID_base;
140			}
141			}
142
143			/**
144			* @param $id_base
145			* @return array
146			* fonction qui renvoi les posisitons en x et y d'une base
147			*/
148			private static function getPosistionBase($id_base) {
149			$dbc = App::getDb();
150
151			$posx = 0;
152			$posy = 0;
153
154			$query = $dbc->select("posx")
155			->select("posy")
156			->from("_bataille_base")
157			->where("ID_base", "=", $id_base)
158			->get();
159
160			foreach ($query as $obj) {
161			$posx = $obj->posx;
162			$posy = $obj->posy;
163			}
164
165			return ["posx" => $posx, "posy" => $posy];
166			}
167
168			/**
169			* @return int
170			* return now timestamp
171			*/
172			public static function getToday() {
173			$today = new \DateTime();
174			return $today->getTimestamp();
175			}
176
177			/**
178			* @param string $nom_ressource
179			* @param $ressource
180			* @return array
181			* fonction qui permet de renvyer la couleur rouge si pas assez de ressource pour construire le batiment
182			* ou pour creer une unité...
183			*/
184			public static function getTestAssezRessourceBase($nom_ressource, $ressource) {
185			$f = "get".ucfirst($nom_ressource);
186
187			if ($ressource > Bataille::getRessource()->$f()) {
188			return [
189			"ressource" => $ressource,
190			"class" => "rouge"
191			];
192			}
193
194			return [
195			"ressource" => $ressource,
196			"class" => ""
197			];
198			}
199
200			/**
201			* @param $id_base
202			* @param integer $vitesse = vitesse de l'unité en question
203			* @return number
204			* fonction qui renvoi le temps de trajet entre la base du joueur et une autre base en secondes
205			*/
206			public static function getDureeTrajet($id_base, $vitesse = 1) {
			0 ignored issues – show Coding Style introduced 2016-11-21 15:27 UTC by Report Bug Copy Issue Report `getDureeTrajet` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
207			//récupération de la posisiotn de la base du joueur + la base sur laquelle on a cliqué
208			$base_joueur = self::getPosistionBase($_SESSION['id_base']);
209			$base_autre = self::getPosistionBase($id_base);
210
211			//calcul des distances séparant les deux bases en x et y
212			//cette dstance sera multipliée par 15 sur x et y puis ajoutée pour avoir le temps du trajte en seconde
213			$calc_x = abs($base_joueur['posx']-$base_autre['posx']);
214			$calc_y = abs($base_joueur['posy']-$base_autre['posy']);
215
216			$temps_voyage = (($calc_x70)+($calc_y70))/$vitesse;
217
218			return $temps_voyage;
219			}
220
221			/**
222			* @param null $id_identite
223			* get nation of a player
224			*/
225			public static function getNation($id_identite = null) {
226			$dbc = App::getDb();
227
228			if (($id_identite === null) && (self::$nation == null)) {
229			$id_identite = Bataille::getIdIdentite();
230			}
231
232			$query = $dbc->select("nation")
233			->from("identite")
234			->from("_bataille_nation")
235			->where("identite.ID_identite", "=", $id_identite, "AND")
236			->where("identite.ID_identite", "=", "_bataille_nation.ID_identite", "", true)
237			->get();
238
239			if ((is_array($query)) && (count($query) > 0)) {
240			foreach ($query as $obj) {
241			self::setValues(["nation" => $obj->nation]);
242			}
243			}
244			}
245
246			/**
247			* @param $posx
248			* @param $posy
249			* @return int
250			* fonction qui renvoi un ID_base en fonction de sa posx et posy et 0 si base inexistante
251			*/
252			public static function getBaseExistPosition($posx, $posy) {
253			$dbc = App::getDb();
254
255			$query = $dbc->select("ID_base")->from("_bataille_base")
256			->where("posx", "=", $posx, "AND")
257			->where("posy", "=", $posy)
258			->get();
259
260			if ((is_array($query)) && (count($query) == 1)) {
261			foreach ($query as $obj) return $obj->ID_base;
262			}
263
264			return 0;
265			}
266
267			/**
268			* @param string $param
269			* @return mixed
270			* fonction qui sert à récupérer un parametre spécifique pour un batiment
271			* par exemple la vitesse d'un marchand ou le nombred'emplacment de la base
272			*/
273			public static function getParam($param) {
274			$dbc = self::getDb();
275
276			$query = $dbc->select($param)->from("configuration")->where("ID_configuration", "=", 1)->get();
277
278			if ((is_array($query)) && (count($query) == 1)) {
279			foreach ($query as $obj) return $obj->$param;
280			}
281			}
282			//-------------------------- END GETTER ----------------------------------------------------------------------------//
283
284
285
286			//-------------------------- SETTER ----------------------------------------------------------------------------//
287			/**
288			* @param $values
289			* can set values while keep older infos
290			*/
291			public static function setValues($values) {
292			Bataille::$values = array_merge(Bataille::$values, $values);
293			}
294			//-------------------------- END SETTER ----------------------------------------------------------------------------//
295			}

Piou-piou / Ruined-World

Push — master ( 78d9ba...e105a7 )

Bataille C

Complexity

Size/Duplication

Coupling/Cohesion

Importance

20 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like