PermissionsFaction - Code Metrics - Piou-piou/Ruined-World - Measure and Improve Code Quality continuously with Scrutinizer

PermissionsFaction A
last analyzed 2017-06-28 20:29 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	182
Duplicated Lines	7.69 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	20
c	2
b	0
f	0
lcom	1
cbo	1
dl	14
loc	182
rs	10

7 Methods

Rating	Name	Duplication	Size	Complexity
A	getListePermissions()	0	15	3
B	getPermissionsMembre()	0	26	4
B	setGererPermission()	0	30	4
A	setSupprilerAllPermissions()	0	5	1
A	getTestChefFaction()	14	14	2
A	getNombrePermissions()	0	7	1
B	getMembrePermissions()	0	32	5

How to fix Duplicated Code

<?php
	namespace modules\bataille\app\controller;
	
	
	use core\App;
	use core\functions\ChaineCaractere;
	use core\HTML\flashmessage\FlashMessage;
	
	class PermissionsFaction {
		//-------------------------- BUILDER ----------------------------------------------------------------------------//
		//-------------------------- END BUILDER ----------------------------------------------------------------------------//
		
		
		//-------------------------- GETTER ----------------------------------------------------------------------------//
		/**
		 * @param $id_identite
		 * @param $id_faction
		 * @return bool
		 * permet de savoir si le joueur en question est le chef de la faction
		 */
		protected function getTestChefFaction($id_identite, $id_faction) {
			$dbc = App::getDb();
			
			$query = $dbc->select("ID_identite")->from("_bataille_faction")
				->where("ID_identite", "=", $id_identite, "AND")
				->where("ID_faction", "=", $id_faction)
				->get();
			
			if (count($query) > 0) {
				return true;
			}
			
			return false;
		}
		
		/**
		 * @return int
		 * fonction qui renvoi le nombre de permissions
		 */
		private function getNombrePermissions() {
			$dbc = App::getDb();
			
			$query = $dbc->select()->from("_bataille_faction_permissions")->get();
			
			return count($query);
		}
		
		/**
		 * @return array
		 * fonction qui liste toutes les permissions
		 */
		public function getListePermissions() {
			$dbc = App::getDb();
			
			$query = $dbc->select()->from("_bataille_faction_permissions")->get();
			
			$permissions = [];
			if (count($query) > 0) {
				foreach ($query as $obj) {
					$permissions[] = str_replace("_", " ", $obj->permission);
				}
			}
			
			Bataille::setValues(["liste_permissions" => $permissions]);
			return $permissions;
		}
		
		/**
		 * @param $id_identite
		 * @param $id_faction
		 * @return array|string
		 * permet de récupérer les permissions d'un membre de la faction
		 */
		protected function getMembrePermissions($id_identite, $id_faction) {
			$dbc = App::getDb();
			
			$nb_permissions = $this->getNombrePermissions();
			
			if ($this->getTestChefFaction($id_identite, $id_faction) === true) {
				$permissions = [];
				for ($i=1 ; $i<=$nb_permissions ; $i++) {
					$permissions[$i] = "checked";
				}
				
				return $permissions;
			}
			
			
			$permissions = [];
			for ($i=1 ; $i<=$nb_permissions ; $i++) {
				$query = $dbc->select()->from("_bataille_faction_permission_player")
					->where("ID_faction", "=", $id_faction, "AND")
					->where("ID_identite", "=", $id_identite, "AND")
					->where("ID_permission", "=", $i)
					->get();
				
				$permissions[$i] = "";
				if (count($query) == 1) {
					$permissions[$i] = "checked";
				}
			}
			
			
			return $permissions;
		}
		
		/**
		 * @param $id_faction
		 * @return bool
		 * fonction qui renvoi les permission du membre connecté
		 */
		public function getPermissionsMembre($id_faction) {
			$dbc = App::getDb();
			
			if ($this->getTestChefFaction(Bataille::getIdIdentite(), $id_faction) == true) {

				Bataille::setValues(["permission_player" => "chef"]);
				return "chef";
			}
			
			$query = $dbc->select()
				->from("_bataille_faction_permission_player")
				->from("_bataille_faction_permissions")
				->where("ID_identite", "=", Bataille::getIdIdentite(), "AND")
				->where("ID_faction", "=", $id_faction, "AND")
				->where("_bataille_faction_permission_player.ID_permission", "=", "_bataille_faction_permissions.ID_permissions", "", true)
				->get();
			
			$permissions = [];
			if ((count($query) > 0)) {
				foreach ($query as $obj) {
					$permissions[] = $obj->permission;
				}
			}
			
			Bataille::setValues(["permission_player" => $permissions]);
			return $permissions;
		}
		//-------------------------- END GETTER ----------------------------------------------------------------------------//
		
		
		//-------------------------- SETTER ----------------------------------------------------------------------------//
		/**
		 * @param $id_permission
		 * @param $id_identite
		 * @param $id_faction
		 * @param $type
		 * cette fonction permet d'ajouter ou de supprimer un permission à un joueur
		 */
		public function setGererPermission($id_permission, $id_identite, $id_faction, $type) {
			$dbc = App::getDb();
			
			$permissions_membre = $this->getPermissionsMembre($this->id_faction);
class MyClass { }

$x = new MyClass();
$x->foo = true;
			
			if ($permissions_membre == "chef" || in_array("GERER_RANG_MEMBRE", $permissions_membre)) {
				if ($type == "add") {
					$dbc->insert("ID_permission", $id_permission)
						->insert("ID_identite", $id_identite)
						->insert("ID_faction", $id_faction)
						->into("_bataille_faction_permission_player")
						->set();
					FlashMessage::setFlash("La permission a bien été ajoutée", "success");
				}
				else {
					$dbc->delete()->from("_bataille_faction_permission_player")
						->where("ID_faction", "=", $id_faction, "AND")
						->where("ID_permission", "=", $id_permission, "AND")
						->where("ID_identite", "=", $id_identite)
						->del();
					
					FlashMessage::setFlash("La permission a bien été supprimée", "success");
				}
				
				return true;
			}
			
			FlashMessage::setFlash("Vous n'avez pas la permission de gérer les permissions des membres");
			return false;
		}
		
		/**
		 * @param $id_identite
		 * fonction qui va supprimer tous les droits d'accès du user
		 */
		protected function setSupprilerAllPermissions($id_identite) {
			$dbc = App::getDb();
			
			$dbc->delete()->from("_bataille_faction_permission_player")->where("ID_identite", "=", $id_identite)->del();
		}
		//-------------------------- END SETTER ----------------------------------------------------------------------------//    
	}

1		<?php
2		namespace modules\bataille\app\controller;
3
4
5		use core\App;
6		use core\functions\ChaineCaractere;
7		use core\HTML\flashmessage\FlashMessage;
8
9		class PermissionsFaction {
10		//-------------------------- BUILDER ----------------------------------------------------------------------------//
11		//-------------------------- END BUILDER ----------------------------------------------------------------------------//
12
13
14		//-------------------------- GETTER ----------------------------------------------------------------------------//
15		/**
16		* @param $id_identite
17		* @param $id_faction
18		* @return bool
19		* permet de savoir si le joueur en question est le chef de la faction
20		*/
21	View Code Duplication	protected function getTestChefFaction($id_identite, $id_faction) {
22		$dbc = App::getDb();
23
24		$query = $dbc->select("ID_identite")->from("_bataille_faction")
25		->where("ID_identite", "=", $id_identite, "AND")
26		->where("ID_faction", "=", $id_faction)
27		->get();
28
29		if (count($query) > 0) {
30		return true;
31		}
32
33		return false;
34		}
35
36		/**
37		* @return int
38		* fonction qui renvoi le nombre de permissions
39		*/
40		private function getNombrePermissions() {
41		$dbc = App::getDb();
42
43		$query = $dbc->select()->from("_bataille_faction_permissions")->get();
44
45		return count($query);
46		}
47
48		/**
49		* @return array
50		* fonction qui liste toutes les permissions
51		*/
52		public function getListePermissions() {
53		$dbc = App::getDb();
54
55		$query = $dbc->select()->from("_bataille_faction_permissions")->get();
56
57		$permissions = [];
58		if (count($query) > 0) {
59		foreach ($query as $obj) {
60		$permissions[] = str_replace("_", " ", $obj->permission);
61		}
62		}
63
64		Bataille::setValues(["liste_permissions" => $permissions]);
65		return $permissions;
66		}
67
68		/**
69		* @param $id_identite
70		* @param $id_faction
71		* @return array\|string
72		* permet de récupérer les permissions d'un membre de la faction
73		*/
74		protected function getMembrePermissions($id_identite, $id_faction) {
75		$dbc = App::getDb();
76
77		$nb_permissions = $this->getNombrePermissions();
78
79		if ($this->getTestChefFaction($id_identite, $id_faction) === true) {
80		$permissions = [];
81		for ($i=1 ; $i<=$nb_permissions ; $i++) {
82		$permissions[$i] = "checked";
83		}
84
85		return $permissions;
86		}
87
88
89		$permissions = [];
90		for ($i=1 ; $i<=$nb_permissions ; $i++) {
91		$query = $dbc->select()->from("_bataille_faction_permission_player")
92		->where("ID_faction", "=", $id_faction, "AND")
93		->where("ID_identite", "=", $id_identite, "AND")
94		->where("ID_permission", "=", $i)
95		->get();
96
97		$permissions[$i] = "";
98		if (count($query) == 1) {
99		$permissions[$i] = "checked";
100		}
101		}
102
103
104		return $permissions;
105		}
106
107		/**
108		* @param $id_faction
109		* @return bool
110		* fonction qui renvoi les permission du membre connecté
111		*/
112		public function getPermissionsMembre($id_faction) {
113		$dbc = App::getDb();
114
115		if ($this->getTestChefFaction(Bataille::getIdIdentite(), $id_faction) == true) {
		0 ignored issues – show Coding Style Best Practice introduced 2017-02-12 13:01 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
116		Bataille::setValues(["permission_player" => "chef"]);
117		return "chef";
118		}
119
120		$query = $dbc->select()
121		->from("_bataille_faction_permission_player")
122		->from("_bataille_faction_permissions")
123		->where("ID_identite", "=", Bataille::getIdIdentite(), "AND")
124		->where("ID_faction", "=", $id_faction, "AND")
125		->where("_bataille_faction_permission_player.ID_permission", "=", "_bataille_faction_permissions.ID_permissions", "", true)
126		->get();
127
128		$permissions = [];
129		if ((count($query) > 0)) {
130		foreach ($query as $obj) {
131		$permissions[] = $obj->permission;
132		}
133		}
134
135		Bataille::setValues(["permission_player" => $permissions]);
136		return $permissions;
137		}
138		//-------------------------- END GETTER ----------------------------------------------------------------------------//
139
140
141		//-------------------------- SETTER ----------------------------------------------------------------------------//
142		/**
143		* @param $id_permission
144		* @param $id_identite
145		* @param $id_faction
146		* @param $type
147		* cette fonction permet d'ajouter ou de supprimer un permission à un joueur
148		*/
149		public function setGererPermission($id_permission, $id_identite, $id_faction, $type) {
150		$dbc = App::getDb();
151
152		$permissions_membre = $this->getPermissionsMembre($this->id_faction);
		0 ignored issues – show Bug introduced 2017-02-14 16:03 UTC by Report Bug Copy Issue Report The property `id_faction` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
153
154		if ($permissions_membre == "chef" \|\| in_array("GERER_RANG_MEMBRE", $permissions_membre)) {
155		if ($type == "add") {
156		$dbc->insert("ID_permission", $id_permission)
157		->insert("ID_identite", $id_identite)
158		->insert("ID_faction", $id_faction)
159		->into("_bataille_faction_permission_player")
160		->set();
161		FlashMessage::setFlash("La permission a bien été ajoutée", "success");
162		}
163		else {
164		$dbc->delete()->from("_bataille_faction_permission_player")
165		->where("ID_faction", "=", $id_faction, "AND")
166		->where("ID_permission", "=", $id_permission, "AND")
167		->where("ID_identite", "=", $id_identite)
168		->del();
169
170		FlashMessage::setFlash("La permission a bien été supprimée", "success");
171		}
172
173		return true;
174		}
175
176		FlashMessage::setFlash("Vous n'avez pas la permission de gérer les permissions des membres");
177		return false;
178		}
179
180		/**
181		* @param $id_identite
182		* fonction qui va supprimer tous les droits d'accès du user
183		*/
184		protected function setSupprilerAllPermissions($id_identite) {
185		$dbc = App::getDb();
186
187		$dbc->delete()->from("_bataille_faction_permission_player")->where("ID_identite", "=", $id_identite)->del();
188		}
189		//-------------------------- END SETTER ----------------------------------------------------------------------------//
190		}

Piou-piou / Ruined-World

PermissionsFaction A last analyzed 2017-06-28 20:29 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

PermissionsFaction A
last analyzed 2017-06-28 20:29 UTC