Piou-piou /
Ruined-World
Complex classes like MissionsAleatoire often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use MissionsAleatoire, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 9 | class MissionsAleatoire { |
||
| 10 | private $last_check_mission; |
||
| 11 | |||
| 12 | |||
| 13 | //-------------------------- BUILDER ----------------------------------------------------------------------------// |
||
| 14 | /** |
||
| 15 | * MissionsAleatoire constructor. |
||
| 16 | * le constructeur s'occupe de vérifier le last_check des missions et au cas ou si il est plus vieux d'un jour |
||
| 17 | * appeler la fonction pour recharger les missions |
||
| 18 | */ |
||
| 19 | public function __construct() { |
||
| 20 | $dbc = App::getDb(); |
||
| 21 | |||
| 22 | $query = $dbc->select("last_check_mission")->from("_bataille_base")->where("ID_base", "=", Bataille::getIdBase())->get(); |
||
| 23 | |||
| 24 | if (is_array($query) && (count($query) == 1)) { |
||
| 25 | foreach ($query as $obj) { |
||
| 26 | $this->last_check_mission = $obj->last_check_mission; |
||
| 27 | } |
||
| 28 | |||
| 29 | if ($this->last_check_mission == "") { |
||
| 30 | $this->setUpdateLastCheckMissions(); |
||
| 31 | $this->setMissionsAleatoire(); |
||
| 32 | } |
||
| 33 | else { |
||
| 34 | $today = Bataille::getToday(); |
||
| 35 | $interval = $today-$this->last_check_mission; |
||
| 36 | |||
| 37 | if ($interval >= 10800) { |
||
| 38 | $this->setUpdateLastCheckMissions(); |
||
| 39 | $this->setMissionsAleatoire(); |
||
| 40 | } |
||
| 41 | } |
||
| 42 | } |
||
| 43 | |||
| 44 | $this->getNbMissions(); |
||
| 45 | Bataille::setValues(["next_check_missions" => ($this->last_check_mission+10800)-Bataille::getToday()]); |
||
| 46 | |||
| 47 | $this->getMissionsCours(); |
||
| 48 | } |
||
| 49 | //-------------------------- END BUILDER ----------------------------------------------------------------------------// |
||
| 50 | |||
| 51 | |||
| 52 | |||
| 53 | //-------------------------- GETTER ----------------------------------------------------------------------------// |
||
| 54 | /** |
||
| 55 | * fonction qui récupere tous les types de missions et les return dans un array |
||
| 56 | */ |
||
| 57 | private function getTypeMission() { |
||
| 58 | return explode(",", Bataille::getParam("type_missions")); |
||
| 59 | } |
||
| 60 | |||
| 61 | /** |
||
| 62 | * @return int |
||
| 63 | * renvoi le nombre de missions encore disponibles dans la base |
||
| 64 | */ |
||
| 65 | private function getNbMissions() { |
||
| 83 | |||
| 84 | /** |
||
| 85 | * @param $id_mission |
||
| 86 | * @return mixed |
||
| 87 | * fonction qui récupère la durée d'une mission |
||
| 88 | */ |
||
| 89 | private function getTempsMission($id_mission) { |
||
| 100 | |||
| 101 | /** |
||
| 102 | * récupères les missions encore disponible dans la base |
||
| 103 | */ |
||
| 104 | public function getMissions() { |
||
| 117 | |||
| 118 | /** |
||
| 119 | * @param $id_mission |
||
| 120 | * @return array |
||
| 121 | * pour récupérer les infos d'une mission dans la bdd _core |
||
| 122 | */ |
||
| 123 | private function getInfosMission($id_mission) { |
||
| 141 | |||
| 142 | /** |
||
| 143 | * fonction qui récupère les missions qui sont en cours dans la base |
||
| 144 | */ |
||
| 145 | private function getMissionsCours() { |
||
| 162 | //-------------------------- END GETTER ----------------------------------------------------------------------------// |
||
| 163 | |||
| 164 | |||
| 165 | |||
| 166 | //-------------------------- SETTER ----------------------------------------------------------------------------// |
||
| 167 | /** |
||
| 168 | * fonction qui met a jour le last_ckeck_missions dans _bataille_base |
||
| 169 | * le met à la date du jour |
||
| 170 | */ |
||
| 171 | private function setUpdateLastCheckMissions() { |
||
| 181 | |||
| 182 | /** |
||
| 183 | * @param $id_mission |
||
| 184 | * fonction qui retire une mission de la liste des missions aleatoire des qu'on la lance |
||
| 185 | */ |
||
| 186 | private function setDeleteMission($id_mission) { |
||
| 192 | |||
| 193 | /** |
||
| 194 | * @param $type |
||
| 195 | * fonction qui recupere des missions aleatoirement de chaque type et qui les ajoute |
||
| 196 | * dans la table _bataille_mission_aleatoire |
||
| 197 | */ |
||
| 198 | private function setMissionsAleatoire() { |
||
| 223 | |||
| 224 | /** |
||
| 225 | * @param $id_mission |
||
| 226 | * @param $nombre_unite |
||
| 227 | * @param $nom_unite |
||
| 228 | * @param $type_unite |
||
| 229 | * @param null $id_groupe |
||
| 230 | * @return bool |
||
| 231 | * fonction sert a lancer une mission |
||
| 232 | */ |
||
| 233 | public function setCommencerMission($id_mission, $nombre_unite, $nom_unite, $type_unite, $id_groupe = null) { |
||
| 263 | |||
| 264 | /** |
||
| 265 | * fonctin qui termine les missions en cours et qui ajoutera les ressources + les points |
||
| 266 | * et qui au cas ou pourra tuer des inités |
||
| 267 | */ |
||
| 268 | public function setTerminerMissions() { |
||
| 306 | //-------------------------- END SETTER ----------------------------------------------------------------------------// |
||
| 307 | |||
| 308 | } |
Loading history...
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.
Let’s take a look at an example:
As you can see in this example, the array
$myArrayis initialized the first time when the foreach loop is entered. You can also see that the value of thebarkey is only written conditionally; thus, its value might result from a previous iteration.This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.