Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
9 | class ForumFaction extends Faction { |
||
10 | private $id_forum; |
||
11 | |||
12 | //-------------------------- BUILDER ----------------------------------------------------------------------------// |
||
13 | public function __construct() { |
||
14 | |||
15 | } |
||
16 | //-------------------------- END BUILDER ----------------------------------------------------------------------------// |
||
17 | |||
18 | |||
19 | //-------------------------- GETTER ----------------------------------------------------------------------------// |
||
20 | /** |
||
21 | * fonction qui récupère les forums de la faction |
||
22 | */ |
||
23 | public function getListeForum() { |
||
24 | $dbc = App::getDb(); |
||
25 | |||
26 | $query = $dbc->select()->from("_bataille_faction_forum")->where("ID_faction", "=", $this->id_faction)->get(); |
||
27 | |||
28 | $forums = []; |
||
29 | if ((count($query) > 0)) { |
||
30 | foreach ($query as $obj) { |
||
31 | $forums[] = [ |
||
32 | "id_forum" => $obj->ID_faction_forum, |
||
33 | "titre" => $obj->titre, |
||
34 | "url" => $obj->url, |
||
35 | "texte" => $obj->texte, |
||
36 | "date_creation" => $obj->date_creation |
||
37 | ]; |
||
38 | } |
||
39 | } |
||
40 | |||
41 | Bataille::setValues(["forums" => $forums]); |
||
42 | } |
||
43 | |||
44 | /** |
||
45 | * @param $titre |
||
46 | * @return bool |
||
47 | * fonction qui test si un forum aec ce titre existe déjà |
||
48 | */ |
||
49 | View Code Duplication | private function getForumExist($titre) { |
|
63 | |||
64 | /** |
||
65 | * @param $id_forum |
||
66 | * fonction qui va chercher un forum en particulier |
||
67 | */ |
||
68 | public function getForum($id_forum) { |
||
92 | |||
93 | /** |
||
94 | * fonction qui récupère les commentaires d'un forum en particulier |
||
95 | */ |
||
96 | private function getCommentaireForum() { |
||
121 | //-------------------------- END GETTER ----------------------------------------------------------------------------// |
||
122 | |||
123 | |||
124 | //-------------------------- SETTER ----------------------------------------------------------------------------// |
||
125 | /** |
||
126 | * @param $titre |
||
127 | * @param $texte |
||
128 | * @return bool |
||
129 | */ |
||
130 | public function setCreerForum($titre, $texte) { |
||
153 | |||
154 | /** |
||
155 | * @param $url |
||
156 | * fonction qui supprime un forum |
||
157 | */ |
||
158 | public function setSupprimerForum($id_forum) { |
||
171 | |||
172 | /** |
||
173 | * @param $commentaire |
||
174 | * @param $id_forum |
||
175 | * @return bool |
||
176 | * fonction qui permet d'ajouter un commentaire sur un forum |
||
177 | */ |
||
178 | public function setAjouterCommentaire($commentaire, $id_forum) { |
||
195 | |||
196 | /** |
||
197 | * @param $id_commentaire |
||
198 | * @return bool |
||
199 | * fonction qui permet de supprimer un commentaire sur un forum |
||
200 | */ |
||
201 | View Code Duplication | public function setSupprimerCommentaire($id_commentaire) { |
|
217 | //-------------------------- END SETTER ----------------------------------------------------------------------------// |
||
218 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.