Piou-piou / RibsAdminBundle

Service/PackagistApi.php

<?php

namespace PiouPiou\RibsAdminBundle\Service;

use Exception;
use Symfony\Contracts\HttpClient\Exception\ClientExceptionInterface;
use Symfony\Contracts\HttpClient\Exception\RedirectionExceptionInterface;
use Symfony\Contracts\HttpClient\Exception\ServerExceptionInterface;
use Symfony\Contracts\HttpClient\Exception\TransportExceptionInterface;
use Symfony\Contracts\HttpClient\HttpClientInterface;

class PackagistApi
{
    /**
     * @var HttpClientInterface
     */
    private $client;

    /**
     * @var string
     */
    private $package_name = null;

    /**
     * @var array
     */
    private $package_info = [];

    /**
     * PackagistApi constructor.
     * @param HttpClientInterface $client
     */
    public function __construct(HttpClientInterface $client)
    {
        $this->client = $client;
    }

    /**
     * @return false|mixed
     * @throws ClientExceptionInterface
     * @throws RedirectionExceptionInterface
     * @throws ServerExceptionInterface
     * @throws TransportExceptionInterface
     */
    private function getPackageInformation()
    {
        if ($this->package_info) {

The expression $this->package_info of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return $this->package_info;
        }

        if (!$this->package_name || !strpos($this->package_name, "/")) {
            return false;
        }

        $packgist_url = "https://repo.packagist.org/p/".$this->package_name.".json";
        $response = $this->client->request("GET", $packgist_url);

        if ($response->getStatusCode() == 200) {
            $content = json_decode($response->getContent(), true);
            if (is_array($content) && $content["packages"] && $content["packages"][$this->package_name]) {
                $this->package_info = $content["packages"][$this->package_name];
                return $this->package_info;
            }
        }

        return false;
    }

    /**
     * @param string $package_name
     * @return false|int|string|null
     * @throws ClientExceptionInterface
     * @throws RedirectionExceptionInterface
     * @throws ServerExceptionInterface
     * @throws TransportExceptionInterface
     */
    public function getLastPackagistVersion(string $package_name)
    {
        $this->package_name = $package_name;
        if ($package = $this->getPackageInformation()) {
            return array_key_first($package);
        }

        return false;
    }

    /**
     * @param string $package_name
     * @return array
     * @throws ClientExceptionInterface
     * @throws RedirectionExceptionInterface
     * @throws ServerExceptionInterface
     * @throws TransportExceptionInterface
     */
    public function getAllPackagistVersions(string $package_name)
    {
        $this->package_name = $package_name;
        if ($package = $this->getPackageInformation()) {
            return array_keys($package);
        }
    }
}