Piou-piou / RibsAdminBundle

Command/CreateAdminCommand.php

<?php

namespace PiouPiou\RibsAdminBundle\Command;

use Doctrine\ORM\EntityManagerInterface;
use PiouPiou\RibsAdminBundle\Entity\Account;
use PiouPiou\RibsAdminBundle\Entity\User;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Security\Core\Encoder\UserPasswordEncoderInterface;

class CreateAdminCommand extends Command
{
    /** @var EntityManagerInterface */
    private $em;

    /** @var UserPasswordEncoderInterface */
    private $passwordEncoder;

    /**
     * CreateAdminCommand constructor.
     * @param EntityManagerInterface $em
     * @param UserPasswordEncoderInterface $passwordEncoder
     * @param string|null $name
     */
    public function __construct(EntityManagerInterface $em, UserPasswordEncoderInterface $passwordEncoder, string $name = null)
    {
        parent::__construct($name);
        $this->em = $em;
        $this->passwordEncoder = $passwordEncoder;
    }

    protected function configure()
    {
        $this
            ->setName('ribsadmin:create-admin')
            ->setDescription('Create an admin in ribs admin')
            ->addArgument(
                'firstname',
                InputArgument::REQUIRED,
                'Firstname of admin to create'
            )
            ->addArgument(
                'lastname',
                InputArgument::REQUIRED,
                'Lastname of admin to create'
            )
            ->addArgument(
                'email',
                InputArgument::REQUIRED,
                'email of admin to create'
            )
            ->addArgument(
                'password',
                InputArgument::REQUIRED,
                'password of admin to create'
            )
        ;
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $firstname = $input->getArgument('firstname');
        $lastname = $input->getArgument('lastname');
        $email = $input->getArgument('email');
        $password = $input->getArgument('password');

        $output->writeln("Create admin " . $firstname . " " . $lastname);

Are you sure $firstname of type null|string|string[] can be used in concatenation?

Are you sure $lastname of type null|string|string[] can be used in concatenation?

        $user = new User();
        $user->setFirstname($firstname);

It seems like $firstname can also be of type string[]; however, parameter $firstname of PiouPiou\RibsAdminBundle\Entity\User::setFirstname() does only seem to accept string, maybe add an additional type check?

        $user->setLastname($lastname);

It seems like $lastname can also be of type string[]; however, parameter $lastname of PiouPiou\RibsAdminBundle\Entity\User::setLastname() does only seem to accept string, maybe add an additional type check?

        $user->setAccessRights("*");
        $this->em->persist($user);

        $account = new Account();
        $temp_password = $this->passwordEncoder->encodePassword($account, $password);

It seems like $password can also be of type null and string[]; however, parameter $plainPassword of Symfony\Component\Security\Core\Encoder\UserPasswordEncoderInterface::encodePassword() does only seem to accept string, maybe add an additional type check?

        $account->setPassword($temp_password);
        $account->setUser($user);
        $account->setEmail($email);
        $account->setUsername(substr($firstname, 0, 1).".".$lastname);

It seems like $firstname can also be of type string[]; however, parameter $string of substr() does only seem to accept string, maybe add an additional type check?

        $this->em->persist($account);

        $this->em->flush();

        $output->writeln("End Create admin " . $firstname . " " . $lastname);

        return 0;
    }
}