AccessRights::__construct() - Code Metrics - Inspection of "[func] add composer lock open urls" - Piou-piou/RibsAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( 07a5d2...98935d )

by Anthony
created 2020-12-10 18:27 UTC
AccessRights::__construct() A

↳ Parent: AccessRights
Complexity

Conditions	4
Paths	2
Size

Total Lines	12
Code Lines	10
Duplication

Lines	0
Ratio	0 %
Importance

Changes	5
Bugs	1	Features	1
Metric	Value
cc	4
eloc	10
c	5
b	1
f	1
nc	2
nop	8
dl	0
loc	12
rs	9.9332
How to fix Many Parameters

<?php

namespace PiouPiou\RibsAdminBundle\Service;

use PiouPiou\RibsAdminBundle\Entity\User;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Component\HttpFoundation\Session\SessionInterface;
use Symfony\Component\Routing\RouterInterface;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;

class AccessRights
{
	/**
	 * @var ContainerInterface
	 */
	private $container;
	
	/**
	 * @var RouterInterface
	 */
	private $router;
	
	/**
	 * @var SessionInterface
	 */
	private $session;
	
	/**
	 * @var RequestStack
	 */
	private $request;
	
	/**
	 * @var Globals
	 */
	private $globals;
	
	/**
	 * @var ModuleService
	 */
	private $module;

    /**
     * @var Api
     */
    private $api;
	
	/**
	 * @var User
	 */
	private $user;

	/** @var TokenStorageInterface */
	private $token_storage;

    /**
     * AccessRights constructor.
     * @param ContainerInterface $container
     * @param RouterInterface $router
     * @param SessionInterface $session
     * @param RequestStack $request
     * @param TokenStorageInterface $tokenStorage
     * @param Globals $globals
     * @param ModuleService $module
     * @param Api $api
     */
	public function __construct(ContainerInterface $container, RouterInterface $router, SessionInterface $session, RequestStack $request, TokenStorageInterface $tokenStorage, Globals $globals, ModuleService $module, Api $api)
	{
		$this->container = $container;
		$this->router = $router;
		$this->session = $session;
		$this->request = $request;
		$this->globals = $globals;
		$this->module = $module;
		$this->api = $api;
		$this->token_storage = $tokenStorage;
		if ($this->token_storage->getToken() && is_object($this->token_storage->getToken()->getUser()) && $this->token_storage->getToken()->getUser()->getUser()) {
		if ($this->token_storage->getToken() && is_object($this->token_storage->getToken()->getUser()) && $this->token_storage->getToken()->getUser()->/** @scrutinizer ignore-call */ getUser()) {
            $this->user = $this->token_storage->getToken()->getUser()->getUser();
        }
	}
	
	public function onKernelController()
	{
		$route = $this->request->getCurrentRequest()->get("_route");
		$route_array = explode("_", $route);
		$admin_page = $route_array[0];
		$api = in_array("api", $route_array);
		
		//to show admin panel
		if (in_array($route, ["_profiler", "_profiler_search_bar", "_wdt"])) {
			return;
		}
		
		$ribs_admin_rights = json_decode(file_get_contents($this->globals->getBaseBundlePath() . "/Resources/json/ribsadmin_rights.json"));
		$modules_rights = $this->module->getModuleRights();
		$ribs_admin_rights = (object)array_merge((array)$ribs_admin_rights, (array)$modules_rights);

        if ($this->testIsOpenUrl($route)) {
            return;
        }

		if ($admin_page == "ribsadmin" && !$api && strpos($route, "login") === false && strpos($route, "register") === false) {
			//redirection if user not connected
			if ($this->container->get("security.token_storage")->getToken() === null || !$this->container->get('security.authorization_checker')->isGranted('IS_AUTHENTICATED_FULLY')) {
				return new RedirectResponse($this->router->generate("ribs_admin_logout"));
			}
			
			$this->user = $this->token_storage->getToken()->getUser()->getUser();
			
			$route_right = $this->in_array_recursive($route, $ribs_admin_rights);
			
			if ($route_right === false) {
				throw new AccessDeniedException("No access");
			}
			
			if ($this->testRouteRight($route_right) === true) {
				return;
			} else if ($this->user->getAdmin() === true && in_array("ribsadmin@index", $route_right)) {
				return;
			}
			
			throw new AccessDeniedException("No access");
		} else if ($api && strpos($route, "login") === false && strpos($route, "register") === false) {
            if ($this->api->userIslogged($this->request->getCurrentRequest()->get("infos"), $this->request->getCurrentRequest()->get("token")) === false) {
            if ($this->api->userIslogged($this->request->getCurrentRequest()->get("infos"), /** @scrutinizer ignore-type */ $this->request->getCurrentRequest()->get("token")) === false) {
                throw new AccessDeniedException("User is not connected");
            }
        }
	}

	private function testIsOpenUrl($route)
    {
        $open_urls = json_decode(file_get_contents($this->globals->getBaseBundlePath() . "/Resources/json/ribsadmin_open_url.json"), true);

        if ($open_urls && $open_urls["items"] && in_array($route, $open_urls["items"])) {
            return true;
        }

        return false;
    }
	
	/**
     * function that allow to test a right directly in the view
	 * @param string $right
	 * @return bool
	 */
	public function testRight(string $right): bool
	{
		$user_rights = $this->getUserRights();
		$list_rights = $this->getRightsListOfUser();
		
		$all_rights = array_merge($user_rights, $list_rights);

        if (in_array("*", $all_rights)) {
            return true;
        }

		if (in_array($right, $all_rights)) {
			return true;
		}
		
		return false;
	}
	
	/**
     * test if route_right is found in users rights
	 * @param array $route_right
	 * @return bool
	 */
	private function testRouteRight(array $route_right): bool
	{
		$user_rights = $this->getUserRights();
		$list_rights = $this->getRightsListOfUser();
		
		$all_rights = array_merge($user_rights, $list_rights);

		if (in_array("*", $all_rights)) {
		    return true;
        }

		foreach ($all_rights as $right) {
			if (in_array($right, $route_right)) {
				return true;
			}
		}
		
		return false;
	}
	
	/**
     * function that search if the right contain an url or more
	 * @param $needle
	 * @param $haystack
	 * @return bool|mixed
	 */
	private function in_array_recursive($needle, $haystack)
	{
		$rights = [];
		$it = new \RecursiveIteratorIterator(new \RecursiveArrayIterator($haystack));
		
		foreach ($it AS $element => $value) {
		    if (strpos($value, ", ") !== false) {
		        if (in_array($needle, $explode = explode(", ", $value))) {
                    $value = $needle;
                }
            }

			if ($value == $needle) {
				$rights[] = $it->getInnerIterator()["right"];
			}
		}
		
		if (count($rights) === 0) {
			return false;
		}
		
		return $rights;
	}
	
	/**
     * function that retun a array that contain all user rights or empty array if no right found
	 * @return array
	 */
	private function getUserRights(): array
	{
		$user_rights = $this->user->getAccessRights();
		
		if ($user_rights) {
			return explode(",", $user_rights);
		}
		
		return [""];
	}
	
	/**
     * function that retun a array that contain all rights of rattached list right of the current user
	 * @return array
	 */
	private function getRightsListOfUser(): array
	{
		if ($this->user->getAccessRightList()) {
			$user_rights = $this->user->getAccessRightList()->getAccessRights();
			
			if ($user_rights) {
				return explode(",", $user_rights);
			}
		}
		
		return [""];
	}
}

Piou-piou / RibsAdminBundle

Push — master ( 07a5d2...98935d )

AccessRights::__construct() A

Complexity

Size

Duplication

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like
